)]}'
{"doc/specs/in-progress/osprofiler.rst":[{"author":{"_account_id":23936,"name":"Ronan-Alexandre Cherrueau","email":"Ronan-Alexandre.Cherrueau@inria.fr","username":"rcherrueau"},"change_message_id":"55a53bf3ea7174de0328b1f78b16a02f1240a3b9","unresolved":false,"context_lines":[{"line_number":14,"context_line":" To test out your formatting, see http://www.tele3.cz/jbar/rest/rest.html"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":17,"context_line":"OSprofiler integration into Rally"},{"line_number":18,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"The OSprofiler is a distributed trace toolkit library. It provides pythonic"}],"source_content_type":"text/x-rst","patch_set":1,"id":"7ffa3b31_825defea","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":10},"updated":"2017-04-18 09:23:58.000000000","message":"The OSProfiler project writes the word OSProfiler with an uppercase *P*. There are few places in the document were OSProfiler is written with a lowercase *p*. In particular, in the code example of section: \"Storing profiling results\".","commit_id":"da876a28d37c346d5f4cc386cee8e4fccfac50b5"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"957ad447fc9318245368d8238a016ef2516318d7","unresolved":false,"context_lines":[{"line_number":14,"context_line":" To test out your formatting, see http://www.tele3.cz/jbar/rest/rest.html"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":17,"context_line":"OSprofiler integration into Rally"},{"line_number":18,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"The OSprofiler is a distributed trace toolkit library. It provides pythonic"}],"source_content_type":"text/x-rst","patch_set":1,"id":"7ffa3b31_a4ba3807","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":10},"in_reply_to":"7ffa3b31_825defea","updated":"2017-04-18 09:30:30.000000000","message":"There are a lot of places where \"p\" is written in lowercase[1][2][3]. I\u0027m ok to change it to the capital letter since it looks better.\n\n[1] - https://docs.openstack.org/developer/osprofiler/integration.html\n[2] - http://osprofiler.readthedocs.io/en/latest/\n[3] - https://specs.openstack.org/openstack/oslo-specs/specs/mitaka/osprofiler-cross-service-project-profiling.html","commit_id":"da876a28d37c346d5f4cc386cee8e4fccfac50b5"},{"author":{"_account_id":23936,"name":"Ronan-Alexandre Cherrueau","email":"Ronan-Alexandre.Cherrueau@inria.fr","username":"rcherrueau"},"change_message_id":"55a53bf3ea7174de0328b1f78b16a02f1240a3b9","unresolved":false,"context_lines":[{"line_number":40,"context_line":"Two facts about OSprofiler which are the start point for the proposed changes:"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"* HMAC key is used as a secret identifier while profiling"},{"line_number":43,"context_line":"* Initialization of profiling is made in thread save mode. Profiling of one"},{"line_number":44,"context_line":"  iteration should not influence profiling another one"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"Storing secret key"}],"source_content_type":"text/x-rst","patch_set":1,"id":"7ffa3b31_e2639319","line":43,"range":{"start_line":43,"start_character":48,"end_line":43,"end_character":52},"updated":"2017-04-18 09:23:58.000000000","message":"safe","commit_id":"da876a28d37c346d5f4cc386cee8e4fccfac50b5"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"5aa160b17d13f47c2b86580c29783ed452941276","unresolved":false,"context_lines":[{"line_number":40,"context_line":"Two facts about OSprofiler which are the start point for the proposed changes:"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"* HMAC key is used as a secret identifier while profiling"},{"line_number":43,"context_line":"* Initialization of profiling is made in thread save mode. Profiling of one"},{"line_number":44,"context_line":"  iteration should not influence profiling another one"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"Storing secret key"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5ff73747_1e2e0043","line":43,"range":{"start_line":43,"start_character":48,"end_line":43,"end_character":52},"in_reply_to":"7ffa3b31_e2639319","updated":"2017-04-24 20:40:17.000000000","message":"Done","commit_id":"da876a28d37c346d5f4cc386cee8e4fccfac50b5"},{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"b891497155aaab8f5b80c5d10355589cd28ee091","unresolved":false,"context_lines":[{"line_number":63,"context_line":"OSprofiler is made in thread safe mode [3]_, so we should not have problem from"},{"line_number":64,"context_line":"that side."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"Initialization of OSprofiler is quite simple."},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"  .. code-block:: python"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    from osprofiler import profiler"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    profiler.init(HMAC_KEY)"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"As for the place where to initialize OSprofiler in Rally, constructor of"}],"source_content_type":"text/x-rst","patch_set":1,"id":"7ffa3b31_7f7ebdaf","line":72,"range":{"start_line":66,"start_character":0,"end_line":72,"end_character":27},"updated":"2017-04-20 01:24:37.000000000","message":"Agree!\nHowever, do we have to modify credential class to make it re-initialize every test run?\nOSprofiler trace usually starts from an OpenStack Client \u003d\u003d\u003e If we put OSprofiler initial in credential, I think we have to re-generate base_id in client class (such as Nova) in every run.\n---\nI have 1 question (:D): I saw that we initialize OpenStack Client only 1 time and then put it in cache [1] \u003d\u003d\u003e Do we have to edit it too?\n\n[1] https://github.com/openstack/rally/blob/master/rally/osclients.py#L208-L210","commit_id":"da876a28d37c346d5f4cc386cee8e4fccfac50b5"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"18c247c96aaa57ee6bd1a66dff9be326dc292cdc","unresolved":false,"context_lines":[{"line_number":63,"context_line":"OSprofiler is made in thread safe mode [3]_, so we should not have problem from"},{"line_number":64,"context_line":"that side."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"Initialization of OSprofiler is quite simple."},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"  .. code-block:: python"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    from osprofiler import profiler"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    profiler.init(HMAC_KEY)"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"As for the place where to initialize OSprofiler in Rally, constructor of"}],"source_content_type":"text/x-rst","patch_set":1,"id":"7ffa3b31_12f1e301","line":72,"range":{"start_line":66,"start_character":0,"end_line":72,"end_character":27},"in_reply_to":"7ffa3b31_7f7ebdaf","updated":"2017-04-20 09:56:34.000000000","message":"Short answer: no any changes related to cache do not require\n\nLong: To prevent any kind of collisions and to provide the similar conditions for all iterations of one workload, rally runner initializes a new instance of scenario class for each iteration[1]. The scenario instance accepts a dict-like information which is used for initialization of OSClients objects[2]. In other works caching works only in terms of one iteration, so no collisions with osprofiler trace ids should appear.\n\nAlso, I prefer to not initialize osprofiler in OSClients class, since OSClients is used in many places in rally(not only in scenario workload, but in contexts, cleanups, etc). I posted a right place in the comment for L77.\n\n\n[1] - https://github.com/openstack/rally/blob/master/rally/task/runner.py#L68\n[2] - https://github.com/openstack/rally/blob/master/rally/plugins/openstack/scenario.py#L41-L49","commit_id":"da876a28d37c346d5f4cc386cee8e4fccfac50b5"},{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"b891497155aaab8f5b80c5d10355589cd28ee091","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":"As for the place where to initialize OSprofiler in Rally, constructor of"},{"line_number":76,"context_line":"scenario is a good choice. First of all, we have a separate class for OpenStack"},{"line_number":77,"context_line":"scenarios[4] which means that integration with OSprofiler there will not affect"},{"line_number":78,"context_line":"all other platforms. Another reason for using constructor is that we initialize"},{"line_number":79,"context_line":"new instance of scenario class for each iterations."},{"line_number":80,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"7ffa3b31_8463bc1a","line":77,"range":{"start_line":77,"start_character":9,"end_line":77,"end_character":12},"updated":"2017-04-20 01:24:37.000000000","message":"may be you use wrong reference number here?","commit_id":"da876a28d37c346d5f4cc386cee8e4fccfac50b5"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"5aa160b17d13f47c2b86580c29783ed452941276","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":"As for the place where to initialize OSprofiler in Rally, constructor of"},{"line_number":76,"context_line":"scenario is a good choice. First of all, we have a separate class for OpenStack"},{"line_number":77,"context_line":"scenarios[4] which means that integration with OSprofiler there will not affect"},{"line_number":78,"context_line":"all other platforms. Another reason for using constructor is that we initialize"},{"line_number":79,"context_line":"new instance of scenario class for each iterations."},{"line_number":80,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"5ff73747_3eed3cef","line":77,"range":{"start_line":77,"start_character":9,"end_line":77,"end_character":12},"in_reply_to":"7ffa3b31_314f446c","updated":"2017-04-24 20:40:17.000000000","message":"Done","commit_id":"da876a28d37c346d5f4cc386cee8e4fccfac50b5"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"18c247c96aaa57ee6bd1a66dff9be326dc292cdc","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":"As for the place where to initialize OSprofiler in Rally, constructor of"},{"line_number":76,"context_line":"scenario is a good choice. First of all, we have a separate class for OpenStack"},{"line_number":77,"context_line":"scenarios[4] which means that integration with OSprofiler there will not affect"},{"line_number":78,"context_line":"all other platforms. Another reason for using constructor is that we initialize"},{"line_number":79,"context_line":"new instance of scenario class for each iterations."},{"line_number":80,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"7ffa3b31_314f446c","line":77,"range":{"start_line":77,"start_character":9,"end_line":77,"end_character":12},"in_reply_to":"7ffa3b31_8463bc1a","updated":"2017-04-20 09:56:34.000000000","message":"yes, it is a wrong reference. The right one - https://github.com/openstack/rally/blob/a5691d7850b5abd7ea707730f0d48d75116d88d3/rally/plugins/openstack/scenario.py#L28-L55","commit_id":"da876a28d37c346d5f4cc386cee8e4fccfac50b5"}]}
