)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"635b3d62e4721f510e3e92cf5ac3f16ae28738c8","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Modify task/validation.py to make it more compatible"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Extend required_paramaters validator to be able to"},{"line_number":10,"context_line":"search sub-dict of \"config\"."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Subdict is something like \"create_image_args\" to be"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7ffa3b31_957d6870","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":36},"updated":"2017-04-14 14:15:50.000000000","message":"Please use that phrase as a title of commit","commit_id":"a4736630d083c44683bde220743648ffa77eafac"}],"rally/plugins/common/validators.py":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"ca8d4046e452167783a8b5c654003bc66fe785f4","unresolved":false,"context_lines":[{"line_number":91,"context_line":"        if self.subdict:"},{"line_number":92,"context_line":"            args \u003d args.get(self.subdict, {})"},{"line_number":93,"context_line":"        for arg in self.params:"},{"line_number":94,"context_line":"            if type(arg) \u003d\u003d tuple:"},{"line_number":95,"context_line":"                for case in arg:"},{"line_number":96,"context_line":"                    if (case not in args and"},{"line_number":97,"context_line":"                            case not in config.get(\"args\", {})):"}],"source_content_type":"text/x-python","patch_set":3,"id":"7ffa3b31_6aa4f9b9","line":94,"range":{"start_line":94,"start_character":12,"end_line":94,"end_character":34},"updated":"2017-04-18 10:46:41.000000000","message":"let\u0027s use \"isinstance\" and allow list too:\n   \n    if isinstance(arg, (tuple, list))","commit_id":"892973982b20b542382d080d511fa29f6da5baa3"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"ca8d4046e452167783a8b5c654003bc66fe785f4","unresolved":false,"context_lines":[{"line_number":93,"context_line":"        for arg in self.params:"},{"line_number":94,"context_line":"            if type(arg) \u003d\u003d tuple:"},{"line_number":95,"context_line":"                for case in arg:"},{"line_number":96,"context_line":"                    if (case not in args and"},{"line_number":97,"context_line":"                            case not in config.get(\"args\", {})):"},{"line_number":98,"context_line":"                        missing.append(case)"},{"line_number":99,"context_line":"            else:"},{"line_number":100,"context_line":"                if (arg not in args and"}],"source_content_type":"text/x-python","patch_set":3,"id":"7ffa3b31_aac44160","line":97,"range":{"start_line":96,"start_character":40,"end_line":97,"end_character":62},"updated":"2017-04-18 10:46:41.000000000","message":"it is redundant. The first statement is equal to it since `args \u003d\u003d config.get(\"args\")`","commit_id":"892973982b20b542382d080d511fa29f6da5baa3"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"ca8d4046e452167783a8b5c654003bc66fe785f4","unresolved":false,"context_lines":[{"line_number":97,"context_line":"                            case not in config.get(\"args\", {})):"},{"line_number":98,"context_line":"                        missing.append(case)"},{"line_number":99,"context_line":"            else:"},{"line_number":100,"context_line":"                if (arg not in args and"},{"line_number":101,"context_line":"                        arg not in config.get(\"args\", {})):"},{"line_number":102,"context_line":"                    missing.append(arg)"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"        if missing:"}],"source_content_type":"text/x-python","patch_set":3,"id":"7ffa3b31_2ab951e8","line":101,"range":{"start_line":100,"start_character":35,"end_line":101,"end_character":57},"updated":"2017-04-18 10:46:41.000000000","message":"same here","commit_id":"892973982b20b542382d080d511fa29f6da5baa3"}],"rally/plugins/openstack/scenarios/cinder/volumes.py":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"635b3d62e4721f510e3e92cf5ac3f16ae28738c8","unresolved":false,"context_lines":[{"line_number":569,"context_line":"@validation.restricted_parameters([\"name\", \"display_name\"])"},{"line_number":570,"context_line":"@validation.required_services(consts.Service.CINDER, consts.Service.GLANCE)"},{"line_number":571,"context_line":"@validation.add(\"required_platform\", platform\u003d\"openstack\", users\u003dTrue)"},{"line_number":572,"context_line":"@validation.required_parameters(None, \"size\")"},{"line_number":573,"context_line":"@scenario.configure(context\u003d{\"cleanup\": [\"cinder\", \"glance\"]},"},{"line_number":574,"context_line":"                    name\u003d\"CinderVolumes.create_and_upload_volume_to_image\")"},{"line_number":575,"context_line":"class CreateAndUploadVolumeToImage(cinder_utils.CinderBasic,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7ffa3b31_f58eecce","line":572,"range":{"start_line":572,"start_character":0,"end_line":572,"end_character":45},"updated":"2017-04-14 14:15:50.000000000","message":"and here","commit_id":"a4736630d083c44683bde220743648ffa77eafac"}],"rally/plugins/openstack/scenarios/mistral/executions.py":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"635b3d62e4721f510e3e92cf5ac3f16ae28738c8","unresolved":false,"context_lines":[{"line_number":51,"context_line":"                              sort_keys\u003dsort_keys, sort_dirs\u003dsort_dirs)"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"@validation.required_parameters(None, \"definition\")"},{"line_number":55,"context_line":"@validation.file_exists(\"definition\")"},{"line_number":56,"context_line":"@types.convert(definition\u003d{\"type\": \"file\"})"},{"line_number":57,"context_line":"@types.convert(params\u003d{\"type\": \"file\"})"}],"source_content_type":"text/x-python","patch_set":2,"id":"7ffa3b31_159278f7","line":54,"range":{"start_line":54,"start_character":0,"end_line":54,"end_character":51},"updated":"2017-04-14 14:15:50.000000000","message":"redundant(see comments for other modules)","commit_id":"a4736630d083c44683bde220743648ffa77eafac"}],"rally/plugins/openstack/scenarios/mistral/workbooks.py":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"635b3d62e4721f510e3e92cf5ac3f16ae28738c8","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        self._list_workbooks()"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"@validation.required_parameters(None, \"definition\")"},{"line_number":42,"context_line":"@validation.file_exists(\"definition\")"},{"line_number":43,"context_line":"@types.convert(definition\u003d{\"type\": \"file\"})"},{"line_number":44,"context_line":"@validation.required_clients(\"mistral\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"7ffa3b31_75a3fc50","line":41,"range":{"start_line":41,"start_character":0,"end_line":41,"end_character":51},"updated":"2017-04-14 14:15:50.000000000","message":"definition argument doesn\u0027t have default value, so it is required by default. this validator is redundant here","commit_id":"a4736630d083c44683bde220743648ffa77eafac"}],"rally/plugins/openstack/scenarios/murano/packages.py":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"635b3d62e4721f510e3e92cf5ac3f16ae28738c8","unresolved":false,"context_lines":[{"line_number":25,"context_line":"\"\"\"Scenarios for Murano packages.\"\"\""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"@validation.required_parameters(None, \"package\")"},{"line_number":29,"context_line":"@validation.file_exists(param_name\u003d\"package\", mode\u003dos.F_OK)"},{"line_number":30,"context_line":"@validation.required_clients(\"murano\")"},{"line_number":31,"context_line":"@validation.required_services(consts.Service.MURANO)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7ffa3b31_15e4b8ab","line":28,"range":{"start_line":28,"start_character":0,"end_line":28,"end_character":48},"updated":"2017-04-14 14:15:50.000000000","message":"the same comment as like for \trally/plugins/openstack/scenarios/nova/security_group.py . let\u0027s just remove usage of that validator here (in whole packages module)","commit_id":"a4736630d083c44683bde220743648ffa77eafac"}],"rally/plugins/openstack/scenarios/neutron/network.py":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"635b3d62e4721f510e3e92cf5ac3f16ae28738c8","unresolved":false,"context_lines":[{"line_number":186,"context_line":"                self._show_subnet(subnet, atomic_action\u003dFalse)"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"@validation.required_parameters(None, \"subnets_per_network\")"},{"line_number":190,"context_line":"@validation.required_services(consts.Service.NEUTRON)"},{"line_number":191,"context_line":"@scenario.configure(context\u003d{\"cleanup\": [\"neutron\"]},"},{"line_number":192,"context_line":"                    name\u003d\"NeutronNetworks.create_and_delete_subnets\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"7ffa3b31_1576f807","line":189,"range":{"start_line":189,"start_character":0,"end_line":189,"end_character":60},"updated":"2017-04-14 14:15:50.000000000","message":"not sure that we need to require that parameter. let\u0027s put \"1\" as a default value.","commit_id":"a4736630d083c44683bde220743648ffa77eafac"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"635b3d62e4721f510e3e92cf5ac3f16ae28738c8","unresolved":false,"context_lines":[{"line_number":242,"context_line":""},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"@validation.number(\"subnets_per_network\", minval\u003d1, integer_only\u003dTrue)"},{"line_number":245,"context_line":"@validation.required_parameters(None, \"subnets_per_network\")"},{"line_number":246,"context_line":"@validation.required_services(consts.Service.NEUTRON)"},{"line_number":247,"context_line":"@scenario.configure(context\u003d{\"cleanup\": [\"neutron\"]},"},{"line_number":248,"context_line":"                    name\u003d\"NeutronNetworks.create_and_update_routers\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"7ffa3b31_35521469","line":245,"range":{"start_line":245,"start_character":0,"end_line":245,"end_character":60},"updated":"2017-04-14 14:15:50.000000000","message":"same here, let\u0027s put 1 as a default value and remove that validator.","commit_id":"a4736630d083c44683bde220743648ffa77eafac"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"635b3d62e4721f510e3e92cf5ac3f16ae28738c8","unresolved":false,"context_lines":[{"line_number":272,"context_line":"            self._update_router(router, router_update_args)"},{"line_number":273,"context_line":""},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"@validation.required_parameters(None, \"subnets_per_network\")"},{"line_number":276,"context_line":"@validation.required_services(consts.Service.NEUTRON)"},{"line_number":277,"context_line":"@scenario.configure(context\u003d{\"cleanup\": [\"neutron\"]},"},{"line_number":278,"context_line":"                    name\u003d\"NeutronNetworks.create_and_delete_routers\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"7ffa3b31_f54b8cad","line":275,"range":{"start_line":275,"start_character":0,"end_line":275,"end_character":60},"updated":"2017-04-14 14:15:50.000000000","message":"and here","commit_id":"a4736630d083c44683bde220743648ffa77eafac"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"635b3d62e4721f510e3e92cf5ac3f16ae28738c8","unresolved":false,"context_lines":[{"line_number":416,"context_line":"                                 err_msg\u003dmsg)"},{"line_number":417,"context_line":""},{"line_number":418,"context_line":""},{"line_number":419,"context_line":"@validation.required_parameters(None, \"ports_per_network\")"},{"line_number":420,"context_line":"@validation.required_services(consts.Service.NEUTRON)"},{"line_number":421,"context_line":"@scenario.configure(context\u003d{\"cleanup\": [\"neutron\"]},"},{"line_number":422,"context_line":"                    name\u003d\"NeutronNetworks.create_and_delete_ports\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"7ffa3b31_d5c65017","line":419,"range":{"start_line":419,"start_character":0,"end_line":419,"end_character":58},"updated":"2017-04-14 14:15:50.000000000","message":"and here","commit_id":"a4736630d083c44683bde220743648ffa77eafac"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"ca8d4046e452167783a8b5c654003bc66fe785f4","unresolved":false,"context_lines":[{"line_number":192,"context_line":"class CreateAndDeleteSubnets(utils.NeutronScenario):"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"    def run(self, network_create_args\u003dNone, subnet_create_args\u003dNone,"},{"line_number":195,"context_line":"            subnet_cidr_start\u003dNone, subnets_per_network\u003dNone):"},{"line_number":196,"context_line":"        \"\"\"Create and delete a given number of subnets."},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"        The scenario creates a network, a given number of subnets and then"}],"source_content_type":"text/x-python","patch_set":3,"id":"7ffa3b31_2a9cb15b","line":195,"range":{"start_line":195,"start_character":54,"end_line":195,"end_character":60},"updated":"2017-04-18 10:46:41.000000000","message":"Please, put 1 as a default value","commit_id":"892973982b20b542382d080d511fa29f6da5baa3"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"ca8d4046e452167783a8b5c654003bc66fe785f4","unresolved":false,"context_lines":[{"line_number":248,"context_line":""},{"line_number":249,"context_line":"    def run(self, router_update_args, network_create_args\u003dNone,"},{"line_number":250,"context_line":"            subnet_create_args\u003dNone, subnet_cidr_start\u003dNone,"},{"line_number":251,"context_line":"            subnets_per_network\u003dNone, router_create_args\u003dNone):"},{"line_number":252,"context_line":"        \"\"\"Create and update a given number of routers."},{"line_number":253,"context_line":""},{"line_number":254,"context_line":"        Create a network, a given number of subnets and routers"}],"source_content_type":"text/x-python","patch_set":3,"id":"7ffa3b31_8ab865c8","line":251,"range":{"start_line":251,"start_character":32,"end_line":251,"end_character":36},"updated":"2017-04-18 10:46:41.000000000","message":"same here","commit_id":"892973982b20b542382d080d511fa29f6da5baa3"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"ca8d4046e452167783a8b5c654003bc66fe785f4","unresolved":false,"context_lines":[{"line_number":276,"context_line":"class CreateAndDeleteRouters(utils.NeutronScenario):"},{"line_number":277,"context_line":""},{"line_number":278,"context_line":"    def run(self, network_create_args\u003dNone, subnet_create_args\u003dNone,"},{"line_number":279,"context_line":"            subnet_cidr_start\u003dNone, subnets_per_network\u003dNone,"},{"line_number":280,"context_line":"            router_create_args\u003dNone):"},{"line_number":281,"context_line":"        \"\"\"Create and delete a given number of routers."},{"line_number":282,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7ffa3b31_eac6c949","line":279,"range":{"start_line":279,"start_character":56,"end_line":279,"end_character":60},"updated":"2017-04-18 10:46:41.000000000","message":"and here","commit_id":"892973982b20b542382d080d511fa29f6da5baa3"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"ca8d4046e452167783a8b5c654003bc66fe785f4","unresolved":false,"context_lines":[{"line_number":419,"context_line":"class CreateAndDeletePorts(utils.NeutronScenario):"},{"line_number":420,"context_line":""},{"line_number":421,"context_line":"    def run(self, network_create_args\u003dNone,"},{"line_number":422,"context_line":"            port_create_args\u003dNone, ports_per_network\u003dNone):"},{"line_number":423,"context_line":"            \"\"\"Create and delete a port."},{"line_number":424,"context_line":""},{"line_number":425,"context_line":"            Measure the \"neutron port-create\" and \"neutron port-delete\""}],"source_content_type":"text/x-python","patch_set":3,"id":"7ffa3b31_8add0516","line":422,"range":{"start_line":422,"start_character":53,"end_line":422,"end_character":57},"updated":"2017-04-18 10:46:41.000000000","message":"and here","commit_id":"892973982b20b542382d080d511fa29f6da5baa3"}],"rally/plugins/openstack/scenarios/nova/security_group.py":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"635b3d62e4721f510e3e92cf5ac3f16ae28738c8","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    msg_fmt \u003d _(\"%(message)s\")"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"@validation.required_parameters(None, (\"security_group_count\","},{"line_number":36,"context_line":"                                \"rules_per_security_group\"))"},{"line_number":37,"context_line":"@validation.required_services(consts.Service.NOVA)"},{"line_number":38,"context_line":"@validation.add(\"required_platform\", platform\u003d\"openstack\", users\u003dTrue)"},{"line_number":39,"context_line":"@scenario.configure(context\u003d{\"cleanup\": [\"nova\"]},"}],"source_content_type":"text/x-python","patch_set":2,"id":"7ffa3b31_b57d04e9","line":36,"range":{"start_line":35,"start_character":38,"end_line":36,"end_character":59},"updated":"2017-04-14 14:15:50.000000000","message":"while wrapping these two arguments in a tuple, you changed the meaning. Previously both these argument were required and now only one of it is required.\n\nAnyway, all usage of `required_parameters` in current module is redundant, since described parameters do not have default values which means that another validator will handle them by default. Please remove usage of that validator here and in all other modules. It seams that we need required_parameters validator only for your case - when we need to support old name of argument and the new one","commit_id":"a4736630d083c44683bde220743648ffa77eafac"}],"rally/task/validation.py":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"635b3d62e4721f510e3e92cf5ac3f16ae28738c8","unresolved":false,"context_lines":[{"line_number":459,"context_line":"        return ValidationResult(False, message)"},{"line_number":460,"context_line":""},{"line_number":461,"context_line":""},{"line_number":462,"context_line":"@validator"},{"line_number":463,"context_line":"def required_parameters(config, clients, deployment,"},{"line_number":464,"context_line":"                        subdict\u003dNone, *required_params):"},{"line_number":465,"context_line":"    \"\"\"Validator for checking required parameters are specified."},{"line_number":466,"context_line":""},{"line_number":467,"context_line":"    :param subdict: sub-dict of \"config\" to search. if"}],"source_content_type":"text/x-python","patch_set":2,"id":"7ffa3b31_9559e8ff","line":464,"range":{"start_line":462,"start_character":0,"end_line":464,"end_character":56},"updated":"2017-04-14 14:15:50.000000000","message":"While we are here, let\u0027s move that validator to the new style.\n\n1) it should be located here - https://github.com/openstack/rally/blob/master/rally/plugins/common/validators.py\n\n2) it is class based. custom arguments(subdict, required_params) should be described in its __init__ method.\n\n3) for backward compatibility see L776","commit_id":"a4736630d083c44683bde220743648ffa77eafac"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"635b3d62e4721f510e3e92cf5ac3f16ae28738c8","unresolved":false,"context_lines":[{"line_number":469,"context_line":"    :param *required_params: list of required parameters"},{"line_number":470,"context_line":"    \"\"\""},{"line_number":471,"context_line":"    missing \u003d []"},{"line_number":472,"context_line":"    args \u003d config.get(\"args\", {})"},{"line_number":473,"context_line":"    for arg in required_params:"},{"line_number":474,"context_line":"        if type(arg) \u003d\u003d tuple:"},{"line_number":475,"context_line":"            for case in arg:"}],"source_content_type":"text/x-python","patch_set":2,"id":"7ffa3b31_d50410c9","line":472,"range":{"start_line":472,"start_character":4,"end_line":472,"end_character":33},"updated":"2017-04-14 14:15:50.000000000","message":"it is better to process \"subdict\" here.\n  \n   args \u003d config.get(\"args\", {})\n   if subdict:\n       args \u003d args.get(\"subdict\", {})","commit_id":"a4736630d083c44683bde220743648ffa77eafac"}]}
