)]}'
{"rally/api.py":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"19b157ecf2cd2a990cc1da277fb7f23abef23731","unresolved":false,"context_lines":[{"line_number":108,"context_line":"            LOG.info(_(\"Deployment %s will be deleted despite exception\")"},{"line_number":109,"context_line":"                     % deployment[\"uuid\"])"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"        for verifier in self.api._verifier.list():"},{"line_number":112,"context_line":"            self.api._verifier.delete(verifier.name, deployment[\"name\"],"},{"line_number":113,"context_line":"                                      force\u003dTrue)"},{"line_number":114,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7ffa3b31_d5a80221","line":111,"range":{"start_line":111,"start_character":33,"end_line":111,"end_character":42},"updated":"2017-04-20 12:08:06.000000000","message":"let\u0027s use property without `_` (see L1200)","commit_id":"a818b2fecc25279b6f19e2786192ef89c7b4f870"},{"author":{"_account_id":22960,"name":"Hai Shi","email":"shihai1992@gmail.com","username":"haishi"},"change_message_id":"b4e58db648aa5f5ae94188989123d13f75ea01ca","unresolved":false,"context_lines":[{"line_number":108,"context_line":"            LOG.info(_(\"Deployment %s will be deleted despite exception\")"},{"line_number":109,"context_line":"                     % deployment[\"uuid\"])"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"        for verifier in self.api._verifier.list():"},{"line_number":112,"context_line":"            self.api._verifier.delete(verifier.name, deployment[\"name\"],"},{"line_number":113,"context_line":"                                      force\u003dTrue)"},{"line_number":114,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7ffa3b31_a81bd0c7","line":111,"range":{"start_line":111,"start_character":33,"end_line":111,"end_character":42},"in_reply_to":"7ffa3b31_d5a80221","updated":"2017-04-24 04:19:43.000000000","message":"Done","commit_id":"a818b2fecc25279b6f19e2786192ef89c7b4f870"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"19b157ecf2cd2a990cc1da277fb7f23abef23731","unresolved":false,"context_lines":[{"line_number":589,"context_line":"                      deployment will be deleted"},{"line_number":590,"context_line":"        \"\"\""},{"line_number":591,"context_line":"        verifier \u003d self._get(verifier_id)"},{"line_number":592,"context_line":"        verifications \u003d _Verification.list(verifier_id, deployment_id)"},{"line_number":593,"context_line":"        if verifications:"},{"line_number":594,"context_line":"            d_msg \u003d ((\" for deployment \u0027%s\u0027\" % deployment_id)"},{"line_number":595,"context_line":"                     if deployment_id else \"\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"7ffa3b31_d504821a","line":592,"range":{"start_line":592,"start_character":23,"end_line":592,"end_character":37},"updated":"2017-04-20 12:08:06.000000000","message":"please, use self.api.verification here","commit_id":"a818b2fecc25279b6f19e2786192ef89c7b4f870"},{"author":{"_account_id":22960,"name":"Hai Shi","email":"shihai1992@gmail.com","username":"haishi"},"change_message_id":"b4e58db648aa5f5ae94188989123d13f75ea01ca","unresolved":false,"context_lines":[{"line_number":589,"context_line":"                      deployment will be deleted"},{"line_number":590,"context_line":"        \"\"\""},{"line_number":591,"context_line":"        verifier \u003d self._get(verifier_id)"},{"line_number":592,"context_line":"        verifications \u003d _Verification.list(verifier_id, deployment_id)"},{"line_number":593,"context_line":"        if verifications:"},{"line_number":594,"context_line":"            d_msg \u003d ((\" for deployment \u0027%s\u0027\" % deployment_id)"},{"line_number":595,"context_line":"                     if deployment_id else \"\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"7ffa3b31_48fd6c6c","line":592,"range":{"start_line":592,"start_character":23,"end_line":592,"end_character":37},"in_reply_to":"7ffa3b31_d504821a","updated":"2017-04-24 04:19:43.000000000","message":"Done","commit_id":"a818b2fecc25279b6f19e2786192ef89c7b4f870"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"19b157ecf2cd2a990cc1da277fb7f23abef23731","unresolved":false,"context_lines":[{"line_number":597,"context_line":"                LOG.info(\"Deleting all verifications created by verifier \""},{"line_number":598,"context_line":"                         \"%s%s.\", verifier, d_msg)"},{"line_number":599,"context_line":"                for verification in verifications:"},{"line_number":600,"context_line":"                    _Verification.delete(verification[\"uuid\"])"},{"line_number":601,"context_line":"            else:"},{"line_number":602,"context_line":"                raise exceptions.RallyException("},{"line_number":603,"context_line":"                    \"Failed to delete verifier {0} because there are stored \""}],"source_content_type":"text/x-python","patch_set":4,"id":"7ffa3b31_98007103","line":600,"range":{"start_line":600,"start_character":20,"end_line":600,"end_character":33},"updated":"2017-04-20 12:08:06.000000000","message":"same here","commit_id":"a818b2fecc25279b6f19e2786192ef89c7b4f870"},{"author":{"_account_id":22960,"name":"Hai Shi","email":"shihai1992@gmail.com","username":"haishi"},"change_message_id":"b4e58db648aa5f5ae94188989123d13f75ea01ca","unresolved":false,"context_lines":[{"line_number":597,"context_line":"                LOG.info(\"Deleting all verifications created by verifier \""},{"line_number":598,"context_line":"                         \"%s%s.\", verifier, d_msg)"},{"line_number":599,"context_line":"                for verification in verifications:"},{"line_number":600,"context_line":"                    _Verification.delete(verification[\"uuid\"])"},{"line_number":601,"context_line":"            else:"},{"line_number":602,"context_line":"                raise exceptions.RallyException("},{"line_number":603,"context_line":"                    \"Failed to delete verifier {0} because there are stored \""}],"source_content_type":"text/x-python","patch_set":4,"id":"7ffa3b31_c8f05c94","line":600,"range":{"start_line":600,"start_character":20,"end_line":600,"end_character":33},"in_reply_to":"7ffa3b31_98007103","updated":"2017-04-24 04:19:43.000000000","message":"Done","commit_id":"a818b2fecc25279b6f19e2786192ef89c7b4f870"}],"tests/unit/doc/test_task_samples.py":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"19b157ecf2cd2a990cc1da277fb7f23abef23731","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"                with open(full_path) as task_file:"},{"line_number":59,"context_line":"                    try:"},{"line_number":60,"context_line":"                        rapi \u003d api.API()"},{"line_number":61,"context_line":"                        task_config \u003d yaml.safe_load(rapi.task.render_template"},{"line_number":62,"context_line":"                                                     (task_file.read()))"},{"line_number":63,"context_line":"                        eng \u003d engine.TaskEngine(task_config,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7ffa3b31_d8c6f968","line":60,"range":{"start_line":60,"start_character":24,"end_line":60,"end_character":40},"updated":"2017-04-20 12:08:06.000000000","message":"1) It would be better to initialize API one time at the start of the test instead of re-initialization for each sample.\n\n2) __init__ method of rally.apy.API tries to initialize oslo.config and checks database. In case of usage in unit tests it is redundant (we do not require the database). It is actually a reason of failed tests. There to possible fixes.\n\n* Create a separate method for that initialize API class and put it into tests.unit.test:\n\n\n     def API():\n         with mock.patch(\"rally.api.API.check_db_revision\"):\n               return rally.api.API()\n\n* Create a separate class like:\n\n    class API(object):\n        def __init__(self):\n            self._deployment \u003d _Deployment(self)\n            self._task \u003d _Task(self)\n            self._verifier \u003d _Verifier(self)\n            self._verification \u003d _Verification(self)\n\n        @property\n        def deployment(self):\n            return self._deployment\n    \n        @property\n        def task(self):\n            return self._task\n    \n        @property\n        def verifier(self):\n            return self._verifier\n    \n        @property\n        def verification(self):\n            return self._verification","commit_id":"a818b2fecc25279b6f19e2786192ef89c7b4f870"},{"author":{"_account_id":22960,"name":"Hai Shi","email":"shihai1992@gmail.com","username":"haishi"},"change_message_id":"b4e58db648aa5f5ae94188989123d13f75ea01ca","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"                with open(full_path) as task_file:"},{"line_number":59,"context_line":"                    try:"},{"line_number":60,"context_line":"                        rapi \u003d api.API()"},{"line_number":61,"context_line":"                        task_config \u003d yaml.safe_load(rapi.task.render_template"},{"line_number":62,"context_line":"                                                     (task_file.read()))"},{"line_number":63,"context_line":"                        eng \u003d engine.TaskEngine(task_config,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7ffa3b31_63a169f8","line":60,"range":{"start_line":60,"start_character":24,"end_line":60,"end_character":40},"in_reply_to":"7ffa3b31_d8c6f968","updated":"2017-04-24 04:19:43.000000000","message":"You are right. It is rendundant, so I decide remove api.API() to setUp().","commit_id":"a818b2fecc25279b6f19e2786192ef89c7b4f870"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"19b157ecf2cd2a990cc1da277fb7f23abef23731","unresolved":false,"context_lines":[{"line_number":85,"context_line":"                full_path \u003d os.path.join(dirname, filename)"},{"line_number":86,"context_line":"                with open(full_path) as task_file:"},{"line_number":87,"context_line":"                    try:"},{"line_number":88,"context_line":"                        rapi \u003d api.API()"},{"line_number":89,"context_line":"                        json.loads(rapi.task.render_template(task_file.read()))"},{"line_number":90,"context_line":"                    except Exception:"},{"line_number":91,"context_line":"                        print(traceback.format_exc())"}],"source_content_type":"text/x-python","patch_set":4,"id":"7ffa3b31_b8c32d57","line":88,"range":{"start_line":88,"start_character":24,"end_line":88,"end_character":40},"updated":"2017-04-20 12:08:06.000000000","message":"same here","commit_id":"a818b2fecc25279b6f19e2786192ef89c7b4f870"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"19b157ecf2cd2a990cc1da277fb7f23abef23731","unresolved":false,"context_lines":[{"line_number":123,"context_line":"                partial_path \u003d os.path.join(dirname, sample_name)"},{"line_number":124,"context_line":"                yaml_path \u003d partial_path + \".yaml\""},{"line_number":125,"context_line":"                json_path \u003d partial_path + \".json\""},{"line_number":126,"context_line":"                rapi \u003d api.API()"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"                if os.path.exists(yaml_path) and os.path.exists(json_path):"},{"line_number":129,"context_line":"                    with open(json_path) as json_file:"}],"source_content_type":"text/x-python","patch_set":4,"id":"7ffa3b31_58a8a98a","line":126,"range":{"start_line":126,"start_character":16,"end_line":126,"end_character":32},"updated":"2017-04-20 12:08:06.000000000","message":"and here","commit_id":"a818b2fecc25279b6f19e2786192ef89c7b4f870"}],"tests/unit/test_api.py":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"19b157ecf2cd2a990cc1da277fb7f23abef23731","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        fake_deployment \u003d fakes.FakeDeployment("},{"line_number":63,"context_line":"            uuid\u003d\"deployment_uuid_1\", admin\u003d\"fake_admin\", users\u003d[\"fake_user\"])"},{"line_number":64,"context_line":"        mock_deployment_get.return_value \u003d fake_deployment"},{"line_number":65,"context_line":"        task_inst \u003d api._Task(api.API())"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        #######################################################################"},{"line_number":68,"context_line":"        # The case #1 -- create temporary task"}],"source_content_type":"text/x-python","patch_set":4,"id":"7ffa3b31_d89b9970","line":65,"range":{"start_line":65,"start_character":30,"end_line":65,"end_character":39},"updated":"2017-04-20 12:08:06.000000000","message":"it is better to put some mock.Mock() here or even None, since no external calls to other apis should be done in this test.\nrelates to all changes in that module","commit_id":"a818b2fecc25279b6f19e2786192ef89c7b4f870"}]}
