)]}'
{"rally/plugins/openstack/validators.py":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"d35fd6a7a1aa1627ebd7fb407a4a2a968e15cc67","unresolved":false,"context_lines":[{"line_number":22,"context_line":"from rally import exceptions"},{"line_number":23,"context_line":"from rally.plugins.openstack import types as openstack_types"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"ValidationResult \u003d validation.ValidationResult"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"@validation.add(\"required_platform\", platform\u003d\"openstack\", users\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":6,"id":"7ffa3b31_e0de763c","line":25,"range":{"start_line":25,"start_character":0,"end_line":25,"end_character":46},"updated":"2017-04-21 11:47:23.000000000","message":"it is not used.","commit_id":"91c40958970f4f6c3616f7d39e1b8879d1e7475c"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"438f81359fface989d7b01a3a1079e3fe778d91d","unresolved":false,"context_lines":[{"line_number":25,"context_line":"ValidationResult \u003d validation.ValidationResult"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"@validation.add(\"required_platform\", platform\u003d\"openstack\", users\u003dTrue)"},{"line_number":29,"context_line":"@validation.configure(name\u003d\"image_exists\", namespace\u003d\"openstack\")"},{"line_number":30,"context_line":"class ImageExistsValidator(validation.Validator):"},{"line_number":31,"context_line":"    param_name \u003d \"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"7ffa3b31_60282696","line":28,"range":{"start_line":28,"start_character":59,"end_line":28,"end_character":69},"updated":"2017-04-21 12:02:11.000000000","message":"it requires admin user not regular ones (L73)","commit_id":"91c40958970f4f6c3616f7d39e1b8879d1e7475c"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"d35fd6a7a1aa1627ebd7fb407a4a2a968e15cc67","unresolved":false,"context_lines":[{"line_number":28,"context_line":"@validation.add(\"required_platform\", platform\u003d\"openstack\", users\u003dTrue)"},{"line_number":29,"context_line":"@validation.configure(name\u003d\"image_exists\", namespace\u003d\"openstack\")"},{"line_number":30,"context_line":"class ImageExistsValidator(validation.Validator):"},{"line_number":31,"context_line":"    param_name \u003d \"\""},{"line_number":32,"context_line":"    nullable \u003d \"\""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    @logging.log_deprecated_args("},{"line_number":35,"context_line":"        \"The \u0027platform\u0027 argument to initiate \u0027image_exists\u0027 \""}],"source_content_type":"text/x-python","patch_set":6,"id":"7ffa3b31_20d9fe55","line":32,"range":{"start_line":31,"start_character":4,"end_line":32,"end_character":17},"updated":"2017-04-21 11:47:23.000000000","message":"it is redundant","commit_id":"91c40958970f4f6c3616f7d39e1b8879d1e7475c"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"d35fd6a7a1aa1627ebd7fb407a4a2a968e15cc67","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    param_name \u003d \"\""},{"line_number":32,"context_line":"    nullable \u003d \"\""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    @logging.log_deprecated_args("},{"line_number":35,"context_line":"        \"The \u0027platform\u0027 argument to initiate \u0027image_exists\u0027 \""},{"line_number":36,"context_line":"        \"validator is ignored\","},{"line_number":37,"context_line":"        \"0.10.0\", [\"platform\"], once\u003dTrue)"},{"line_number":38,"context_line":"    def __init__(self, param_name, nullable, platform\u003dNone):"},{"line_number":39,"context_line":"        \"\"\"Validator checks existed image or not"},{"line_number":40,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"7ffa3b31_801a1214","line":37,"range":{"start_line":34,"start_character":4,"end_line":37,"end_character":42},"updated":"2017-04-21 11:47:23.000000000","message":"it is redundant(see my comment to rally.task.validation)","commit_id":"91c40958970f4f6c3616f7d39e1b8879d1e7475c"}],"rally/task/validation.py":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"d35fd6a7a1aa1627ebd7fb407a4a2a968e15cc67","unresolved":false,"context_lines":[{"line_number":301,"context_line":"        return ValidationResult(False, message)"},{"line_number":302,"context_line":""},{"line_number":303,"context_line":""},{"line_number":304,"context_line":"# @validator"},{"line_number":305,"context_line":"# def image_exists(config, clients, deployment, param_name, nullable\u003dFalse):"},{"line_number":306,"context_line":"#     \"\"\"Returns validator for image_id"},{"line_number":307,"context_line":"#"},{"line_number":308,"context_line":"#     :param param_name: defines which variable should be used"},{"line_number":309,"context_line":"#                        to get image id value."},{"line_number":310,"context_line":"#     :param nullable: defines image id param is required"},{"line_number":311,"context_line":"#     \"\"\""},{"line_number":312,"context_line":"#     image_value \u003d config.get(\"args\", {}).get(param_name)"},{"line_number":313,"context_line":"#     if not image_value and nullable:"},{"line_number":314,"context_line":"#         return ValidationResult(True)"},{"line_number":315,"context_line":"#     res \u003d _get_validated_image(config, clients, param_name)"},{"line_number":316,"context_line":"#     if res:"},{"line_number":317,"context_line":"#         return res[0]"},{"line_number":318,"context_line":""},{"line_number":319,"context_line":""},{"line_number":320,"context_line":"@validator"}],"source_content_type":"text/x-python","patch_set":6,"id":"7ffa3b31_4031aaa2","line":317,"range":{"start_line":304,"start_character":0,"end_line":317,"end_character":23},"updated":"2017-04-21 11:47:23.000000000","message":"let\u0027s remove it","commit_id":"91c40958970f4f6c3616f7d39e1b8879d1e7475c"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"d35fd6a7a1aa1627ebd7fb407a4a2a968e15cc67","unresolved":false,"context_lines":[{"line_number":702,"context_line":""},{"line_number":703,"context_line":"number \u003d deprecated_validator(\"number\", \"number\", \"0.10.0\")"},{"line_number":704,"context_line":""},{"line_number":705,"context_line":"_deprecated_platform_validator \u003d deprecated_validator("},{"line_number":706,"context_line":"    \"image_exists\", \"image_exists\", \"0.10.0\""},{"line_number":707,"context_line":")"},{"line_number":708,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"7ffa3b31_a0f62ed6","line":705,"range":{"start_line":705,"start_character":0,"end_line":705,"end_character":30},"updated":"2017-04-21 11:47:23.000000000","message":"name it image_exists and it will work:)","commit_id":"91c40958970f4f6c3616f7d39e1b8879d1e7475c"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"d35fd6a7a1aa1627ebd7fb407a4a2a968e15cc67","unresolved":false,"context_lines":[{"line_number":706,"context_line":"    \"image_exists\", \"image_exists\", \"0.10.0\""},{"line_number":707,"context_line":")"},{"line_number":708,"context_line":""},{"line_number":709,"context_line":"image_exists \u003d functools.partial("},{"line_number":710,"context_line":"    _deprecated_platform_validator, platform\u003d\"openstack\")"}],"source_content_type":"text/x-python","patch_set":6,"id":"7ffa3b31_606706b9","line":710,"range":{"start_line":709,"start_character":0,"end_line":710,"end_character":57},"updated":"2017-04-21 11:47:23.000000000","message":"you do not need it. It was used for required_openstack validator since it was replaced by more general validator - required_platform which accept one extra argument which required_openstack doesn\u0027t have. To support backward compatibility L700 was introduced. In your case, the old and the new validators have the same interface","commit_id":"91c40958970f4f6c3616f7d39e1b8879d1e7475c"}]}
