)]}'
{"rally/plugins/openstack/validators.py":[{"author":{"_account_id":22960,"name":"Hai Shi","email":"shihai1992@gmail.com","username":"haishi"},"change_message_id":"238fe5b0b7bcb1773ea305fa30ab637db647416b","unresolved":false,"context_lines":[{"line_number":179,"context_line":""},{"line_number":180,"context_line":"        :param config: dict, configuration of workload"},{"line_number":181,"context_line":"        :param credentials: credentials dict for all platforms"},{"line_number":182,"context_line":"        :param flavor_name: defines which variable should be used"},{"line_number":183,"context_line":"                           to get flavor id value."},{"line_number":184,"context_line":"        :param image_name: defines which variable should be used"},{"line_number":185,"context_line":"                           to get image id value."},{"line_number":186,"context_line":"        :param validate_disk: flag to indicate whether to validate"},{"line_number":187,"context_line":"                              flavor\u0027s disk."},{"line_number":188,"context_line":"                              Should be True if instance is booted from image."},{"line_number":189,"context_line":"                              Should be False if instance is booted from"},{"line_number":190,"context_line":"                              volume."},{"line_number":191,"context_line":"                              Default value is True."},{"line_number":192,"context_line":"        :param fail_on_404_image: flag what indicate whether to validate image"},{"line_number":193,"context_line":"                                  or not."},{"line_number":194,"context_line":"        \"\"\""},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"        clients \u003d credentials[\"openstack\"][\"admin\"].clients()"}],"source_content_type":"text/x-python","patch_set":9,"id":"5ff73747_41848db1","line":193,"range":{"start_line":182,"start_character":0,"end_line":193,"end_character":41},"updated":"2017-04-25 15:12:09.000000000","message":"But these params don\u0027t be transmited from input.","commit_id":"ca5ecf03161ceafdc905c456988bfad7ac99c5c3"},{"author":{"_account_id":23094,"name":"Staroverov Anton","email":"avstaroverov@gmail.com","username":"astaroverov"},"change_message_id":"858c52b7840d52db04d6762feb5112fd68f323c1","unresolved":false,"context_lines":[{"line_number":179,"context_line":""},{"line_number":180,"context_line":"        :param config: dict, configuration of workload"},{"line_number":181,"context_line":"        :param credentials: credentials dict for all platforms"},{"line_number":182,"context_line":"        :param flavor_name: defines which variable should be used"},{"line_number":183,"context_line":"                           to get flavor id value."},{"line_number":184,"context_line":"        :param image_name: defines which variable should be used"},{"line_number":185,"context_line":"                           to get image id value."},{"line_number":186,"context_line":"        :param validate_disk: flag to indicate whether to validate"},{"line_number":187,"context_line":"                              flavor\u0027s disk."},{"line_number":188,"context_line":"                              Should be True if instance is booted from image."},{"line_number":189,"context_line":"                              Should be False if instance is booted from"},{"line_number":190,"context_line":"                              volume."},{"line_number":191,"context_line":"                              Default value is True."},{"line_number":192,"context_line":"        :param fail_on_404_image: flag what indicate whether to validate image"},{"line_number":193,"context_line":"                                  or not."},{"line_number":194,"context_line":"        \"\"\""},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"        clients \u003d credentials[\"openstack\"][\"admin\"].clients()"}],"source_content_type":"text/x-python","patch_set":9,"id":"5ff73747_4e66db53","line":193,"range":{"start_line":182,"start_character":0,"end_line":193,"end_character":41},"in_reply_to":"5ff73747_41848db1","updated":"2017-04-26 09:36:27.000000000","message":"it\u0027s misprint, thanks","commit_id":"ca5ecf03161ceafdc905c456988bfad7ac99c5c3"},{"author":{"_account_id":21528,"name":"chenhb","email":"chen.haibing1@zte.com.cn","username":"chenhb"},"change_message_id":"da6b6d31f5e7cf1d7da61f979cbd2f3e60bb6b1e","unresolved":false,"context_lines":[{"line_number":188,"context_line":"                config, clients, self.image_name)"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"            if not image and not self.fail_on_404_image:"},{"line_number":191,"context_line":"                return"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"            if not valid_result.is_valid:"},{"line_number":194,"context_line":"                return valid_result"}],"source_content_type":"text/x-python","patch_set":12,"id":"5ff73747_fc1972d6","line":191,"updated":"2017-04-29 15:04:50.000000000","message":"miss result","commit_id":"ba789c9642dc96b13e75324ac3d27ddee0975c50"},{"author":{"_account_id":23094,"name":"Staroverov Anton","email":"avstaroverov@gmail.com","username":"astaroverov"},"change_message_id":"d215cf82150054bdb897747bdce6d775654dc339","unresolved":false,"context_lines":[{"line_number":188,"context_line":"                config, clients, self.image_name)"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"            if not image and not self.fail_on_404_image:"},{"line_number":191,"context_line":"                return"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"            if not valid_result.is_valid:"},{"line_number":194,"context_line":"                return valid_result"}],"source_content_type":"text/x-python","patch_set":12,"id":"5ff73747_94a583a1","line":191,"in_reply_to":"5ff73747_fc1972d6","updated":"2017-05-02 08:46:23.000000000","message":"validators are successful by default, so there is no any reason to return something, we\u0027re just exit from function.","commit_id":"ba789c9642dc96b13e75324ac3d27ddee0975c50"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"cd2bf19dd8555d4e03fe6da9451db9ba2a97aefa","unresolved":false,"context_lines":[{"line_number":80,"context_line":"@validation.configure(name\u003d\"image_valid_on_flavor\", namespace\u003d\"openstack\")"},{"line_number":81,"context_line":"class ImageValidOnFlavorValidator(validation.Validator):"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    def __init__(self, flavor_name, image_name,"},{"line_number":84,"context_line":"                 fail_on_404_image\u003dTrue, validate_disk\u003dTrue):"},{"line_number":85,"context_line":"        \"\"\"Returns validator for image could be used for current flavor"},{"line_number":86,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"5ff73747_95aaf8cf","line":83,"range":{"start_line":83,"start_character":23,"end_line":83,"end_character":47},"updated":"2017-05-03 14:52:37.000000000","message":"let\u0027s name these parameters like \"flavor_param\" and \"image_param\"","commit_id":"21053febfefd9742a7f8fea1e87b7cb01ab4631e"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"cd2bf19dd8555d4e03fe6da9451db9ba2a97aefa","unresolved":false,"context_lines":[{"line_number":179,"context_line":"        for user in credentials[\"openstack\"][\"users\"]:"},{"line_number":180,"context_line":"            clients \u003d user[\"credential\"].clients()"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"            valid_result, flavor \u003d self._get_validated_flavor("},{"line_number":183,"context_line":"                config, clients, self.flavor_name)"},{"line_number":184,"context_line":"            if not valid_result.is_valid:"},{"line_number":185,"context_line":"                return valid_result"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"            valid_result, image \u003d self._get_validated_image("},{"line_number":188,"context_line":"                config, clients, self.image_name)"}],"source_content_type":"text/x-python","patch_set":14,"id":"5ff73747_19d17a58","line":185,"range":{"start_line":182,"start_character":12,"end_line":185,"end_character":35},"updated":"2017-05-03 14:52:37.000000000","message":"\"flavors\" is a common entity for all regular users and admin too, that is why there is no need to validate it for all users. \nLet\u0027s initialize an empty variable \"flavor\" at L178, and make here check `if flavor is None: # get flavor`. In this case only the first user from credentials[\"openstack\"][\"users\"] will check existense of flavor.","commit_id":"21053febfefd9742a7f8fea1e87b7cb01ab4631e"}]}