)]}'
{"rally/aas/server.py":[{"author":{"_account_id":21528,"name":"chenhb","email":"chen.haibing1@zte.com.cn","username":"chenhb"},"change_message_id":"a4b18abec036e6f2b018ab3a5d43aa91d7b88176","unresolved":false,"context_lines":[{"line_number":36,"context_line":"                   and not method.startswith(\"_\")]"},{"line_number":37,"context_line":"        for name, method in methods:"},{"line_number":38,"context_line":"            if hasattr(method, \"path\") and hasattr(method, \"method\"):"},{"line_number":39,"context_line":"                routes.append({\"path\": \"%s/%s\" % (group.strip(\"_\"), name),"},{"line_number":40,"context_line":"                               \"method\": method.method,"},{"line_number":41,"context_line":"                               \"handler\": method})"},{"line_number":42,"context_line":"    return routes"}],"source_content_type":"text/x-python","patch_set":7,"id":"5f201791_83111360","line":39,"updated":"2017-06-27 08:54:11.000000000","message":"why not use method.path ?\nAlso, there is not version in client url.\nhttps://github.com/openstack/rally/blob/master/rally/api.py#L117","commit_id":"ccdf7f8be8e8e6408172f888c76e86f746def4c7"},{"author":{"_account_id":21528,"name":"chenhb","email":"chen.haibing1@zte.com.cn","username":"chenhb"},"change_message_id":"ba67ce50e61e9bde998b46f3fd4bd7257079c6fb","unresolved":false,"context_lines":[{"line_number":36,"context_line":"                   and not method.startswith(\"_\")]"},{"line_number":37,"context_line":"        for name, method in methods:"},{"line_number":38,"context_line":"            if hasattr(method, \"path\") and hasattr(method, \"method\"):"},{"line_number":39,"context_line":"                routes.append({\"path\": \"%s/%s\" % (group.strip(\"_\"), name),"},{"line_number":40,"context_line":"                               \"method\": method.method,"},{"line_number":41,"context_line":"                               \"handler\": method})"},{"line_number":42,"context_line":"    return routes"}],"source_content_type":"text/x-python","patch_set":7,"id":"5f201791_876a1f17","line":39,"in_reply_to":"5f201791_1c0c39a3","updated":"2017-06-27 23:45:51.000000000","message":"sorry,i still do not understand. when we use cli to send request to remote rally, the client rally will request the remote rally via the url, but now the client request url is different from the server response url, i think the client rally will request a wrong url.","commit_id":"ccdf7f8be8e8e6408172f888c76e86f746def4c7"},{"author":{"_account_id":22960,"name":"Hai Shi","email":"shihai1992@gmail.com","username":"haishi"},"change_message_id":"b7c4b020baa4d66ce959d63a817ee15f31a30196","unresolved":false,"context_lines":[{"line_number":36,"context_line":"                   and not method.startswith(\"_\")]"},{"line_number":37,"context_line":"        for name, method in methods:"},{"line_number":38,"context_line":"            if hasattr(method, \"path\") and hasattr(method, \"method\"):"},{"line_number":39,"context_line":"                routes.append({\"path\": \"%s/%s\" % (group.strip(\"_\"), name),"},{"line_number":40,"context_line":"                               \"method\": method.method,"},{"line_number":41,"context_line":"                               \"handler\": method})"},{"line_number":42,"context_line":"    return routes"}],"source_content_type":"text/x-python","patch_set":7,"id":"5f201791_1c0c39a3","line":39,"in_reply_to":"5f201791_83111360","updated":"2017-06-27 13:28:07.000000000","message":"1] method.path should be used in the side of client and side of server should not depend on it.\n2] Version stores in head.","commit_id":"ccdf7f8be8e8e6408172f888c76e86f746def4c7"},{"author":{"_account_id":22960,"name":"Hai Shi","email":"shihai1992@gmail.com","username":"haishi"},"change_message_id":"ff4a9d8e42a120199cf6d9ae1267d5f25eaa5c00","unresolved":false,"context_lines":[{"line_number":36,"context_line":"                   and not method.startswith(\"_\")]"},{"line_number":37,"context_line":"        for name, method in methods:"},{"line_number":38,"context_line":"            if hasattr(method, \"path\") and hasattr(method, \"method\"):"},{"line_number":39,"context_line":"                routes.append({\"path\": \"%s/%s\" % (group.strip(\"_\"), name),"},{"line_number":40,"context_line":"                               \"method\": method.method,"},{"line_number":41,"context_line":"                               \"handler\": method})"},{"line_number":42,"context_line":"    return routes"}],"source_content_type":"text/x-python","patch_set":7,"id":"5f201791_6eda3878","line":39,"in_reply_to":"5f201791_876a1f17","updated":"2017-06-28 03:32:21.000000000","message":"Client and server side are independently, so we should make sure client send a request to a right url. And method.path have little different with the server\u0027s url, such as: version\u0027s info not in method.path.","commit_id":"ccdf7f8be8e8e6408172f888c76e86f746def4c7"}],"rally/cli/manage.py":[{"author":{"_account_id":21528,"name":"chenhb","email":"chen.haibing1@zte.com.cn","username":"chenhb"},"change_message_id":"9b3a1191a65ec9a4da10b3b7ad7a7ddf824e84b1","unresolved":false,"context_lines":[{"line_number":75,"context_line":"                   help\u003d\"Ip of server.\")"},{"line_number":76,"context_line":"    @cliutils.args(\"--port\", type\u003dstr, dest\u003d\"port\", required\u003dTrue,"},{"line_number":77,"context_line":"                   help\u003d\"Port of server.\")"},{"line_number":78,"context_line":"    def start(self, api, ip\u003dNone, port\u003dNone):"},{"line_number":79,"context_line":"        app \u003d server.Application(api)"},{"line_number":80,"context_line":"        app.start(ip, port)"},{"line_number":81,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"5f201791_c7d257d1","line":78,"updated":"2017-06-27 23:49:35.000000000","message":"please add the comment for this command.","commit_id":"d7ac5be4c4e17861af710d5295aa14230326d2c9"},{"author":{"_account_id":22960,"name":"Hai Shi","email":"shihai1992@gmail.com","username":"haishi"},"change_message_id":"56ef52c3ae153b11f86501302ff43c9093ab66b1","unresolved":false,"context_lines":[{"line_number":75,"context_line":"                   help\u003d\"Ip of server.\")"},{"line_number":76,"context_line":"    @cliutils.args(\"--port\", type\u003dstr, dest\u003d\"port\", required\u003dTrue,"},{"line_number":77,"context_line":"                   help\u003d\"Port of server.\")"},{"line_number":78,"context_line":"    def start(self, api, ip\u003dNone, port\u003dNone):"},{"line_number":79,"context_line":"        app \u003d server.Application(api)"},{"line_number":80,"context_line":"        app.start(ip, port)"},{"line_number":81,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"5f201791_4e49bc5d","line":78,"in_reply_to":"5f201791_c7d257d1","updated":"2017-06-28 03:36:12.000000000","message":"Done","commit_id":"d7ac5be4c4e17861af710d5295aa14230326d2c9"}]}
