)]}'
{"rally/plugins/common/validators.py":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"b4f45aa2cc98d9e7395fb652ab503d5a37c15272","unresolved":false,"context_lines":[{"line_number":167,"context_line":"                                           \"type\": num_func.__name__})"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"@validation.configure(name\u003d\"restricted_parameters\", namespace\u003d\"openstack\")"},{"line_number":171,"context_line":"class RestrictedParametersValidator(validation.Validator):"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"    def __init__(self, param_names, subdict\u003dNone, *args):"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f013ff3_dd62fed8","line":170,"range":{"start_line":170,"start_character":50,"end_line":170,"end_character":73},"updated":"2017-05-13 20:16:19.000000000","message":"it is not in openstack namespace. just do not specify it","commit_id":"a3fcd68edf20cdcbd83c40441a200a0620642c1f"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"1f3c141238d95b6dba9bc1c556183239db69e25b","unresolved":false,"context_lines":[{"line_number":170,"context_line":"@validation.configure(name\u003d\"restricted_parameters\")"},{"line_number":171,"context_line":"class RestrictedParametersValidator(validation.Validator):"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"    def __init__(self, param_names, subdict\u003dNone, *args):"},{"line_number":174,"context_line":"        \"\"\"Validates that parameters is not set."},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"        :param param_names: parameter or parameters list to be validated."}],"source_content_type":"text/x-python","patch_set":6,"id":"1f013ff3_df9bd6c6","line":173,"range":{"start_line":173,"start_character":51,"end_line":173,"end_character":55},"updated":"2017-05-16 16:30:18.000000000","message":"it is not used at all. do we need it?","commit_id":"18b6dc383cf725fa98a9b3efccf4518cfa6eb51f"}],"rally/plugins/openstack/scenarios/cinder/volume_types.py":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"f86b8489d655a9f7519e6e22b94f7c13559282af","unresolved":false,"context_lines":[{"line_number":131,"context_line":""},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"@validation.add(\"restricted_parameters\", param_names\u003d\"name\")"},{"line_number":134,"context_line":"@validation.add(\"required_services\", services\u003dconsts.Service.CINDER)"},{"line_number":135,"context_line":"@validation.required_contexts(\"volume_types\")"},{"line_number":136,"context_line":"@validation.add(\"required_params\", params\u003d[(\"create_specs\", \"provider\")])"},{"line_number":137,"context_line":"@validation.restricted_parameters(\"name\")"},{"line_number":138,"context_line":"@validation.add(\"required_services\", services\u003d[consts.Service.CINDER])"}],"source_content_type":"text/x-python","patch_set":10,"id":"ff0f0b1f_45bfcd60","line":135,"range":{"start_line":134,"start_character":0,"end_line":135,"end_character":45},"updated":"2017-05-20 07:53:04.000000000","message":"it is redundant","commit_id":"74618ea6bf39cab700bd2addd4587feab084d1b2"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"f86b8489d655a9f7519e6e22b94f7c13559282af","unresolved":false,"context_lines":[{"line_number":134,"context_line":"@validation.add(\"required_services\", services\u003dconsts.Service.CINDER)"},{"line_number":135,"context_line":"@validation.required_contexts(\"volume_types\")"},{"line_number":136,"context_line":"@validation.add(\"required_params\", params\u003d[(\"create_specs\", \"provider\")])"},{"line_number":137,"context_line":"@validation.restricted_parameters(\"name\")"},{"line_number":138,"context_line":"@validation.add(\"required_services\", services\u003d[consts.Service.CINDER])"},{"line_number":139,"context_line":"@validation.add(\"required_platform\", platform\u003d\"openstack\", admin\u003dTrue)"},{"line_number":140,"context_line":"@scenario.configure(context\u003d{\"admin_cleanup\": [\"cinder\"]},"}],"source_content_type":"text/x-python","patch_set":10,"id":"ff0f0b1f_25c299ea","line":137,"range":{"start_line":137,"start_character":0,"end_line":137,"end_character":41},"updated":"2017-05-20 07:53:04.000000000","message":"it should be replaced by L133","commit_id":"74618ea6bf39cab700bd2addd4587feab084d1b2"}],"rally/plugins/openstack/validators.py":[{"author":{"_account_id":19011,"name":"Anton Studenov","email":"tohin1332@gmail.com","username":"tohin"},"change_message_id":"dca08fd417d7a7c3074c09848824c0b03aa0338b","unresolved":false,"context_lines":[{"line_number":344,"context_line":""},{"line_number":345,"context_line":""},{"line_number":346,"context_line":"@validation.add(\"required_platform\", platform\u003d\"openstack\", users\u003dTrue)"},{"line_number":347,"context_line":"@validation.configure(name\u003d\"restricted_parameters\", namespace\u003d\"openstack\")"},{"line_number":348,"context_line":"class RestrictedParametersValidator(validation.Validator):"},{"line_number":349,"context_line":""},{"line_number":350,"context_line":"    def __init__(self, param_names, subdict\u003dNone, *args):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f044301_528d32d1","line":347,"range":{"start_line":347,"start_character":52,"end_line":347,"end_character":73},"updated":"2017-05-10 19:36:28.000000000","message":"Plugin looks like not OpenStack related","commit_id":"4a5d1f2ea3d82c6eb2ff464ea596c65a38223ec7"},{"author":{"_account_id":19011,"name":"Anton Studenov","email":"tohin1332@gmail.com","username":"tohin"},"change_message_id":"a02a37675996f55b8cd5bb9a7db8a3e44fae6f3b","unresolved":false,"context_lines":[{"line_number":344,"context_line":""},{"line_number":345,"context_line":""},{"line_number":346,"context_line":"@validation.add(\"required_platform\", platform\u003d\"openstack\", users\u003dTrue)"},{"line_number":347,"context_line":"@validation.configure(name\u003d\"restricted_parameters\", namespace\u003d\"openstack\")"},{"line_number":348,"context_line":"class RestrictedParametersValidator(validation.Validator):"},{"line_number":349,"context_line":""},{"line_number":350,"context_line":"    def __init__(self, param_names, subdict\u003dNone, *args):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f044301_cfa4f4a8","line":347,"range":{"start_line":347,"start_character":52,"end_line":347,"end_character":73},"in_reply_to":"3f044301_2f06b81e","updated":"2017-05-11 09:36:08.000000000","message":"yes, I think we can move this plugin to \u0027default\u0027 namespace and remove required_platform\u003d\"openstack\"","commit_id":"4a5d1f2ea3d82c6eb2ff464ea596c65a38223ec7"},{"author":{"_account_id":23094,"name":"Staroverov Anton","email":"avstaroverov@gmail.com","username":"astaroverov"},"change_message_id":"32edbec2895cfd5f518b511c20340047f2bba777","unresolved":false,"context_lines":[{"line_number":344,"context_line":""},{"line_number":345,"context_line":""},{"line_number":346,"context_line":"@validation.add(\"required_platform\", platform\u003d\"openstack\", users\u003dTrue)"},{"line_number":347,"context_line":"@validation.configure(name\u003d\"restricted_parameters\", namespace\u003d\"openstack\")"},{"line_number":348,"context_line":"class RestrictedParametersValidator(validation.Validator):"},{"line_number":349,"context_line":""},{"line_number":350,"context_line":"    def __init__(self, param_names, subdict\u003dNone, *args):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f044301_2f06b81e","line":347,"range":{"start_line":347,"start_character":52,"end_line":347,"end_character":73},"in_reply_to":"3f044301_528d32d1","updated":"2017-05-11 09:12:58.000000000","message":"Do you mean \u0027NOT ONLY openstack related\u0027?","commit_id":"4a5d1f2ea3d82c6eb2ff464ea596c65a38223ec7"}],"tests/unit/plugins/common/test_validators.py":[{"author":{"_account_id":21528,"name":"chenhb","email":"chen.haibing1@zte.com.cn","username":"chenhb"},"change_message_id":"00faeb2f9feaf400167687526cf836ca5a2a9d07","unresolved":false,"context_lines":[{"line_number":202,"context_line":"        result \u003d validator.validate(context, self.credentials, None, None)"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"        if err_msg:"},{"line_number":205,"context_line":"            self.assertTrue(result)"},{"line_number":206,"context_line":"            self.assertEqual(err_msg, result.msg)"},{"line_number":207,"context_line":"        else:"},{"line_number":208,"context_line":"            self.assertIsNone(result)"}],"source_content_type":"text/x-python","patch_set":7,"id":"1f013ff3_da6d0d33","line":205,"updated":"2017-05-17 08:53:03.000000000","message":"I think this line is inapposite. Here we could use self.assertFalse(result.is_valid)","commit_id":"37663beb3c13f70ed1d482b9a9e6500f9dbcd0e7"},{"author":{"_account_id":21528,"name":"chenhb","email":"chen.haibing1@zte.com.cn","username":"chenhb"},"change_message_id":"c4e21ce92a5d9f8ac030039cebd8129db718edf6","unresolved":false,"context_lines":[{"line_number":202,"context_line":"        result \u003d validator.validate(context, self.credentials, None, None)"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"        if err_msg:"},{"line_number":205,"context_line":"            self.assertTrue(result)"},{"line_number":206,"context_line":"            self.assertEqual(err_msg, result.msg)"},{"line_number":207,"context_line":"        else:"},{"line_number":208,"context_line":"            self.assertIsNone(result)"}],"source_content_type":"text/x-python","patch_set":7,"id":"ff0f0b1f_3d2445c6","line":205,"in_reply_to":"1f013ff3_6bbd0dd7","updated":"2017-05-17 23:58:49.000000000","message":"no, i meant line #205. This is the failed case, we have the returned value.\nhttps://github.com/openstack/rally/blob/master/rally/common/validation.py#L50\nAnd \u0027result\u0027 is not a bool value.","commit_id":"37663beb3c13f70ed1d482b9a9e6500f9dbcd0e7"},{"author":{"_account_id":23094,"name":"Staroverov Anton","email":"avstaroverov@gmail.com","username":"astaroverov"},"change_message_id":"9d86404fbe7042735ac4b325e1dc8be33a40b818","unresolved":false,"context_lines":[{"line_number":202,"context_line":"        result \u003d validator.validate(context, self.credentials, None, None)"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"        if err_msg:"},{"line_number":205,"context_line":"            self.assertTrue(result)"},{"line_number":206,"context_line":"            self.assertEqual(err_msg, result.msg)"},{"line_number":207,"context_line":"        else:"},{"line_number":208,"context_line":"            self.assertIsNone(result)"}],"source_content_type":"text/x-python","patch_set":7,"id":"1f013ff3_6bbd0dd7","line":205,"in_reply_to":"1f013ff3_da6d0d33","updated":"2017-05-17 09:51:07.000000000","message":"In general validator in case of success returns nothing (validators are Pass by default), so in your case following message will be shown: \u0027None type doesn\u0027t have .is_valid attribute\u0027","commit_id":"37663beb3c13f70ed1d482b9a9e6500f9dbcd0e7"},{"author":{"_account_id":23094,"name":"Staroverov Anton","email":"avstaroverov@gmail.com","username":"astaroverov"},"change_message_id":"288874e4c842fe4683fa386d5e3ae226082e5d4b","unresolved":false,"context_lines":[{"line_number":202,"context_line":"        result \u003d validator.validate(context, self.credentials, None, None)"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"        if err_msg:"},{"line_number":205,"context_line":"            self.assertTrue(result)"},{"line_number":206,"context_line":"            self.assertEqual(err_msg, result.msg)"},{"line_number":207,"context_line":"        else:"},{"line_number":208,"context_line":"            self.assertIsNone(result)"}],"source_content_type":"text/x-python","patch_set":7,"id":"ff0f0b1f_88bc2a6a","line":205,"in_reply_to":"ff0f0b1f_3d2445c6","updated":"2017-05-18 03:26:32.000000000","message":"We EXPECT that case on line #205 shall be failed. But what if something goes wrong and validator is not failed as expected?\nBut probably usage of \u0027self.assertIsNotNone\u0027 is a better solution in this case","commit_id":"37663beb3c13f70ed1d482b9a9e6500f9dbcd0e7"},{"author":{"_account_id":21528,"name":"chenhb","email":"chen.haibing1@zte.com.cn","username":"chenhb"},"change_message_id":"353235a9423da36b200449ffe9bafd6539233292","unresolved":false,"context_lines":[{"line_number":202,"context_line":"        result \u003d validator.validate(context, self.credentials, None, None)"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"        if err_msg:"},{"line_number":205,"context_line":"            self.assertTrue(result)"},{"line_number":206,"context_line":"            self.assertEqual(err_msg, result.msg)"},{"line_number":207,"context_line":"        else:"},{"line_number":208,"context_line":"            self.assertIsNone(result)"}],"source_content_type":"text/x-python","patch_set":7,"id":"ff0f0b1f_3eae782e","line":205,"in_reply_to":"ff0f0b1f_88bc2a6a","updated":"2017-05-18 05:06:35.000000000","message":"it is ok too if using \u0027self.assertIsNotNone\u0027. :)","commit_id":"37663beb3c13f70ed1d482b9a9e6500f9dbcd0e7"}]}
