)]}'
{"rally/plugins/openstack/scenarios/manila/shares.py":[{"author":{"_account_id":21528,"name":"chenhb","email":"chen.haibing1@zte.com.cn","username":"chenhb"},"change_message_id":"f834976710a52004ccfa8b99839180501602b47c","unresolved":false,"context_lines":[{"line_number":70,"context_line":""},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"@validation.validate_share_proto()"},{"line_number":73,"context_line":"@validation.required_services(consts.Service.MANILA)"},{"line_number":74,"context_line":"@validation.required_openstack(users\u003dTrue)"},{"line_number":75,"context_line":"@scenario.configure(context\u003d{\"cleanup\": [\"manila\"]},"},{"line_number":76,"context_line":"                    name\u003d\"ManilaShares.create_and_extend_share\")"},{"line_number":77,"context_line":"class CreateAndExtendShare(utils.ManilaScenario):"}],"source_content_type":"text/x-python","patch_set":3,"id":"df140735_0afea2ad","line":74,"range":{"start_line":73,"start_character":0,"end_line":74,"end_character":42},"updated":"2017-05-31 07:55:45.000000000","message":"please use new validator like line #116, #117. :)","commit_id":"08e6b0faed2d4f936da25f22d0680b9b3c82436f"},{"author":{"_account_id":21528,"name":"chenhb","email":"chen.haibing1@zte.com.cn","username":"chenhb"},"change_message_id":"f834976710a52004ccfa8b99839180501602b47c","unresolved":false,"context_lines":[{"line_number":75,"context_line":"@scenario.configure(context\u003d{\"cleanup\": [\"manila\"]},"},{"line_number":76,"context_line":"                    name\u003d\"ManilaShares.create_and_extend_share\")"},{"line_number":77,"context_line":"class CreateAndExtendShare(utils.ManilaScenario):"},{"line_number":78,"context_line":"    def run(self, share_proto, size\u003d1, new_size\u003d2, **kwargs):"},{"line_number":79,"context_line":"        \"\"\"Create and extend a share"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"        :param share_proto: share protocol, valid values are NFS, CIFS,"}],"source_content_type":"text/x-python","patch_set":3,"id":"df140735_ca09ca95","line":78,"updated":"2017-05-31 07:55:45.000000000","message":"Here i want we should restrict name argument, custom name is not expected in rally, we cleanup resources which was created by rally via name.\nAlso, here could we use explicit arguments? like https://github.com/openstack/python-manilaclient/blob/master/manilaclient/v2/shares.py#L121-L124","commit_id":"08e6b0faed2d4f936da25f22d0680b9b3c82436f"},{"author":{"_account_id":21528,"name":"chenhb","email":"chen.haibing1@zte.com.cn","username":"chenhb"},"change_message_id":"f834976710a52004ccfa8b99839180501602b47c","unresolved":false,"context_lines":[{"line_number":92,"context_line":""},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"@validation.validate_share_proto()"},{"line_number":95,"context_line":"@validation.required_services(consts.Service.MANILA)"},{"line_number":96,"context_line":"@validation.required_openstack(users\u003dTrue)"},{"line_number":97,"context_line":"@scenario.configure(context\u003d{\"cleanup\": [\"manila\"]},"},{"line_number":98,"context_line":"                    name\u003d\"ManilaShares.create_and_shrink_share\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"df140735_2a4966cf","line":95,"updated":"2017-05-31 07:55:45.000000000","message":"same here","commit_id":"08e6b0faed2d4f936da25f22d0680b9b3c82436f"},{"author":{"_account_id":21528,"name":"chenhb","email":"chen.haibing1@zte.com.cn","username":"chenhb"},"change_message_id":"f834976710a52004ccfa8b99839180501602b47c","unresolved":false,"context_lines":[{"line_number":97,"context_line":"@scenario.configure(context\u003d{\"cleanup\": [\"manila\"]},"},{"line_number":98,"context_line":"                    name\u003d\"ManilaShares.create_and_shrink_share\")"},{"line_number":99,"context_line":"class CreateAndShrinkShare(utils.ManilaScenario):"},{"line_number":100,"context_line":"    def run(self, share_proto, size\u003d2, new_size\u003d1, **kwargs):"},{"line_number":101,"context_line":"        \"\"\"Create and shrink a share"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"        :param share_proto: share protocol, valid values are NFS, CIFS,"}],"source_content_type":"text/x-python","patch_set":3,"id":"df140735_0a4462b6","line":100,"updated":"2017-05-31 07:55:45.000000000","message":"same here","commit_id":"08e6b0faed2d4f936da25f22d0680b9b3c82436f"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"bb45cd55de1258fbe297cd575830d6c3a2234107","unresolved":false,"context_lines":[{"line_number":116,"context_line":"@scenario.configure(context\u003d{\"cleanup\": [\"manila\"]},"},{"line_number":117,"context_line":"                    name\u003d\"ManilaShares.create_and_shrink_share\")"},{"line_number":118,"context_line":"class CreateAndShrinkShare(utils.ManilaScenario):"},{"line_number":119,"context_line":"    def run(self, share_proto, size\u003d1, new_size\u003d2, snapshot_id\u003dNone,"},{"line_number":120,"context_line":"            description\u003dNone, metadata\u003dNone, share_network\u003dNone,"},{"line_number":121,"context_line":"            share_type\u003dNone, is_public\u003dFalse, availability_zone\u003dNone,"},{"line_number":122,"context_line":"            share_group_id\u003dNone):"}],"source_content_type":"text/x-python","patch_set":4,"id":"df140735_59511662","line":119,"range":{"start_line":119,"start_character":31,"end_line":119,"end_character":49},"updated":"2017-05-31 10:33:26.000000000","message":"It is shrink operation, new size should be less than current one.","commit_id":"8ef7d0d7377eafaaa35d67351477594c3b575a43"},{"author":{"_account_id":18404,"name":"Ma Xinjian","email":"maxj.fnst@cn.fujitsu.com","username":"maxinjian"},"change_message_id":"46209e9393d6ae9394ef67671e1a702cf9d5fecd","unresolved":false,"context_lines":[{"line_number":70,"context_line":""},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"@validation.validate_share_proto()"},{"line_number":73,"context_line":"@validation.add(\"required_services\", services\u003d[consts.Service.MANILA])"},{"line_number":74,"context_line":"@validation.add(\"required_platform\", platform\u003d\"openstack\", users\u003dTrue)"},{"line_number":75,"context_line":"@scenario.configure(context\u003d{\"cleanup\": [\"manila\"]},"},{"line_number":76,"context_line":"                    name\u003d\"ManilaShares.create_and_extend_share\")"}],"source_content_type":"text/x-python","patch_set":6,"id":"df140735_7d9001ee","line":73,"range":{"start_line":73,"start_character":46,"end_line":73,"end_character":69},"updated":"2017-06-02 06:44:47.000000000","message":"small nits\n\nredundant [],refer to https://review.openstack.org/#/c/468973/1/rally/plugins/openstack/scenarios/manila/shares.py","commit_id":"07f4842591e2b2a6aad1bf395e5269b9b54c2dca"},{"author":{"_account_id":18404,"name":"Ma Xinjian","email":"maxj.fnst@cn.fujitsu.com","username":"maxinjian"},"change_message_id":"46209e9393d6ae9394ef67671e1a702cf9d5fecd","unresolved":false,"context_lines":[{"line_number":111,"context_line":""},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"@validation.validate_share_proto()"},{"line_number":114,"context_line":"@validation.add(\"required_services\", services\u003d[consts.Service.MANILA])"},{"line_number":115,"context_line":"@validation.add(\"required_platform\", platform\u003d\"openstack\", users\u003dTrue)"},{"line_number":116,"context_line":"@scenario.configure(context\u003d{\"cleanup\": [\"manila\"]},"},{"line_number":117,"context_line":"                    name\u003d\"ManilaShares.create_and_shrink_share\")"}],"source_content_type":"text/x-python","patch_set":6,"id":"df140735_3df28971","line":114,"range":{"start_line":114,"start_character":46,"end_line":114,"end_character":69},"updated":"2017-06-02 06:44:47.000000000","message":"same here","commit_id":"07f4842591e2b2a6aad1bf395e5269b9b54c2dca"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"2ccf2f51f622a09c4e6d524b647b58c4ea1249e5","unresolved":false,"context_lines":[{"line_number":75,"context_line":"@scenario.configure(context\u003d{\"cleanup\": [\"manila\"]},"},{"line_number":76,"context_line":"                    name\u003d\"ManilaShares.create_and_extend_share\")"},{"line_number":77,"context_line":"class CreateAndExtendShare(utils.ManilaScenario):"},{"line_number":78,"context_line":"    def run(self, share_proto, size\u003d1, new_size\u003d2, snapshot_id\u003dNone,"},{"line_number":79,"context_line":"            description\u003dNone, metadata\u003dNone, share_network\u003dNone,"},{"line_number":80,"context_line":"            share_type\u003dNone, is_public\u003dFalse, availability_zone\u003dNone,"},{"line_number":81,"context_line":"            share_group_id\u003dNone):"},{"line_number":82,"context_line":"        \"\"\"Create and extend a share"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        :param share_proto: share protocol for new share"}],"source_content_type":"text/x-python","patch_set":9,"id":"7f231b9d_d0e99d80","line":81,"range":{"start_line":78,"start_character":18,"end_line":81,"end_character":31},"updated":"2017-06-12 13:09:59.000000000","message":"Why do you use explicit definition of keys instead o \"kwargs\"? Using \"kwargs\" you remove dependency on version of manilaclient and provide arguments from scenario template directly without need to update source code.","commit_id":"4c72db22bca32bfb391238528f66b648d7359637"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"0d2d7c8ce4611f24d4f2a3c3e458f4f2622dd775","unresolved":false,"context_lines":[{"line_number":75,"context_line":"@scenario.configure(context\u003d{\"cleanup\": [\"manila\"]},"},{"line_number":76,"context_line":"                    name\u003d\"ManilaShares.create_and_extend_share\")"},{"line_number":77,"context_line":"class CreateAndExtendShare(utils.ManilaScenario):"},{"line_number":78,"context_line":"    def run(self, share_proto, size\u003d1, new_size\u003d2, snapshot_id\u003dNone,"},{"line_number":79,"context_line":"            description\u003dNone, metadata\u003dNone, share_network\u003dNone,"},{"line_number":80,"context_line":"            share_type\u003dNone, is_public\u003dFalse, availability_zone\u003dNone,"},{"line_number":81,"context_line":"            share_group_id\u003dNone):"},{"line_number":82,"context_line":"        \"\"\"Create and extend a share"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        :param share_proto: share protocol for new share"}],"source_content_type":"text/x-python","patch_set":9,"id":"7f231b9d_e6c05f53","line":81,"range":{"start_line":78,"start_character":18,"end_line":81,"end_character":31},"in_reply_to":"7f231b9d_d0e99d80","updated":"2017-06-12 13:32:54.000000000","message":"Usually, I ask to do it in such way. The explicit definition of keys provides a good documentation. I mean I\u0027m not a manila expert, but with such documentation, it is easy to understand what to transmit here to launch it.","commit_id":"4c72db22bca32bfb391238528f66b648d7359637"},{"author":{"_account_id":21528,"name":"chenhb","email":"chen.haibing1@zte.com.cn","username":"chenhb"},"change_message_id":"181890eb48a42a88448e252f78853b0e194197f5","unresolved":false,"context_lines":[{"line_number":81,"context_line":"            share_group_id\u003dNone):"},{"line_number":82,"context_line":"        \"\"\"Create and extend a share"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        :param share_proto: share protocol for new share"},{"line_number":85,"context_line":"            available values are NFS, CIFS, CephFS, GlusterFS and HDFS."},{"line_number":86,"context_line":"        :param size: size in GiB"},{"line_number":87,"context_line":"        :param new_size: new size of the share in GiB"},{"line_number":88,"context_line":"        :param snapshot_id: ID of the snapshot"}],"source_content_type":"text/x-python","patch_set":9,"id":"7f231b9d_a4e14701","line":85,"range":{"start_line":84,"start_character":1,"end_line":85,"end_character":71},"updated":"2017-06-12 11:11:41.000000000","message":"if this is a enum type, please use enum validation to share_proto arugment.\nlike this line https://github.com/openstack/rally/blob/master/rally/plugins/openstack/scenarios/neutron/bgpvpn.py#L55","commit_id":"4c72db22bca32bfb391238528f66b648d7359637"},{"author":{"_account_id":21528,"name":"chenhb","email":"chen.haibing1@zte.com.cn","username":"chenhb"},"change_message_id":"181890eb48a42a88448e252f78853b0e194197f5","unresolved":false,"context_lines":[{"line_number":122,"context_line":"            share_group_id\u003dNone):"},{"line_number":123,"context_line":"        \"\"\"Create and shrink a share"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"        :param share_proto: share protocol for new share"},{"line_number":126,"context_line":"            available values are NFS, CIFS, CephFS, GlusterFS and HDFS."},{"line_number":127,"context_line":"        :param size: size in GiB"},{"line_number":128,"context_line":"        :param new_size: new size of the share in GiB"},{"line_number":129,"context_line":"        :param snapshot_id: ID of the snapshot"}],"source_content_type":"text/x-python","patch_set":9,"id":"7f231b9d_e4c05f53","line":126,"range":{"start_line":125,"start_character":4,"end_line":126,"end_character":71},"updated":"2017-06-12 11:11:41.000000000","message":"same here","commit_id":"4c72db22bca32bfb391238528f66b648d7359637"}],"tests/unit/plugins/openstack/scenarios/manila/test_utils.py":[{"author":{"_account_id":21528,"name":"chenhb","email":"chen.haibing1@zte.com.cn","username":"chenhb"},"change_message_id":"f834976710a52004ccfa8b99839180501602b47c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"df140735_2a50465d","updated":"2017-05-31 07:55:45.000000000","message":"miss the unit test of _shrink_share?","commit_id":"08e6b0faed2d4f936da25f22d0680b9b3c82436f"}]}