)]}'
{"rally-jobs/rally-manila-no-ss.yaml":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"d49adae67661539e09835f5ab312e7d9ba973118","unresolved":false,"context_lines":[{"line_number":51,"context_line":"            gigabytes: -1"},{"line_number":52,"context_line":"        users:"},{"line_number":53,"context_line":"          tenants: 2"},{"line_number":54,"context_line":"          users_per_tenant: 1"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"  {% for s in (\"create_and_delete_share\", \"create_and_list_share\") %}"},{"line_number":57,"context_line":"  ManilaShares.{{s}}:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"1f1a1f67_ccd4aa4a","line":54,"updated":"2017-07-19 15:00:46.000000000","message":"you need to add sla section.","commit_id":"c571b4790e1d4ae6aa27b8ad479d5ed29121b3af"}],"rally-jobs/rally-manila.yaml":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"bdf283c0aebb4660bdfa67d13ae2c2a7abb9e165","unresolved":false,"context_lines":[{"line_number":88,"context_line":"        failure_rate:"},{"line_number":89,"context_line":"          max: 0"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"  ManilaShares.create_and_allow_and_deny_access_share:"},{"line_number":92,"context_line":"    -"},{"line_number":93,"context_line":"      args:"},{"line_number":94,"context_line":"        share_proto: \"nfs\""},{"line_number":95,"context_line":"        size: 1"},{"line_number":96,"context_line":"        access: \"127.0.0.1\""},{"line_number":97,"context_line":"        access_type: \"ip\""},{"line_number":98,"context_line":"      runner:"},{"line_number":99,"context_line":"        type: \"constant\""},{"line_number":100,"context_line":"        times: 2"},{"line_number":101,"context_line":"        concurrency: 2"},{"line_number":102,"context_line":"      context:"},{"line_number":103,"context_line":"        quotas:"},{"line_number":104,"context_line":"          manila:"},{"line_number":105,"context_line":"            shares: -1"},{"line_number":106,"context_line":"            gigabytes: -1"},{"line_number":107,"context_line":"        users:"},{"line_number":108,"context_line":"          tenants: 2"},{"line_number":109,"context_line":"          users_per_tenant: 1"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"  {% for s in (\"create_and_delete_share\", \"create_and_list_share\") %}"},{"line_number":112,"context_line":"  ManilaShares.{{s}}:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3f1d235d_7c2ead92","line":109,"range":{"start_line":91,"start_character":1,"end_line":109,"end_character":29},"updated":"2017-07-05 11:00:36.000000000","message":"This scenario does not use share-networks, but this FILE is for such scenarios.","commit_id":"3d4f7da6e42eeea5d34f13c747d56f02b53e2993"}],"rally/plugins/openstack/cfg/manila.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"e8eeabe74fc509b55d56b161b626a61900bb1c27","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    cfg.FloatOpt("},{"line_number":43,"context_line":"        \"manila_access_create_timeout\","},{"line_number":44,"context_line":"        default\u003d300.0,"},{"line_number":45,"context_line":"        help\u003d\"Timeout for Manila share creation.\"),"},{"line_number":46,"context_line":"    cfg.FloatOpt("},{"line_number":47,"context_line":"        \"manila_access_create_poll_interval\","},{"line_number":48,"context_line":"        default\u003d3.0,"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f1d235d_916172ac","line":45,"range":{"start_line":45,"start_character":14,"end_line":45,"end_character":48},"updated":"2017-07-05 10:38:58.000000000","message":"copy-paste","commit_id":"3d4f7da6e42eeea5d34f13c747d56f02b53e2993"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"d49adae67661539e09835f5ab312e7d9ba973118","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"1f1a1f67_0cbe22fe","line":61,"updated":"2017-07-19 15:00:46.000000000","message":"you need to call `tox -egenconfig` to update a sample of config file.","commit_id":"c571b4790e1d4ae6aa27b8ad479d5ed29121b3af"}],"rally/plugins/openstack/scenarios/manila/shares.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"79cc7f266bebfe4e8a67f035731f725874141e8d","unresolved":false,"context_lines":[{"line_number":153,"context_line":"@scenario.configure(context\u003d{\"cleanup\": [\"manila\"]},"},{"line_number":154,"context_line":"                    name\u003d\"ManilaShares.create_and_allow_and_deny_access_share\")"},{"line_number":155,"context_line":"class CreateAndAllowAndDenyAccessShare(utils.ManilaScenario):"},{"line_number":156,"context_line":"    def run(self, share_proto, access_type, access, access_level\u003d\"rw\", size\u003d1,"},{"line_number":157,"context_line":"            snapshot_id\u003dNone, description\u003dNone, metadata\u003dNone,"},{"line_number":158,"context_line":"            share_network\u003dNone, share_type\u003dNone, is_public\u003dFalse,"},{"line_number":159,"context_line":"            availability_zone\u003dNone, share_group_id\u003dNone):"},{"line_number":160,"context_line":"        \"\"\"Create a share and allow and deny access to it"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"        :param share_proto: share protocol for new share"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f231b9d_cbcb2ea3","line":159,"range":{"start_line":156,"start_character":31,"end_line":159,"end_character":55},"updated":"2017-06-12 13:16:19.000000000","message":"Same question as in [1].\n\n[1] https://review.openstack.org/#/c/469170/9/rally/plugins/openstack/scenarios/manila/shares.py","commit_id":"f5c89d4df9ff08234cf11ebc6a76991ab391a54b"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"96dcd24097623f9c0ea8419ee41b5818215bab4e","unresolved":false,"context_lines":[{"line_number":239,"context_line":"@validation.required_services(consts.Service.MANILA)"},{"line_number":240,"context_line":"@validation.required_openstack(users\u003dTrue)"},{"line_number":241,"context_line":"@scenario.configure(context\u003d{\"cleanup\": [\"manila\"]},"},{"line_number":242,"context_line":"                    name\u003d\"ManilaShares.create_and_allow_and_deny_access_share\")"},{"line_number":243,"context_line":"class CreateAndAllowAndDenyAccessShare(utils.ManilaScenario):"},{"line_number":244,"context_line":"    def run(self, share_proto, access_type, access, access_level\u003d\"rw\", size\u003d1,"},{"line_number":245,"context_line":"            snapshot_id\u003dNone, description\u003dNone, metadata\u003dNone,"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f1d235d_d1180a1f","line":242,"range":{"start_line":242,"start_character":39,"end_line":242,"end_character":77},"updated":"2017-07-05 10:53:48.000000000","message":"s/create_and_allow_and_deny_access_share/create_share_then_allow_and_deny_access/ ?","commit_id":"3d4f7da6e42eeea5d34f13c747d56f02b53e2993"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"96dcd24097623f9c0ea8419ee41b5818215bab4e","unresolved":false,"context_lines":[{"line_number":240,"context_line":"@validation.required_openstack(users\u003dTrue)"},{"line_number":241,"context_line":"@scenario.configure(context\u003d{\"cleanup\": [\"manila\"]},"},{"line_number":242,"context_line":"                    name\u003d\"ManilaShares.create_and_allow_and_deny_access_share\")"},{"line_number":243,"context_line":"class CreateAndAllowAndDenyAccessShare(utils.ManilaScenario):"},{"line_number":244,"context_line":"    def run(self, share_proto, access_type, access, access_level\u003d\"rw\", size\u003d1,"},{"line_number":245,"context_line":"            snapshot_id\u003dNone, description\u003dNone, metadata\u003dNone,"},{"line_number":246,"context_line":"            share_network\u003dNone, share_type\u003dNone, is_public\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f1d235d_71349693","line":243,"range":{"start_line":243,"start_character":6,"end_line":243,"end_character":38},"updated":"2017-07-05 10:53:48.000000000","message":"s/CreateAndAllowAndDenyAccessShare/CreateShareThenAllowAndDenyAccess/ ?","commit_id":"3d4f7da6e42eeea5d34f13c747d56f02b53e2993"}],"rally/plugins/openstack/scenarios/manila/utils.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"79cc7f266bebfe4e8a67f035731f725874141e8d","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        access_result \u003d share.allow(access_type, access, access_level)"},{"line_number":99,"context_line":"        utils.wait_for_status("},{"line_number":100,"context_line":"            share,"},{"line_number":101,"context_line":"            ready_statuses\u003d[\"available\"],"},{"line_number":102,"context_line":"            update_resource\u003dutils.get_from_manager(),"},{"line_number":103,"context_line":"            timeout\u003dCONF.benchmark.manila_share_create_timeout,"},{"line_number":104,"context_line":"            check_interval\u003dCONF.benchmark.manila_share_create_poll_interval)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f231b9d_eb9f0ab2","line":101,"range":{"start_line":101,"start_character":12,"end_line":101,"end_character":41},"updated":"2017-06-12 13:16:19.000000000","message":"It is status of a share. You should track status of an access rule, not share\u0027s. Same below.","commit_id":"f5c89d4df9ff08234cf11ebc6a76991ab391a54b"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"3b3440a1f0a5754c77283217eaff0c07fd44991e","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        access_result \u003d share.allow(access_type, access, access_level)"},{"line_number":99,"context_line":"        utils.wait_for_status("},{"line_number":100,"context_line":"            share,"},{"line_number":101,"context_line":"            ready_statuses\u003d[\"available\"],"},{"line_number":102,"context_line":"            update_resource\u003dutils.get_from_manager(),"},{"line_number":103,"context_line":"            timeout\u003dCONF.benchmark.manila_share_create_timeout,"},{"line_number":104,"context_line":"            check_interval\u003dCONF.benchmark.manila_share_create_poll_interval)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f231b9d_8320e4f8","line":101,"range":{"start_line":101,"start_character":12,"end_line":101,"end_character":41},"in_reply_to":"7f231b9d_9453846b","updated":"2017-06-16 12:04:16.000000000","message":"Not by index in list, but by ID.","commit_id":"f5c89d4df9ff08234cf11ebc6a76991ab391a54b"},{"author":{"_account_id":25568,"name":"Luis Pigueiras","email":"lpigueiras@gmail.com","username":"lpigueiras"},"change_message_id":"07306a325c92aff0067f3a1d90c93de37de54ce1","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        access_result \u003d share.allow(access_type, access, access_level)"},{"line_number":99,"context_line":"        utils.wait_for_status("},{"line_number":100,"context_line":"            share,"},{"line_number":101,"context_line":"            ready_statuses\u003d[\"available\"],"},{"line_number":102,"context_line":"            update_resource\u003dutils.get_from_manager(),"},{"line_number":103,"context_line":"            timeout\u003dCONF.benchmark.manila_share_create_timeout,"},{"line_number":104,"context_line":"            check_interval\u003dCONF.benchmark.manila_share_create_poll_interval)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f231b9d_9453846b","line":101,"range":{"start_line":101,"start_character":12,"end_line":101,"end_character":41},"in_reply_to":"7f231b9d_eb9f0ab2","updated":"2017-06-16 12:00:23.000000000","message":"Any idea how to do this? Something like this is fine: https://pastebin.com/3W012wEi  ?","commit_id":"f5c89d4df9ff08234cf11ebc6a76991ab391a54b"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"79cc7f266bebfe4e8a67f035731f725874141e8d","unresolved":false,"context_lines":[{"line_number":101,"context_line":"            ready_statuses\u003d[\"available\"],"},{"line_number":102,"context_line":"            update_resource\u003dutils.get_from_manager(),"},{"line_number":103,"context_line":"            timeout\u003dCONF.benchmark.manila_share_create_timeout,"},{"line_number":104,"context_line":"            check_interval\u003dCONF.benchmark.manila_share_create_poll_interval)"},{"line_number":105,"context_line":"        return access_result"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    @atomic.action_timer(\"manila.access_deny_share\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f231b9d_2b8e2278","line":104,"range":{"start_line":104,"start_character":42,"end_line":104,"end_character":75},"updated":"2017-06-12 13:16:19.000000000","message":"Not sure that we should use the same timeout.","commit_id":"f5c89d4df9ff08234cf11ebc6a76991ab391a54b"},{"author":{"_account_id":25568,"name":"Luis Pigueiras","email":"lpigueiras@gmail.com","username":"lpigueiras"},"change_message_id":"07306a325c92aff0067f3a1d90c93de37de54ce1","unresolved":false,"context_lines":[{"line_number":101,"context_line":"            ready_statuses\u003d[\"available\"],"},{"line_number":102,"context_line":"            update_resource\u003dutils.get_from_manager(),"},{"line_number":103,"context_line":"            timeout\u003dCONF.benchmark.manila_share_create_timeout,"},{"line_number":104,"context_line":"            check_interval\u003dCONF.benchmark.manila_share_create_poll_interval)"},{"line_number":105,"context_line":"        return access_result"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    @atomic.action_timer(\"manila.access_deny_share\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f231b9d_ebf4aa5d","line":104,"range":{"start_line":104,"start_character":42,"end_line":104,"end_character":75},"in_reply_to":"7f231b9d_2b8e2278","updated":"2017-06-16 12:00:23.000000000","message":"A new one then?","commit_id":"f5c89d4df9ff08234cf11ebc6a76991ab391a54b"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"3b3440a1f0a5754c77283217eaff0c07fd44991e","unresolved":false,"context_lines":[{"line_number":101,"context_line":"            ready_statuses\u003d[\"available\"],"},{"line_number":102,"context_line":"            update_resource\u003dutils.get_from_manager(),"},{"line_number":103,"context_line":"            timeout\u003dCONF.benchmark.manila_share_create_timeout,"},{"line_number":104,"context_line":"            check_interval\u003dCONF.benchmark.manila_share_create_poll_interval)"},{"line_number":105,"context_line":"        return access_result"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    @atomic.action_timer(\"manila.access_deny_share\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f231b9d_a325200b","line":104,"range":{"start_line":104,"start_character":42,"end_line":104,"end_character":75},"in_reply_to":"7f231b9d_ebf4aa5d","updated":"2017-06-16 12:04:16.000000000","message":"Could be new, yes.","commit_id":"f5c89d4df9ff08234cf11ebc6a76991ab391a54b"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"1b8751e8b9c0148ee9d1f682511d6cc98180869c","unresolved":false,"context_lines":[{"line_number":95,"context_line":"            resource"},{"line_number":96,"context_line":"        \"\"\""},{"line_number":97,"context_line":"        def _is_created(_):"},{"line_number":98,"context_line":"            return next(access for access in share.access_list()"},{"line_number":99,"context_line":"                        if access.id \u003d\u003d access_id)"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"        return _is_created"},{"line_number":102,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"3f1d235d_b36ce49c","line":99,"range":{"start_line":98,"start_character":19,"end_line":99,"end_character":50},"updated":"2017-07-10 13:54:00.000000000","message":"this code duplicates in several places. I suggest you move it to separate method. Also, the code for _is_deleted action looks valid as for _is_created, i.e if access is None, it is not created and we should raise an exception :)","commit_id":"b1b2a39dfd47cc37c31878cc1e25995df4ca6312"}],"samples/tasks/scenarios/manila/create-share-allow-and-deny-access.json":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"d49adae67661539e09835f5ab312e7d9ba973118","unresolved":false,"context_lines":[{"line_number":23,"context_line":"                    \"tenants\": 2,"},{"line_number":24,"context_line":"                    \"users_per_tenant\": 1"},{"line_number":25,"context_line":"                }"},{"line_number":26,"context_line":"            }"},{"line_number":27,"context_line":"        }"},{"line_number":28,"context_line":"    ]"},{"line_number":29,"context_line":"}"}],"source_content_type":"application/json","patch_set":8,"id":"1f1a1f67_4c765a72","line":26,"updated":"2017-07-19 15:00:46.000000000","message":"do not forget about sla section :)","commit_id":"c571b4790e1d4ae6aa27b8ad479d5ed29121b3af"}],"tests/unit/plugins/openstack/scenarios/manila/test_utils.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"9e628891e6786aaa7750946b33563d252441aeab","unresolved":false,"context_lines":[{"line_number":157,"context_line":"        fake_share.allow.return_value \u003d fake_allow_result"},{"line_number":158,"context_line":"        fake_share.access_list.return_value \u003d [fake_access]"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"        assert self.scenario._allow_access_share("},{"line_number":161,"context_line":"            fake_share, access_type, access, access_level) \u003d\u003d fake_allow_result"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"        self.scenario._update_resource_in_allow_access_share \\"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f1d235d_9c006903","line":160,"range":{"start_line":160,"start_character":8,"end_line":160,"end_character":14},"updated":"2017-07-05 10:58:19.000000000","message":"built-in assert should not be used. it should be \"self.assertEqual()\"","commit_id":"3d4f7da6e42eeea5d34f13c747d56f02b53e2993"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"9e628891e6786aaa7750946b33563d252441aeab","unresolved":false,"context_lines":[{"line_number":170,"context_line":"            timeout\u003d300.0)"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"    @ddt.data("},{"line_number":173,"context_line":"        {\"access_id\": \"foo\"},"},{"line_number":174,"context_line":"        {\"access_id\": \"bar\"}"},{"line_number":175,"context_line":"    )"},{"line_number":176,"context_line":"    @ddt.unpack"},{"line_number":177,"context_line":"    def test__update_resource_in_allow_access_share(self, access_id):"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f1d235d_9132920f","line":174,"range":{"start_line":173,"start_character":8,"end_line":174,"end_character":28},"updated":"2017-07-05 10:58:19.000000000","message":"These two test completely the same code. It is useless to duplicate, better to add something else that will cover other code lines.","commit_id":"3d4f7da6e42eeea5d34f13c747d56f02b53e2993"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"9e628891e6786aaa7750946b33563d252441aeab","unresolved":false,"context_lines":[{"line_number":229,"context_line":"        fn \u003d self.scenario._update_resource_in_deny_access_share("},{"line_number":230,"context_line":"            fake_share, access_id)"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"        assert fn(fake_resource) \u003d\u003d fake_access"},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"    @ddt.data("},{"line_number":235,"context_line":"        {\"access_id\": \"foo\"},"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f1d235d_d17daab2","line":232,"range":{"start_line":232,"start_character":8,"end_line":232,"end_character":47},"updated":"2017-07-05 10:58:19.000000000","message":"self.assertEqual(fake_access, fn(fake_resource))","commit_id":"3d4f7da6e42eeea5d34f13c747d56f02b53e2993"}]}
