)]}'
{"rally/plugins/openstack/scenarios/neutron/network.py":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"e62b48cca7f12fcc0b8f26f3256adae68aae81c5","unresolved":false,"context_lines":[{"line_number":560,"context_line":""},{"line_number":561,"context_line":"@validation.add(\"required_services\","},{"line_number":562,"context_line":"                services\u003d[consts.Service.NEUTRON])"},{"line_number":563,"context_line":"@validation.add(\"required_platform\", platform\u003d\"openstack\", admin\u003dTrue)"},{"line_number":564,"context_line":"@scenario.configure(context\u003d{\"cleanup\": [\"neutron\"]},"},{"line_number":565,"context_line":"                    name\u003d\"NeutronNetworks.create_and_list_qos_policies\")"},{"line_number":566,"context_line":"class CreateAndListQosPolicies(utils.NeutronScenario):"}],"source_content_type":"text/x-python","patch_set":5,"id":"7f231b9d_3c942737","line":563,"range":{"start_line":563,"start_character":59,"end_line":563,"end_character":69},"updated":"2017-06-12 15:28:29.000000000","message":"it doesn\u0027t look as true, these neutron actions don\u0027t require admin user. please change to users\u003dTrue","commit_id":"da1ec06a7c42a993465c086a929b3a7f9b22ccfe"},{"author":{"_account_id":22960,"name":"Hai Shi","email":"shihai1992@gmail.com","username":"haishi"},"change_message_id":"7373e1323361fcc5c4ecc7cb35f91770d5f97e64","unresolved":false,"context_lines":[{"line_number":565,"context_line":"                    name\u003d\"NeutronNetworks.create_and_list_qos_policies\")"},{"line_number":566,"context_line":"class CreateAndListQosPolicies(utils.NeutronScenario):"},{"line_number":567,"context_line":""},{"line_number":568,"context_line":"    def run(self, policies_args\u003dNone):"},{"line_number":569,"context_line":"        \"\"\"Create a network qos policy and list the policies"},{"line_number":570,"context_line":""},{"line_number":571,"context_line":"        Measure the \"neutron create_qos_policy\" and \"neutron list_qos_policy\""}],"source_content_type":"text/x-python","patch_set":5,"id":"7f231b9d_f8537be1","line":568,"range":{"start_line":568,"start_character":18,"end_line":568,"end_character":31},"updated":"2017-06-11 02:30:38.000000000","message":"Pls use exact arguments.","commit_id":"da1ec06a7c42a993465c086a929b3a7f9b22ccfe"},{"author":{"_account_id":22960,"name":"Hai Shi","email":"shihai1992@gmail.com","username":"haishi"},"change_message_id":"7373e1323361fcc5c4ecc7cb35f91770d5f97e64","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"7f231b9d_d850bfd7","line":579,"updated":"2017-06-11 02:30:38.000000000","message":"use assertIn function to judge the created qos in list of qos.","commit_id":"da1ec06a7c42a993465c086a929b3a7f9b22ccfe"},{"author":{"_account_id":22960,"name":"Hai Shi","email":"shihai1992@gmail.com","username":"haishi"},"change_message_id":"28f7d9ecf2d4a0eae28be1bb2c20f9bdfd405180","unresolved":false,"context_lines":[{"line_number":574,"context_line":"        :param policies: dict, POST /v2.0/qos/policies/ request options"},{"line_number":575,"context_line":"        \"\"\""},{"line_number":576,"context_line":"        policies \u003d policies or {}"},{"line_number":577,"context_line":"        created_policy \u003d {}"},{"line_number":578,"context_line":"        all_policies \u003d []"},{"line_number":579,"context_line":"        created_policy \u003d self._create_qos_policy(**policies)"},{"line_number":580,"context_line":"        all_policies \u003d self._list_qos_policies()"},{"line_number":581,"context_line":"        self.assertIn(created_policy[\"policy\"][\"name\"],"}],"source_content_type":"text/x-python","patch_set":14,"id":"3f1d235d_9f0ced41","line":578,"range":{"start_line":577,"start_character":0,"end_line":578,"end_character":25},"updated":"2017-07-05 00:53:28.000000000","message":"Looks redundant.","commit_id":"284649f9443982939ef36a4460ad0413fc382e5b"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"aca1d12980936ad0b7104721976daa69a7f20d5b","unresolved":false,"context_lines":[{"line_number":560,"context_line":""},{"line_number":561,"context_line":"@validation.add(\"required_services\","},{"line_number":562,"context_line":"                services\u003d[consts.Service.NEUTRON])"},{"line_number":563,"context_line":"@validation.add(\"required_platform\", platform\u003d\"openstack\", users\u003dTrue)"},{"line_number":564,"context_line":"@scenario.configure(context\u003d{\"cleanup\": [\"neutron\"]},"},{"line_number":565,"context_line":"                    name\u003d\"NeutronNetworks.create_and_list_qos_policies\")"},{"line_number":566,"context_line":"class CreateAndListQosPolicies(utils.NeutronScenario):"}],"source_content_type":"text/x-python","patch_set":15,"id":"3f1d235d_4ef0dbfd","line":563,"range":{"start_line":563,"start_character":59,"end_line":563,"end_character":69},"updated":"2017-07-05 10:07:48.000000000","message":"it should be `admin\u003dTrue`, since that scenario uses admin user, not regular users.","commit_id":"2ce26429eee5ac5c20dc1815299e97590dbd9183"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"ae8f0484aae02d5b8e3076566bb0a7d135b48019","unresolved":false,"context_lines":[{"line_number":565,"context_line":"                    name\u003d\"NeutronNetworks.create_and_list_qos_policies\")"},{"line_number":566,"context_line":"class CreateAndListQosPolicies(utils.NeutronScenario):"},{"line_number":567,"context_line":""},{"line_number":568,"context_line":"    def run(self, policies\u003dNone):"},{"line_number":569,"context_line":"        \"\"\"Create a network qos policy and list the policies"},{"line_number":570,"context_line":""},{"line_number":571,"context_line":"        Measure the \"neutron create_qos_policy\" and \"neutron list_qos_policy\""}],"source_content_type":"text/x-python","patch_set":15,"id":"3f1d235d_4b9c4d0d","line":568,"range":{"start_line":568,"start_character":18,"end_line":568,"end_character":26},"updated":"2017-07-05 09:57:46.000000000","message":"As far as I understand, it includes not so much arguments, so I prefer to set them explicitly\n\nhttps://developer.openstack.org/api-ref/networking/v2/index.html?expanded\u003dcreate-qos-policy-detail","commit_id":"2ce26429eee5ac5c20dc1815299e97590dbd9183"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"6f5a40f021890a41f46c5d89a29591ef58f63e0a","unresolved":false,"context_lines":[{"line_number":565,"context_line":"                    name\u003d\"NeutronNetworks.create_and_list_qos_policies\")"},{"line_number":566,"context_line":"class CreateAndListQosPolicies(utils.NeutronScenario):"},{"line_number":567,"context_line":""},{"line_number":568,"context_line":"    def run(self):"},{"line_number":569,"context_line":"        \"\"\"Create a network qos policy and list the policies"},{"line_number":570,"context_line":""},{"line_number":571,"context_line":"        Measure the \"neutron create_qos_policy\" and \"neutron list_qos_policy\""}],"source_content_type":"text/x-python","patch_set":18,"id":"3f1d235d_691d460e","line":568,"range":{"start_line":568,"start_character":12,"end_line":568,"end_character":17},"updated":"2017-07-10 11:28:51.000000000","message":"You misunderstood my comment to patch #15 or I expressed unclear:)\n\nCan you extend expected arguments by shared and description accroding to https://developer.openstack.org/api-ref/networking/v2/index.html?expanded\u003dcreate-qos-policy-detail?","commit_id":"f0df3cdac1274b89dcdea8736c6f34db6598007c"}],"rally/plugins/openstack/scenarios/neutron/utils.py":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"aca1d12980936ad0b7104721976daa69a7f20d5b","unresolved":false,"context_lines":[{"line_number":830,"context_line":"        :return dict: a new created policy"},{"line_number":831,"context_line":"        \"\"\""},{"line_number":832,"context_line":"        policies[\"name\"] \u003d self.generate_random_name()"},{"line_number":833,"context_line":"        return self.admin_clients(\"neutron\").create_qos_policy("},{"line_number":834,"context_line":"            {\"policy\": policies})"},{"line_number":835,"context_line":""},{"line_number":836,"context_line":"    @atomic.action_timer(\"neutron.list_qos_policies\")"},{"line_number":837,"context_line":"    def _list_qos_policies(self):"}],"source_content_type":"text/x-python","patch_set":15,"id":"3f1d235d_8ed39360","line":834,"range":{"start_line":833,"start_character":8,"end_line":834,"end_character":33},"updated":"2017-07-05 10:07:48.000000000","message":"can qos policy be created from regular user?","commit_id":"2ce26429eee5ac5c20dc1815299e97590dbd9183"}]}
