)]}'
{"rally/plugins/common/utils.py":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"af5a1af8145bc1a7c8d7f9a9972525f81486391e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2017: Mirantis Inc."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f201791_66cc376a","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":31},"updated":"2017-06-22 12:58:06.000000000","message":"Anton, you do not work in Mirantis now:) so there is no reason to add this copy-right.","commit_id":"ba02a909e1dfa14fda52e447317c25ced75c6fad"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"af5a1af8145bc1a7c8d7f9a9972525f81486391e","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import os"},{"line_number":17,"context_line":"from rally.common import validation"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"class ValidatorUtils(object):"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f201791_c6bb0bc2","line":17,"range":{"start_line":16,"start_character":0,"end_line":17,"end_character":35},"updated":"2017-06-22 12:58:06.000000000","message":"It is strange that pep8 did not fail on this. Imports of built-in packages and own ones should be split.","commit_id":"ba02a909e1dfa14fda52e447317c25ced75c6fad"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"af5a1af8145bc1a7c8d7f9a9972525f81486391e","unresolved":false,"context_lines":[{"line_number":17,"context_line":"from rally.common import validation"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"class ValidatorUtils(object):"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    @staticmethod"},{"line_number":23,"context_line":"    def _file_access_ok(filename, mode, param_name, required\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f201791_e937f8af","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":29},"updated":"2017-06-22 12:58:06.000000000","message":"if it is supposed to be used only in validation, why not just name the whole module \"validation_utils\" or put _file_access_ok method at module level of rally/plugins/common/validation.py","commit_id":"ba02a909e1dfa14fda52e447317c25ced75c6fad"}],"rally/plugins/openstack/scenarios/heat/utils.py":[{"author":{"_account_id":21528,"name":"chenhb","email":"chen.haibing1@zte.com.cn","username":"chenhb"},"change_message_id":"bf7cee51669300a5f8dda55efbc7f6cc4ece6865","unresolved":false,"context_lines":[{"line_number":57,"context_line":"            \"stack_name\": stack_name,"},{"line_number":58,"context_line":"            \"disable_rollback\": True,"},{"line_number":59,"context_line":"            \"parameters\": parameters or {},"},{"line_number":60,"context_line":"            \"template\": os.path.expanduser(template),"},{"line_number":61,"context_line":"            \"files\": files or {},"},{"line_number":62,"context_line":"            \"environment\": environment or {}"},{"line_number":63,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":8,"id":"5f201791_6706e322","line":60,"updated":"2017-06-28 00:00:09.000000000","message":"Hi @Anton, this is not related with this patch. if you wanted to fix our ci ,please commit a new patch. :)\nthanks","commit_id":"6017e01e93acc3db22d02ca527f05b90b00bf784"}]}