)]}'
{"rally/cli/commands/task.py":[{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"ef75df28315d31bf32e95ed5aec8d53437e4b2fd","unresolved":false,"context_lines":[{"line_number":609,"context_line":"                    except jsonschema.ValidationError as e:"},{"line_number":610,"context_line":"                        raise FailedToLoadResults(source\u003dtask_id,"},{"line_number":611,"context_line":"                                                  msg\u003dsix.text_type(e))"},{"line_number":612,"context_line":"            else:"},{"line_number":613,"context_line":"                raise FailedToLoadResults("},{"line_number":614,"context_line":"                    source\u003dtask_id, msg\u003d\"Wrong format\")"},{"line_number":615,"context_line":"        task \u003d {\"subtasks\": []}"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f231b9d_56c4e5f4","line":612,"updated":"2017-06-15 18:44:10.000000000","message":"so I don\u0027t get this, if \"else\" than we should check whatever it\u0027s new format, not just raise exception.","commit_id":"5d59a0cfa64be7ab77b275df73ecacad6df6f986"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"adc0177ff0d338b3eeee8beb288a3e484583cb43","unresolved":false,"context_lines":[{"line_number":609,"context_line":"                    except jsonschema.ValidationError as e:"},{"line_number":610,"context_line":"                        raise FailedToLoadResults(source\u003dtask_id,"},{"line_number":611,"context_line":"                                                  msg\u003dsix.text_type(e))"},{"line_number":612,"context_line":"            else:"},{"line_number":613,"context_line":"                raise FailedToLoadResults("},{"line_number":614,"context_line":"                    source\u003dtask_id, msg\u003d\"Wrong format\")"},{"line_number":615,"context_line":"        task \u003d {\"subtasks\": []}"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f201791_028fd42a","line":612,"in_reply_to":"7f231b9d_56c4e5f4","updated":"2017-06-21 12:21:10.000000000","message":"so we do not have new format yet. lol. it will be soon.","commit_id":"5d59a0cfa64be7ab77b275df73ecacad6df6f986"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"3a888e33be4e2d187f8af60456f309f8be7b7460","unresolved":false,"context_lines":[{"line_number":824,"context_line":"                              key\u003dlambda x: x[\"criterion\"]):"},{"line_number":825,"context_line":"                success \u003d sla.pop(\"success\")"},{"line_number":826,"context_line":"                sla[\"status\"] \u003d success and STATUS_PASS or STATUS_FAIL"},{"line_number":827,"context_line":"                sla[\"benchmark\"] \u003d workload[\"name\"]"},{"line_number":828,"context_line":"                sla[\"pos\"] \u003d workload[\"position\"]"},{"line_number":829,"context_line":"                failed_criteria +\u003d int(not success)"},{"line_number":830,"context_line":"                data.append(sla if tojson else rutils.Struct(**sla))"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f231b9d_5652a53c","line":827,"updated":"2017-06-15 19:17:45.000000000","message":"maybe we should change this from benchmark -\u003e subtask/workload?","commit_id":"5d59a0cfa64be7ab77b275df73ecacad6df6f986"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"adc0177ff0d338b3eeee8beb288a3e484583cb43","unresolved":false,"context_lines":[{"line_number":824,"context_line":"                              key\u003dlambda x: x[\"criterion\"]):"},{"line_number":825,"context_line":"                success \u003d sla.pop(\"success\")"},{"line_number":826,"context_line":"                sla[\"status\"] \u003d success and STATUS_PASS or STATUS_FAIL"},{"line_number":827,"context_line":"                sla[\"benchmark\"] \u003d workload[\"name\"]"},{"line_number":828,"context_line":"                sla[\"pos\"] \u003d workload[\"position\"]"},{"line_number":829,"context_line":"                failed_criteria +\u003d int(not success)"},{"line_number":830,"context_line":"                data.append(sla if tojson else rutils.Struct(**sla))"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f201791_6277a83c","line":827,"in_reply_to":"7f231b9d_5652a53c","updated":"2017-06-21 12:21:10.000000000","message":"let\u0027s do it separately. it relates to a lot of logging messaging in task engine.","commit_id":"5d59a0cfa64be7ab77b275df73ecacad6df6f986"}],"rally/common/db/api.py":[{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"3a888e33be4e2d187f8af60456f309f8be7b7460","unresolved":false,"context_lines":[{"line_number":141,"context_line":"    task \u003d get_impl().task_get(uuid, detailed\u003ddetailed)"},{"line_number":142,"context_line":"    if detailed:"},{"line_number":143,"context_line":"        for subtask in task[\"subtasks\"]:"},{"line_number":144,"context_line":"            for workload in subtask[\"workloads\"]:"},{"line_number":145,"context_line":"                del workload[\"statistics\"]"},{"line_number":146,"context_line":"                del workload[\"context_execution\"]"},{"line_number":147,"context_line":"                del workload[\"_profiling_data\"]"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f231b9d_16166d56","line":144,"updated":"2017-06-15 19:17:45.000000000","message":"this looks quite sad. we shouldn\u0027t load this fields if we are not using them...","commit_id":"5d59a0cfa64be7ab77b275df73ecacad6df6f986"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"adc0177ff0d338b3eeee8beb288a3e484583cb43","unresolved":false,"context_lines":[{"line_number":141,"context_line":"    task \u003d get_impl().task_get(uuid, detailed\u003ddetailed)"},{"line_number":142,"context_line":"    if detailed:"},{"line_number":143,"context_line":"        for subtask in task[\"subtasks\"]:"},{"line_number":144,"context_line":"            for workload in subtask[\"workloads\"]:"},{"line_number":145,"context_line":"                del workload[\"statistics\"]"},{"line_number":146,"context_line":"                del workload[\"context_execution\"]"},{"line_number":147,"context_line":"                del workload[\"_profiling_data\"]"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f201791_a2cf007e","line":144,"in_reply_to":"7f231b9d_16166d56","updated":"2017-06-21 12:21:10.000000000","message":"please be patient, in the following patch one more field will be removed from here. after the step of finalizing interface, the unused fields will be cut","commit_id":"5d59a0cfa64be7ab77b275df73ecacad6df6f986"}],"rally/common/db/sqlalchemy/api.py":[{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"3a888e33be4e2d187f8af60456f309f8be7b7460","unresolved":false,"context_lines":[{"line_number":292,"context_line":"                                \"tag\": t})"},{"line_number":293,"context_line":"                    tag.save()"},{"line_number":294,"context_line":"            # take an updated instance of task"},{"line_number":295,"context_line":"            task \u003d self._task_get(uuid, session\u003dsession)"},{"line_number":296,"context_line":"        return task"},{"line_number":297,"context_line":""},{"line_number":298,"context_line":"    def task_update_status(self, uuid, statuses, status_value):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f231b9d_586bf3b5","line":295,"updated":"2017-06-15 19:17:45.000000000","message":"I would rather return whatever update is successful or not. and if one needs updated version one can query it againt.","commit_id":"5d59a0cfa64be7ab77b275df73ecacad6df6f986"}]}
