)]}'
{"rally/plugins/openstack/verification/tempest/config.py":[{"author":{"_account_id":21528,"name":"chenhb","email":"chen.haibing1@zte.com.cn","username":"chenhb"},"change_message_id":"47259cd28bcee9747bbcfe13a422d9f3982804f6","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"CONF \u003d cfg.CONF"},{"line_number":29,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"class TempestConfigfileManager(object):"}],"source_content_type":"text/x-python","patch_set":6,"id":"5f201791_ac66e550","line":29,"updated":"2017-06-21 01:14:59.000000000","message":"Also,LOG is unused.","commit_id":"715e34eb72597bfe927329ea750eb7d69a9f5d6b"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"9bb6f568c98bdcfaff4ec539400b5abccc93809b","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"CONF \u003d cfg.CONF"},{"line_number":29,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"class TempestConfigfileManager(object):"}],"source_content_type":"text/x-python","patch_set":6,"id":"5f201791_5655974f","line":29,"in_reply_to":"5f201791_ac66e550","updated":"2017-06-21 09:44:01.000000000","message":"I used it in new patch-set :P","commit_id":"715e34eb72597bfe927329ea750eb7d69a9f5d6b"},{"author":{"_account_id":22960,"name":"Hai Shi","email":"shihai1992@gmail.com","username":"haishi"},"change_message_id":"ae5347bb9e8ab3ba687134fc966665d75a6f895a","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        cropped_auth_url \u003d self.clients.keystone._remove_url_version()"},{"line_number":88,"context_line":"        if cropped_auth_url \u003d\u003d self.credential.auth_url:"},{"line_number":89,"context_line":"            # the given auth_url doesn\u0027t contain version"},{"line_number":90,"context_line":"            if len(versions) \u003d\u003d 2:"},{"line_number":91,"context_line":"                # ok, both versions of keystone are enabled, we can take urls"},{"line_number":92,"context_line":"                # there"},{"line_number":93,"context_line":"                uri \u003d versions[0][\"url\"]"}],"source_content_type":"text/x-python","patch_set":6,"id":"5f201791_8927a9b7","line":90,"updated":"2017-06-20 14:49:51.000000000","message":"If keystone have more version in future, those code looks like the hard code.","commit_id":"715e34eb72597bfe927329ea750eb7d69a9f5d6b"},{"author":{"_account_id":21528,"name":"chenhb","email":"chen.haibing1@zte.com.cn","username":"chenhb"},"change_message_id":"47259cd28bcee9747bbcfe13a422d9f3982804f6","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        cropped_auth_url \u003d self.clients.keystone._remove_url_version()"},{"line_number":88,"context_line":"        if cropped_auth_url \u003d\u003d self.credential.auth_url:"},{"line_number":89,"context_line":"            # the given auth_url doesn\u0027t contain version"},{"line_number":90,"context_line":"            if len(versions) \u003d\u003d 2:"},{"line_number":91,"context_line":"                # ok, both versions of keystone are enabled, we can take urls"},{"line_number":92,"context_line":"                # there"},{"line_number":93,"context_line":"                uri \u003d versions[0][\"url\"]"}],"source_content_type":"text/x-python","patch_set":6,"id":"5f201791_f7902a98","line":90,"in_reply_to":"5f201791_8927a9b7","updated":"2017-06-21 01:14:59.000000000","message":"@Hai Shi, looks this segment codes are only for v2.0 and v3","commit_id":"715e34eb72597bfe927329ea750eb7d69a9f5d6b"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"4a1b1c494e9547d123df24b3d8fa228e0286fc62","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        cropped_auth_url \u003d self.clients.keystone._remove_url_version()"},{"line_number":88,"context_line":"        if cropped_auth_url \u003d\u003d self.credential.auth_url:"},{"line_number":89,"context_line":"            # the given auth_url doesn\u0027t contain version"},{"line_number":90,"context_line":"            if len(versions) \u003d\u003d 2:"},{"line_number":91,"context_line":"                # ok, both versions of keystone are enabled, we can take urls"},{"line_number":92,"context_line":"                # there"},{"line_number":93,"context_line":"                uri \u003d versions[0][\"url\"]"}],"source_content_type":"text/x-python","patch_set":6,"id":"5f201791_56c5978d","line":90,"in_reply_to":"5f201791_8927a9b7","updated":"2017-06-21 09:34:01.000000000","message":"Keystone V3 was introduced long time ago(at least several years ago) and not all of projects supports even base features of it. As for global situation, most services move to \"microversioning\" which allows delivering small changes of API in more quicker way (the customers are not happy to move from one major version to another, it is too difficult), so I do not believe that new keystone version will come in next 2-3 years :) After the 2-3 years, I hope the whole this module will be rewritten.\n\nBut anyway, based on your comment and comment at L107, I\u0027ll rewrite logic a bit.","commit_id":"715e34eb72597bfe927329ea750eb7d69a9f5d6b"},{"author":{"_account_id":21528,"name":"chenhb","email":"chen.haibing1@zte.com.cn","username":"chenhb"},"change_message_id":"4fcd3874b4489c9d648f624f7b7124c5bd4e160b","unresolved":false,"context_lines":[{"line_number":94,"context_line":"                uri_v3 \u003d versions[1][\"url\"]"},{"line_number":95,"context_line":"                target_version \u003d 3"},{"line_number":96,"context_line":"            else:"},{"line_number":97,"context_line":"                # only one version is available while discovering, let\u0027s just"},{"line_number":98,"context_line":"                # guess the second auth_url (it should not be used)"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"                # get the most recent version"},{"line_number":101,"context_line":"                target_version \u003d versions[-1][\"version\"][0]"},{"line_number":102,"context_line":"                if target_version \u003d\u003d 2:"},{"line_number":103,"context_line":"                    uri \u003d self.credential.auth_url"},{"line_number":104,"context_line":"                    uri_v3 \u003d parse.urljoin(uri, \"/v3\")"},{"line_number":105,"context_line":"                else:"},{"line_number":106,"context_line":"                    uri_v3 \u003d self.credential.auth_url"},{"line_number":107,"context_line":"                    uri \u003d parse.urljoin(uri_v3, \"/v2.0\")"},{"line_number":108,"context_line":"        else:"},{"line_number":109,"context_line":"            if self.credential.auth_url.rstrip(\"/\").endswith(\"v2.0\"):"},{"line_number":110,"context_line":"                uri \u003d self.credential.auth_url"}],"source_content_type":"text/x-python","patch_set":6,"id":"7f231b9d_2e01a6b0","line":107,"range":{"start_line":97,"start_character":5,"end_line":107,"end_character":56},"updated":"2017-06-20 11:02:14.000000000","message":"Here is len(versions) \u003d\u003d 1?","commit_id":"715e34eb72597bfe927329ea750eb7d69a9f5d6b"}],"rally/ui/templates/ci/index_verify.html":[{"author":{"_account_id":22960,"name":"Hai Shi","email":"shihai1992@gmail.com","username":"haishi"},"change_message_id":"ae5347bb9e8ab3ba687134fc966665d75a6f895a","unresolved":false,"context_lines":[{"line_number":12,"context_line":"    .columns li { position:relative }"},{"line_number":13,"context_line":"    .columns li \u003e :first-child { display:block }"},{"line_number":14,"context_line":"    .columns li \u003e :nth-child(2) { display:block; position:static; left:165px; top:0; white-space:nowrap }"},{"line_number":15,"context_line":"    .fail {color: #cc0000}"},{"line_number":16,"context_line":"    .error {color: #cc0000}"},{"line_number":17,"context_line":"    .success {color: green}"},{"line_number":18,"context_line":"    .skip {color: #A9A9A9}"}],"source_content_type":"text/html","patch_set":6,"id":"5f201791_096959bd","line":15,"range":{"start_line":15,"start_character":18,"end_line":15,"end_character":25},"updated":"2017-06-20 14:49:51.000000000","message":"Why do this changed?","commit_id":"715e34eb72597bfe927329ea750eb7d69a9f5d6b"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"4a1b1c494e9547d123df24b3d8fa228e0286fc62","unresolved":false,"context_lines":[{"line_number":12,"context_line":"    .columns li { position:relative }"},{"line_number":13,"context_line":"    .columns li \u003e :first-child { display:block }"},{"line_number":14,"context_line":"    .columns li \u003e :nth-child(2) { display:block; position:static; left:165px; top:0; white-space:nowrap }"},{"line_number":15,"context_line":"    .fail {color: #cc0000}"},{"line_number":16,"context_line":"    .error {color: #cc0000}"},{"line_number":17,"context_line":"    .success {color: green}"},{"line_number":18,"context_line":"    .skip {color: #A9A9A9}"}],"source_content_type":"text/html","patch_set":6,"id":"5f201791_9640cf09","line":15,"range":{"start_line":15,"start_character":18,"end_line":15,"end_character":25},"in_reply_to":"5f201791_096959bd","updated":"2017-06-21 09:34:01.000000000","message":"It is an attempt to make failed steps more notable/visible.","commit_id":"715e34eb72597bfe927329ea750eb7d69a9f5d6b"}]}
