)]}'
{"rally/plugins/common/validators.py":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"aa309fd9e20cc70b854e6bc92ac63c47f89b7ba8","unresolved":false,"context_lines":[{"line_number":194,"context_line":"        value \u003d config.get(\"args\", {}).get(self.param_name)"},{"line_number":195,"context_line":"        if value:"},{"line_number":196,"context_line":"            if self.case_insensitive:"},{"line_number":197,"context_line":"                test_value \u003d value.lower()"},{"line_number":198,"context_line":"                test_values \u003d [v.lower() for v in self.values]"},{"line_number":199,"context_line":"            else:"},{"line_number":200,"context_line":"                test_value \u003d value"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f231b9d_3b0d86e7","line":197,"range":{"start_line":197,"start_character":17,"end_line":197,"end_character":42},"updated":"2017-06-19 15:53:02.000000000","message":"since python is a quite dynamic language, this and the next line can produce an error, if a user transmits not a string value. let\u0027s make a check:\n\n   if self.case_insensitive:\n       if isinstance(value, six.text_types):\n           value \u003d value.lower()\n\nas for self.values, the similar transformation can be done at `__init__` method:\n\n     \n   self.case_insensitive \u003d case_insensitive\n   if self.case_insensitive:\n       self.values \u003d []\n       for value in values:\n            if isinstance(value, six.text_types):\n               value \u003d value.lower()\n            self.values.append(value)\n    else:\n       self.values \u003d values","commit_id":"c97167f09e62d4813a84d017fc6a04b07b904793"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"9d183de0c8b0b693c66490b0c95d637162da15f6","unresolved":false,"context_lines":[{"line_number":192,"context_line":"        if self.case_insensitive:"},{"line_number":193,"context_line":"            self.values \u003d []"},{"line_number":194,"context_line":"            for value in values:"},{"line_number":195,"context_line":"                if isinstance(value, six.text_type) or isinstance("},{"line_number":196,"context_line":"                        value, six.string_types):"},{"line_number":197,"context_line":"                    value \u003d value.lower()"},{"line_number":198,"context_line":"                self.values.append(value)"},{"line_number":199,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f231b9d_d368a088","line":196,"range":{"start_line":195,"start_character":16,"end_line":196,"end_character":49},"updated":"2017-06-20 08:50:45.000000000","message":"you can merge it together:\n\n    if isinstance(value, (six.text_type, six.string_types)):","commit_id":"f46a8b3f5fe02ced4f67d18fd24c4942c2affa8b"}]}
