)]}'
{"rally/cli/commands/task.py":[{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"cb971f0c2c29074630daf75246db433bc21ce93d","unresolved":false,"context_lines":[{"line_number":619,"context_line":"                    raise FailedToLoadResults(source\u003dtask_id,"},{"line_number":620,"context_line":"                                              msg\u003dsix.text_type(e))"},{"line_number":621,"context_line":""},{"line_number":622,"context_line":"                iter_count \u003d 0"},{"line_number":623,"context_line":"                failed_iter_count \u003d 0"},{"line_number":624,"context_line":"                min_duration \u003d float(\"inf\")"},{"line_number":625,"context_line":"                max_duration \u003d 0"}],"source_content_type":"text/x-python","patch_set":28,"id":"3f1d235d_f55ecbe7","line":622,"updated":"2017-07-10 09:02:36.000000000","message":"so I though that we should have this information in results no?","commit_id":"7159025a59cca8151bd3dded6d932f504fffac64"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"e951a02dba78b1289e7b8266d66fabb079b797c9","unresolved":false,"context_lines":[{"line_number":619,"context_line":"                    raise FailedToLoadResults(source\u003dtask_id,"},{"line_number":620,"context_line":"                                              msg\u003dsix.text_type(e))"},{"line_number":621,"context_line":""},{"line_number":622,"context_line":"                iter_count \u003d 0"},{"line_number":623,"context_line":"                failed_iter_count \u003d 0"},{"line_number":624,"context_line":"                min_duration \u003d float(\"inf\")"},{"line_number":625,"context_line":"                max_duration \u003d 0"}],"source_content_type":"text/x-python","patch_set":28,"id":"3f1d235d_5509ff2e","line":622,"in_reply_to":"3f1d235d_f55ecbe7","updated":"2017-07-10 09:22:46.000000000","message":"L607-702 are about converting old json format(which doesn\u0027t include this information) to the new format. see the following patch of Chen, it adds loading of a new format.","commit_id":"7159025a59cca8151bd3dded6d932f504fffac64"}],"rally/common/db/sqlalchemy/migrations/versions/35fe16d4ab1c_update_tasks_based_on_workloads.py":[{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"8c8154c4541f4a032274feb84b42db462f9df71b","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    \"tasks\","},{"line_number":47,"context_line":"    sa.MetaData(),"},{"line_number":48,"context_line":"    sa.Column(\"id\", sa.Integer, primary_key\u003dTrue, autoincrement\u003dTrue),"},{"line_number":49,"context_line":"    sa.Column(\"uuid\", sa.String(36), default\u003dUUID, nullable\u003dFalse),"},{"line_number":50,"context_line":"    sa.Column(\"task_duration\", sa.Float()),"},{"line_number":51,"context_line":"    sa.Column(\"pass_sla\", sa.Boolean())"},{"line_number":52,"context_line":")"}],"source_content_type":"text/x-python","patch_set":28,"id":"3f1d235d_b5a3b300","side":"PARENT","line":49,"updated":"2017-07-10 08:55:28.000000000","message":"I am really not sure that we should change old migrations. \nIf we are changing old migrations let\u0027s make this explicit as possible in separated commit.","commit_id":"02ec4c065bb1f9df50710542aac9149bd6d391d1"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"7682bccc57daa31c204d5629754f1a40424e7b69","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    \"tasks\","},{"line_number":47,"context_line":"    sa.MetaData(),"},{"line_number":48,"context_line":"    sa.Column(\"id\", sa.Integer, primary_key\u003dTrue, autoincrement\u003dTrue),"},{"line_number":49,"context_line":"    sa.Column(\"uuid\", sa.String(36), default\u003dUUID, nullable\u003dFalse),"},{"line_number":50,"context_line":"    sa.Column(\"task_duration\", sa.Float()),"},{"line_number":51,"context_line":"    sa.Column(\"pass_sla\", sa.Boolean())"},{"line_number":52,"context_line":")"}],"source_content_type":"text/x-python","patch_set":28,"id":"3f1d235d_75f75bd6","side":"PARENT","line":49,"in_reply_to":"3f1d235d_b5a3b300","updated":"2017-07-10 09:03:25.000000000","message":"It doesn\u0027t change anything (we do not call alter, delete or create). It is just helper class which is used for updating existing results.","commit_id":"02ec4c065bb1f9df50710542aac9149bd6d391d1"}],"rally/common/db/sqlalchemy/migrations/versions/c517b0011857_fill_missed_workload_info.py":[{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"8c8154c4541f4a032274feb84b42db462f9df71b","unresolved":false,"context_lines":[{"line_number":111,"context_line":"                        atomics[name][\"max_duration\"] \u003d duration"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"        durations_stat \u003d charts.MainStatsTable("},{"line_number":114,"context_line":"            {\"total_iteration_count\": len(workloads[workload.uuid]),"},{"line_number":115,"context_line":"             \"statistics\": {\"atomics\": atomics}})"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"        for itr in workloads[workload.uuid]:"}],"source_content_type":"text/x-python","patch_set":28,"id":"3f1d235d_b57cd372","line":114,"updated":"2017-07-10 08:55:28.000000000","message":"you can\u0027t just take and change old migration, you need to create new one","commit_id":"7159025a59cca8151bd3dded6d932f504fffac64"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"7682bccc57daa31c204d5629754f1a40424e7b69","unresolved":false,"context_lines":[{"line_number":111,"context_line":"                        atomics[name][\"max_duration\"] \u003d duration"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"        durations_stat \u003d charts.MainStatsTable("},{"line_number":114,"context_line":"            {\"total_iteration_count\": len(workloads[workload.uuid]),"},{"line_number":115,"context_line":"             \"statistics\": {\"atomics\": atomics}})"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"        for itr in workloads[workload.uuid]:"}],"source_content_type":"text/x-python","patch_set":28,"id":"3f1d235d_55e21f03","line":114,"in_reply_to":"3f1d235d_b57cd372","updated":"2017-07-10 09:03:25.000000000","message":"It input values of a class which processes task results. Output of it(L123) doesn\u0027t change.","commit_id":"7159025a59cca8151bd3dded6d932f504fffac64"}],"rally/common/objects/task.py":[{"author":{"_account_id":21528,"name":"chenhb","email":"chen.haibing1@zte.com.cn","username":"chenhb"},"change_message_id":"374e1433cca4c79c258f5d361f2da81194dc07e3","unresolved":false,"context_lines":[{"line_number":228,"context_line":"}"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":""},{"line_number":231,"context_line":"TASK_EXTENDED_RESULT_SCHEMA \u003d {"},{"line_number":232,"context_line":"    \"type\": \"object\","},{"line_number":233,"context_line":"    \"$schema\": consts.JSON_SCHEMA,"},{"line_number":234,"context_line":"    \"properties\": {"},{"line_number":235,"context_line":"        \"id\": {\"type\": \"integer\"},"},{"line_number":236,"context_line":"        \"position\": {\"type\": \"integer\"},"},{"line_number":237,"context_line":"        \"task_uuid\": {\"type\": \"string\"},"},{"line_number":238,"context_line":"        \"name\": {\"type\": \"string\"},"},{"line_number":239,"context_line":"        \"load_duration\": {\"type\": \"number\"},"},{"line_number":240,"context_line":"        \"full_duration\": {\"type\": \"number\"},"},{"line_number":241,"context_line":"        \"data\": {\"type\": \"array\"},"},{"line_number":242,"context_line":"        \"sla\": {"},{"line_number":243,"context_line":"            \"type\": \"array\","},{"line_number":244,"context_line":"            \"items\": {"},{"line_number":245,"context_line":"                \"type\": \"object\","},{"line_number":246,"context_line":"                \"properties\": {"},{"line_number":247,"context_line":"                    \"criterion\": {"},{"line_number":248,"context_line":"                        \"type\": \"string\""},{"line_number":249,"context_line":"                    },"},{"line_number":250,"context_line":"                    \"detail\": {"},{"line_number":251,"context_line":"                        \"type\": \"string\""},{"line_number":252,"context_line":"                    },"},{"line_number":253,"context_line":"                    \"success\": {"},{"line_number":254,"context_line":"                        \"type\": \"boolean\""},{"line_number":255,"context_line":"                    }"},{"line_number":256,"context_line":"                }"},{"line_number":257,"context_line":"            }"},{"line_number":258,"context_line":"        },"},{"line_number":259,"context_line":"        \"hooks\": {\"type\": \"array\", \"items\": HOOK_RESULTS_SCHEMA},"},{"line_number":260,"context_line":"        \"iterations\": {"},{"line_number":261,"context_line":"            \"type\": \"array\","},{"line_number":262,"context_line":"            \"items\": {"},{"line_number":263,"context_line":"                \"type\": \"object\","},{"line_number":264,"context_line":"                \"properties\": {"},{"line_number":265,"context_line":"                    \"timestamp\": {"},{"line_number":266,"context_line":"                        \"type\": \"number\""},{"line_number":267,"context_line":"                    },"},{"line_number":268,"context_line":"                    \"atomic_actions\": {"},{"line_number":269,"context_line":"                        \"type\": \"array\""},{"line_number":270,"context_line":"                    },"},{"line_number":271,"context_line":"                    \"duration\": {"},{"line_number":272,"context_line":"                        \"type\": \"number\""},{"line_number":273,"context_line":"                    },"},{"line_number":274,"context_line":"                    \"error\": {"},{"line_number":275,"context_line":"                        \"type\": \"array\""},{"line_number":276,"context_line":"                    },"},{"line_number":277,"context_line":"                    \"idle_duration\": {"},{"line_number":278,"context_line":"                        \"type\": \"number\""},{"line_number":279,"context_line":"                    },"},{"line_number":280,"context_line":"                    \"output\": OUTPUT_SCHEMA"},{"line_number":281,"context_line":"                },"},{"line_number":282,"context_line":"                \"required\": [\"atomic_actions\", \"duration\", \"error\","},{"line_number":283,"context_line":"                             \"idle_duration\", \"output\"]"},{"line_number":284,"context_line":"            },"},{"line_number":285,"context_line":"            \"minItems\": 1"},{"line_number":286,"context_line":"        },"},{"line_number":287,"context_line":"        \"created_at\": {"},{"line_number":288,"context_line":"            \"anyOf\": ["},{"line_number":289,"context_line":"                {\"type\": \"string\", \"format\": \"date-time\"}"},{"line_number":290,"context_line":"            ]"},{"line_number":291,"context_line":"        },"},{"line_number":292,"context_line":"        \"updated_at\": {"},{"line_number":293,"context_line":"            \"anyOf\": ["},{"line_number":294,"context_line":"                {\"type\": \"string\", \"format\": \"date-time\"}"},{"line_number":295,"context_line":"            ]"},{"line_number":296,"context_line":"        },"},{"line_number":297,"context_line":"        \"info\": {"},{"line_number":298,"context_line":"            \"type\": \"object\","},{"line_number":299,"context_line":"            \"properties\": {"},{"line_number":300,"context_line":"                \"atomic\": {\"type\": \"object\"},"},{"line_number":301,"context_line":"                \"iterations_count\": {\"type\": \"integer\"},"},{"line_number":302,"context_line":"                \"iterations_failed\": {\"type\": \"integer\"},"},{"line_number":303,"context_line":"                \"min_duration\": {\"type\": \"number\"},"},{"line_number":304,"context_line":"                \"max_duration\": {\"type\": \"number\"},"},{"line_number":305,"context_line":"                \"tstamp_start\": {\"type\": \"number\"},"},{"line_number":306,"context_line":"                \"full_duration\": {\"type\": \"number\"},"},{"line_number":307,"context_line":"                \"load_duration\": {\"type\": \"number\"}"},{"line_number":308,"context_line":"            }"},{"line_number":309,"context_line":"        }"},{"line_number":310,"context_line":"    },"},{"line_number":311,"context_line":"    \"required\": [\"name\", \"position\", \"sla\", \"iterations\", \"info\"],"},{"line_number":312,"context_line":"    \"additionalProperties\": False"},{"line_number":313,"context_line":"}"},{"line_number":314,"context_line":""},{"line_number":315,"context_line":""},{"line_number":316,"context_line":"class Task(object):"}],"source_content_type":"text/x-python","patch_set":23,"id":"3f1d235d_5f220aa6","line":313,"range":{"start_line":231,"start_character":0,"end_line":313,"end_character":1},"updated":"2017-07-03 09:25:47.000000000","message":"looks we could remove this json schema.","commit_id":"f8491325b306b72fdfd90e78201185297ae50270"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"b75df8e43e79c83b5efbe400d26aa670f6925e93","unresolved":false,"context_lines":[{"line_number":228,"context_line":"}"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":""},{"line_number":231,"context_line":"TASK_EXTENDED_RESULT_SCHEMA \u003d {"},{"line_number":232,"context_line":"    \"type\": \"object\","},{"line_number":233,"context_line":"    \"$schema\": consts.JSON_SCHEMA,"},{"line_number":234,"context_line":"    \"properties\": {"},{"line_number":235,"context_line":"        \"id\": {\"type\": \"integer\"},"},{"line_number":236,"context_line":"        \"position\": {\"type\": \"integer\"},"},{"line_number":237,"context_line":"        \"task_uuid\": {\"type\": \"string\"},"},{"line_number":238,"context_line":"        \"name\": {\"type\": \"string\"},"},{"line_number":239,"context_line":"        \"load_duration\": {\"type\": \"number\"},"},{"line_number":240,"context_line":"        \"full_duration\": {\"type\": \"number\"},"},{"line_number":241,"context_line":"        \"data\": {\"type\": \"array\"},"},{"line_number":242,"context_line":"        \"sla\": {"},{"line_number":243,"context_line":"            \"type\": \"array\","},{"line_number":244,"context_line":"            \"items\": {"},{"line_number":245,"context_line":"                \"type\": \"object\","},{"line_number":246,"context_line":"                \"properties\": {"},{"line_number":247,"context_line":"                    \"criterion\": {"},{"line_number":248,"context_line":"                        \"type\": \"string\""},{"line_number":249,"context_line":"                    },"},{"line_number":250,"context_line":"                    \"detail\": {"},{"line_number":251,"context_line":"                        \"type\": \"string\""},{"line_number":252,"context_line":"                    },"},{"line_number":253,"context_line":"                    \"success\": {"},{"line_number":254,"context_line":"                        \"type\": \"boolean\""},{"line_number":255,"context_line":"                    }"},{"line_number":256,"context_line":"                }"},{"line_number":257,"context_line":"            }"},{"line_number":258,"context_line":"        },"},{"line_number":259,"context_line":"        \"hooks\": {\"type\": \"array\", \"items\": HOOK_RESULTS_SCHEMA},"},{"line_number":260,"context_line":"        \"iterations\": {"},{"line_number":261,"context_line":"            \"type\": \"array\","},{"line_number":262,"context_line":"            \"items\": {"},{"line_number":263,"context_line":"                \"type\": \"object\","},{"line_number":264,"context_line":"                \"properties\": {"},{"line_number":265,"context_line":"                    \"timestamp\": {"},{"line_number":266,"context_line":"                        \"type\": \"number\""},{"line_number":267,"context_line":"                    },"},{"line_number":268,"context_line":"                    \"atomic_actions\": {"},{"line_number":269,"context_line":"                        \"type\": \"array\""},{"line_number":270,"context_line":"                    },"},{"line_number":271,"context_line":"                    \"duration\": {"},{"line_number":272,"context_line":"                        \"type\": \"number\""},{"line_number":273,"context_line":"                    },"},{"line_number":274,"context_line":"                    \"error\": {"},{"line_number":275,"context_line":"                        \"type\": \"array\""},{"line_number":276,"context_line":"                    },"},{"line_number":277,"context_line":"                    \"idle_duration\": {"},{"line_number":278,"context_line":"                        \"type\": \"number\""},{"line_number":279,"context_line":"                    },"},{"line_number":280,"context_line":"                    \"output\": OUTPUT_SCHEMA"},{"line_number":281,"context_line":"                },"},{"line_number":282,"context_line":"                \"required\": [\"atomic_actions\", \"duration\", \"error\","},{"line_number":283,"context_line":"                             \"idle_duration\", \"output\"]"},{"line_number":284,"context_line":"            },"},{"line_number":285,"context_line":"            \"minItems\": 1"},{"line_number":286,"context_line":"        },"},{"line_number":287,"context_line":"        \"created_at\": {"},{"line_number":288,"context_line":"            \"anyOf\": ["},{"line_number":289,"context_line":"                {\"type\": \"string\", \"format\": \"date-time\"}"},{"line_number":290,"context_line":"            ]"},{"line_number":291,"context_line":"        },"},{"line_number":292,"context_line":"        \"updated_at\": {"},{"line_number":293,"context_line":"            \"anyOf\": ["},{"line_number":294,"context_line":"                {\"type\": \"string\", \"format\": \"date-time\"}"},{"line_number":295,"context_line":"            ]"},{"line_number":296,"context_line":"        },"},{"line_number":297,"context_line":"        \"info\": {"},{"line_number":298,"context_line":"            \"type\": \"object\","},{"line_number":299,"context_line":"            \"properties\": {"},{"line_number":300,"context_line":"                \"atomic\": {\"type\": \"object\"},"},{"line_number":301,"context_line":"                \"iterations_count\": {\"type\": \"integer\"},"},{"line_number":302,"context_line":"                \"iterations_failed\": {\"type\": \"integer\"},"},{"line_number":303,"context_line":"                \"min_duration\": {\"type\": \"number\"},"},{"line_number":304,"context_line":"                \"max_duration\": {\"type\": \"number\"},"},{"line_number":305,"context_line":"                \"tstamp_start\": {\"type\": \"number\"},"},{"line_number":306,"context_line":"                \"full_duration\": {\"type\": \"number\"},"},{"line_number":307,"context_line":"                \"load_duration\": {\"type\": \"number\"}"},{"line_number":308,"context_line":"            }"},{"line_number":309,"context_line":"        }"},{"line_number":310,"context_line":"    },"},{"line_number":311,"context_line":"    \"required\": [\"name\", \"position\", \"sla\", \"iterations\", \"info\"],"},{"line_number":312,"context_line":"    \"additionalProperties\": False"},{"line_number":313,"context_line":"}"},{"line_number":314,"context_line":""},{"line_number":315,"context_line":""},{"line_number":316,"context_line":"class Task(object):"}],"source_content_type":"text/x-python","patch_set":23,"id":"3f1d235d_b4e7fc40","line":313,"range":{"start_line":231,"start_character":0,"end_line":313,"end_character":1},"in_reply_to":"3f1d235d_5f220aa6","updated":"2017-07-03 12:40:27.000000000","message":"yes, it is not used for now, but it can be helpful in the following patch( yours patch:P ), where we need the validation of input data while importing results :)","commit_id":"f8491325b306b72fdfd90e78201185297ae50270"}]}
