)]}'
{"rally-jobs/rally-neutron.yaml":[{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"83ef44cde21f019e2b838990f258c42c311be64d","unresolved":false,"context_lines":[{"line_number":258,"context_line":"        security_group_rule_args: {}"},{"line_number":259,"context_line":"      runner:"},{"line_number":260,"context_line":"        type: \"constant\""},{"line_number":261,"context_line":"        times: 20"},{"line_number":262,"context_line":"        concurrency: 10"},{"line_number":263,"context_line":"      context:"},{"line_number":264,"context_line":"        users:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"df3967d1_47f66565","line":261,"updated":"2017-08-04 19:39:38.000000000","message":"please reduce the log. This is adding huge amount of time in gates: \n\nspecify 4 times with 4 concurrency","commit_id":"2c4b38ff4432955c5f7bd836f32d8bd625eeae86"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"83ef44cde21f019e2b838990f258c42c311be64d","unresolved":false,"context_lines":[{"line_number":262,"context_line":"        concurrency: 10"},{"line_number":263,"context_line":"      context:"},{"line_number":264,"context_line":"        users:"},{"line_number":265,"context_line":"          tenants: 3"},{"line_number":266,"context_line":"          users_per_tenant: 3"},{"line_number":267,"context_line":"        quotas:"},{"line_number":268,"context_line":"          neutron:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"df3967d1_c786d5b9","line":265,"updated":"2017-08-04 19:39:38.000000000","message":"this is going to create 3 tenaants and 9 users. We don\u0027t need that match to check that this things works: \n\nPlease put 2 tenants and 1 users","commit_id":"2c4b38ff4432955c5f7bd836f32d8bd625eeae86"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"83ef44cde21f019e2b838990f258c42c311be64d","unresolved":false,"context_lines":[{"line_number":264,"context_line":"        users:"},{"line_number":265,"context_line":"          tenants: 3"},{"line_number":266,"context_line":"          users_per_tenant: 3"},{"line_number":267,"context_line":"        quotas:"},{"line_number":268,"context_line":"          neutron:"},{"line_number":269,"context_line":"            security_group: -1"},{"line_number":270,"context_line":"      sla:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"df3967d1_878c4dd7","line":267,"updated":"2017-08-04 19:39:38.000000000","message":"you  won\u0027t need to setup quotas here then","commit_id":"2c4b38ff4432955c5f7bd836f32d8bd625eeae86"}],"rally/plugins/openstack/scenarios/neutron/security_groups.py":[{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"6e985be3ba681ed4f951562574bf02781d05f59e","unresolved":false,"context_lines":[{"line_number":225,"context_line":"        self.assertTrue(security_group_rule, err_msg\u003dmsg)"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"        self._delete_security_group_rule("},{"line_number":228,"context_line":"            security_group_rule[\"security_group_rule\"][\"id\"])"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f1a1f67_3fe5eca8","line":228,"updated":"2017-07-16 06:38:37.000000000","message":"It makes sense to delete security group as well here. \n\nOtherwise the purpose of this plugin is not clear: \n\n- From one side we are trying to scalability test of security groups (because we don\u0027t delete them) \n- From other side create-delete security group rule means that we would like to do load/performance testing. \n\nSo it would make sense to delete security group and use it for performance testing (because we already have tests for scale testing with list/show operations)","commit_id":"fe8614b6cb7a84bfd26b23a519d0952dab234b6a"},{"author":{"_account_id":23435,"name":"zhangzhihui","email":"zhangzh.fnst@cn.fujitsu.com","username":"zhangzhang"},"change_message_id":"87da2bf17947344ebf024b2a41a5b1ac713fa025","unresolved":false,"context_lines":[{"line_number":225,"context_line":"        self.assertTrue(security_group_rule, err_msg\u003dmsg)"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"        self._delete_security_group_rule("},{"line_number":228,"context_line":"            security_group_rule[\"security_group_rule\"][\"id\"])"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f1a1f67_72b03644","line":228,"in_reply_to":"1f1a1f67_3fe5eca8","updated":"2017-07-17 02:11:39.000000000","message":"Thanks for your comment.","commit_id":"fe8614b6cb7a84bfd26b23a519d0952dab234b6a"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"6cc07ef690f6dc256e8627c95f71fac83c7133e9","unresolved":false,"context_lines":[{"line_number":196,"context_line":"                services\u003d[consts.Service.NEUTRON])"},{"line_number":197,"context_line":"@validation.add(\"required_platform\", platform\u003d\"openstack\", users\u003dTrue)"},{"line_number":198,"context_line":"@scenario.configure(context\u003d{\"cleanup\": [\"neutron\"]},"},{"line_number":199,"context_line":"                    name\u003d(\"NeutronSecurityGroup\""},{"line_number":200,"context_line":"                          \".create_and_delete_security_group_rule\"))"},{"line_number":201,"context_line":"class CreateAndDeleteSecurityGroupRule(utils.NeutronScenario):"},{"line_number":202,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"df3967d1_e7b43982","line":199,"updated":"2017-08-04 19:40:09.000000000","message":"please don\u0027t split the name it makes it hard to find it using CTRL+F","commit_id":"2c4b38ff4432955c5f7bd836f32d8bd625eeae86"}],"rally/plugins/openstack/scenarios/neutron/utils.py":[{"author":{"_account_id":26229,"name":"Amy Ge","email":"amy.ge@aol.com","username":"yaoge"},"change_message_id":"deaed4c3be081e08722b570f8b9fce0aaa37ce3a","unresolved":false,"context_lines":[{"line_number":846,"context_line":""},{"line_number":847,"context_line":"    @atomic.action_timer(\"neutron.delete_security_group_rule\")"},{"line_number":848,"context_line":"    def _delete_security_group_rule(self, security_group_rule):"},{"line_number":849,"context_line":"        \"\"\"Deletea given security group rule."},{"line_number":850,"context_line":""},{"line_number":851,"context_line":"        :param security_group_rule: id of security group rule"},{"line_number":852,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"1f1a1f67_21780ec2","line":849,"range":{"start_line":849,"start_character":17,"end_line":849,"end_character":19},"updated":"2017-07-17 23:39:34.000000000","message":"missed a space","commit_id":"26ded3d862ae05d30e599276afd6c27a5505015c"}]}