)]}'
{"rally/plugins/openstack/scenarios/neutron/firewall.py":[{"author":{"_account_id":22960,"name":"Hai Shi","email":"shihai1992@gmail.com","username":"haishi"},"change_message_id":"de51f7f3c2368e021d75a49dd3d5cc565a48253b","unresolved":false,"context_lines":[{"line_number":25,"context_line":"@scenario.configure(context\u003d{\"cleanup\": [\"neutron\"]},"},{"line_number":26,"context_line":"                    name\u003d\"NeutronNetworks.create_and_list_firewall_rule\")"},{"line_number":27,"context_line":"class CreateAndListFirewallRules(utils.NeutronScenario):"},{"line_number":28,"context_line":"    def run(self, firewall_create_rule_args\u003dNone):"},{"line_number":29,"context_line":"        \"\"\"Create a firewall rule and list it."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"        The scenario create a firewall and list it."}],"source_content_type":"text/x-python","patch_set":4,"id":"3f1d235d_ce71d20e","line":28,"range":{"start_line":28,"start_character":18,"end_line":28,"end_character":43},"updated":"2017-07-03 08:27:22.000000000","message":"Pls use exact arguments if it could be, like: https://github.com/openstack/rally/blob/master/rally/plugins/openstack/scenarios/keystone/basic.py#L319.","commit_id":"d3f1433f74890bbd361e77f1727ea7f80ceaf524"},{"author":{"_account_id":22960,"name":"Hai Shi","email":"shihai1992@gmail.com","username":"haishi"},"change_message_id":"de51f7f3c2368e021d75a49dd3d5cc565a48253b","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        \"\"\""},{"line_number":36,"context_line":"        firewall_create_rule_args \u003d firewall_create_rule_args or {}"},{"line_number":37,"context_line":"        self._create_firewall_rule(**firewall_create_rule_args)"},{"line_number":38,"context_line":"        self._list_firewall_rule()"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"@validation.add(\"required_services\","}],"source_content_type":"text/x-python","patch_set":4,"id":"3f1d235d_0ec7ca47","line":38,"updated":"2017-07-03 08:27:22.000000000","message":"pls use self.assertIn to judge new firewall_rule in the list of firewall_rules.\nrefs:\n[1]https://github.com/openstack/rally/blob/master/rally/plugins/openstack/scenarios/keystone/basic.py#L392","commit_id":"d3f1433f74890bbd361e77f1727ea7f80ceaf524"},{"author":{"_account_id":22960,"name":"Hai Shi","email":"shihai1992@gmail.com","username":"haishi"},"change_message_id":"de51f7f3c2368e021d75a49dd3d5cc565a48253b","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        \"\"\""},{"line_number":53,"context_line":"        firewall_create_policy_args \u003d firewall_create_policy_args or {}"},{"line_number":54,"context_line":"        self._create_firewall_policy(**firewall_create_policy_args)"},{"line_number":55,"context_line":"        self._list_firewall_policy()"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"@validation.add(\"required_services\", services\u003d[consts.Service.NEUTRON])"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f1d235d_cec0b22d","line":55,"updated":"2017-07-03 08:27:22.000000000","message":"dittio.","commit_id":"d3f1433f74890bbd361e77f1727ea7f80ceaf524"},{"author":{"_account_id":22960,"name":"Hai Shi","email":"shihai1992@gmail.com","username":"haishi"},"change_message_id":"de51f7f3c2368e021d75a49dd3d5cc565a48253b","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        \"\"\""},{"line_number":71,"context_line":"        firewall_create_group_args \u003d firewall_create_group_args or {}"},{"line_number":72,"context_line":"        self._create_firewall_group(**firewall_create_group_args)"},{"line_number":73,"context_line":"        self._list_firewall_group()"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f1d235d_2ed166fc","line":73,"updated":"2017-07-03 08:27:22.000000000","message":"dittio","commit_id":"d3f1433f74890bbd361e77f1727ea7f80ceaf524"}],"tests/unit/plugins/openstack/scenarios/neutron/test_firewall.py":[{"author":{"_account_id":22960,"name":"Hai Shi","email":"shihai1992@gmail.com","username":"haishi"},"change_message_id":"de51f7f3c2368e021d75a49dd3d5cc565a48253b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2014: Intel Inc."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f1d235d_2e8966c9","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":28},"updated":"2017-07-03 08:27:22.000000000","message":"Remove it or add this line:`Copyright 2017: Huawei Inc`.","commit_id":"d3f1433f74890bbd361e77f1727ea7f80ceaf524"}]}