)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":19853,"name":"Nguyen Hung Phuong","email":"phuongnh@vn.fujitsu.com","username":"phuongnh"},"change_message_id":"c689ba0b88b0ceb060a4c2c29f0576107ba230a3","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     unknown \u003cciwei_chen@163.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-07-04 14:12:50 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add Neutron.CreateAndList FirewallGroup scenrio"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I76a6009a2b114397af32e054abe39c7d316d1f2a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f1d235d_4fdb601a","line":7,"range":{"start_line":7,"start_character":40,"end_line":7,"end_character":47},"updated":"2017-07-04 06:21:19.000000000","message":"scenarios","commit_id":"bc719e79d4cdcb7041eca3952480ce197adcac2e"}],"rally/plugins/openstack/scenarios/neutron/firewall_group.py":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"35dbdb5b9888f47ff76e41666767ff3df66e9abc","unresolved":false,"context_lines":[{"line_number":21,"context_line":"@scenario.configure(context\u003d{\"cleanup\": [\"neutron\"]},"},{"line_number":22,"context_line":"                    name\u003d\"NeutronNetworks.create_and_list_firewall_group\")"},{"line_number":23,"context_line":"class CreateAndListFirewallGroup(utils.NeutronScenario):"},{"line_number":24,"context_line":"    def run(self, group\u003dNone):"},{"line_number":25,"context_line":"        \"\"\"Create a firewall group and list it."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"        The scenario create a firewall group and list it."}],"source_content_type":"text/x-python","patch_set":5,"id":"3f1d235d_ae49afb7","line":24,"range":{"start_line":24,"start_character":18,"end_line":24,"end_character":23},"updated":"2017-07-05 10:29:30.000000000","message":"please, list all expected arguments explicitly. It will be easier to understand what to transmit into scenario.","commit_id":"cf4494203804631da507615cc554aac533de024e"},{"author":{"_account_id":18404,"name":"Ma Xinjian","email":"maxj.fnst@cn.fujitsu.com","username":"maxinjian"},"change_message_id":"b1dbe7294154102690914a72cb1e2781edc1b278","unresolved":false,"context_lines":[{"line_number":21,"context_line":"@scenario.configure(context\u003d{\"cleanup\": [\"neutron\"]},"},{"line_number":22,"context_line":"                    name\u003d\"NeutronNetworks.create_and_list_firewall_group\")"},{"line_number":23,"context_line":"class CreateAndListFirewallGroup(utils.NeutronScenario):"},{"line_number":24,"context_line":"    def run(self, firewall_create_args\u003dNone):"},{"line_number":25,"context_line":"        \"\"\"Create a firewall group and list it."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"        The scenario create a firewall group and list it."}],"source_content_type":"text/x-python","patch_set":7,"id":"3f1d235d_ccfbacbe","line":24,"range":{"start_line":24,"start_character":18,"end_line":24,"end_character":38},"updated":"2017-07-06 08:28:13.000000000","message":"please specify and document all available args explicitly instead of having one arg.","commit_id":"38a35eeeddbb63e3710fd316318b9f8c8d002f9e"},{"author":{"_account_id":18404,"name":"Ma Xinjian","email":"maxj.fnst@cn.fujitsu.com","username":"maxinjian"},"change_message_id":"b1dbe7294154102690914a72cb1e2781edc1b278","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"        The scenario create a firewall group and list it."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"        :param firewall_create_args: dict,"},{"line_number":30,"context_line":"        POST /v2.0/fw/firewall_groups request"},{"line_number":31,"context_line":"        \"\"\""},{"line_number":32,"context_line":"        firewall_create_args \u003d firewall_create_args or {}"},{"line_number":33,"context_line":"        created_group \u003d self._create_firewall_group(**firewall_create_args)"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f1d235d_2c346092","line":30,"range":{"start_line":29,"start_character":7,"end_line":30,"end_character":45},"updated":"2017-07-06 08:28:13.000000000","message":"Be carefull with indent","commit_id":"38a35eeeddbb63e3710fd316318b9f8c8d002f9e"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"abdef8a32b83b7f474e71b1d70d2c357a53d0be4","unresolved":false,"context_lines":[{"line_number":15,"context_line":"from rally.plugins.openstack.scenarios.neutron import utils"},{"line_number":16,"context_line":"from rally.task import validation"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"@validation.add(\"required_services\", services\u003d[consts.Service.NEUTRON])"},{"line_number":20,"context_line":"@validation.add(\"required_platform\", platform\u003d\"openstack\", users\u003dTrue)"},{"line_number":21,"context_line":"@scenario.configure(context\u003d{\"cleanup\": [\"neutron\"]},"}],"source_content_type":"text/x-python","patch_set":8,"id":"3f1d235d_e47cdbec","line":18,"updated":"2017-07-10 12:15:38.000000000","message":"as for validation, you need to check that the proper extension is configured.\n\nIt can be done like https://github.com/openstack/rally/blob/master/rally/plugins/openstack/scenarios/neutron/bgpvpn.py#L23","commit_id":"f2785bc27b60f9fa9fbc0da7ef5352037e24dcb0"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"abdef8a32b83b7f474e71b1d70d2c357a53d0be4","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"@validation.add(\"required_services\", services\u003d[consts.Service.NEUTRON])"},{"line_number":20,"context_line":"@validation.add(\"required_platform\", platform\u003d\"openstack\", users\u003dTrue)"},{"line_number":21,"context_line":"@scenario.configure(context\u003d{\"cleanup\": [\"neutron\"]},"},{"line_number":22,"context_line":"                    name\u003d\"NeutronNetworks.create_and_list_firewall_group\")"},{"line_number":23,"context_line":"class CreateAndListFirewallGroup(utils.NeutronScenario):"},{"line_number":24,"context_line":"    def run(self, firewall_create_args\u003dNone):"}],"source_content_type":"text/x-python","patch_set":8,"id":"3f1d235d_64ffab34","line":21,"range":{"start_line":21,"start_character":29,"end_line":21,"end_character":51},"updated":"2017-07-10 12:15:38.000000000","message":"it doesn\u0027t have any magic to handle all resources. Since you add a new type of entity, you need to extend cleanup too. It should be quite simple.\n\nSee https://github.com/openstack/rally/blob/master/rally/plugins/openstack/cleanup/resources.py#L332-L338 for example. Also, we have a special script that checks resources after rally run in gates(checks that cleanup removes everything). You need to extend it too: see https://github.com/openstack/rally/blob/master/tests/ci/osresources.py#L235","commit_id":"f2785bc27b60f9fa9fbc0da7ef5352037e24dcb0"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"67cc149c5b8f5e010bc6e8cf7392903fa26685e5","unresolved":false,"context_lines":[{"line_number":21,"context_line":"@scenario.configure(context\u003d{\"cleanup\": [\"neutron\"]},"},{"line_number":22,"context_line":"                    name\u003d\"NeutronNetworks.create_and_list_firewall_group\")"},{"line_number":23,"context_line":"class CreateAndListFirewallGroup(utils.NeutronScenario):"},{"line_number":24,"context_line":"    def run(self, firewall_create_args\u003dNone):"},{"line_number":25,"context_line":"        \"\"\"Create a firewall group and list it."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"        The scenario create a firewall group and list it."}],"source_content_type":"text/x-python","patch_set":8,"id":"3f1d235d_e992764b","line":24,"range":{"start_line":24,"start_character":18,"end_line":24,"end_character":38},"updated":"2017-07-10 11:34:34.000000000","message":"it would be nice to specify all arguments explicitly(you can check the list of expected arguments here [*]). It will help to provide a better documentation and validation.\n\nAlso, the name should not be available for setting by the task. the name of each resource should be \"random\"(use self.generate_random_name), it allows identifying resources created by Rally and provide a good cleanup.\n\n[*] - https://developer.openstack.org/api-ref/networking/v2/?expanded\u003dcreate-firewall-group-detail","commit_id":"f2785bc27b60f9fa9fbc0da7ef5352037e24dcb0"}],"rally/plugins/openstack/scenarios/neutron/utils.py":[{"author":{"_account_id":19853,"name":"Nguyen Hung Phuong","email":"phuongnh@vn.fujitsu.com","username":"phuongnh"},"change_message_id":"c689ba0b88b0ceb060a4c2c29f0576107ba230a3","unresolved":false,"context_lines":[{"line_number":824,"context_line":""},{"line_number":825,"context_line":"    @atomic.action_timer(\"neutron.create_firewall_group\")"},{"line_number":826,"context_line":"    def _create_firewall_group(self, **create_firewall_group):"},{"line_number":827,"context_line":"        \"\"\"create a firewall group.the scenario create a firewall group."},{"line_number":828,"context_line":""},{"line_number":829,"context_line":"        :param **create_firewall_group: dict,"},{"line_number":830,"context_line":"               Post /v2.0/fw/firewalls create options"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f1d235d_0fde8810","line":827,"range":{"start_line":827,"start_character":11,"end_line":827,"end_character":72},"updated":"2017-07-04 06:21:19.000000000","message":"Is this line duplicated?","commit_id":"bc719e79d4cdcb7041eca3952480ce197adcac2e"},{"author":{"_account_id":19853,"name":"Nguyen Hung Phuong","email":"phuongnh@vn.fujitsu.com","username":"phuongnh"},"change_message_id":"c689ba0b88b0ceb060a4c2c29f0576107ba230a3","unresolved":false,"context_lines":[{"line_number":834,"context_line":""},{"line_number":835,"context_line":"    @atomic.action_timer(\"neutron.list_firewall_group\")"},{"line_number":836,"context_line":"    def _list_firewall_group(self, **list_firewall_group):"},{"line_number":837,"context_line":"        \"\"\"list a firewall group.the scenario list a firewall."},{"line_number":838,"context_line":""},{"line_number":839,"context_line":"        :param **list_firewall_group: dict,"},{"line_number":840,"context_line":"               GET /v2.0/fw/firewalls List firewalls"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f1d235d_afeaf4a8","line":837,"range":{"start_line":837,"start_character":12,"end_line":837,"end_character":24},"updated":"2017-07-04 06:21:19.000000000","message":"ditto","commit_id":"bc719e79d4cdcb7041eca3952480ce197adcac2e"},{"author":{"_account_id":18404,"name":"Ma Xinjian","email":"maxj.fnst@cn.fujitsu.com","username":"maxinjian"},"change_message_id":"b1dbe7294154102690914a72cb1e2781edc1b278","unresolved":false,"context_lines":[{"line_number":848,"context_line":"    def _create_firewall_group(self, **create_firewall_group):"},{"line_number":849,"context_line":"        \"\"\"create a firewall group."},{"line_number":850,"context_line":""},{"line_number":851,"context_line":"        :param **create_firewall_group: dict,"},{"line_number":852,"context_line":"               Post /v2.0/fw/firewalls create options"},{"line_number":853,"context_line":"        \"\"\""},{"line_number":854,"context_line":"        return self.clients(\"neutron\").create_fwaas_firewall_group("},{"line_number":855,"context_line":"            {\"firewall_group\": create_firewall_group})"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f1d235d_e9153a4a","line":852,"range":{"start_line":851,"start_character":9,"end_line":852,"end_character":53},"updated":"2017-07-06 08:28:13.000000000","message":"please add explanation of return value","commit_id":"38a35eeeddbb63e3710fd316318b9f8c8d002f9e"},{"author":{"_account_id":18404,"name":"Ma Xinjian","email":"maxj.fnst@cn.fujitsu.com","username":"maxinjian"},"change_message_id":"b1dbe7294154102690914a72cb1e2781edc1b278","unresolved":false,"context_lines":[{"line_number":858,"context_line":"    def _list_firewall_group(self, **list_firewall_group):"},{"line_number":859,"context_line":"        \"\"\"list a firewall group."},{"line_number":860,"context_line":""},{"line_number":861,"context_line":"        :param **list_firewall_group: dict,"},{"line_number":862,"context_line":"               GET /v2.0/fw/firewalls List firewalls"},{"line_number":863,"context_line":"        \"\"\""},{"line_number":864,"context_line":"        return self.clients(\"neutron\").list_fwaas_firewall_groups("},{"line_number":865,"context_line":"            True, **list_firewall_group)[\"firewall_groups\"]"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f1d235d_69012a06","line":862,"range":{"start_line":861,"start_character":8,"end_line":862,"end_character":52},"updated":"2017-07-06 08:28:13.000000000","message":"same here","commit_id":"38a35eeeddbb63e3710fd316318b9f8c8d002f9e"}]}
