)]}'
{"rally/cli/commands/plugin.py":[{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"9697a4fb545a5b9502f2e6fb80d120cf9a2a917e","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        matched \u003d all_plugins"},{"line_number":96,"context_line":"        if name:"},{"line_number":97,"context_line":"            name_lw \u003d name.lower()"},{"line_number":98,"context_line":"            for p in all_plugins:"},{"line_number":99,"context_line":"                if p.get_name() is None:"},{"line_number":100,"context_line":"                    raise Exception(\"%s.%s\" % (p.__module__, p.__name__))"},{"line_number":101,"context_line":"            matched \u003d [p for p in all_plugins"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f1d235d_3b69df8a","line":98,"updated":"2017-07-09 22:34:48.000000000","message":"This can\u0027t occur anymore, because if you try to create plugin with \"None\" name it will fail and if you are trying to create plugin with same name it will fail and clean meta (so we won\u0027t discover that plugin anymore)","commit_id":"bf80c9239f9b79f9b0d8c0564c7deb5f448bd9c3"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"336ca1a56e06b606b428094954a09bdc4b61e3df","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        matched \u003d all_plugins"},{"line_number":96,"context_line":"        if name:"},{"line_number":97,"context_line":"            name_lw \u003d name.lower()"},{"line_number":98,"context_line":"            for p in all_plugins:"},{"line_number":99,"context_line":"                if p.get_name() is None:"},{"line_number":100,"context_line":"                    raise Exception(\"%s.%s\" % (p.__module__, p.__name__))"},{"line_number":101,"context_line":"            matched \u003d [p for p in all_plugins"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f1d235d_629323a5","line":98,"in_reply_to":"3f1d235d_3b69df8a","updated":"2017-07-10 08:24:20.000000000","message":"(facepalm)\n\n1) the patch had wip status and these lines were added only for debugging :)\n\n2) there was another case with None name -\u003e initializing just meta.\n\nWill update commit message and remove these lines.","commit_id":"bf80c9239f9b79f9b0d8c0564c7deb5f448bd9c3"}],"rally/common/plugin/plugin.py":[{"author":{"_account_id":21528,"name":"chenhb","email":"chen.haibing1@zte.com.cn","username":"chenhb"},"change_message_id":"0527b5c1066e75760337ff6c11f180b723362112","unresolved":false,"context_lines":[{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    def decorator(plugin):"},{"line_number":73,"context_line":"        if name is None:"},{"line_number":74,"context_line":"            raise ValueError(\"The name of a Plugin cannot be None.\")"},{"line_number":75,"context_line":"        plugin._configure(name, namespace)"},{"line_number":76,"context_line":"        plugin._meta_set(\"hidden\", hidden)"},{"line_number":77,"context_line":"        return plugin"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f1d235d_9e68e1ba","line":74,"updated":"2017-07-10 01:32:05.000000000","message":"let us add plugin.__name__ to exception message.","commit_id":"bf80c9239f9b79f9b0d8c0564c7deb5f448bd9c3"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"1bf48b9670ec428bab3757031e6fc338a79cbdb6","unresolved":false,"context_lines":[{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    def decorator(plugin):"},{"line_number":73,"context_line":"        if name is None:"},{"line_number":74,"context_line":"            raise ValueError(\"The name of a Plugin cannot be None.\")"},{"line_number":75,"context_line":"        plugin._configure(name, namespace)"},{"line_number":76,"context_line":"        plugin._meta_set(\"hidden\", hidden)"},{"line_number":77,"context_line":"        return plugin"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f1d235d_a76830ba","line":74,"in_reply_to":"3f1d235d_9e68e1ba","updated":"2017-07-10 05:02:06.000000000","message":"and actually module as well","commit_id":"bf80c9239f9b79f9b0d8c0564c7deb5f448bd9c3"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"336ca1a56e06b606b428094954a09bdc4b61e3df","unresolved":false,"context_lines":[{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    def decorator(plugin):"},{"line_number":73,"context_line":"        if name is None:"},{"line_number":74,"context_line":"            raise ValueError(\"The name of a Plugin cannot be None.\")"},{"line_number":75,"context_line":"        plugin._configure(name, namespace)"},{"line_number":76,"context_line":"        plugin._meta_set(\"hidden\", hidden)"},{"line_number":77,"context_line":"        return plugin"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f1d235d_a2f6dbf8","line":74,"in_reply_to":"3f1d235d_a76830ba","updated":"2017-07-10 08:24:20.000000000","message":"Done","commit_id":"bf80c9239f9b79f9b0d8c0564c7deb5f448bd9c3"}]}