)]}'
{"rally/plugins/openstack/scenarios/nova/utils.py":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"9420b4ed38ef1840d35d255a6dcd741f745b0290","unresolved":false,"context_lines":[{"line_number":692,"context_line":"        return attachment"},{"line_number":693,"context_line":""},{"line_number":694,"context_line":"    @atomic.action_timer(\"nova.detach_volume\")"},{"line_number":695,"context_line":"    def _detach_volume(self, server, volume, attachment\u003dNone):"},{"line_number":696,"context_line":"        server_id \u003d server.id"},{"line_number":697,"context_line":""},{"line_number":698,"context_line":"        self.clients(\"nova\").volumes.delete_server_volume(server_id,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f1a1f67_a3256a5e","line":695,"range":{"start_line":695,"start_character":43,"end_line":695,"end_character":60},"updated":"2017-07-16 09:12:03.000000000","message":"we need to print a warning message in case when this argument is transmitted (I do not see any usage of it now).\n\nAlso, all usage of this method should be modified to not transmit attachament:\n\n    rally/plugins/openstack/scenarios/nova/servers.py:480:            self._detach_volume(server, volume, attachment)\n    rally/plugins/openstack/scenarios/nova/servers.py:772:        self._detach_volume(server, volume, attachment)\n    rally/plugins/openstack/scenarios/cinder/volumes.py:436:        self._detach_volume(server, volume, attachment)\n    rally/plugins/openstack/scenarios/cinder/volumes.py:473:        self._detach_volume(server, volume, attachment)\n    rally/plugins/openstack/scenarios/cinder/volumes.py:544:            self._detach_volume(server, volume, attachment)","commit_id":"1230f585870dd9a35cfb4271a42e0cbcf2762e26"},{"author":{"_account_id":21135,"name":"zhangdaolong","email":"daodragonzhang@gmail.com","username":"zhangdaolong"},"change_message_id":"7d4be4a62ef9ab7718e4d2865e75e2a63f80397c","unresolved":false,"context_lines":[{"line_number":692,"context_line":"        return attachment"},{"line_number":693,"context_line":""},{"line_number":694,"context_line":"    @atomic.action_timer(\"nova.detach_volume\")"},{"line_number":695,"context_line":"    def _detach_volume(self, server, volume, attachment\u003dNone):"},{"line_number":696,"context_line":"        server_id \u003d server.id"},{"line_number":697,"context_line":""},{"line_number":698,"context_line":"        self.clients(\"nova\").volumes.delete_server_volume(server_id,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f1a1f67_e685b05b","line":695,"range":{"start_line":695,"start_character":43,"end_line":695,"end_character":60},"in_reply_to":"1f1a1f67_a3256a5e","updated":"2017-07-16 12:37:55.000000000","message":"Ok You are wright ！\nI will change it","commit_id":"1230f585870dd9a35cfb4271a42e0cbcf2762e26"},{"author":{"_account_id":21528,"name":"chenhb","email":"chen.haibing1@zte.com.cn","username":"chenhb"},"change_message_id":"57891feb3756b94b3348818b950d90c44cc2d6ac","unresolved":false,"context_lines":[{"line_number":693,"context_line":""},{"line_number":694,"context_line":"    @atomic.action_timer(\"nova.detach_volume\")"},{"line_number":695,"context_line":"    def _detach_volume(self, server, volume, attachment\u003dNone):"},{"line_number":696,"context_line":"        LOG.warning(\"attachment_id argument \""},{"line_number":697,"context_line":"                    \"of volumes.delet_server_volume \""},{"line_number":698,"context_line":"                    \"method is deprecated in favor \""},{"line_number":699,"context_line":"                    \"of volume_id.\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f1a1f67_983f67b3","line":696,"updated":"2017-07-17 12:19:33.000000000","message":"please add `if attachment:`, let us print warning while attachment was specified. we have too many log.warning.","commit_id":"cb2cfe702dfe0d61bb4b3f62b6a66be87fe10c25"}]}