)]}'
{"rally-jobs/rally.yaml":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"25dbfe6054f12ff2c068a895300c7c9646df37ca","unresolved":false,"context_lines":[{"line_number":591,"context_line":"            name: \"m1.tiny\""},{"line_number":592,"context_line":"        number_instances: 2"},{"line_number":593,"context_line":"        create_image_kwargs:"},{"line_number":594,"context_line":"          properties:"},{"line_number":595,"context_line":"            hw_video_model: vga"},{"line_number":596,"context_line":"      runner:"},{"line_number":597,"context_line":"        type: \"constant\""},{"line_number":598,"context_line":"        times: 1"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bf3e73b7_530956db","line":595,"range":{"start_line":594,"start_character":10,"end_line":595,"end_character":31},"updated":"2017-08-04 21:15:02.000000000","message":"1) it will fail with TypeError\n2) Glance V2 is a default api version and it looks like it doesn\u0027t support such argument https://developer.openstack.org/api-ref/image/v2/index.html#images","commit_id":"ffc373fad2cf162b4c8ffc4624655bab11584fdf"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"acdeb854e2b6a2ec2757364cc5fcfbde6179eb08","unresolved":false,"context_lines":[{"line_number":601,"context_line":"        users:"},{"line_number":602,"context_line":"          tenants: 3"},{"line_number":603,"context_line":"          users_per_tenant: 1"},{"line_number":604,"context_line":"      sla:"},{"line_number":605,"context_line":"        failure_rate:"},{"line_number":606,"context_line":"          max: 100"},{"line_number":607,"context_line":""},{"line_number":608,"context_line":"  GlanceImages.create_and_update_image:"},{"line_number":609,"context_line":"    -"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bf3e73b7_7989db24","line":606,"range":{"start_line":604,"start_character":5,"end_line":606,"end_character":18},"updated":"2017-08-04 22:44:56.000000000","message":"glance api is not stable after moving under uwsgi, so we applied such temporary workaround. \n\nBut the workload failed:\n\nhttp://logs.openstack.org/39/491039/2/check/gate-rally-dsvm-rally-ubuntu-xenial/f081917/rally-plot/results.html.gz#/GlanceImages.create_image_and_boot_instances/failures","commit_id":"ffc373fad2cf162b4c8ffc4624655bab11584fdf"},{"author":{"_account_id":22960,"name":"Hai Shi","email":"shihai1992@gmail.com","username":"haishi"},"change_message_id":"506eac43ba322a6e33738cb464c4973204ef33d7","unresolved":false,"context_lines":[{"line_number":601,"context_line":"        users:"},{"line_number":602,"context_line":"          tenants: 3"},{"line_number":603,"context_line":"          users_per_tenant: 1"},{"line_number":604,"context_line":"      sla:"},{"line_number":605,"context_line":"        failure_rate:"},{"line_number":606,"context_line":"          max: 100"},{"line_number":607,"context_line":""},{"line_number":608,"context_line":"  GlanceImages.create_and_update_image:"},{"line_number":609,"context_line":"    -"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9f436f4f_e904a67d","line":606,"range":{"start_line":604,"start_character":5,"end_line":606,"end_character":18},"in_reply_to":"bf3e73b7_7989db24","updated":"2017-08-09 16:51:12.000000000","message":"Copy that. Can we adjust the num of failure_rate appropriately?","commit_id":"ffc373fad2cf162b4c8ffc4624655bab11584fdf"}],"rally/plugins/openstack/scenarios/glance/images.py":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"25dbfe6054f12ff2c068a895300c7c9646df37ca","unresolved":false,"context_lines":[{"line_number":201,"context_line":""},{"line_number":202,"context_line":"    def run(self, container_format, image_location, disk_format,"},{"line_number":203,"context_line":"            flavor, number_instances, visibility\u003d\"private\", min_disk\u003d0,"},{"line_number":204,"context_line":"            min_ram\u003d0, boot_server_kwargs\u003dNone, create_image_kwargs\u003dNone,"},{"line_number":205,"context_line":"            **kwargs):"},{"line_number":206,"context_line":"        \"\"\"Create an image and boot several instances from it."},{"line_number":207,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bf3e73b7_501eec70","line":204,"range":{"start_line":204,"start_character":48,"end_line":204,"end_character":72},"updated":"2017-08-04 21:15:02.000000000","message":"1) First of all, I dislike using *_kwargs arguments in scenarios since it is hard to validate the data in it and there is no way to add good documentation(setting all expected arguments explicitly works much much better). \n\n2) \"create_image_kwargs\" doesn\u0027t fix a described issue since self.glance object accepts only unified parameters for both Glance V1 and V2. See https://github.com/openstack/rally/blob/master/rally/plugins/openstack/services/image/image.py#L48-L51 . Does \"properties\" argument available in Glance V2? Can we make some compatible code for V1 and V2?","commit_id":"ffc373fad2cf162b4c8ffc4624655bab11584fdf"}]}
