)]}'
{"rally/plugins/openstack/cleanup/resources.py":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"9e5a0ee71f4b2516173cd4b1422edca386c9ef59","unresolved":false,"context_lines":[{"line_number":598,"context_line":"        # unconditionally reactivate it first. Reactivation is"},{"line_number":599,"context_line":"        # idempotent, so we can safely reactivate an already active"},{"line_number":600,"context_line":"        # image."},{"line_number":601,"context_line":"        client.reactivate_image(self.raw_resource.id)"},{"line_number":602,"context_line":"        client.delete_image(self.raw_resource.id)"},{"line_number":603,"context_line":"        task_utils.wait_for_status("},{"line_number":604,"context_line":"            self.raw_resource, [\"deleted\"],"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f436f4f_fe0464c8","line":601,"range":{"start_line":601,"start_character":8,"end_line":601,"end_character":53},"updated":"2017-08-09 10:08:12.000000000","message":"to reduce number of redundant calls, can we add a check for image.status?","commit_id":"ee92aa74fed1f047b564df47111b804b753cbcb2"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"e662bbe129e87a5dfce780efcb0952b92a5f93ef","unresolved":false,"context_lines":[{"line_number":598,"context_line":"        # unconditionally reactivate it first. Reactivation is"},{"line_number":599,"context_line":"        # idempotent, so we can safely reactivate an already active"},{"line_number":600,"context_line":"        # image."},{"line_number":601,"context_line":"        client.reactivate_image(self.raw_resource.id)"},{"line_number":602,"context_line":"        client.delete_image(self.raw_resource.id)"},{"line_number":603,"context_line":"        task_utils.wait_for_status("},{"line_number":604,"context_line":"            self.raw_resource, [\"deleted\"],"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f436f4f_5a748e35","line":601,"range":{"start_line":601,"start_character":8,"end_line":601,"end_character":53},"in_reply_to":"9f436f4f_fe0464c8","updated":"2017-08-09 18:46:51.000000000","message":"Done","commit_id":"ee92aa74fed1f047b564df47111b804b753cbcb2"}],"rally/plugins/openstack/scenarios/glance/images.py":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"9e5a0ee71f4b2516173cd4b1422edca386c9ef59","unresolved":false,"context_lines":[{"line_number":288,"context_line":""},{"line_number":289,"context_line":"@validation.add(\"required_services\", services\u003d(consts.Service.GLANCE, ))"},{"line_number":290,"context_line":"@validation.add(\"required_platform\", platform\u003d\"openstack\", users\u003dTrue)"},{"line_number":291,"context_line":"@scenario.configure(context\u003d{\"cleanup\": [\"glance\"]},"},{"line_number":292,"context_line":"                    name\u003d\"GlanceImages.create_and_deactivate_image\","},{"line_number":293,"context_line":"                    platform\u003d\"openstack\")"},{"line_number":294,"context_line":"class CreateAndDeactivateImage(GlanceBasic):"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f436f4f_7e73d481","line":291,"updated":"2017-08-09 10:08:12.000000000","message":"It doesn\u0027t make sense to launch the scenario for glance v1. Let\u0027s:\n1) add validator for selected api_version - https://github.com/openstack/rally/blob/master/rally/plugins/openstack/validators.py#L475\n2) do not extend ImageService and GlanceV1Service and just use GlanceV2Service directly.","commit_id":"ee92aa74fed1f047b564df47111b804b753cbcb2"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"e662bbe129e87a5dfce780efcb0952b92a5f93ef","unresolved":false,"context_lines":[{"line_number":288,"context_line":""},{"line_number":289,"context_line":"@validation.add(\"required_services\", services\u003d(consts.Service.GLANCE, ))"},{"line_number":290,"context_line":"@validation.add(\"required_platform\", platform\u003d\"openstack\", users\u003dTrue)"},{"line_number":291,"context_line":"@scenario.configure(context\u003d{\"cleanup\": [\"glance\"]},"},{"line_number":292,"context_line":"                    name\u003d\"GlanceImages.create_and_deactivate_image\","},{"line_number":293,"context_line":"                    platform\u003d\"openstack\")"},{"line_number":294,"context_line":"class CreateAndDeactivateImage(GlanceBasic):"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f436f4f_3a8f8a24","line":291,"in_reply_to":"9f436f4f_7e73d481","updated":"2017-08-09 18:46:51.000000000","message":"Done","commit_id":"ee92aa74fed1f047b564df47111b804b753cbcb2"}],"rally/plugins/openstack/services/image/glance_v2.py":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"eba7bb4924e38fc154c23c7d8a3e049a4c2f2bb1","unresolved":false,"context_lines":[{"line_number":223,"context_line":"        self._check_v2_visibility(visibility)"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"        self._impl.set_visibility(image_id\u003dimage_id, visibility\u003dvisibility)"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"    def deactivate_image(self, image_id):"},{"line_number":228,"context_line":"        \"\"\"deactivate image.\"\"\""},{"line_number":229,"context_line":"        self._impl.deactivate_image(image_id)"},{"line_number":230,"context_line":""},{"line_number":231,"context_line":"    def reactivate_image(self, image_id):"},{"line_number":232,"context_line":"        \"\"\"reactivate image.\"\"\""},{"line_number":233,"context_line":"        self._impl.reactivate_image(image_id)"}],"source_content_type":"text/x-python","patch_set":8,"id":"9f436f4f_8214baa1","line":233,"range":{"start_line":226,"start_character":0,"end_line":233,"end_character":45},"updated":"2017-08-10 13:00:33.000000000","message":"there is no need in these methods.","commit_id":"be2defb5b10adb63da3b027dc7b07ff5bd91c713"}]}