)]}'
{"rally/common/plugin/meta.py":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"82e806f25c02a8c88799e98d9c7d66c55ac1c566","unresolved":false,"context_lines":[{"line_number":125,"context_line":"        if cls is not cls._default_meta[0]:"},{"line_number":126,"context_line":"            raise ReferenceError("},{"line_number":127,"context_line":"                \"Trying to update default meta from children class.\")"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        cls._default_meta[1][key] \u003d value"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f436f4f_80bcd605","line":128,"updated":"2017-08-09 12:01:26.000000000","message":"Let\u0027s hardcode check for restricting setting default name of the plugin.","commit_id":"20598e29140b952411c2b209c8d3d4839d1161b7"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"2e35ab75f2002b3ebcdc43aa817e101920a5e051","unresolved":false,"context_lines":[{"line_number":125,"context_line":"        if cls is not cls._default_meta[0]:"},{"line_number":126,"context_line":"            raise ReferenceError("},{"line_number":127,"context_line":"                \"Trying to update default meta from children class.\")"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        cls._default_meta[1][key] \u003d value"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f436f4f_eb3a56e5","line":128,"in_reply_to":"9f436f4f_80bcd605","updated":"2017-08-09 21:01:17.000000000","message":"- Let\u0027s try to avoid hardcoding of anything especially when it is not needed\n\n- Mixin should not now anything about plugins otherwise it creates hard to understand architecture \n\n Plugin class should control his things (name/platforms/deprecations/...) Mixin just provides the mechanism for it. \n\n- Even if you setup default_meta your plugin won\u0027t work until you trigger plugin.configure that is going to init meta and set name and platfrom, so even if someone sets name and platform in default_meta it won\u0027t change actually anything","commit_id":"20598e29140b952411c2b209c8d3d4839d1161b7"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"fd4e3ec12e1eb0c09793158a7f3cb5f1e410fdbd","unresolved":false,"context_lines":[{"line_number":125,"context_line":"        if cls is not cls._default_meta[0]:"},{"line_number":126,"context_line":"            raise ReferenceError("},{"line_number":127,"context_line":"                \"Trying to update default meta from children class.\")"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        cls._default_meta[1][key] \u003d value"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f436f4f_22862edd","line":128,"in_reply_to":"9f436f4f_eb3a56e5","updated":"2017-08-10 13:01:13.000000000","message":"ok","commit_id":"20598e29140b952411c2b209c8d3d4839d1161b7"}]}