)]}'
{"rally/plugins/openstack/validators.py":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"c007019a17789a271f7c9a2894c814b36938ca21","unresolved":false,"context_lines":[{"line_number":642,"context_line":"        return self._get_validated_flavor(config, credentials, self.param_name)[0]"},{"line_number":643,"context_line":""},{"line_number":644,"context_line":""},{"line_number":645,"context_line":"@validation.add(\"required_platform\", platform\u003d\"openstack\", users\u003dTrue)"},{"line_number":646,"context_line":"@validation.configure(name\u003d\"validate_share_proto\", platform\u003d\"openstack\")"},{"line_number":647,"context_line":"class ValidateShareProtoValidator(validation.Validator):"},{"line_number":648,"context_line":""},{"line_number":649,"context_line":"    def __init__(self,):"},{"line_number":650,"context_line":"        \"\"\"Validates value of share protocol for creation of Manila share.\"\"\""},{"line_number":651,"context_line":""},{"line_number":652,"context_line":"        super(ValidateShareProtoValidator, self).__init__()"},{"line_number":653,"context_line":""},{"line_number":654,"context_line":"    def validate(self, config, credentials, plugin_cls, plugin_cfg):"},{"line_number":655,"context_line":"        allowed \u003d (\"NFS\", \"CIFS\", \"GLUSTERFS\", \"HDFS\", \"CEPHFS\",)"},{"line_number":656,"context_line":"        share_proto \u003d config.get(\"args\", {}).get(\"share_proto\")"},{"line_number":657,"context_line":"        if six.text_type(share_proto).upper() not in allowed:"},{"line_number":658,"context_line":"            message \u003d _(\"Share protocol \u0027%(sp)s\u0027 is invalid, allowed values are \""},{"line_number":659,"context_line":"                        \"%(allowed)s.\") % {\"sp\": share_proto,"},{"line_number":660,"context_line":"                                           \"allowed\": \"\u0027, \u0027\".join(allowed)}"},{"line_number":661,"context_line":"            return self.fail(message)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f436f4f_83550553","line":661,"range":{"start_line":645,"start_character":0,"end_line":661,"end_character":37},"updated":"2017-08-09 09:50:23.000000000","message":"let\u0027s remove this validator at all and replace it usage by enum validator which has similar behavior.","commit_id":"eea645615ffd61fa85b970bef809cabb80ceefe4"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"8e351e47f5d808dbab4fd78167c36fcbfdd77718","unresolved":false,"context_lines":[{"line_number":642,"context_line":"        return self._get_validated_flavor(config, credentials, self.param_name)[0]"},{"line_number":643,"context_line":""},{"line_number":644,"context_line":""},{"line_number":645,"context_line":"@validation.add(\"required_platform\", platform\u003d\"openstack\", users\u003dTrue)"},{"line_number":646,"context_line":"@validation.configure(name\u003d\"validate_share_proto\", platform\u003d\"openstack\")"},{"line_number":647,"context_line":"class ValidateShareProtoValidator(validation.Validator):"},{"line_number":648,"context_line":""},{"line_number":649,"context_line":"    def __init__(self,):"},{"line_number":650,"context_line":"        \"\"\"Validates value of share protocol for creation of Manila share.\"\"\""},{"line_number":651,"context_line":""},{"line_number":652,"context_line":"        super(ValidateShareProtoValidator, self).__init__()"},{"line_number":653,"context_line":""},{"line_number":654,"context_line":"    def validate(self, config, credentials, plugin_cls, plugin_cfg):"},{"line_number":655,"context_line":"        allowed \u003d (\"NFS\", \"CIFS\", \"GLUSTERFS\", \"HDFS\", \"CEPHFS\",)"},{"line_number":656,"context_line":"        share_proto \u003d config.get(\"args\", {}).get(\"share_proto\")"},{"line_number":657,"context_line":"        if six.text_type(share_proto).upper() not in allowed:"},{"line_number":658,"context_line":"            message \u003d _(\"Share protocol \u0027%(sp)s\u0027 is invalid, allowed values are \""},{"line_number":659,"context_line":"                        \"%(allowed)s.\") % {\"sp\": share_proto,"},{"line_number":660,"context_line":"                                           \"allowed\": \"\u0027, \u0027\".join(allowed)}"},{"line_number":661,"context_line":"            return self.fail(message)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f436f4f_6cbbfb0d","line":661,"range":{"start_line":645,"start_character":0,"end_line":661,"end_character":37},"in_reply_to":"9f436f4f_0647b07a","updated":"2017-08-10 21:40:57.000000000","message":"\u003e I think it may be done in separate change. \n\nno. If it is done in the separate patch, it will mean that we need to deprecate two validators (old one and a new one) instead just old one. What is the reason to introduce an entity which will be deprecated from the birth? \n\n\u003e And we should deprecate this one and so on?\n\nIf we do not introduce a new validator, we do not need to deprecate it. The old validator should be deprecated in any case (see rally.task.validators module at the end). \n\nTo simplify the code in rally.task.validors and follow the standard flow for deprecation, we can use `partial` method, like:\n\n    _deprecated_share_proto \u003d deprecated_validator(\n        \"enum\", \"validate_share_proto\", \"0.10.0\")\n\n    validate_share_proto \u003d functools.partial(\n        _deprecated_share_proto, param_name\u003d\"share_proto\", enum\u003d[...])","commit_id":"eea645615ffd61fa85b970bef809cabb80ceefe4"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"01bf90c382e338af8a08dd225637e863eaf98bdc","unresolved":false,"context_lines":[{"line_number":642,"context_line":"        return self._get_validated_flavor(config, credentials, self.param_name)[0]"},{"line_number":643,"context_line":""},{"line_number":644,"context_line":""},{"line_number":645,"context_line":"@validation.add(\"required_platform\", platform\u003d\"openstack\", users\u003dTrue)"},{"line_number":646,"context_line":"@validation.configure(name\u003d\"validate_share_proto\", platform\u003d\"openstack\")"},{"line_number":647,"context_line":"class ValidateShareProtoValidator(validation.Validator):"},{"line_number":648,"context_line":""},{"line_number":649,"context_line":"    def __init__(self,):"},{"line_number":650,"context_line":"        \"\"\"Validates value of share protocol for creation of Manila share.\"\"\""},{"line_number":651,"context_line":""},{"line_number":652,"context_line":"        super(ValidateShareProtoValidator, self).__init__()"},{"line_number":653,"context_line":""},{"line_number":654,"context_line":"    def validate(self, config, credentials, plugin_cls, plugin_cfg):"},{"line_number":655,"context_line":"        allowed \u003d (\"NFS\", \"CIFS\", \"GLUSTERFS\", \"HDFS\", \"CEPHFS\",)"},{"line_number":656,"context_line":"        share_proto \u003d config.get(\"args\", {}).get(\"share_proto\")"},{"line_number":657,"context_line":"        if six.text_type(share_proto).upper() not in allowed:"},{"line_number":658,"context_line":"            message \u003d _(\"Share protocol \u0027%(sp)s\u0027 is invalid, allowed values are \""},{"line_number":659,"context_line":"                        \"%(allowed)s.\") % {\"sp\": share_proto,"},{"line_number":660,"context_line":"                                           \"allowed\": \"\u0027, \u0027\".join(allowed)}"},{"line_number":661,"context_line":"            return self.fail(message)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f436f4f_ac8443b2","line":661,"range":{"start_line":645,"start_character":0,"end_line":661,"end_character":37},"in_reply_to":"9f436f4f_6cbbfb0d","updated":"2017-08-10 21:54:58.000000000","message":"fair enough","commit_id":"eea645615ffd61fa85b970bef809cabb80ceefe4"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"db384eba5afcca17c8ef9b60df766d7040220bc6","unresolved":false,"context_lines":[{"line_number":642,"context_line":"        return self._get_validated_flavor(config, credentials, self.param_name)[0]"},{"line_number":643,"context_line":""},{"line_number":644,"context_line":""},{"line_number":645,"context_line":"@validation.add(\"required_platform\", platform\u003d\"openstack\", users\u003dTrue)"},{"line_number":646,"context_line":"@validation.configure(name\u003d\"validate_share_proto\", platform\u003d\"openstack\")"},{"line_number":647,"context_line":"class ValidateShareProtoValidator(validation.Validator):"},{"line_number":648,"context_line":""},{"line_number":649,"context_line":"    def __init__(self,):"},{"line_number":650,"context_line":"        \"\"\"Validates value of share protocol for creation of Manila share.\"\"\""},{"line_number":651,"context_line":""},{"line_number":652,"context_line":"        super(ValidateShareProtoValidator, self).__init__()"},{"line_number":653,"context_line":""},{"line_number":654,"context_line":"    def validate(self, config, credentials, plugin_cls, plugin_cfg):"},{"line_number":655,"context_line":"        allowed \u003d (\"NFS\", \"CIFS\", \"GLUSTERFS\", \"HDFS\", \"CEPHFS\",)"},{"line_number":656,"context_line":"        share_proto \u003d config.get(\"args\", {}).get(\"share_proto\")"},{"line_number":657,"context_line":"        if six.text_type(share_proto).upper() not in allowed:"},{"line_number":658,"context_line":"            message \u003d _(\"Share protocol \u0027%(sp)s\u0027 is invalid, allowed values are \""},{"line_number":659,"context_line":"                        \"%(allowed)s.\") % {\"sp\": share_proto,"},{"line_number":660,"context_line":"                                           \"allowed\": \"\u0027, \u0027\".join(allowed)}"},{"line_number":661,"context_line":"            return self.fail(message)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f436f4f_0647b07a","line":661,"range":{"start_line":645,"start_character":0,"end_line":661,"end_character":37},"in_reply_to":"9f436f4f_83550553","updated":"2017-08-10 20:59:30.000000000","message":"I think it may be done in separate change. \n\nAnd we should deprecate this one and so on?","commit_id":"eea645615ffd61fa85b970bef809cabb80ceefe4"},{"author":{"_account_id":12395,"name":"Roman Vasylets","email":"pomeo92@gmail.com","username":"rvasilets"},"change_message_id":"4660abeb9f95d06e1bdf82165940b778825bfc88","unresolved":false,"context_lines":[{"line_number":642,"context_line":"        return self._get_validated_flavor(config, credentials, self.param_name)[0]"},{"line_number":643,"context_line":""},{"line_number":644,"context_line":""},{"line_number":645,"context_line":"@validation.add(\"required_platform\", platform\u003d\"openstack\", users\u003dTrue)"},{"line_number":646,"context_line":"@validation.configure(name\u003d\"validate_share_proto\", platform\u003d\"openstack\")"},{"line_number":647,"context_line":"class ValidateShareProtoValidator(validation.Validator):"},{"line_number":648,"context_line":""},{"line_number":649,"context_line":"    def __init__(self,):"},{"line_number":650,"context_line":"        \"\"\"Validates value of share protocol for creation of Manila share.\"\"\""},{"line_number":651,"context_line":""},{"line_number":652,"context_line":"        super(ValidateShareProtoValidator, self).__init__()"},{"line_number":653,"context_line":""},{"line_number":654,"context_line":"    def validate(self, config, credentials, plugin_cls, plugin_cfg):"},{"line_number":655,"context_line":"        allowed \u003d (\"NFS\", \"CIFS\", \"GLUSTERFS\", \"HDFS\", \"CEPHFS\",)"},{"line_number":656,"context_line":"        share_proto \u003d config.get(\"args\", {}).get(\"share_proto\")"},{"line_number":657,"context_line":"        if six.text_type(share_proto).upper() not in allowed:"},{"line_number":658,"context_line":"            message \u003d _(\"Share protocol \u0027%(sp)s\u0027 is invalid, allowed values are \""},{"line_number":659,"context_line":"                        \"%(allowed)s.\") % {\"sp\": share_proto,"},{"line_number":660,"context_line":"                                           \"allowed\": \"\u0027, \u0027\".join(allowed)}"},{"line_number":661,"context_line":"            return self.fail(message)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f436f4f_99619b08","line":661,"range":{"start_line":645,"start_character":0,"end_line":661,"end_character":37},"in_reply_to":"9f436f4f_ac8443b2","updated":"2017-08-11 20:54:38.000000000","message":"Ok. Will do in latter patchset","commit_id":"eea645615ffd61fa85b970bef809cabb80ceefe4"}],"rally/task/validation.py":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"c0bc68816b7ad499d51f3fec047e0e6d8dbf8415","unresolved":false,"context_lines":[{"line_number":63,"context_line":"                        *self.args, **self.kwargs) or ValidationResult(True))"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"def validator(fn):"},{"line_number":67,"context_line":"    \"\"\"Decorator that constructs a scenario validator from given function."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    Decorated function should return ValidationResult on error."}],"source_content_type":"text/x-python","patch_set":1,"id":"9f436f4f_63d7c1c1","line":66,"range":{"start_line":66,"start_character":0,"end_line":66,"end_character":18},"updated":"2017-08-09 09:51:21.000000000","message":"let\u0027s  deprecate this.","commit_id":"eea645615ffd61fa85b970bef809cabb80ceefe4"}]}
