)]}'
{"rally/api.py":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"f91dfaca25f5c306dd0e6bfdd488ff900e0ccf23","unresolved":false,"context_lines":[{"line_number":62,"context_line":"def api_wrapper(path, method):"},{"line_number":63,"context_line":"    def decorator(func):"},{"line_number":64,"context_line":"        def inner(self, *args, **kwargs):"},{"line_number":65,"context_line":"            if args:"},{"line_number":66,"context_line":"                raise TypeError(\"It is restricted to use positional\""},{"line_number":67,"context_line":"                                \" argument for API calls\")"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"            if self.api.endpoint_url:"},{"line_number":70,"context_line":"                # it\u0027s a call to the remote Rally instance"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f287b81_3a4b012c","side":"PARENT","line":67,"range":{"start_line":65,"start_character":12,"end_line":67,"end_character":58},"updated":"2017-08-24 08:15:31.000000000","message":"this is a thing which I\u0027ll really miss.","commit_id":"88e9a56716390c38225536e1e487c4f12bea7e3c"},{"author":{"_account_id":22960,"name":"Hai Shi","email":"shihai1992@gmail.com","username":"haishi"},"change_message_id":"9ff05953efcc0532cc5d0f65beca248e7cd5517c","unresolved":false,"context_lines":[{"line_number":62,"context_line":"def api_wrapper(path, method):"},{"line_number":63,"context_line":"    def decorator(func):"},{"line_number":64,"context_line":"        def inner(self, *args, **kwargs):"},{"line_number":65,"context_line":"            if args:"},{"line_number":66,"context_line":"                raise TypeError(\"It is restricted to use positional\""},{"line_number":67,"context_line":"                                \" argument for API calls\")"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"            if self.api.endpoint_url:"},{"line_number":70,"context_line":"                # it\u0027s a call to the remote Rally instance"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f287b81_97176046","side":"PARENT","line":67,"range":{"start_line":65,"start_character":12,"end_line":67,"end_character":58},"in_reply_to":"7f287b81_3a4b012c","updated":"2017-08-24 15:02:58.000000000","message":"heh. We could do some checking operation of args.","commit_id":"88e9a56716390c38225536e1e487c4f12bea7e3c"},{"author":{"_account_id":21528,"name":"chenhb","email":"chen.haibing1@zte.com.cn","username":"chenhb"},"change_message_id":"32f5c5cfcd53078a7b7be978751b573543e16b9c","unresolved":false,"context_lines":[{"line_number":62,"context_line":"def api_wrapper(path, method):"},{"line_number":63,"context_line":"    def decorator(func):"},{"line_number":64,"context_line":"        def inner(self, *args, **kwargs):"},{"line_number":65,"context_line":"            if args:"},{"line_number":66,"context_line":"                raise TypeError(\"It is restricted to use positional\""},{"line_number":67,"context_line":"                                \" argument for API calls\")"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"            if self.api.endpoint_url:"},{"line_number":70,"context_line":"                # it\u0027s a call to the remote Rally instance"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f287b81_f51c6a6b","side":"PARENT","line":67,"range":{"start_line":65,"start_character":12,"end_line":67,"end_character":58},"in_reply_to":"7f287b81_3a4b012c","updated":"2017-08-24 08:39:59.000000000","message":"it is ok,just call api in inner methods, or we could commit a new patch for this. :)","commit_id":"88e9a56716390c38225536e1e487c4f12bea7e3c"}],"tests/unit/test_api.py":[{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"6f544f4c92d954cd6cd4cdf89d12df9de65ae0cf","unresolved":false,"context_lines":[{"line_number":185,"context_line":"            task_template\u003dtemplate))"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"    def test_render_template_missing_args(self):"},{"line_number":188,"context_line":"        self.assertRaises(TypeError, self.task_inst.render_template, \"{{a}}\")"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"    def test_render_template_include_other_template(self):"},{"line_number":191,"context_line":"        other_template_path \u003d os.path.join("}],"source_content_type":"text/x-python","patch_set":3,"id":"7f287b81_0746b77d","line":188,"updated":"2017-08-23 20:50:45.000000000","message":"can you please elaborate how this change actually change what exceptions are raised?","commit_id":"23a3f76f520f39051410e84cd411c79e01430c4d"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"f91dfaca25f5c306dd0e6bfdd488ff900e0ccf23","unresolved":false,"context_lines":[{"line_number":185,"context_line":"            task_template\u003dtemplate))"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"    def test_render_template_missing_args(self):"},{"line_number":188,"context_line":"        self.assertRaises(TypeError, self.task_inst.render_template, \"{{a}}\")"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"    def test_render_template_include_other_template(self):"},{"line_number":191,"context_line":"        other_template_path \u003d os.path.join("}],"source_content_type":"text/x-python","patch_set":3,"id":"7f287b81_5acfedaf","line":188,"in_reply_to":"7f287b81_0746b77d","updated":"2017-08-24 08:15:31.000000000","message":"see L77 at https://review.openstack.org/#/c/495934/3/rally/api.py","commit_id":"23a3f76f520f39051410e84cd411c79e01430c4d"},{"author":{"_account_id":22960,"name":"Hai Shi","email":"shihai1992@gmail.com","username":"haishi"},"change_message_id":"9ff05953efcc0532cc5d0f65beca248e7cd5517c","unresolved":false,"context_lines":[{"line_number":185,"context_line":"            task_template\u003dtemplate))"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"    def test_render_template_missing_args(self):"},{"line_number":188,"context_line":"        self.assertRaises(TypeError, self.task_inst.render_template, \"{{a}}\")"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"    def test_render_template_include_other_template(self):"},{"line_number":191,"context_line":"        other_template_path \u003d os.path.join("}],"source_content_type":"text/x-python","patch_set":3,"id":"7f287b81_143eced9","line":188,"in_reply_to":"7f287b81_5acfedaf","updated":"2017-08-24 15:02:58.000000000","message":"And it is a rollback before adding the patch of api_wrapper.","commit_id":"23a3f76f520f39051410e84cd411c79e01430c4d"}]}