)]}'
{"rally/common/objects/task.py":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"ba8789e4c1667dcf6d3555d3af986469551ea6ec","unresolved":false,"context_lines":[{"line_number":197,"context_line":"        \"total_iteration_count\": {\"type\": \"integer\"},"},{"line_number":198,"context_line":"        \"created_at\": {\"type\": \"string\"},"},{"line_number":199,"context_line":"        \"context\": {\"type\": \"object\"},"},{"line_number":200,"context_line":"        \"position\": {\"type\": \"integer\"},"},{"line_number":201,"context_line":"        \"sla\": {\"type\": \"object\"}"},{"line_number":202,"context_line":"    },"},{"line_number":203,"context_line":"    \"required\": [\"pass_sla\", \"sla_results\", \"sla\", \"statistics\", \"context\","}],"source_content_type":"text/x-python","patch_set":3,"id":"5f2577a7_cf565d5d","line":200,"range":{"start_line":200,"start_character":0,"end_line":200,"end_character":40},"updated":"2017-09-13 13:20:00.000000000","message":"not sure that we need it in results.","commit_id":"2a7210fc42ed9a25f259e4755c6a8a39fefc6a10"},{"author":{"_account_id":21528,"name":"chenhb","email":"chen.haibing1@zte.com.cn","username":"chenhb"},"change_message_id":"5e93dd38ab9106e7632516a3b7bd886472dfda1d","unresolved":false,"context_lines":[{"line_number":197,"context_line":"        \"total_iteration_count\": {\"type\": \"integer\"},"},{"line_number":198,"context_line":"        \"created_at\": {\"type\": \"string\"},"},{"line_number":199,"context_line":"        \"context\": {\"type\": \"object\"},"},{"line_number":200,"context_line":"        \"position\": {\"type\": \"integer\"},"},{"line_number":201,"context_line":"        \"sla\": {\"type\": \"object\"}"},{"line_number":202,"context_line":"    },"},{"line_number":203,"context_line":"    \"required\": [\"pass_sla\", \"sla_results\", \"sla\", \"statistics\", \"context\","}],"source_content_type":"text/x-python","patch_set":3,"id":"5f2577a7_573891ed","line":200,"range":{"start_line":200,"start_character":0,"end_line":200,"end_character":40},"in_reply_to":"5f2577a7_cf565d5d","updated":"2017-09-15 06:43:53.000000000","message":"i think it should be required.\nhttps://github.com/openstack/rally/blob/master/rally/api.py#L525\n\nAlso, Could you comment this line for me? i did not clear :(\nhttps://github.com/openstack/rally/blob/master/rally/plugins/common/exporter/reporters.py#L45","commit_id":"2a7210fc42ed9a25f259e4755c6a8a39fefc6a10"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"ba8789e4c1667dcf6d3555d3af986469551ea6ec","unresolved":false,"context_lines":[{"line_number":203,"context_line":"    \"required\": [\"pass_sla\", \"sla_results\", \"sla\", \"statistics\", \"context\","},{"line_number":204,"context_line":"                 \"data\", \"runner\", \"args\", \"full_duration\", \"load_duration\","},{"line_number":205,"context_line":"                 \"total_iteration_count\", \"failed_iteration_count\","},{"line_number":206,"context_line":"                 \"position\"]"},{"line_number":207,"context_line":"}"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"TASK_SCHEMA \u003d {"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f2577a7_8f50555f","line":206,"updated":"2017-09-13 13:20:00.000000000","message":"do not forget additionalProperties: False","commit_id":"2a7210fc42ed9a25f259e4755c6a8a39fefc6a10"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"ba8789e4c1667dcf6d3555d3af986469551ea6ec","unresolved":false,"context_lines":[{"line_number":237,"context_line":"                        \"items\": TASK_WORKLOADS_SCHEMA"},{"line_number":238,"context_line":"                    }"},{"line_number":239,"context_line":"                },"},{"line_number":240,"context_line":"                \"required\": [\"workloads\"]"},{"line_number":241,"context_line":"            }"},{"line_number":242,"context_line":"        }"},{"line_number":243,"context_line":"    },"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f2577a7_2fcba11e","line":240,"updated":"2017-09-13 13:20:00.000000000","message":"same about additional properties.","commit_id":"2a7210fc42ed9a25f259e4755c6a8a39fefc6a10"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"ba8789e4c1667dcf6d3555d3af986469551ea6ec","unresolved":false,"context_lines":[{"line_number":241,"context_line":"            }"},{"line_number":242,"context_line":"        }"},{"line_number":243,"context_line":"    },"},{"line_number":244,"context_line":"    \"required\": [\"subtasks\"]"},{"line_number":245,"context_line":"}"},{"line_number":246,"context_line":""},{"line_number":247,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5f2577a7_4fc82d21","line":244,"updated":"2017-09-13 13:20:00.000000000","message":"same about additional properties.","commit_id":"2a7210fc42ed9a25f259e4755c6a8a39fefc6a10"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"ba8789e4c1667dcf6d3555d3af986469551ea6ec","unresolved":false,"context_lines":[{"line_number":242,"context_line":"        }"},{"line_number":243,"context_line":"    },"},{"line_number":244,"context_line":"    \"required\": [\"subtasks\"]"},{"line_number":245,"context_line":"}"},{"line_number":246,"context_line":""},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"class Task(object):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f2577a7_0feb4579","line":245,"updated":"2017-09-13 13:20:00.000000000","message":"let\u0027s use definitions here. see \n\nhttps://github.com/openstack/rally/blob/4cc2877e314015001ac70bacdf337272d24735ff/rally/task/engine.py#L627-L635\n\nhttps://github.com/openstack/rally/blob/4cc2877e314015001ac70bacdf337272d24735ff/rally/task/engine.py#L646","commit_id":"2a7210fc42ed9a25f259e4755c6a8a39fefc6a10"},{"author":{"_account_id":21528,"name":"chenhb","email":"chen.haibing1@zte.com.cn","username":"chenhb"},"change_message_id":"15d2893721ddc30cec14ab42e1ae3802c1589558","unresolved":false,"context_lines":[{"line_number":242,"context_line":"        }"},{"line_number":243,"context_line":"    },"},{"line_number":244,"context_line":"    \"required\": [\"subtasks\"]"},{"line_number":245,"context_line":"}"},{"line_number":246,"context_line":""},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"class Task(object):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f2577a7_e0ba166c","line":245,"in_reply_to":"5f2577a7_0feb4579","updated":"2017-09-15 03:52:27.000000000","message":"hm... you sure? it was so long dict object.  it could be easy to read them since we split them into different dict objects.","commit_id":"2a7210fc42ed9a25f259e4755c6a8a39fefc6a10"}],"tests/unit/task/test_runner.py":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"fa3022066ee77546883522a6f47d98714594f943","unresolved":false,"context_lines":[{"line_number":217,"context_line":"    def test__send_result(self):"},{"line_number":218,"context_line":"        runner_ \u003d self._get_runner(task\u003dmock.Mock(uuid\u003d\"foo_uuid\"))"},{"line_number":219,"context_line":"        result \u003d {\"timestamp\": 42}"},{"line_number":220,"context_line":"        runner_.task.result_has_valid_schema \u003d mock.Mock(return_value\u003dTrue)"},{"line_number":221,"context_line":"        self.assertIsNone(runner_._send_result(result))"},{"line_number":222,"context_line":"        self.assertEqual([], runner_.result_batch)"},{"line_number":223,"context_line":"        self.assertEqual(collections.deque([[result]]), runner_.result_queue)"}],"source_content_type":"text/x-python","patch_set":8,"id":"7f515b1d_f72f5885","line":220,"range":{"start_line":220,"start_character":16,"end_line":220,"end_character":75},"updated":"2017-09-28 14:23:17.000000000","message":"`runner_.task` object should not be modified by a runner, so I prefer to do such manipulations before transmitting fake task as an argument at L218.","commit_id":"899e71d233dbf0e9cb8f95ab3002444810fea04a"}]}
