)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"f817d5433fa477c8e0e5accdd60b7f0d81e5f04d","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Stop reinventing the is_public filter"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"glanceclient has a perfectly good is_public filter -- better than"},{"line_number":10,"context_line":"ours, in fact. Moreover, the default value for is_public appears to be"},{"line_number":11,"context_line":"\u0027True\u0027, so unless we explicitly pass a different value (False to get"},{"line_number":12,"context_line":"private images, None to get all images), we never ever see private"},{"line_number":13,"context_line":"images from Glance v1 at all. So using glanceclient\u0027s filter instead"},{"line_number":14,"context_line":"of our own is truly a mitzvah."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7f287b81_7b9284a0","line":11,"range":{"start_line":10,"start_character":15,"end_line":11,"end_character":6},"updated":"2017-08-25 11:36:01.000000000","message":"Nice catch, but it looks this patch doesn\u0027t fix the issue.\nThere is no scenario for glance v1 only, so everything is going throw ImageService -\u003e UnifiedGlanceV1Service -\u003e GlanceV1Service . In this case, \"is_public\" argument is always specified. See https://github.com/openstack/rally/blob/master/rally/plugins/openstack/services/image/glance_v1.py#L196","commit_id":"fb973c457a70b06be1515f101d9ef81c6c325dd0"}],"rally/plugins/openstack/services/image/glance_v1.py":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"f817d5433fa477c8e0e5accdd60b7f0d81e5f04d","unresolved":false,"context_lines":[{"line_number":108,"context_line":"        \"\"\""},{"line_number":109,"context_line":"        images \u003d self._clients.glance(\"1\").images.list(status\u003dstatus,"},{"line_number":110,"context_line":"                                                       owner\u003downer,"},{"line_number":111,"context_line":"                                                       is_public\u003dis_public)"},{"line_number":112,"context_line":"        return images"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    @atomic.action_timer(\"glance_v1.set_visibility\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_9b3770e4","line":111,"range":{"start_line":111,"start_character":55,"end_line":111,"end_character":75},"updated":"2017-08-25 11:36:01.000000000","message":"Do you know the release from which glance v1 start supporting this filter out of the box?","commit_id":"fb973c457a70b06be1515f101d9ef81c6c325dd0"},{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"4ca388abf04c4f8729c6a38d3412c983cad331e2","unresolved":false,"context_lines":[{"line_number":108,"context_line":"        \"\"\""},{"line_number":109,"context_line":"        images \u003d self._clients.glance(\"1\").images.list(status\u003dstatus,"},{"line_number":110,"context_line":"                                                       owner\u003downer,"},{"line_number":111,"context_line":"                                                       is_public\u003dis_public)"},{"line_number":112,"context_line":"        return images"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    @atomic.action_timer(\"glance_v1.set_visibility\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_6be4bde0","line":111,"range":{"start_line":111,"start_character":55,"end_line":111,"end_character":75},"in_reply_to":"7f287b81_9b3770e4","updated":"2017-08-28 18:38:22.000000000","message":"At least essex: https://github.com/openstack/glance/blob/essex-eol/glance/api/v1/__init__.py#L20","commit_id":"fb973c457a70b06be1515f101d9ef81c6c325dd0"}]}
