)]}'
{"tests/unit/plugins/openstack/wrappers/test_network.py":[{"author":{"_account_id":11748,"name":"Chris St. Pierre","email":"cstpierr@cisco.com","username":"stpierre"},"change_message_id":"2ac85ea47c7d6913ae6bd46245622a277a903c53","unresolved":false,"context_lines":[{"line_number":329,"context_line":""},{"line_number":330,"context_line":"    @mock.patch(\"rally.plugins.openstack.wrappers.network.NeutronWrapper\""},{"line_number":331,"context_line":"                \".supports_extension\", return_value\u003d(True, \"\"))"},{"line_number":332,"context_line":"    def test_delete_network_with_router_throw_legit_exception_2("},{"line_number":333,"context_line":"            self, mock_neutron_wrapper_supports_extension):"},{"line_number":334,"context_line":"        # Ensure cleanup context still move forward even remove_interface_router"},{"line_number":335,"context_line":"        # throw BadRequest exception"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f287b81_cd4a2c82","line":332,"updated":"2017-09-01 17:44:20.000000000","message":"Use DDT to combine these two cases into a single parameterized case.","commit_id":"32c0081209f70e02d23811913365ef3c461acdb8"},{"author":{"_account_id":14064,"name":"Kahou Lei","email":"kahou82@gmail.com","username":"kahou82"},"change_message_id":"6673491e79d33c9d4cd300126a16b3dbcd0ac0f6","unresolved":false,"context_lines":[{"line_number":329,"context_line":""},{"line_number":330,"context_line":"    @mock.patch(\"rally.plugins.openstack.wrappers.network.NeutronWrapper\""},{"line_number":331,"context_line":"                \".supports_extension\", return_value\u003d(True, \"\"))"},{"line_number":332,"context_line":"    def test_delete_network_with_router_throw_legit_exception_2("},{"line_number":333,"context_line":"            self, mock_neutron_wrapper_supports_extension):"},{"line_number":334,"context_line":"        # Ensure cleanup context still move forward even remove_interface_router"},{"line_number":335,"context_line":"        # throw BadRequest exception"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f287b81_88e8927c","line":332,"in_reply_to":"7f287b81_cd4a2c82","updated":"2017-09-01 18:22:49.000000000","message":"Done","commit_id":"32c0081209f70e02d23811913365ef3c461acdb8"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"11580ab48d8e49ba8b57b71c1ef9849c379c0775","unresolved":false,"context_lines":[{"line_number":333,"context_line":""},{"line_number":334,"context_line":"    @mock.patch(\"rally.plugins.openstack.wrappers.network.NeutronWrapper\""},{"line_number":335,"context_line":"                \".supports_extension\", return_value\u003d(True, \"\"))"},{"line_number":336,"context_line":"    def test_delete_network_with_router_throw_non_legit_exception("},{"line_number":337,"context_line":"            self, mock_neutron_wrapper_supports_extension):"},{"line_number":338,"context_line":"        # Ensure cleanup context throw exception for not acceptable"},{"line_number":339,"context_line":"        # exceptions"}],"source_content_type":"text/x-python","patch_set":4,"id":"7f287b81_add472be","line":336,"updated":"2017-09-03 03:09:53.000000000","message":"This and above test cases are almost similar, the only difference is that one raises exception and another one doesn\u0027t. \n\nBasically you can join them using ddt framework (as you are using it above scenario) do something like: \n\n\n  @ddt.data({\"exception_type\": neutron_exceptions.NotFound, \"should_raise\": False},\n            {\"exception_type\": neutron_exceptions.BadRequest, \"should_raise\": False, \n            {\"exception_type\": Exception, \"should_raise\": True})\n\n\nand inside the code use should_raise in if statement to adjust the test case.","commit_id":"996db7d44d490a5c14c19e06ee2e01296310d958"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"11580ab48d8e49ba8b57b71c1ef9849c379c0775","unresolved":false,"context_lines":[{"line_number":351,"context_line":"        service.client.delete_network.return_value \u003d \"foo_deleted\""},{"line_number":352,"context_line":""},{"line_number":353,"context_line":"        try:"},{"line_number":354,"context_line":"            service.delete_network("},{"line_number":355,"context_line":"                {\"id\": \"foo_id\", \"router_id\": \"foo_router\", \"subnets\": subnets,"},{"line_number":356,"context_line":"                 \"lb_pools\": []})"},{"line_number":357,"context_line":"        except Exception:"}],"source_content_type":"text/x-python","patch_set":4,"id":"7f287b81_cdcfbe27","line":354,"updated":"2017-09-03 03:09:53.000000000","message":"usually in unit tests you would like to specify something like: \n\n  self.assertRaises(Exception, service.delete_network, {\"id\": \"foo_id\", \"router_id\": \"foo_router\", \"subnets\": subnets,\n                 \"lb_pools\": []})","commit_id":"996db7d44d490a5c14c19e06ee2e01296310d958"}]}