)]}'
{"rally-jobs/self-rally.yaml":[{"author":{"_account_id":21528,"name":"chenhb","email":"chen.haibing1@zte.com.cn","username":"chenhb"},"change_message_id":"c10dfaca51b5f0bd63da6c654a6102408ab81fdd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"7f515b1d_07987467","updated":"2017-09-29 03:21:12.000000000","message":"let us keep or add one test case for v1 format of task hook?","commit_id":"6de3a62e9fa4d3ced990ff9e3adff114be8a0f09"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"ac455affb77c11e510ab391123295c06c2dd3ec4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"7f515b1d_6f0816d9","in_reply_to":"7f515b1d_07987467","updated":"2017-09-29 15:07:49.000000000","message":"I added a unit test for checking the compatibility with an old format.","commit_id":"6de3a62e9fa4d3ced990ff9e3adff114be8a0f09"}],"rally/task/engine.py":[{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"ef61e70ac9ed512b6827a5d7dc28a11c828730cb","unresolved":false,"context_lines":[{"line_number":311,"context_line":"                vtype\u003dvtype))"},{"line_number":312,"context_line":""},{"line_number":313,"context_line":"        for hook_conf in workload[\"hooks\"]:"},{"line_number":314,"context_line":"            action_name, action_cfg \u003d list("},{"line_number":315,"context_line":"                hook_conf[\"config\"][\"action\"].items())[0]"},{"line_number":316,"context_line":"            results.extend(hook.HookAction.validate("},{"line_number":317,"context_line":"                name\u003daction_name,"}],"source_content_type":"text/x-python","patch_set":10,"id":"7f515b1d_28c46a90","line":314,"updated":"2017-09-28 18:50:04.000000000","message":"why do you need here list()? items() is going to create a copy in any case, and list creates a copy of pointers...","commit_id":"584c9cca05e3e9780aaa23d675d3a866046f72e9"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"8fddcee03dcdb8345a28bbc4afa5552ce3e07d71","unresolved":false,"context_lines":[{"line_number":311,"context_line":"                vtype\u003dvtype))"},{"line_number":312,"context_line":""},{"line_number":313,"context_line":"        for hook_conf in workload[\"hooks\"]:"},{"line_number":314,"context_line":"            action_name, action_cfg \u003d list("},{"line_number":315,"context_line":"                hook_conf[\"config\"][\"action\"].items())[0]"},{"line_number":316,"context_line":"            results.extend(hook.HookAction.validate("},{"line_number":317,"context_line":"                name\u003daction_name,"}],"source_content_type":"text/x-python","patch_set":10,"id":"7f515b1d_c8c83623","line":314,"in_reply_to":"7f515b1d_28c46a90","updated":"2017-09-28 19:19:08.000000000","message":"dict_items doesn\u0027t support indexing.","commit_id":"584c9cca05e3e9780aaa23d675d3a866046f72e9"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"ef61e70ac9ed512b6827a5d7dc28a11c828730cb","unresolved":false,"context_lines":[{"line_number":671,"context_line":"                                \"maxProperties\": 1,"},{"line_number":672,"context_line":"                                \"patternProperties\": {\".*\": {}}"},{"line_number":673,"context_line":"                            },"},{"line_number":674,"context_line":"                            \"trigger\": {\"$ref\": \"#/definitions/singleEntity\"},"},{"line_number":675,"context_line":"                            \"description\": {\"type\": \"string\"},"},{"line_number":676,"context_line":"                        },"},{"line_number":677,"context_line":"                        \"required\": [\"action\", \"trigger\"],"}],"source_content_type":"text/x-python","patch_set":10,"id":"7f515b1d_685ca2ec","line":674,"updated":"2017-09-28 18:50:04.000000000","message":"why not using the same property for action and trigger?","commit_id":"584c9cca05e3e9780aaa23d675d3a866046f72e9"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"8fddcee03dcdb8345a28bbc4afa5552ce3e07d71","unresolved":false,"context_lines":[{"line_number":671,"context_line":"                                \"maxProperties\": 1,"},{"line_number":672,"context_line":"                                \"patternProperties\": {\".*\": {}}"},{"line_number":673,"context_line":"                            },"},{"line_number":674,"context_line":"                            \"trigger\": {\"$ref\": \"#/definitions/singleEntity\"},"},{"line_number":675,"context_line":"                            \"description\": {\"type\": \"string\"},"},{"line_number":676,"context_line":"                        },"},{"line_number":677,"context_line":"                        \"required\": [\"action\", \"trigger\"],"}],"source_content_type":"text/x-python","patch_set":10,"id":"7f515b1d_88cebe2a","line":674,"in_reply_to":"7f515b1d_685ca2ec","updated":"2017-09-28 19:19:08.000000000","message":"I think it left after rebasing...this patch is too old.\naction should reference to singleEntity as well.","commit_id":"584c9cca05e3e9780aaa23d675d3a866046f72e9"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"3c7d618f84aa2dc541fb2796c293feaad6eee3f2","unresolved":false,"context_lines":[{"line_number":671,"context_line":"                                \"maxProperties\": 1,"},{"line_number":672,"context_line":"                                \"patternProperties\": {\".*\": {}}"},{"line_number":673,"context_line":"                            },"},{"line_number":674,"context_line":"                            \"trigger\": {\"$ref\": \"#/definitions/singleEntity\"},"},{"line_number":675,"context_line":"                            \"description\": {\"type\": \"string\"},"},{"line_number":676,"context_line":"                        },"},{"line_number":677,"context_line":"                        \"required\": [\"action\", \"trigger\"],"}],"source_content_type":"text/x-python","patch_set":10,"id":"7f515b1d_03ca614e","line":674,"in_reply_to":"7f515b1d_685ca2ec","updated":"2017-10-03 20:47:48.000000000","message":"patternProperties is different for action. It can be not only the dict like is designed in singleEntity.","commit_id":"584c9cca05e3e9780aaa23d675d3a866046f72e9"}],"rally/task/hook.py":[{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"ef61e70ac9ed512b6827a5d7dc28a11c828730cb","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        self.triggers \u003d collections.defaultdict(list)"},{"line_number":47,"context_line":"        for hook in config.get(\"hooks\", []):"},{"line_number":48,"context_line":"            hook_cfg \u003d hook[\"config\"]"},{"line_number":49,"context_line":"            action_name \u003d list(hook_cfg[\"action\"].keys())[0]"},{"line_number":50,"context_line":"            trigger_name \u003d list(hook_cfg[\"trigger\"].keys())[0]"},{"line_number":51,"context_line":"            action_cls \u003d HookAction.get(action_name)"},{"line_number":52,"context_line":"            trigger_obj \u003d HookTrigger.get("}],"source_content_type":"text/x-python","patch_set":10,"id":"7f515b1d_086bee84","line":49,"updated":"2017-09-28 18:50:04.000000000","message":"same here i do not understand why list() is required what\u0027s the point?","commit_id":"584c9cca05e3e9780aaa23d675d3a866046f72e9"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"8fddcee03dcdb8345a28bbc4afa5552ce3e07d71","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        self.triggers \u003d collections.defaultdict(list)"},{"line_number":47,"context_line":"        for hook in config.get(\"hooks\", []):"},{"line_number":48,"context_line":"            hook_cfg \u003d hook[\"config\"]"},{"line_number":49,"context_line":"            action_name \u003d list(hook_cfg[\"action\"].keys())[0]"},{"line_number":50,"context_line":"            trigger_name \u003d list(hook_cfg[\"trigger\"].keys())[0]"},{"line_number":51,"context_line":"            action_cls \u003d HookAction.get(action_name)"},{"line_number":52,"context_line":"            trigger_obj \u003d HookTrigger.get("}],"source_content_type":"text/x-python","patch_set":10,"id":"7f515b1d_28546a52","line":49,"in_reply_to":"7f515b1d_086bee84","updated":"2017-09-28 19:19:08.000000000","message":"dict_keys (as like dict_values and dict_items) doesn\u0027t support indexing","commit_id":"584c9cca05e3e9780aaa23d675d3a866046f72e9"}]}