)]}'
{"rally/common/validation.py":[{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"232141062b72e848f762ce0a422f20828963f563","unresolved":false,"context_lines":[{"line_number":201,"context_line":"            plugin \u003d cls.get(name, allow_hidden\u003dallow_hidden,"},{"line_number":202,"context_line":"                             platform\u003dnamespace)"},{"line_number":203,"context_line":"        except exceptions.PluginNotFound:"},{"line_number":204,"context_line":"            return [\"There is no %s plugin with name: \u0027%s\u0027\" %"},{"line_number":205,"context_line":"                    (cls.__name__, name)]"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"        if vtype is None:"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f2577a7_6c9b9c65","line":204,"updated":"2017-09-18 06:55:14.000000000","message":"is it maybe ?\n\n  self.fail(\"There is no %s plugin with name: \u0027%s\u0027\" \n             %(cls.__name__, name)])\n\notherwise I don\u0027t understand this thing","commit_id":"8c2058e00e2fd55a8b855aab865ec9aadcd21008"}],"rally/plugins/openstack/scenarios/mistral/executions.py":[{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"232141062b72e848f762ce0a422f20828963f563","unresolved":false,"context_lines":[{"line_number":60,"context_line":"                services\u003d[consts.Service.MISTRAL])"},{"line_number":61,"context_line":"@validation.add(\"workbook_contains_workflow\","},{"line_number":62,"context_line":"                workbook_param\u003d\"definition\","},{"line_number":63,"context_line":"                workflow_param\u003d\"workflow_name\")"},{"line_number":64,"context_line":"@scenario.configure(name\u003d\"MistralExecutions.create_execution_from_workbook\","},{"line_number":65,"context_line":"                    context\u003d{\"cleanup\": [\"mistral\"]},"},{"line_number":66,"context_line":"                    platform\u003d\"openstack\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f2577a7_2cf8f478","line":63,"updated":"2017-09-18 06:55:14.000000000","message":"this looks like not a backward compatible change, and I don\u0027t see clear benifit of doing it. \n\nMaybe we should keep it as is, in any case if we are going to change it, I would prefer to do in separate patch, so it\u0027s going to be easier for Mistral team to find it and understand","commit_id":"8c2058e00e2fd55a8b855aab865ec9aadcd21008"}],"tests/unit/plugins/openstack/test_validators.py":[{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"b27219789ca896f34c6faf7ae76c9293015e81f8","unresolved":false,"context_lines":[{"line_number":356,"context_line":"        self.assertEqual(1, validator._get_validated_flavor.call_count)"},{"line_number":357,"context_line":"        self.assertEqual(2, validator._get_validated_image.call_count)"},{"line_number":358,"context_line":""},{"line_number":359,"context_line":"    def test_validate_failed(self):"},{"line_number":360,"context_line":"        validator \u003d validators.ImageValidOnFlavorValidator("},{"line_number":361,"context_line":"            flavor_param\u003d\"foo_flavor\","},{"line_number":362,"context_line":"            image_param\u003d\"image\","}],"source_content_type":"text/x-python","patch_set":6,"id":"7f515b1d_72031d0f","line":359,"updated":"2017-09-22 05:45:00.000000000","message":"it\u0027s way better to split this kinds of tests in multiple test cases and use for example common setUp()","commit_id":"d28c42c6f85715af72658fb72ca9824a7dbcd3ee"}]}