)]}'
{"rally/common/i18n.py":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"4c71685427a9cac0b07be9d1eaf76dd5d80a6c35","unresolved":false,"context_lines":[{"line_number":29,"context_line":"# The abbreviated names are meant to reflect the usual use of a short"},{"line_number":30,"context_line":"# name like \u0027_\u0027. The \"L\" is for \"log\" and the other letter comes from"},{"line_number":31,"context_line":"# the level."},{"line_number":32,"context_line":"_LI \u003d _translators.log_info"},{"line_number":33,"context_line":"_LW \u003d _translators.log_warning"},{"line_number":34,"context_line":"_LE \u003d _translators.log_error"},{"line_number":35,"context_line":"_LC \u003d _translators.log_critical"}],"source_content_type":"text/x-python","patch_set":6,"id":"7f515b1d_e34e7336","side":"PARENT","line":35,"range":{"start_line":32,"start_character":0,"end_line":35,"end_character":31},"updated":"2017-09-28 19:43:41.000000000","message":"http://codesearch.openstack.org/?q\u003dfrom%20rally.common.i18n\u0026i\u003dnope\u0026files\u003d\u0026repos\u003d\n\nWe cannot just remove the module. It should be done in a backward compatible way. Let\u0027s add fake methods with a deprecation message in the top of the module","commit_id":"6412a18127471a6154b8f789578790a3c18b249b"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"32afab03ef6d76c418e849a714d8a73317cf25d4","unresolved":false,"context_lines":[{"line_number":29,"context_line":"# The abbreviated names are meant to reflect the usual use of a short"},{"line_number":30,"context_line":"# name like \u0027_\u0027. The \"L\" is for \"log\" and the other letter comes from"},{"line_number":31,"context_line":"# the level."},{"line_number":32,"context_line":"_LI \u003d _translators.log_info"},{"line_number":33,"context_line":"_LW \u003d _translators.log_warning"},{"line_number":34,"context_line":"_LE \u003d _translators.log_error"},{"line_number":35,"context_line":"_LC \u003d _translators.log_critical"}],"source_content_type":"text/x-python","patch_set":6,"id":"7f515b1d_7939e1ef","side":"PARENT","line":35,"range":{"start_line":32,"start_character":0,"end_line":35,"end_character":31},"in_reply_to":"7f515b1d_e34e7336","updated":"2017-10-03 20:26:11.000000000","message":"good catch. Going just to log that this module is deprecated","commit_id":"6412a18127471a6154b8f789578790a3c18b249b"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"0e97682e86332ab3d485d7d0d723124e572afe12","unresolved":false,"context_lines":[{"line_number":24,"context_line":"LOG.warning(\"rally.common.i18n module is deprecated and is going to be \""},{"line_number":25,"context_line":"            \"removed. Please do not import it.\")"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"_translators \u003d oslo_i18n.TranslatorFactory(domain\u003d\"rally\")"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"# The primary translation function using the well-known name \"_\""},{"line_number":31,"context_line":"_ \u003d _translators.primary"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"# Translators for log levels."},{"line_number":34,"context_line":"#"},{"line_number":35,"context_line":"# The abbreviated names are meant to reflect the usual use of a short"},{"line_number":36,"context_line":"# name like \u0027_\u0027. The \"L\" is for \"log\" and the other letter comes from"},{"line_number":37,"context_line":"# the level."},{"line_number":38,"context_line":"_LI \u003d _translators.log_info"},{"line_number":39,"context_line":"_LW \u003d _translators.log_warning"},{"line_number":40,"context_line":"_LE \u003d _translators.log_error"},{"line_number":41,"context_line":"_LC \u003d _translators.log_critical"}],"source_content_type":"text/x-python","patch_set":12,"id":"7f515b1d_c11ce814","line":41,"range":{"start_line":27,"start_character":0,"end_line":41,"end_character":31},"updated":"2017-10-06 10:25:41.000000000","message":"Let\u0027s do a fake method like below and remove oslo_i18n dependency now.\n\n    def _do_nothing(msg):\n        return message\n\n    _LI \u003d _do_nothing\n    _LW \u003d _do_nothing\n    _LE \u003d _do_nothing\n    _LC \u003d _do_nothing","commit_id":"24258bbe4a059a0fee168d864c4e29dbedb1728e"}],"rally/common/logging.py":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"8da8439f68eca629c288bcf8028e54e6ffb231d1","unresolved":false,"context_lines":[{"line_number":59,"context_line":""},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"class RallyContextAdapter(oslogging.KeywordArgumentAdapter):"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    def error(self, msg, **kwargs):"},{"line_number":64,"context_line":"        self.log(log.ERROR, msg, **kwargs)"},{"line_number":65,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"7f515b1d_830c5fec","line":62,"updated":"2017-09-28 19:54:00.000000000","message":"what about log exception? let\u0027s add a method for it too (with a proper check of the first argument)","commit_id":"9a0544ce34483696b62042ca0b42e7172b890969"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"32afab03ef6d76c418e849a714d8a73317cf25d4","unresolved":false,"context_lines":[{"line_number":59,"context_line":""},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"class RallyContextAdapter(oslogging.KeywordArgumentAdapter):"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    def error(self, msg, **kwargs):"},{"line_number":64,"context_line":"        self.log(log.ERROR, msg, **kwargs)"},{"line_number":65,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"7f515b1d_44a63811","line":62,"in_reply_to":"7f515b1d_830c5fec","updated":"2017-10-03 20:26:11.000000000","message":"not sure how to implement it because there is no log.EXCEPTION maybe in some other patch","commit_id":"9a0544ce34483696b62042ca0b42e7172b890969"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"8da8439f68eca629c288bcf8028e54e6ffb231d1","unresolved":false,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":"class RallyContextAdapter(oslogging.KeywordArgumentAdapter):"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    def error(self, msg, **kwargs):"},{"line_number":64,"context_line":"        self.log(log.ERROR, msg, **kwargs)"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    def warning(self, msg, **kwargs):"},{"line_number":67,"context_line":"        self.log(log.WARNING, msg, **kwargs)"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    def info(self, msg, **kwargs):"},{"line_number":70,"context_line":"        self.log(log.INFO, msg, **kwargs)"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    def debug(self, msg, **kwargs):"},{"line_number":73,"context_line":"        self.log(log.RDEBUG, msg, **kwargs)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"def getLogger(name\u003d\"unknown\", version\u003d\"unknown\"):"}],"source_content_type":"text/x-python","patch_set":6,"id":"7f515b1d_c38b771c","line":73,"range":{"start_line":63,"start_character":3,"end_line":73,"end_character":43},"updated":"2017-09-28 19:54:00.000000000","message":"the same as for rally.common.i18n . It is backward incompatible. I found at least one external plugin which tries to transmit args. We need to print a big warning message(use CAPS?).\n\nhttps://git.openstack.org/cgit/openstack/neutron-vpnaas/tree/rally-jobs/plugins/vpn_utils.py#n41\nhttp://codesearch.openstack.org/?q\u003dfrom%20rally.common%20import%20logging\u0026i\u003dnope\u0026files\u003d\u0026repos\u003d","commit_id":"9a0544ce34483696b62042ca0b42e7172b890969"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"32afab03ef6d76c418e849a714d8a73317cf25d4","unresolved":false,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":"class RallyContextAdapter(oslogging.KeywordArgumentAdapter):"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    def error(self, msg, **kwargs):"},{"line_number":64,"context_line":"        self.log(log.ERROR, msg, **kwargs)"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    def warning(self, msg, **kwargs):"},{"line_number":67,"context_line":"        self.log(log.WARNING, msg, **kwargs)"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    def info(self, msg, **kwargs):"},{"line_number":70,"context_line":"        self.log(log.INFO, msg, **kwargs)"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    def debug(self, msg, **kwargs):"},{"line_number":73,"context_line":"        self.log(log.RDEBUG, msg, **kwargs)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"def getLogger(name\u003d\"unknown\", version\u003d\"unknown\"):"}],"source_content_type":"text/x-python","patch_set":6,"id":"7f515b1d_64a37401","line":73,"range":{"start_line":63,"start_character":3,"end_line":73,"end_character":43},"in_reply_to":"7f515b1d_c38b771c","updated":"2017-10-03 20:26:11.000000000","message":"okay fixed","commit_id":"9a0544ce34483696b62042ca0b42e7172b890969"}],"rally/task/utils.py":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"8da8439f68eca629c288bcf8028e54e6ffb231d1","unresolved":false,"context_lines":[{"line_number":299,"context_line":"                if service.status \u003d\u003d \"enabled\" and service.state \u003d\u003d \"up\":"},{"line_number":300,"context_line":"                    return True"},{"line_number":301,"context_line":"    except nova_exc.NotFound:"},{"line_number":302,"context_line":"        LOG.warning(\"Unable to retrieve a list of available services from \""},{"line_number":303,"context_line":"                    \"nova. Pre-Grizzly OpenStack deployment?\")"},{"line_number":304,"context_line":"        return False"},{"line_number":305,"context_line":"    return False"},{"line_number":306,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"7f515b1d_23e5ab09","line":303,"range":{"start_line":302,"start_character":21,"end_line":303,"end_character":62},"updated":"2017-09-28 19:54:00.000000000","message":"funny message. lol","commit_id":"9a0544ce34483696b62042ca0b42e7172b890969"}],"tests/unit/common/test_i18.py":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"0e97682e86332ab3d485d7d0d723124e572afe12","unresolved":false,"context_lines":[{"line_number":11,"context_line":"#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":12,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":13,"context_line":"#    under the License."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"# TODO(boris-42): This is used just to check that i18n.py can be imported"},{"line_number":16,"context_line":"#                 it should be removed as soon as we remove i18n module"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from rally.common import i18n    # noqa"}],"source_content_type":"text/x-python","patch_set":12,"id":"7f515b1d_21b61cfc","line":16,"range":{"start_line":14,"start_character":0,"end_line":16,"end_character":71},"updated":"2017-10-06 10:25:41.000000000","message":"sounds like a dirty hook for coverage job :)","commit_id":"24258bbe4a059a0fee168d864c4e29dbedb1728e"}]}