)]}'
{"rally/api.py":[{"author":{"_account_id":21528,"name":"chenhb","email":"chen.haibing1@zte.com.cn","username":"chenhb"},"change_message_id":"9b1884a7ba089cf1669ba4ac5e347e681bd0fdbb","unresolved":false,"context_lines":[{"line_number":599,"context_line":"                    start_time\u003dworkload[\"start_time\"],"},{"line_number":600,"context_line":"                    full_duration\u003dworkload[\"full_duration\"],"},{"line_number":601,"context_line":"                    load_duration\u003dworkload[\"load_duration\"],"},{"line_number":602,"context_line":"                    contexts_data\u003dworkload[\"contexts_data\"])"},{"line_number":603,"context_line":"            subtask_obj.update_status(consts.SubtaskStatus.FINISHED)"},{"line_number":604,"context_line":"        task_inst.update_status(consts.SubtaskStatus.FINISHED)"},{"line_number":605,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"df87a7cf_b30c79a5","line":602,"updated":"2017-12-09 06:08:37.000000000","message":"s/contexts_data/contexts_results","commit_id":"65c02189e36d03b2b068a99ac62b30f5a583a390"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"c8e7cd8cd6025fe53e42c628f25cb3549a42d259","unresolved":false,"context_lines":[{"line_number":599,"context_line":"                    start_time\u003dworkload[\"start_time\"],"},{"line_number":600,"context_line":"                    full_duration\u003dworkload[\"full_duration\"],"},{"line_number":601,"context_line":"                    load_duration\u003dworkload[\"load_duration\"],"},{"line_number":602,"context_line":"                    contexts_data\u003dworkload[\"contexts_data\"])"},{"line_number":603,"context_line":"            subtask_obj.update_status(consts.SubtaskStatus.FINISHED)"},{"line_number":604,"context_line":"        task_inst.update_status(consts.SubtaskStatus.FINISHED)"},{"line_number":605,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"df87a7cf_ee49b4b6","line":602,"in_reply_to":"df87a7cf_b30c79a5","updated":"2017-12-09 11:11:57.000000000","message":"Done","commit_id":"65c02189e36d03b2b068a99ac62b30f5a583a390"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"3c7feccfc503664eb7636a651a4b12ebc84adef4","unresolved":false,"context_lines":[{"line_number":599,"context_line":"                    start_time\u003dworkload[\"start_time\"],"},{"line_number":600,"context_line":"                    full_duration\u003dworkload[\"full_duration\"],"},{"line_number":601,"context_line":"                    load_duration\u003dworkload[\"load_duration\"],"},{"line_number":602,"context_line":"                    contexts_data\u003dworkload[\"contexts_data\"])"},{"line_number":603,"context_line":"            subtask_obj.update_status(consts.SubtaskStatus.FINISHED)"},{"line_number":604,"context_line":"        task_inst.update_status(consts.SubtaskStatus.FINISHED)"},{"line_number":605,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"df87a7cf_8ed4a821","line":602,"in_reply_to":"df87a7cf_b30c79a5","updated":"2017-12-09 08:42:15.000000000","message":"good catch","commit_id":"65c02189e36d03b2b068a99ac62b30f5a583a390"}],"rally/common/db/api.py":[{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"3c7feccfc503664eb7636a651a4b12ebc84adef4","unresolved":false,"context_lines":[{"line_number":214,"context_line":"    :param runner: a dict with config of Workload runner"},{"line_number":215,"context_line":"    :param runner_type: a type of Workload runner"},{"line_number":216,"context_line":"    :param hooks: a list with Workload hooks config and results"},{"line_number":217,"context_line":"    :param contexts: a dict with config of Workload context"},{"line_number":218,"context_line":"    :param sla: a dict with config of Workload sla"},{"line_number":219,"context_line":"    :param args: a dict with arguments of Workload"},{"line_number":220,"context_line":"    :returns: a dict with data on the workload."}],"source_content_type":"text/x-python","patch_set":21,"id":"df87a7cf_ee1534e6","line":217,"updated":"2017-12-09 08:42:15.000000000","message":"there is already change that you have to fix, so can you fix this descprition as well to unify with params of subtask_create method","commit_id":"65c02189e36d03b2b068a99ac62b30f5a583a390"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"c8e7cd8cd6025fe53e42c628f25cb3549a42d259","unresolved":false,"context_lines":[{"line_number":214,"context_line":"    :param runner: a dict with config of Workload runner"},{"line_number":215,"context_line":"    :param runner_type: a type of Workload runner"},{"line_number":216,"context_line":"    :param hooks: a list with Workload hooks config and results"},{"line_number":217,"context_line":"    :param contexts: a dict with config of Workload context"},{"line_number":218,"context_line":"    :param sla: a dict with config of Workload sla"},{"line_number":219,"context_line":"    :param args: a dict with arguments of Workload"},{"line_number":220,"context_line":"    :returns: a dict with data on the workload."}],"source_content_type":"text/x-python","patch_set":21,"id":"df87a7cf_09fbb278","line":217,"in_reply_to":"df87a7cf_ee1534e6","updated":"2017-12-09 11:11:57.000000000","message":"Done","commit_id":"65c02189e36d03b2b068a99ac62b30f5a583a390"}],"rally/common/db/sqlalchemy/migrations/versions/dc46687661df_update_contexts.py":[{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"6d013398358a9beecd94cd43271cc0253a33c9a2","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    sa.Column(\"uuid\", sa.String(36), nullable\u003dFalse),"},{"line_number":51,"context_line":"    sa.Column(\"task_uuid\", sa.String(length\u003d36), nullable\u003dFalse),"},{"line_number":52,"context_line":"    sa.Column(\"context\", sa_types.MutableJSONEncodedDict()),"},{"line_number":53,"context_line":"    sa.Column(\"contexts\", sa_types.MutableJSONEncodedDict()),"},{"line_number":54,"context_line":"    sa.Column(\"context_execution\", sa_types.MutableJSONEncodedList()),"},{"line_number":55,"context_line":"    sa.Column(\"contexts_execution\", sa_types.MutableJSONEncodedList())"},{"line_number":56,"context_line":")"}],"source_content_type":"text/x-python","patch_set":10,"id":"3f4b6375_46d2c0d2","line":53,"updated":"2017-10-27 07:27:46.000000000","message":"I\u0027ll put some comments here: \n\n\n1) I really don\u0027t like name contexts_execution, it\u0027s unclear what we can expect there \n\n2) I really can\u0027t find anything better than contexts_info, contexts_data \n\n3) I don\u0027t think that we should have seperated contexts and contexts_data \n\nWhy we can\u0027t just keep contexts or context_data where it\u0027s going to be ordered dict or list with next filelds: \n\n{\n    \"full_name\": \u003cplugin_name\u003e, \n    \"args\": {}, \n     \"extra_data\": {dict_with_custom_keys_controlled_by_context},\n     \"setup\": {\n         \"duration\": , \n         \"atomics\": ,\n          \"error\": \"str\"\n      },\n     \"cleanup\": {\n          \"duration\": ,\n          \"atomics\": , \n          \"error\": \"str\"\n       }, \n     succeed: bool\n\n}\n\nso it will contain all kind of infomration that we need","commit_id":"a90f8cff91b66734dd46f2c0ccd045d3a8aa7bd9"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"2069f5e419e25d8d676762a227c8b4a16f6ed654","unresolved":false,"context_lines":[{"line_number":101,"context_line":"                    \"full_name\": ctx,"},{"line_number":102,"context_line":"                    \"args\": ctx_cfg,"},{"line_number":103,"context_line":"                    \"setup\": {"},{"line_number":104,"context_line":"                        \"started_at\": None,"},{"line_number":105,"context_line":"                        \"finished_at\": None,"},{"line_number":106,"context_line":"                        \"atomic_actions\": [],"},{"line_number":107,"context_line":"                        \"error\": None"}],"source_content_type":"text/x-python","patch_set":16,"id":"ff82abbf_3b4fd093","line":104,"updated":"2017-11-28 18:54:59.000000000","message":"So this is going to cause a problems for all users. \nBecause now we can expect to have or not this information, but instead of 2 states: (no info, full info) we have all variate of possible states (started is None but finished exists for example) \n\nWhat if we change it to \"setup\": None, so user will just write: \n\n  if context_data[\"setup\"]: \n     # do some operation","commit_id":"5c81b804042522c87e93e844f97be215fde1a1db"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"7af03c6ae8d755d0977c5ebe3c774aba2fc58076","unresolved":false,"context_lines":[{"line_number":101,"context_line":"                    \"full_name\": ctx,"},{"line_number":102,"context_line":"                    \"args\": ctx_cfg,"},{"line_number":103,"context_line":"                    \"setup\": {"},{"line_number":104,"context_line":"                        \"started_at\": None,"},{"line_number":105,"context_line":"                        \"finished_at\": None,"},{"line_number":106,"context_line":"                        \"atomic_actions\": [],"},{"line_number":107,"context_line":"                        \"error\": None"}],"source_content_type":"text/x-python","patch_set":16,"id":"df87a7cf_f8c4c742","line":104,"in_reply_to":"df87a7cf_817d1ae9","updated":"2017-12-02 10:14:49.000000000","message":"Seems like some misunderstanding here. \n\n1) We execute context in context manager (we can refactor in any way the code) so saying that it\u0027s not possible to get something seems invalid. \n2) Current implementation has https://github.com/openstack/rally/blob/master/rally/task/context.py#L189 self._visited (which includes all called setup method) field as well as configuration (all specified context) \n3) We are storing array of data, where every element is information about one separate execution of context. And I was telling about change it (e.g. if setup was not called it must be None not deep object) that needs to be analyzed your code from above should look like if ctx[\"setup\"]\n4) It would be nice to have on top level field status (finished, failed, skipped) that is going to simplify work\n\n5) Even if it is migration, and you say that it\u0027s going to be only for old data, that means that all code that we write now should take that into account.","commit_id":"5c81b804042522c87e93e844f97be215fde1a1db"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"eb3f2934f605eacde521ee820be0faf3d3316568","unresolved":false,"context_lines":[{"line_number":101,"context_line":"                    \"full_name\": ctx,"},{"line_number":102,"context_line":"                    \"args\": ctx_cfg,"},{"line_number":103,"context_line":"                    \"setup\": {"},{"line_number":104,"context_line":"                        \"started_at\": None,"},{"line_number":105,"context_line":"                        \"finished_at\": None,"},{"line_number":106,"context_line":"                        \"atomic_actions\": [],"},{"line_number":107,"context_line":"                        \"error\": None"}],"source_content_type":"text/x-python","patch_set":16,"id":"df87a7cf_6d9bd7c8","line":104,"in_reply_to":"df87a7cf_f8c4c742","updated":"2017-12-05 15:14:13.000000000","message":"Your comment looks more generic and a bit unrelated to migration, but anyway, it doesn\u0027t matter where to discuss this.\n\n\u003e Seems like some misunderstanding here. \n\nagree with this. lol\n\n\u003e 2 and 3:\n\nself._visites field is just run-time. It was not saved previously, so if on terms of migrating old results, it can\u0027t help at all.\n\nAs for current implementation, if the context presents in \"contexts_data\" it means that it was executed (visited). (ContextManager adds new items to self._data for each context separately while executing it\u0027s setup method)\n\n\u003e 4 \nIf the context was not executed, it will not be in the dict. No need to check inner properties of contexts_data[ctx_name]. And no need in separate status.\n\n\n\nAs for current db layer, we are storing results separately from configs (sla field and sla_results, workload config and workload data, etc). The only one unified place is hooks field. It was designed to combine config and results since it was hard to map the results and hook config in another way. \n\nIdeally, we can merge the results and configs (i.e. get rid off contexts fields and use contexts_data as one place of truth). But if we decide to do this, it will require a bit more code for context_data patch and planned unification for other fields (sla and workload_cfg) + compatibility things.\n(actually I like this)\n\nIn any case, even for this case, I do not see any need for inner statuses. I mean if \"setup\" exists in context_data[ctx_name], it means that it was executed and if    context_data[ctx_name][\"setup\"][\"error\"] is not None, the ctx failed. It is simple and no need of documentation.\n\n\nIn both cases, since there is no way to identify \"execution\" status of contexts for old results, I made an assumption that all contexts were executed successfuly. If you want, I can add I can take start_time of workload as started_at and finished_at fields for these results.","commit_id":"5c81b804042522c87e93e844f97be215fde1a1db"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"0e4eae3f172c495b2765d7686484902facb7ba5f","unresolved":false,"context_lines":[{"line_number":101,"context_line":"                    \"full_name\": ctx,"},{"line_number":102,"context_line":"                    \"args\": ctx_cfg,"},{"line_number":103,"context_line":"                    \"setup\": {"},{"line_number":104,"context_line":"                        \"started_at\": None,"},{"line_number":105,"context_line":"                        \"finished_at\": None,"},{"line_number":106,"context_line":"                        \"atomic_actions\": [],"},{"line_number":107,"context_line":"                        \"error\": None"}],"source_content_type":"text/x-python","patch_set":16,"id":"df87a7cf_817d1ae9","line":104,"in_reply_to":"ff82abbf_3b4fd093","updated":"2017-12-01 14:14:39.000000000","message":"\u003e So this is going to cause problems for all users. \nnot at all :)\n\nAnd do not forget that it affects only old results (it is a database migration).\n\n\u003e (started is None but finished exists for example) \n\neverything is None.\n\nFrom old behavior:\n\n1) if \"setup\" of particular context fails, all \"setup\" methods which were not executed before it will not be executed at all. There is no way to determine which setup methods were executed and which were not. We are storing just string with error, not even traceback. \nThe fail of `setup` triggers cleanup.\n2) if cleanup of particular context fails, all other cleanups will continue execution. Only cleanups of executed contexts will be performed. There is no way to determine which cleanup methods were executed and which are not, since we do not have info about actually executed setup methods.\n\nBased on above, we have 2 options:\n1) do not add anything to contexts_data, which means that no contexts were executed from the new behavior view.\n2) add empty data which means that all contexts were executed.\n\nBoth cases are not user-friendly, but the second case gives ability to say(display in html report for example) something like \"the next contexts were executed, but I do not have results for it\". Such behaiour, can be achived easily by 2 if checks:\n\n    for ctx in context_data:\n        if ctx[\"setup\"][\"started_at\"]:\n            # display info\n        else:\n            # say that it was executed, but no info is available\n\nThe first option will just hide any information.","commit_id":"5c81b804042522c87e93e844f97be215fde1a1db"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"c8e7cd8cd6025fe53e42c628f25cb3549a42d259","unresolved":false,"context_lines":[{"line_number":107,"context_line":"    for workload in connection.execute(workload_helper.select()):"},{"line_number":108,"context_line":"        # NOTE(andreykurilin): It is impossible to find out the real timestamps"},{"line_number":109,"context_line":"        #   so let\u0027s add some \"random\"."},{"line_number":110,"context_line":"        #   The workload objFor simplification, let\u0027s assume that:"},{"line_number":111,"context_line":"        #       validation step doesn\u0027t cost anything"},{"line_number":112,"context_line":"        #       The last thing in workload was cleanup method of ContextManager"},{"line_number":113,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"df87a7cf_6ee14d2a","line":110,"range":{"start_line":110,"start_character":12,"end_line":110,"end_character":28},"updated":"2017-12-09 11:11:57.000000000","message":"redundant","commit_id":"2a0511d2152d2f6a85671e1db82703734a4c1cae"},{"author":{"_account_id":21528,"name":"chenhb","email":"chen.haibing1@zte.com.cn","username":"chenhb"},"change_message_id":"9b1884a7ba089cf1669ba4ac5e347e681bd0fdbb","unresolved":false,"context_lines":[{"line_number":115,"context_line":"            #   so making an assumption that no contexts were executed at all."},{"line_number":116,"context_line":"            contexts_results \u003d []"},{"line_number":117,"context_line":"        else:"},{"line_number":118,"context_line":"            # We cannot guess timings for each contexts, but we can restore"},{"line_number":119,"context_line":"            # started_at and finished_at timings for setup and cleanup methods"},{"line_number":120,"context_line":"            # of context manager."},{"line_number":121,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"df87a7cf_13052546","line":118,"updated":"2017-12-09 06:08:37.000000000","message":"Why is it requried to guess these time datas?\nif it is required, i think we should add these time datas in _load_task_results_file from json report too.","commit_id":"65c02189e36d03b2b068a99ac62b30f5a583a390"},{"author":{"_account_id":21528,"name":"chenhb","email":"chen.haibing1@zte.com.cn","username":"chenhb"},"change_message_id":"f06f289a940ca1170f777ecdf81004b656e4a3bd","unresolved":false,"context_lines":[{"line_number":115,"context_line":"            #   so making an assumption that no contexts were executed at all."},{"line_number":116,"context_line":"            contexts_results \u003d []"},{"line_number":117,"context_line":"        else:"},{"line_number":118,"context_line":"            # We cannot guess timings for each contexts, but we can restore"},{"line_number":119,"context_line":"            # started_at and finished_at timings for setup and cleanup methods"},{"line_number":120,"context_line":"            # of context manager."},{"line_number":121,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"df87a7cf_b652dedd","line":118,"in_reply_to":"df87a7cf_0e2978e4","updated":"2017-12-13 01:52:18.000000000","message":"I meant why we can not directly save an empty contexts_results if workload.start_time is None or not. In addition, do we need to guess the context time data for json 1.0 report at Line #782 of rally/cli/commands/task.py ? now we import context_results with an empty list at here.","commit_id":"65c02189e36d03b2b068a99ac62b30f5a583a390"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"3c7feccfc503664eb7636a651a4b12ebc84adef4","unresolved":false,"context_lines":[{"line_number":115,"context_line":"            #   so making an assumption that no contexts were executed at all."},{"line_number":116,"context_line":"            contexts_results \u003d []"},{"line_number":117,"context_line":"        else:"},{"line_number":118,"context_line":"            # We cannot guess timings for each contexts, but we can restore"},{"line_number":119,"context_line":"            # started_at and finished_at timings for setup and cleanup methods"},{"line_number":120,"context_line":"            # of context manager."},{"line_number":121,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"df87a7cf_0e2978e4","line":118,"in_reply_to":"df87a7cf_13052546","updated":"2017-12-09 08:42:15.000000000","message":"We didn\u0027t store data about when context were executed and this patch starts doing that, which means that the only option for us is to guess.","commit_id":"65c02189e36d03b2b068a99ac62b30f5a583a390"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"02e259f883f559e33d570047f42ec84cca7ecc2e","unresolved":false,"context_lines":[{"line_number":115,"context_line":"            #   so making an assumption that no contexts were executed at all."},{"line_number":116,"context_line":"            contexts_results \u003d []"},{"line_number":117,"context_line":"        else:"},{"line_number":118,"context_line":"            # We cannot guess timings for each contexts, but we can restore"},{"line_number":119,"context_line":"            # started_at and finished_at timings for setup and cleanup methods"},{"line_number":120,"context_line":"            # of context manager."},{"line_number":121,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"df87a7cf_b835dfaa","line":118,"in_reply_to":"df87a7cf_b652dedd","updated":"2017-12-13 10:47:43.000000000","message":"\u003e I meant why we can not directly save an empty \n\u003e contexts_results if workload.start_time is None or not. \n\nwe do it, but at L183 to reduce code duplication and reduce db calls.\n\n\u003e In addition, do we need to guess the context time data for\n\u003e json 1.0 report at Line #782 of rally/cli/commands/task.py ? \n\u003e now we import context_results with an empty list at here.\n\nhm...sounds valid question. let\u0027s do it in a separate patch to simplify reviewing.","commit_id":"65c02189e36d03b2b068a99ac62b30f5a583a390"}],"rally/plugins/common/exporters/elastic/exporter.py":[{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"06fa4f76d72e592dfa6e46a8769fd6e50d4f111d","unresolved":false,"context_lines":[{"line_number":370,"context_line":"                    \"description\": workload[\"description\"],"},{"line_number":371,"context_line":"                    \"runner_name\": workload[\"runner_type\"],"},{"line_number":372,"context_line":"                    \"runner_cfg\": self._pack(workload[\"runner\"]),"},{"line_number":373,"context_line":"                    \"contexts\": self._pack(workload[\"contexts\"]),"},{"line_number":374,"context_line":"                    \"started_at\": started_at,"},{"line_number":375,"context_line":"                    \"load_duration\": workload[\"load_duration\"],"},{"line_number":376,"context_line":"                    \"full_duration\": workload[\"full_duration\"],"}],"source_content_type":"text/x-python","patch_set":21,"id":"df87a7cf_4e80e0bf","line":373,"updated":"2017-12-09 08:48:09.000000000","message":"probably we should export contexts results as well?","commit_id":"65c02189e36d03b2b068a99ac62b30f5a583a390"}],"rally/plugins/common/exporters/json_exporter.py":[{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"72d624d2b68bfc0a25a1a79760726be09c997682","unresolved":false,"context_lines":[{"line_number":31,"context_line":"\r"},{"line_number":32,"context_line":"    Revisions:\r"},{"line_number":33,"context_line":"        1.0 - the json report v1\r"},{"line_number":34,"context_line":"        1.1 - added context execution stats of workloads\r"},{"line_number":35,"context_line":"    \"\"\"\r"},{"line_number":36,"context_line":"\r"},{"line_number":37,"context_line":"    def _generate_tasks(self):\r"}],"source_content_type":"text/x-python","patch_set":16,"id":"ff82abbf_bb10c058","line":34,"updated":"2017-11-28 19:03:48.000000000","message":"add contexts_data - with context execution stats of workloads","commit_id":"5c81b804042522c87e93e844f97be215fde1a1db"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"5462e540b0e7b8ca6844d76bb3ddf286a91dd47b","unresolved":false,"context_lines":[{"line_number":31,"context_line":"\r"},{"line_number":32,"context_line":"    Revisions:\r"},{"line_number":33,"context_line":"        1.0 - the json report v1\r"},{"line_number":34,"context_line":"        1.1 - added context execution stats of workloads\r"},{"line_number":35,"context_line":"    \"\"\"\r"},{"line_number":36,"context_line":"\r"},{"line_number":37,"context_line":"    def _generate_tasks(self):\r"}],"source_content_type":"text/x-python","patch_set":16,"id":"df87a7cf_01526a68","line":34,"in_reply_to":"ff82abbf_bb10c058","updated":"2017-12-01 14:19:49.000000000","message":"Done","commit_id":"5c81b804042522c87e93e844f97be215fde1a1db"}],"rally/task/context.py":[{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"72d624d2b68bfc0a25a1a79760726be09c997682","unresolved":false,"context_lines":[{"line_number":106,"context_line":"    CONFIG_SCHEMA \u003d {\"type\": \"null\"}"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    def __init__(self, ctx):"},{"line_number":109,"context_line":"        super(BaseContext, self).__init__()"},{"line_number":110,"context_line":"        config \u003d ctx.get(\"config\", {})"},{"line_number":111,"context_line":"        if self.get_name() in config:"},{"line_number":112,"context_line":"            # TODO(boris-42): Fix tests, code is always using fullnames"}],"source_content_type":"text/x-python","patch_set":16,"id":"ff82abbf_160bc123","line":109,"updated":"2017-11-28 19:03:48.000000000","message":"this seems like real bug \u003d)","commit_id":"5c81b804042522c87e93e844f97be215fde1a1db"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"fb030197bc7d525381a59bd4a9f0c8aec8c9491c","unresolved":false,"context_lines":[{"line_number":106,"context_line":"    CONFIG_SCHEMA \u003d {\"type\": \"null\"}"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    def __init__(self, ctx):"},{"line_number":109,"context_line":"        super(BaseContext, self).__init__()"},{"line_number":110,"context_line":"        config \u003d ctx.get(\"config\", {})"},{"line_number":111,"context_line":"        if self.get_name() in config:"},{"line_number":112,"context_line":"            # TODO(boris-42): Fix tests, code is always using fullnames"}],"source_content_type":"text/x-python","patch_set":16,"id":"df87a7cf_305a08f3","line":109,"in_reply_to":"df87a7cf_f8d92722","updated":"2017-12-05 15:33:27.000000000","message":"btw, maybe we should modify atomic.ActionTimerMixin to look like:\n\n   @property\n   def _atomic_actions(self):\n        if not hasattr(self, \"__atomic_actions\"):\n             self.__atomic_actions \u003d []\n        return self.__atomic_actions\n\nIt will fix potential ability of shoot in the foot.\nThought?","commit_id":"5c81b804042522c87e93e844f97be215fde1a1db"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"0e4eae3f172c495b2765d7686484902facb7ba5f","unresolved":false,"context_lines":[{"line_number":106,"context_line":"    CONFIG_SCHEMA \u003d {\"type\": \"null\"}"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    def __init__(self, ctx):"},{"line_number":109,"context_line":"        super(BaseContext, self).__init__()"},{"line_number":110,"context_line":"        config \u003d ctx.get(\"config\", {})"},{"line_number":111,"context_line":"        if self.get_name() in config:"},{"line_number":112,"context_line":"            # TODO(boris-42): Fix tests, code is always using fullnames"}],"source_content_type":"text/x-python","patch_set":16,"id":"ff82abbf_d333d261","line":109,"in_reply_to":"ff82abbf_160bc123","updated":"2017-12-01 14:14:39.000000000","message":"not a bug ;) all previous parents of BaseContext do not have __init__ methods, but atomic.ActionTimerMixin has.","commit_id":"5c81b804042522c87e93e844f97be215fde1a1db"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"3ffc9a4129fa1b1c2adde4d11184599ad8bf3161","unresolved":false,"context_lines":[{"line_number":106,"context_line":"    CONFIG_SCHEMA \u003d {\"type\": \"null\"}"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    def __init__(self, ctx):"},{"line_number":109,"context_line":"        super(BaseContext, self).__init__()"},{"line_number":110,"context_line":"        config \u003d ctx.get(\"config\", {})"},{"line_number":111,"context_line":"        if self.get_name() in config:"},{"line_number":112,"context_line":"            # TODO(boris-42): Fix tests, code is always using fullnames"}],"source_content_type":"text/x-python","patch_set":16,"id":"df87a7cf_f8d92722","line":109,"in_reply_to":"ff82abbf_d333d261","updated":"2017-12-02 10:20:19.000000000","message":"fair enough","commit_id":"5c81b804042522c87e93e844f97be215fde1a1db"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"454115219ad0694c9228eaec0e3c54634d547f68","unresolved":false,"context_lines":[{"line_number":193,"context_line":"        super(ContextManager, self).__init__()"},{"line_number":194,"context_line":"        self._visited \u003d []"},{"line_number":195,"context_line":"        self.context_obj \u003d context_obj"},{"line_number":196,"context_line":"        # Use list to store data in the order of execution"},{"line_number":197,"context_line":"        self._data \u003d collections.OrderedDict()"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"    @property"}],"source_content_type":"text/x-python","patch_set":16,"id":"ff82abbf_e566bec1","line":196,"range":{"start_line":196,"start_character":8,"end_line":196,"end_character":58},"updated":"2017-11-27 21:25:35.000000000","message":"sounds outdated","commit_id":"5c81b804042522c87e93e844f97be215fde1a1db"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"72d624d2b68bfc0a25a1a79760726be09c997682","unresolved":false,"context_lines":[{"line_number":194,"context_line":"        self._visited \u003d []"},{"line_number":195,"context_line":"        self.context_obj \u003d context_obj"},{"line_number":196,"context_line":"        # Use list to store data in the order of execution"},{"line_number":197,"context_line":"        self._data \u003d collections.OrderedDict()"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"    @property"},{"line_number":200,"context_line":"    def execution_data(self):"}],"source_content_type":"text/x-python","patch_set":16,"id":"ff82abbf_76348dde","line":197,"updated":"2017-11-28 19:03:48.000000000","message":"I though that atomic are stored in list now, not in orderddict.....","commit_id":"5c81b804042522c87e93e844f97be215fde1a1db"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"0e4eae3f172c495b2765d7686484902facb7ba5f","unresolved":false,"context_lines":[{"line_number":194,"context_line":"        self._visited \u003d []"},{"line_number":195,"context_line":"        self.context_obj \u003d context_obj"},{"line_number":196,"context_line":"        # Use list to store data in the order of execution"},{"line_number":197,"context_line":"        self._data \u003d collections.OrderedDict()"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"    @property"},{"line_number":200,"context_line":"    def execution_data(self):"}],"source_content_type":"text/x-python","patch_set":16,"id":"ff82abbf_d35af281","line":197,"in_reply_to":"ff82abbf_76348dde","updated":"2017-12-01 14:14:39.000000000","message":"_data stores not only atomic actions but information about contexts themselves. OrderedDict is quite convenient to be used in python. It is used here to add \"cleanup\" information to the proper context without filtering the list of data.\n\nAnyway, OrderedDict is used only in inner logic of ContextManager. To the whole other world, it is available via `execution_data` property which transforms ordered dict into simple list.","commit_id":"5c81b804042522c87e93e844f97be215fde1a1db"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"72d624d2b68bfc0a25a1a79760726be09c997682","unresolved":false,"context_lines":[{"line_number":197,"context_line":"        self._data \u003d collections.OrderedDict()"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"    @property"},{"line_number":200,"context_line":"    def execution_data(self):"},{"line_number":201,"context_line":"        return list(self._data.values())"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"    def _get_sorted_context_lst(self):"}],"source_content_type":"text/x-python","patch_set":16,"id":"ff82abbf_b643f541","line":200,"updated":"2017-11-28 19:03:48.000000000","message":"execution_stats ? data would be interpreted as context object","commit_id":"5c81b804042522c87e93e844f97be215fde1a1db"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"b389d119701972e25a3ba7e63de372fb0bc6d70c","unresolved":false,"context_lines":[{"line_number":197,"context_line":"        self._data \u003d collections.OrderedDict()"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"    @property"},{"line_number":200,"context_line":"    def execution_data(self):"},{"line_number":201,"context_line":"        return list(self._data.values())"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"    def _get_sorted_context_lst(self):"}],"source_content_type":"text/x-python","patch_set":16,"id":"df87a7cf_58f61392","line":200,"in_reply_to":"df87a7cf_81999a20","updated":"2017-12-02 10:22:09.000000000","message":"let\u0027s call it execution_data_and_stats I know it\u0027s long and not sexy but at least it won\u0027t be misleading","commit_id":"5c81b804042522c87e93e844f97be215fde1a1db"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"5462e540b0e7b8ca6844d76bb3ddf286a91dd47b","unresolved":false,"context_lines":[{"line_number":197,"context_line":"        self._data \u003d collections.OrderedDict()"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"    @property"},{"line_number":200,"context_line":"    def execution_data(self):"},{"line_number":201,"context_line":"        return list(self._data.values())"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"    def _get_sorted_context_lst(self):"}],"source_content_type":"text/x-python","patch_set":16,"id":"df87a7cf_81999a20","line":200,"in_reply_to":"ff82abbf_b643f541","updated":"2017-12-01 14:19:49.000000000","message":"do not know. execution_data sounds weird, but I do not think that `execution_stats` is a good replacement, since this data will include not only stats, but custom output in future.","commit_id":"5c81b804042522c87e93e844f97be215fde1a1db"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"72d624d2b68bfc0a25a1a79760726be09c997682","unresolved":false,"context_lines":[{"line_number":220,"context_line":"                    \"started_at\": None,"},{"line_number":221,"context_line":"                    \"finished_at\": None,"},{"line_number":222,"context_line":"                    \"atomic_actions\": None,"},{"line_number":223,"context_line":"                    \"error\": None"},{"line_number":224,"context_line":"                },"},{"line_number":225,"context_line":"                \"cleanup\": {"},{"line_number":226,"context_line":"                    \"started_at\": None,"}],"source_content_type":"text/x-python","patch_set":16,"id":"ff82abbf_d6955988","line":223,"updated":"2017-11-28 19:03:48.000000000","message":"can we store some context specific information here? At least just plain json. \n\nFor example I would like to store infromation about how many users were created during the execution of users context.","commit_id":"5c81b804042522c87e93e844f97be215fde1a1db"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"3ffc9a4129fa1b1c2adde4d11184599ad8bf3161","unresolved":false,"context_lines":[{"line_number":220,"context_line":"                    \"started_at\": None,"},{"line_number":221,"context_line":"                    \"finished_at\": None,"},{"line_number":222,"context_line":"                    \"atomic_actions\": None,"},{"line_number":223,"context_line":"                    \"error\": None"},{"line_number":224,"context_line":"                },"},{"line_number":225,"context_line":"                \"cleanup\": {"},{"line_number":226,"context_line":"                    \"started_at\": None,"}],"source_content_type":"text/x-python","patch_set":16,"id":"df87a7cf_38d0eff7","line":223,"in_reply_to":"ff82abbf_33f47e5b","updated":"2017-12-02 10:20:19.000000000","message":"ok with separate patch","commit_id":"5c81b804042522c87e93e844f97be215fde1a1db"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"0e4eae3f172c495b2765d7686484902facb7ba5f","unresolved":false,"context_lines":[{"line_number":220,"context_line":"                    \"started_at\": None,"},{"line_number":221,"context_line":"                    \"finished_at\": None,"},{"line_number":222,"context_line":"                    \"atomic_actions\": None,"},{"line_number":223,"context_line":"                    \"error\": None"},{"line_number":224,"context_line":"                },"},{"line_number":225,"context_line":"                \"cleanup\": {"},{"line_number":226,"context_line":"                    \"started_at\": None,"}],"source_content_type":"text/x-python","patch_set":16,"id":"ff82abbf_33f47e5b","line":223,"in_reply_to":"ff82abbf_d6955988","updated":"2017-12-01 14:14:39.000000000","message":"yup, I thought about such feature. We need something like `self.add_output` in Scenario plugins. But we do not have here separate complete and additive outputs, so we need to re-think the way of storing such information (in the separate patch). Since the format of \"output\" is unknown and will be added in the separate patch (do not know when it happens, but I hope it will be soon), I prefer to add this key there.","commit_id":"5c81b804042522c87e93e844f97be215fde1a1db"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"72d624d2b68bfc0a25a1a79760726be09c997682","unresolved":false,"context_lines":[{"line_number":274,"context_line":"                LOG.exception("},{"line_number":275,"context_line":"                    \"%(msg)s failed after %(duration)s\""},{"line_number":276,"context_line":"                    % {\"msg\": msg, \"duration\": timer.duration(fmt\u003dTrue)})"},{"line_number":277,"context_line":"                if ctx_data is not None:"},{"line_number":278,"context_line":"                    ctx_data[\"cleanup\"][\"error\"] \u003d tutils.format_exc(exc)"},{"line_number":279,"context_line":"            finally:"},{"line_number":280,"context_line":"                if ctx_data is not None:"}],"source_content_type":"text/x-python","patch_set":16,"id":"ff82abbf_b6b1b549","line":277,"updated":"2017-11-28 19:03:48.000000000","message":"let\u0027s refactor code to make this state impossible. \n\nE.g. we always have context_data and it\u0027s always not None, at least it must contain information about name and args of context","commit_id":"5c81b804042522c87e93e844f97be215fde1a1db"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"0e4eae3f172c495b2765d7686484902facb7ba5f","unresolved":false,"context_lines":[{"line_number":274,"context_line":"                LOG.exception("},{"line_number":275,"context_line":"                    \"%(msg)s failed after %(duration)s\""},{"line_number":276,"context_line":"                    % {\"msg\": msg, \"duration\": timer.duration(fmt\u003dTrue)})"},{"line_number":277,"context_line":"                if ctx_data is not None:"},{"line_number":278,"context_line":"                    ctx_data[\"cleanup\"][\"error\"] \u003d tutils.format_exc(exc)"},{"line_number":279,"context_line":"            finally:"},{"line_number":280,"context_line":"                if ctx_data is not None:"}],"source_content_type":"text/x-python","patch_set":16,"id":"ff82abbf_f3bb766f","line":277,"in_reply_to":"ff82abbf_b6b1b549","updated":"2017-12-01 14:14:39.000000000","message":"Actually, as for current code, ctx_data is always presented. This check is added just for \"disaster cleanup\". I know that the feature was not officially presented, but some folks have own scripts which are based on ContextManager. \n\nI do not want to add specific logic for \"this case\". It is redundant now.","commit_id":"5c81b804042522c87e93e844f97be215fde1a1db"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"3ffc9a4129fa1b1c2adde4d11184599ad8bf3161","unresolved":false,"context_lines":[{"line_number":274,"context_line":"                LOG.exception("},{"line_number":275,"context_line":"                    \"%(msg)s failed after %(duration)s\""},{"line_number":276,"context_line":"                    % {\"msg\": msg, \"duration\": timer.duration(fmt\u003dTrue)})"},{"line_number":277,"context_line":"                if ctx_data is not None:"},{"line_number":278,"context_line":"                    ctx_data[\"cleanup\"][\"error\"] \u003d tutils.format_exc(exc)"},{"line_number":279,"context_line":"            finally:"},{"line_number":280,"context_line":"                if ctx_data is not None:"}],"source_content_type":"text/x-python","patch_set":16,"id":"df87a7cf_58cdb35b","line":277,"in_reply_to":"ff82abbf_f3bb766f","updated":"2017-12-02 10:20:19.000000000","message":"put the NOTE in code, what you said is absolutely not obvious LOL","commit_id":"5c81b804042522c87e93e844f97be215fde1a1db"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"06fa4f76d72e592dfa6e46a8769fd6e50d4f111d","unresolved":false,"context_lines":[{"line_number":25,"context_line":"from rally.common import validation"},{"line_number":26,"context_line":"from rally.task import atomic"},{"line_number":27,"context_line":"from rally.task import functional"},{"line_number":28,"context_line":"from rally.task import utils as tutils"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":21,"id":"df87a7cf_ee70d40a","line":28,"updated":"2017-12-09 08:48:09.000000000","message":"maybe task_utils ? otherwise it\u0027s unclear","commit_id":"65c02189e36d03b2b068a99ac62b30f5a583a390"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"c8e7cd8cd6025fe53e42c628f25cb3549a42d259","unresolved":false,"context_lines":[{"line_number":25,"context_line":"from rally.common import validation"},{"line_number":26,"context_line":"from rally.task import atomic"},{"line_number":27,"context_line":"from rally.task import functional"},{"line_number":28,"context_line":"from rally.task import utils as tutils"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":21,"id":"df87a7cf_6937de4e","line":28,"in_reply_to":"df87a7cf_ee70d40a","updated":"2017-12-09 11:11:57.000000000","message":"I hope someday we will move all utils under rally/utils/*.py and name them in a proper way, so we will have same aliases in imports across all the code.","commit_id":"65c02189e36d03b2b068a99ac62b30f5a583a390"}],"rally/task/engine.py":[{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"72d624d2b68bfc0a25a1a79760726be09c997682","unresolved":false,"context_lines":[{"line_number":51,"context_line":"    about started iterations."},{"line_number":52,"context_line":"    \"\"\""},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    def __init__(self, workload_cfg, task, subtask, workload, runner,"},{"line_number":55,"context_line":"                 abort_on_sla_failure, ctx_manager):"},{"line_number":56,"context_line":"        \"\"\"ResultConsumer constructor."},{"line_number":57,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"ff82abbf_968b5166","line":54,"updated":"2017-11-28 19:03:48.000000000","message":"we should rethink this thing in future after split...","commit_id":"5c81b804042522c87e93e844f97be215fde1a1db"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"0e4eae3f172c495b2765d7686484902facb7ba5f","unresolved":false,"context_lines":[{"line_number":51,"context_line":"    about started iterations."},{"line_number":52,"context_line":"    \"\"\""},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    def __init__(self, workload_cfg, task, subtask, workload, runner,"},{"line_number":55,"context_line":"                 abort_on_sla_failure, ctx_manager):"},{"line_number":56,"context_line":"        \"\"\"ResultConsumer constructor."},{"line_number":57,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"ff82abbf_73a76651","line":54,"in_reply_to":"ff82abbf_968b5166","updated":"2017-12-01 14:14:39.000000000","message":"absolutely.","commit_id":"5c81b804042522c87e93e844f97be215fde1a1db"}]}
