)]}'
{"rally/plugins/openstack/scenarios/neutron/bgpvpn.py":[{"author":{"_account_id":22960,"name":"Hai Shi","email":"shihai1992@gmail.com","username":"haishi"},"change_message_id":"c8d1a5cd8d14392e237ec5e6cfa470e9c3fbdb0e","unresolved":false,"context_lines":[{"line_number":226,"context_line":"            \"id\": self.context[\"tenant\"][\"networks\"][0][\"router_id\"]}"},{"line_number":227,"context_line":"        tenant_id \u003d self.context[\"tenant\"][\"id\"]"},{"line_number":228,"context_line":"        if not route_targets:"},{"line_number":229,"context_line":"            route_targets \u003d \"{}:{}\".format(random.randint(0, 65535),"},{"line_number":230,"context_line":"                                           random.randint(0, 4294967295))"},{"line_number":231,"context_line":"        bgpvpn \u003d self._create_bgpvpn(route_targets\u003droute_targets,"},{"line_number":232,"context_line":"                                     import_targets\u003dimport_targets,"},{"line_number":233,"context_line":"                                     export_targets\u003dexport_targets,"}],"source_content_type":"text/x-python","patch_set":2,"id":"df87a7cf_f1bcddbc","line":230,"range":{"start_line":229,"start_character":0,"end_line":230,"end_character":73},"updated":"2017-12-03 10:30:36.000000000","message":"Packaging those two lines to a function would be better.","commit_id":"02178f04004b8e490d7db3bc0d35ec259bf7817e"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"d65fbe52aca1c73db8427c7d3f1f763fb7d16edb","unresolved":false,"context_lines":[{"line_number":153,"context_line":"                missed\u003dTrue)"},{"line_number":154,"context_line":"@validation.add(\"required_neutron_extensions\", extensions\u003d[\"bgpvpn\"])"},{"line_number":155,"context_line":"@validation.add(\"required_services\", services\u003d[consts.Service.NEUTRON,"},{"line_number":156,"context_line":"                                               consts.Service.NOVA])"},{"line_number":157,"context_line":"@validation.add(\"required_platform\", platform\u003d\"openstack\","},{"line_number":158,"context_line":"                admin\u003dTrue, users\u003dTrue)"},{"line_number":159,"context_line":"@validation.add(\"required_contexts\", contexts\u003d[\"network\", \"servers\"])"}],"source_content_type":"text/x-python","patch_set":4,"id":"df87a7cf_4acb701d","line":156,"range":{"start_line":156,"start_character":47,"end_line":156,"end_character":67},"updated":"2017-12-14 16:33:51.000000000","message":"you do not need this. The \"servers\" context has own validation. your scenario doesn\u0027t use nova.","commit_id":"e2704c9a8a7fc70e448f1dac402c22c04ef6b9a2"},{"author":{"_account_id":21800,"name":"Cedric Savignan","email":"cedric.savignan@orange.com","username":"csavignan"},"change_message_id":"04eef7a5d445786f2fc7131c2bdb16737d39b13c","unresolved":false,"context_lines":[{"line_number":153,"context_line":"                missed\u003dTrue)"},{"line_number":154,"context_line":"@validation.add(\"required_neutron_extensions\", extensions\u003d[\"bgpvpn\"])"},{"line_number":155,"context_line":"@validation.add(\"required_services\", services\u003d[consts.Service.NEUTRON,"},{"line_number":156,"context_line":"                                               consts.Service.NOVA])"},{"line_number":157,"context_line":"@validation.add(\"required_platform\", platform\u003d\"openstack\","},{"line_number":158,"context_line":"                admin\u003dTrue, users\u003dTrue)"},{"line_number":159,"context_line":"@validation.add(\"required_contexts\", contexts\u003d[\"network\", \"servers\"])"}],"source_content_type":"text/x-python","patch_set":4,"id":"df87a7cf_edca9e9f","line":156,"range":{"start_line":156,"start_character":47,"end_line":156,"end_character":67},"in_reply_to":"df87a7cf_4acb701d","updated":"2017-12-14 16:44:56.000000000","message":"Done","commit_id":"e2704c9a8a7fc70e448f1dac402c22c04ef6b9a2"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"d65fbe52aca1c73db8427c7d3f1f763fb7d16edb","unresolved":false,"context_lines":[{"line_number":158,"context_line":"                admin\u003dTrue, users\u003dTrue)"},{"line_number":159,"context_line":"@validation.add(\"required_contexts\", contexts\u003d[\"network\", \"servers\"])"},{"line_number":160,"context_line":"@scenario.configure(context\u003d{\"admin_cleanup@openstack\": [\"neutron\"],"},{"line_number":161,"context_line":"                             \"cleanup@openstack\": [\"neutron\", \"nova\"]},"},{"line_number":162,"context_line":"                    name\u003d\"NeutronBGPVPN.create_bgpvpn_assoc_disassoc_networks\","},{"line_number":163,"context_line":"                    platform\u003d\"openstack\")"},{"line_number":164,"context_line":"class CreateAndAssociateDissassociateNetworks(utils.NeutronScenario,"}],"source_content_type":"text/x-python","patch_set":4,"id":"df87a7cf_eacfe426","line":161,"range":{"start_line":161,"start_character":60,"end_line":161,"end_character":68},"updated":"2017-12-14 16:33:51.000000000","message":"same here","commit_id":"e2704c9a8a7fc70e448f1dac402c22c04ef6b9a2"},{"author":{"_account_id":21800,"name":"Cedric Savignan","email":"cedric.savignan@orange.com","username":"csavignan"},"change_message_id":"04eef7a5d445786f2fc7131c2bdb16737d39b13c","unresolved":false,"context_lines":[{"line_number":158,"context_line":"                admin\u003dTrue, users\u003dTrue)"},{"line_number":159,"context_line":"@validation.add(\"required_contexts\", contexts\u003d[\"network\", \"servers\"])"},{"line_number":160,"context_line":"@scenario.configure(context\u003d{\"admin_cleanup@openstack\": [\"neutron\"],"},{"line_number":161,"context_line":"                             \"cleanup@openstack\": [\"neutron\", \"nova\"]},"},{"line_number":162,"context_line":"                    name\u003d\"NeutronBGPVPN.create_bgpvpn_assoc_disassoc_networks\","},{"line_number":163,"context_line":"                    platform\u003d\"openstack\")"},{"line_number":164,"context_line":"class CreateAndAssociateDissassociateNetworks(utils.NeutronScenario,"}],"source_content_type":"text/x-python","patch_set":4,"id":"df87a7cf_0dd02250","line":161,"range":{"start_line":161,"start_character":60,"end_line":161,"end_character":68},"in_reply_to":"df87a7cf_eacfe426","updated":"2017-12-14 16:44:56.000000000","message":"Done","commit_id":"e2704c9a8a7fc70e448f1dac402c22c04ef6b9a2"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"d65fbe52aca1c73db8427c7d3f1f763fb7d16edb","unresolved":false,"context_lines":[{"line_number":161,"context_line":"                             \"cleanup@openstack\": [\"neutron\", \"nova\"]},"},{"line_number":162,"context_line":"                    name\u003d\"NeutronBGPVPN.create_bgpvpn_assoc_disassoc_networks\","},{"line_number":163,"context_line":"                    platform\u003d\"openstack\")"},{"line_number":164,"context_line":"class CreateAndAssociateDissassociateNetworks(utils.NeutronScenario,"},{"line_number":165,"context_line":"                                              nova_utils.NovaScenario):"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"    def run(self, route_targets\u003dNone, import_targets\u003dNone,"},{"line_number":168,"context_line":"            export_targets\u003dNone, route_distinguishers\u003dNone, bgpvpn_type\u003d\"l3\"):"}],"source_content_type":"text/x-python","patch_set":4,"id":"df87a7cf_0ad568b9","line":165,"range":{"start_line":164,"start_character":66,"end_line":165,"end_character":69},"updated":"2017-12-14 16:33:51.000000000","message":"and here.  you do not call NovaScenario","commit_id":"e2704c9a8a7fc70e448f1dac402c22c04ef6b9a2"},{"author":{"_account_id":21800,"name":"Cedric Savignan","email":"cedric.savignan@orange.com","username":"csavignan"},"change_message_id":"04eef7a5d445786f2fc7131c2bdb16737d39b13c","unresolved":false,"context_lines":[{"line_number":161,"context_line":"                             \"cleanup@openstack\": [\"neutron\", \"nova\"]},"},{"line_number":162,"context_line":"                    name\u003d\"NeutronBGPVPN.create_bgpvpn_assoc_disassoc_networks\","},{"line_number":163,"context_line":"                    platform\u003d\"openstack\")"},{"line_number":164,"context_line":"class CreateAndAssociateDissassociateNetworks(utils.NeutronScenario,"},{"line_number":165,"context_line":"                                              nova_utils.NovaScenario):"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"    def run(self, route_targets\u003dNone, import_targets\u003dNone,"},{"line_number":168,"context_line":"            export_targets\u003dNone, route_distinguishers\u003dNone, bgpvpn_type\u003d\"l3\"):"}],"source_content_type":"text/x-python","patch_set":4,"id":"df87a7cf_adc49693","line":165,"range":{"start_line":164,"start_character":66,"end_line":165,"end_character":69},"in_reply_to":"df87a7cf_0ad568b9","updated":"2017-12-14 16:44:56.000000000","message":"Done","commit_id":"e2704c9a8a7fc70e448f1dac402c22c04ef6b9a2"}]}
