)]}'
{"rally/plugins/openstack/context/network/networks.py":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"9634a7c2c105c60939d861e63cd961446bce39eb","unresolved":false,"context_lines":[{"line_number":74,"context_line":"                            \"enable_snat\": {\"type\": \"boolean\"}"},{"line_number":75,"context_line":"                        }"},{"line_number":76,"context_line":"                    }"},{"line_number":77,"context_line":"                }"},{"line_number":78,"context_line":"            }"},{"line_number":79,"context_line":"        },"},{"line_number":80,"context_line":"        \"additionalProperties\": False"}],"source_content_type":"text/x-python","patch_set":6,"id":"7f96bb07_229b6673","line":77,"range":{"start_line":77,"start_character":16,"end_line":77,"end_character":17},"updated":"2018-01-24 10:54:58.000000000","message":"you need to add `additionalProperties: False`","commit_id":"32626eed01ad9853d8537ee97172da75a912c59d"},{"author":{"_account_id":21528,"name":"chenhb","email":"chen.haibing1@zte.com.cn","username":"chenhb"},"change_message_id":"aec016e6027da6ebf2c38d196ce1a1d4864e4409","unresolved":false,"context_lines":[{"line_number":74,"context_line":"                            \"enable_snat\": {\"type\": \"boolean\"}"},{"line_number":75,"context_line":"                        }"},{"line_number":76,"context_line":"                    }"},{"line_number":77,"context_line":"                }"},{"line_number":78,"context_line":"            }"},{"line_number":79,"context_line":"        },"},{"line_number":80,"context_line":"        \"additionalProperties\": False"}],"source_content_type":"text/x-python","patch_set":6,"id":"5f93b717_48def311","line":77,"range":{"start_line":77,"start_character":16,"end_line":77,"end_character":17},"in_reply_to":"7f96bb07_229b6673","updated":"2018-01-29 01:49:58.000000000","message":"Done","commit_id":"32626eed01ad9853d8537ee97172da75a912c59d"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"d83a413a7acad62483c420bd397264f22244ba6a","unresolved":false,"context_lines":[{"line_number":68,"context_line":"                    },"},{"line_number":69,"context_line":"                    \"external_gateway_info\": {"},{"line_number":70,"context_line":"                        \"description\": \"The external gateway information .\","},{"line_number":71,"context_line":"                        \"type\": \"object\","},{"line_number":72,"context_line":"                        \"properties\": {"},{"line_number":73,"context_line":"                            \"network_id\": {\"type\": \"string\"},"},{"line_number":74,"context_line":"                            \"enable_snat\": {\"type\": \"boolean\"}"}],"source_content_type":"text/x-python","patch_set":7,"id":"5f93b717_aacbe16f","line":71,"range":{"start_line":71,"start_character":25,"end_line":71,"end_character":41},"updated":"2018-01-29 13:46:28.000000000","message":"the same for this object. we should validate what it expects...","commit_id":"5cf9e19dfc8d88400a337d20e17610f3cdb9dba7"}],"rally/plugins/openstack/wrappers/network.py":[{"author":{"_account_id":26025,"name":"chenxu","email":"xuchen1990xx@gmail.com","username":"chenxu"},"change_message_id":"191930bd8844dc5651b86b0839ce3b6a998f97b4","unresolved":false,"context_lines":[{"line_number":200,"context_line":"        * dns_nameservers: Nameservers for each subnet. Default:"},{"line_number":201,"context_line":"                           8.8.8.8, 8.8.4.4"},{"line_number":202,"context_line":"        * network_create_args: Additional network creation arguments."},{"line_number":203,"context_line":"        * router_create_args: Additional network createion arguments."},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"        :param tenant_id: str, tenant ID"},{"line_number":206,"context_line":"        :param kwargs: Additional options, left open-ended for compatbilitiy."}],"source_content_type":"text/x-python","patch_set":4,"id":"7f96bb07_e76689bb","line":203,"range":{"start_line":203,"start_character":41,"end_line":203,"end_character":48},"updated":"2018-01-18 16:10:32.000000000","message":"router","commit_id":"de200a1143e7b5c371e11c7468767d950535b927"},{"author":{"_account_id":21528,"name":"chenhb","email":"chen.haibing1@zte.com.cn","username":"chenhb"},"change_message_id":"117264afa219c676dcf82e9b2d40ec59c5c37b4a","unresolved":false,"context_lines":[{"line_number":200,"context_line":"        * dns_nameservers: Nameservers for each subnet. Default:"},{"line_number":201,"context_line":"                           8.8.8.8, 8.8.4.4"},{"line_number":202,"context_line":"        * network_create_args: Additional network creation arguments."},{"line_number":203,"context_line":"        * router_create_args: Additional network createion arguments."},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"        :param tenant_id: str, tenant ID"},{"line_number":206,"context_line":"        :param kwargs: Additional options, left open-ended for compatbilitiy."}],"source_content_type":"text/x-python","patch_set":4,"id":"7f96bb07_95aa416e","line":203,"range":{"start_line":203,"start_character":41,"end_line":203,"end_character":48},"in_reply_to":"7f96bb07_e76689bb","updated":"2018-01-19 01:55:16.000000000","message":"Done","commit_id":"de200a1143e7b5c371e11c7468767d950535b927"},{"author":{"_account_id":26025,"name":"chenxu","email":"xuchen1990xx@gmail.com","username":"chenxu"},"change_message_id":"191930bd8844dc5651b86b0839ce3b6a998f97b4","unresolved":false,"context_lines":[{"line_number":216,"context_line":"        router \u003d None"},{"line_number":217,"context_line":"        router_args \u003d dict(kwargs.get(\"router_create_args\", {}))"},{"line_number":218,"context_line":"        add_router \u003d kwargs.get(\"add_router\", False)"},{"line_number":219,"context_line":"        if router_args or add_router:"},{"line_number":220,"context_line":"            router_args[\"external\"] \u003d ("},{"line_number":221,"context_line":"                router_args.get(\"external\", False) or add_router)"},{"line_number":222,"context_line":"            router_args[\"tenant_id\"] \u003d tenant_id"}],"source_content_type":"text/x-python","patch_set":4,"id":"7f96bb07_2701d138","line":219,"range":{"start_line":219,"start_character":23,"end_line":219,"end_character":36},"updated":"2018-01-18 16:10:32.000000000","message":"\"add_router\" looks redundant. we can select \"no router\" , \"external\" and \"internal\" just by \"router\".","commit_id":"de200a1143e7b5c371e11c7468767d950535b927"},{"author":{"_account_id":21528,"name":"chenhb","email":"chen.haibing1@zte.com.cn","username":"chenhb"},"change_message_id":"117264afa219c676dcf82e9b2d40ec59c5c37b4a","unresolved":false,"context_lines":[{"line_number":216,"context_line":"        router \u003d None"},{"line_number":217,"context_line":"        router_args \u003d dict(kwargs.get(\"router_create_args\", {}))"},{"line_number":218,"context_line":"        add_router \u003d kwargs.get(\"add_router\", False)"},{"line_number":219,"context_line":"        if router_args or add_router:"},{"line_number":220,"context_line":"            router_args[\"external\"] \u003d ("},{"line_number":221,"context_line":"                router_args.get(\"external\", False) or add_router)"},{"line_number":222,"context_line":"            router_args[\"tenant_id\"] \u003d tenant_id"}],"source_content_type":"text/x-python","patch_set":4,"id":"7f96bb07_f5cdc55c","line":219,"range":{"start_line":219,"start_character":23,"end_line":219,"end_character":36},"in_reply_to":"7f96bb07_2701d138","updated":"2018-01-19 01:55:16.000000000","message":"Here just for backwards compatible. Lets deprecate it in the comment.","commit_id":"de200a1143e7b5c371e11c7468767d950535b927"}]}