)]}'
{"rally/common/objects/deploy.py":[{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"41effc060f3b178a7f22373a6a2cfc7a872a0dcd","unresolved":false,"context_lines":[{"line_number":83,"context_line":"        for p in self._env_data[\"platforms\"]:"},{"line_number":84,"context_line":"            if p[\"plugin_name\"].startswith(\"existing@\"):"},{"line_number":85,"context_line":"                p[\"plugin_name\"] \u003d p[\"plugin_name\"][9:]"},{"line_number":86,"context_line":"            self._all_credentials[p[\"plugin_name\"]] \u003d [p[\"platform_data\"]]"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        self.config \u003d {}"},{"line_number":89,"context_line":"        for p_name, p_cfg in self._env_data[\"spec\"].items():"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f96bb07_d8fb2bbb","line":86,"updated":"2018-01-18 19:04:53.000000000","message":"I think we should actually use here:\n\n   self._all_credentials[p[\"platform_name\"]] \u003d [p[\"platform_data\"]]","commit_id":"e184874c0fb87faa8970886d663e1e07aa89c0f4"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"c90db001ae8450da7f40f5945876e93529a526be","unresolved":false,"context_lines":[{"line_number":162,"context_line":""},{"line_number":163,"context_line":"    def get_all_credentials(self):"},{"line_number":164,"context_line":"        all_credentials \u003d {}"},{"line_number":165,"context_line":"        for platform, credentials in self._all_credentials.items():"},{"line_number":166,"context_line":"            if platform \u003d\u003d \"openstack\":"},{"line_number":167,"context_line":"                from rally.plugins.openstack import credential"},{"line_number":168,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7f96bb07_1b10ad4d","line":165,"updated":"2018-01-18 19:30:52.000000000","message":"let\u0027s refacotr this \n\nall_credentials \u003d copy.deepcopy(self._all_credentials)\nif \"openstack\" in all_credentials: \n  do the imports \n  all_credeintals[\"openstack\"] \u003d [{\"admin\": , \"users\": ...}]","commit_id":"85c7795eb5011a5600b4230e27253b2b06f4660e"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"d78b2c872fc7f839a5570f3b64bb06f2fef8d477","unresolved":false,"context_lines":[{"line_number":162,"context_line":""},{"line_number":163,"context_line":"    def get_all_credentials(self):"},{"line_number":164,"context_line":"        all_credentials \u003d {}"},{"line_number":165,"context_line":"        for platform, credentials in self._all_credentials.items():"},{"line_number":166,"context_line":"            if platform \u003d\u003d \"openstack\":"},{"line_number":167,"context_line":"                from rally.plugins.openstack import credential"},{"line_number":168,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7f96bb07_ad4609c0","line":165,"in_reply_to":"7f96bb07_1b10ad4d","updated":"2018-01-19 11:06:54.000000000","message":"imo, it is not critical. let\u0027s just ignore this and concentrate on making all the code use env manager directly and abandon this class as soon as possible.","commit_id":"85c7795eb5011a5600b4230e27253b2b06f4660e"}],"rally/env/platform.py":[{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"394448ed03ae64fc44c1a0e9f43131f88eacb20b","unresolved":false,"context_lines":[{"line_number":113,"context_line":"            \"Platform %s doesn\u0027t support info action\" % self.get_fullname())"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    def get_validation_context(self):"},{"line_number":116,"context_line":"        \"\"\"Return a validation context for a workload.\"\"\""},{"line_number":117,"context_line":"        return {}"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f96bb07_40de51da","line":116,"updated":"2018-01-18 10:28:15.000000000","message":"for a platform","commit_id":"f69f6878dcea27d9ce57451d495f2183aa704f5f"}]}
