)]}'
{"rally/api.py":[{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"c2c4384a6249170f4e1bf8e40e33cb8726556f56","unresolved":false,"context_lines":[{"line_number":163,"context_line":"        :param deployment: UUID of deployment"},{"line_number":164,"context_line":"        :returns: Service list"},{"line_number":165,"context_line":"        \"\"\""},{"line_number":166,"context_line":"        from rally.plugins.openstack import osclients"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"        result \u003d {}"},{"line_number":169,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"3fa0c359_1d91e44e","line":166,"updated":"2018-02-09 07:53:47.000000000","message":"this is adding hard dependency on openstack in rally.api which is core of rally... which is sort of exactly opposite from what we were doing last few years...","commit_id":"dd12db64c0d16e1a786dd29ed88de8f3452f346c"}],"rally/common/objects/verifier.py":[{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"c2c4384a6249170f4e1bf8e40e33cb8726556f56","unresolved":false,"context_lines":[{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    @property"},{"line_number":90,"context_line":"    def deployment(self):"},{"line_number":91,"context_line":"        # TODO(andreykurilin): deprecate this property someday"},{"line_number":92,"context_line":"        if self._deployment is None:"},{"line_number":93,"context_line":"            raise exceptions.RallyException("},{"line_number":94,"context_line":"                \"Verifier is not linked to any deployment. Please, call \""}],"source_content_type":"text/x-python","patch_set":16,"id":"3fa0c359_fdde780f","line":91,"updated":"2018-02-09 07:53:47.000000000","message":"can we just remove this? I mean depreactions are good but this code is used purely in rally core, I haven\u0027t seen plugins for verifier yet outside...","commit_id":"dd12db64c0d16e1a786dd29ed88de8f3452f346c"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"c92227e42e18843b6dcf3677ecc3bb553e9e95ce","unresolved":false,"context_lines":[{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    @property"},{"line_number":90,"context_line":"    def deployment(self):"},{"line_number":91,"context_line":"        # TODO(andreykurilin): deprecate this property someday"},{"line_number":92,"context_line":"        if self._deployment is None:"},{"line_number":93,"context_line":"            raise exceptions.RallyException("},{"line_number":94,"context_line":"                \"Verifier is not linked to any deployment. Please, call \""}],"source_content_type":"text/x-python","patch_set":16,"id":"3fa0c359_65f087ff","line":91,"in_reply_to":"3fa0c359_fdde780f","updated":"2018-02-09 14:06:22.000000000","message":"Because I did not modified TempestVerifier yet... it is still used","commit_id":"dd12db64c0d16e1a786dd29ed88de8f3452f346c"}],"rally/plugins/openstack/context/keystone/users.py":[{"author":{"_account_id":26025,"name":"chenxu","email":"xuchen1990xx@gmail.com","username":"chenxu"},"change_message_id":"ffb570ad77780e40f1cfbb8ab6046dfdf9fea9b7","unresolved":false,"context_lines":[{"line_number":211,"context_line":"                                      domain_name\u003duser_dom,"},{"line_number":212,"context_line":"                                      default_role\u003ddefault_role)"},{"line_number":213,"context_line":"            user_credential \u003d credential.OpenStackCredential("},{"line_number":214,"context_line":"                auth_url\u003dself.credential.auth_url,"},{"line_number":215,"context_line":"                username\u003duser.name,"},{"line_number":216,"context_line":"                password\u003dpassword,"},{"line_number":217,"context_line":"                tenant_name\u003dself.context[\"tenants\"][tenant_id][\"name\"],"}],"source_content_type":"text/x-python","patch_set":12,"id":"7f96bb07_a31c7cc1","line":214,"range":{"start_line":214,"start_character":16,"end_line":214,"end_character":49},"updated":"2018-01-23 15:31:15.000000000","message":"if should be modified like \"auth_url\u003dself.credential[\u0027auth_url\u0027] :)\"","commit_id":"58aa2f1f503a43f65b065a9cf538cce2f7a3e395"},{"author":{"_account_id":26025,"name":"chenxu","email":"xuchen1990xx@gmail.com","username":"chenxu"},"change_message_id":"ffb570ad77780e40f1cfbb8ab6046dfdf9fea9b7","unresolved":false,"context_lines":[{"line_number":218,"context_line":"                permission\u003dconsts.EndpointPermission.USER,"},{"line_number":219,"context_line":"                project_domain_name\u003dproject_dom,"},{"line_number":220,"context_line":"                user_domain_name\u003duser_dom,"},{"line_number":221,"context_line":"                endpoint_type\u003dself.credential.endpoint_type,"},{"line_number":222,"context_line":"                https_insecure\u003dself.credential.https_insecure,"},{"line_number":223,"context_line":"                https_cacert\u003dself.credential.https_cacert,"},{"line_number":224,"context_line":"                region_name\u003dself.credential.region_name,"},{"line_number":225,"context_line":"                profiler_hmac_key\u003dself.credential.profiler_hmac_key,"},{"line_number":226,"context_line":"                profiler_conn_str\u003dself.credential.profiler_conn_str)"},{"line_number":227,"context_line":"            users.append({\"id\": user.id,"},{"line_number":228,"context_line":"                          \"credential\": user_credential,"},{"line_number":229,"context_line":"                          \"tenant_id\": tenant_id})"}],"source_content_type":"text/x-python","patch_set":12,"id":"7f96bb07_4379f8f9","line":226,"range":{"start_line":221,"start_character":15,"end_line":226,"end_character":68},"updated":"2018-01-23 15:31:15.000000000","message":"and here .","commit_id":"58aa2f1f503a43f65b065a9cf538cce2f7a3e395"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"c2c4384a6249170f4e1bf8e40e33cb8726556f56","unresolved":false,"context_lines":[{"line_number":104,"context_line":"    def __init__(self, context):"},{"line_number":105,"context_line":"        super(UserGenerator, self).__init__(context)"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"        creds \u003d self.env[\"platforms\"][\"openstack\"]"},{"line_number":108,"context_line":"        if creds.get(\"admin\"):"},{"line_number":109,"context_line":"            context[\"admin\"] \u003d {"},{"line_number":110,"context_line":"                \"credential\": credential.OpenStackCredential(**creds[\"admin\"])}"}],"source_content_type":"text/x-python","patch_set":16,"id":"3fa0c359_1de484e0","line":107,"updated":"2018-02-09 07:53:47.000000000","message":"this looks way better!","commit_id":"dd12db64c0d16e1a786dd29ed88de8f3452f346c"}],"rally/task/engine.py":[{"author":{"_account_id":26025,"name":"chenxu","email":"xuchen1990xx@gmail.com","username":"chenxu"},"change_message_id":"ffb570ad77780e40f1cfbb8ab6046dfdf9fea9b7","unresolved":false,"context_lines":[{"line_number":487,"context_line":"        runner_obj \u003d runner_cls(self.task, workload[\"runner\"])"},{"line_number":488,"context_line":"        context_obj \u003d self._prepare_context("},{"line_number":489,"context_line":"            workload[\"contexts\"], workload[\"name\"], workload_obj[\"uuid\"])"},{"line_number":490,"context_line":"        print(context_obj)"},{"line_number":491,"context_line":"        try:"},{"line_number":492,"context_line":"            ctx_manager \u003d context.ContextManager(context_obj)"},{"line_number":493,"context_line":"            with ResultConsumer(workload, task\u003dself.task, subtask\u003dsubtask_obj,"}],"source_content_type":"text/x-python","patch_set":12,"id":"7f96bb07_4ed35f39","line":490,"range":{"start_line":490,"start_character":1,"end_line":490,"end_character":26},"updated":"2018-01-23 15:31:15.000000000","message":"It looks like the debug code. : )","commit_id":"58aa2f1f503a43f65b065a9cf538cce2f7a3e395"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"9712dd2f3aead1c9532bb5e55448d401649560d3","unresolved":false,"context_lines":[{"line_number":487,"context_line":"        runner_obj \u003d runner_cls(self.task, workload[\"runner\"])"},{"line_number":488,"context_line":"        context_obj \u003d self._prepare_context("},{"line_number":489,"context_line":"            workload[\"contexts\"], workload[\"name\"], workload_obj[\"uuid\"])"},{"line_number":490,"context_line":"        print(context_obj)"},{"line_number":491,"context_line":"        try:"},{"line_number":492,"context_line":"            ctx_manager \u003d context.ContextManager(context_obj)"},{"line_number":493,"context_line":"            with ResultConsumer(workload, task\u003dself.task, subtask\u003dsubtask_obj,"}],"source_content_type":"text/x-python","patch_set":12,"id":"7f96bb07_18a7babf","line":490,"range":{"start_line":490,"start_character":1,"end_line":490,"end_character":26},"in_reply_to":"7f96bb07_4ed35f39","updated":"2018-01-24 14:03:17.000000000","message":"Done","commit_id":"58aa2f1f503a43f65b065a9cf538cce2f7a3e395"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"c2c4384a6249170f4e1bf8e40e33cb8726556f56","unresolved":false,"context_lines":[{"line_number":359,"context_line":"            if not res[\"available\"]:"},{"line_number":360,"context_line":"                healthy \u003d False"},{"line_number":361,"context_line":"                if logging.is_debug():"},{"line_number":362,"context_line":"                    LOG.error(res[\"traceback\"])"},{"line_number":363,"context_line":"        if not healthy:"},{"line_number":364,"context_line":"            raise exceptions.ValidationError("},{"line_number":365,"context_line":"                \"One or several platforms are not available. Check logs for \""}],"source_content_type":"text/x-python","patch_set":16,"id":"3fa0c359_dd105cab","line":362,"updated":"2018-02-09 07:53:47.000000000","message":"I would check somewhere else this .... Basically like it was before, check whatever you env is healthy, if healthy perform validation of task spec...","commit_id":"dd12db64c0d16e1a786dd29ed88de8f3452f346c"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"c92227e42e18843b6dcf3677ecc3bb553e9e95ce","unresolved":false,"context_lines":[{"line_number":359,"context_line":"            if not res[\"available\"]:"},{"line_number":360,"context_line":"                healthy \u003d False"},{"line_number":361,"context_line":"                if logging.is_debug():"},{"line_number":362,"context_line":"                    LOG.error(res[\"traceback\"])"},{"line_number":363,"context_line":"        if not healthy:"},{"line_number":364,"context_line":"            raise exceptions.ValidationError("},{"line_number":365,"context_line":"                \"One or several platforms are not available. Check logs for \""}],"source_content_type":"text/x-python","patch_set":16,"id":"3fa0c359_05dbc34e","line":362,"in_reply_to":"3fa0c359_dd105cab","updated":"2018-02-09 14:06:22.000000000","message":"Previously, verify_connection raises a real exception which shows not the abstract message \"something with your deployment\", but Exception which includes root cause. I think that `rally.api` is a better place for checking env health right before calling validate method of TaskEngine, but it will check the current workflow whereas I\u0027m trying to get rid of deployment in easiest way without rewriting anything.","commit_id":"dd12db64c0d16e1a786dd29ed88de8f3452f346c"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"07e235db13d09d5a2d71b0d7882d0be255d85708","unresolved":false,"context_lines":[{"line_number":362,"context_line":"                    LOG.error(res[\"traceback\"])"},{"line_number":363,"context_line":"        if not healthy:"},{"line_number":364,"context_line":"            raise exceptions.ValidationError("},{"line_number":365,"context_line":"                \"One or several platforms are not available. Check logs for \""},{"line_number":366,"context_line":"                \"more details.\")"},{"line_number":367,"context_line":"        validation_ctx \u003d self.env.get_validation_context()"},{"line_number":368,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"3fa0c359_57772fa1","line":365,"updated":"2018-02-10 09:09:03.000000000","message":"let\u0027s actually write what platforms are not available... than there is no need to print LOG.info on line 354","commit_id":"d627c2eb049f8327c655382697104dac9ace11b3"}],"rally/task/runner.py":[{"author":{"_account_id":26025,"name":"chenxu","email":"xuchen1990xx@gmail.com","username":"chenxu"},"change_message_id":"ffb570ad77780e40f1cfbb8ab6046dfdf9fea9b7","unresolved":false,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"def _get_scenario_context(iteration, context_obj):"},{"line_number":48,"context_line":"    print(\"get_scenario_ctx\")"},{"line_number":49,"context_line":"    print(context_obj)"},{"line_number":50,"context_line":"    context_obj \u003d copy.deepcopy(context_obj)"},{"line_number":51,"context_line":"    context_obj[\"iteration\"] \u003d iteration + 1  # Numeration starts from `1\u0027"},{"line_number":52,"context_line":"    return context_obj"}],"source_content_type":"text/x-python","patch_set":12,"id":"7f96bb07_0eab1789","line":49,"range":{"start_line":48,"start_character":0,"end_line":49,"end_character":22},"updated":"2018-01-23 15:31:15.000000000","message":"It looks like the debug code..","commit_id":"58aa2f1f503a43f65b065a9cf538cce2f7a3e395"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"9712dd2f3aead1c9532bb5e55448d401649560d3","unresolved":false,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"def _get_scenario_context(iteration, context_obj):"},{"line_number":48,"context_line":"    print(\"get_scenario_ctx\")"},{"line_number":49,"context_line":"    print(context_obj)"},{"line_number":50,"context_line":"    context_obj \u003d copy.deepcopy(context_obj)"},{"line_number":51,"context_line":"    context_obj[\"iteration\"] \u003d iteration + 1  # Numeration starts from `1\u0027"},{"line_number":52,"context_line":"    return context_obj"}],"source_content_type":"text/x-python","patch_set":12,"id":"7f96bb07_b8a7a6bc","line":49,"range":{"start_line":48,"start_character":0,"end_line":49,"end_character":22},"in_reply_to":"7f96bb07_0eab1789","updated":"2018-01-24 14:03:17.000000000","message":"Done","commit_id":"58aa2f1f503a43f65b065a9cf538cce2f7a3e395"}],"tests/unit/plugins/openstack/test_osclients.py":[{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"c0408211c6f79a5141e5d68648fc2010eaa2f573","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from rally import consts"},{"line_number":21,"context_line":"from rally import exceptions"},{"line_number":22,"context_line":"from rally import osclients as deprecated_osclients  # noqa"},{"line_number":23,"context_line":"from rally.plugins.openstack import credential as oscredential"},{"line_number":24,"context_line":"from rally.plugins.openstack import osclients"},{"line_number":25,"context_line":"from tests.unit import fakes"}],"source_content_type":"text/x-python","patch_set":27,"id":"3fa0c359_7196ec40","line":22,"updated":"2018-02-12 03:53:38.000000000","message":"I don\u0027t understand this. \n\n\nWhy you can\u0027t import not deprecated one? \n\nrally.plugins.openstack import osclients","commit_id":"a9a9fe4b87cdc0f16c72768e6a2aa18459ad2d75"}]}
