)]}'
{"rally/plugins/openstack/platforms/existing.py":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"0433ca759c04586aa0d6ec3c2245e111ecc4a400","unresolved":false,"context_lines":[{"line_number":96,"context_line":"        \"region_name\": None,"},{"line_number":97,"context_line":"        \"endpoint_type\": None,"},{"line_number":98,"context_line":"        \"domain_name\": None,"},{"line_number":99,"context_line":"        \"user_domain_name\": \"default\","},{"line_number":100,"context_line":"        \"project_domain_name\": \"default\","},{"line_number":101,"context_line":"        \"https_insecure\": False,"},{"line_number":102,"context_line":"        \"https_cacert\": None"},{"line_number":103,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa0c359_d38044c2","line":100,"range":{"start_line":99,"start_character":0,"end_line":100,"end_character":41},"updated":"2018-02-09 13:41:06.000000000","message":"There are 2 issues with this change:\n\n1) We have duplication of places with \"default\" values. [1] is used for several OpenStack clients, but is not used for keystone session (do not know why)\n2) Long time ago, we were asked to make these \"defaults\" configurable. See [2]. These config options are used while creating new users here [3]. If we change the values at existing@openstack. project_domain and user_domain will always have not-None values and the checks will not work. \n\n[1] - https://github.com/openstack/rally/blob/0.10.1/rally/plugins/openstack/osclients.py#L180-L185\n[2] - https://github.com/openstack/rally/blob/0.10.1/rally/plugins/openstack/cfg/keystone_users.py#L26-L33\n[3] - https://github.com/openstack/rally/blob/0.10.1/rally/plugins/openstack/context/keystone/users.py#L118-L123","commit_id":"2768037d9f6e4ab909e2bcb78906053839417d47"}]}