)]}'
{"rally/cli/commands/env.py":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"f5a4a679a3f2f55e326346d645b13d333d733f27","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        \"\"\"Create new environment.\"\"\""},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"        if spec is not None and from_sysenv:"},{"line_number":63,"context_line":"            print(\"Arguments \u0027--spec\u0027 and \u0027--from-sys-env\u0027 cannot be used \""},{"line_number":64,"context_line":"                  \"together, use only one of them.\")"},{"line_number":65,"context_line":"            return 1"},{"line_number":66,"context_line":"        spec \u003d spec or {}"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff6b8bd7_537d771a","line":63,"range":{"start_line":63,"start_character":45,"end_line":63,"end_character":58},"updated":"2018-03-06 22:12:43.000000000","message":"TODO: it should be equal to what we have at L49, i.e --from-sysenv","commit_id":"ccc586905778e4ef243e6bd1e9035f3587f69534"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"2397032b33b4cc4e90b66d7c4740fd42e1d4776e","unresolved":false,"context_lines":[{"line_number":89,"context_line":"            return 1"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"        if result:"},{"line_number":92,"context_line":"            _print(\"We iterated over %s platform-plugins.\" % len(result),"},{"line_number":93,"context_line":"                   to_json)"},{"line_number":94,"context_line":"            for platform, res in result.items():"},{"line_number":95,"context_line":"                _print(\"\\t - %s : %s.\" % (platform, res[\"message\"]), to_json)"}],"source_content_type":"text/x-python","patch_set":3,"id":"df7087c5_46c81c21","line":92,"updated":"2018-03-11 19:31:21.000000000","message":"unclear messages... \nrequires some context...","commit_id":"b47633daba511121a611a220ff9b2a303b21132a"},{"author":{"_account_id":26025,"name":"chenxu","email":"xuchen1990xx@gmail.com","username":"chenxu"},"change_message_id":"e3842e801a2001d158e6510f993b4c7dc248895e","unresolved":false,"context_lines":[{"line_number":80,"context_line":"                _print(\"\\t - %s : %s.\" % (p_name, p_result[\"message\"]),"},{"line_number":81,"context_line":"                       to_json)"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"                if \"traceback\" in res:"},{"line_number":84,"context_line":"                    _print(\"\".join(p_result[\"traceback\"]), to_json)"},{"line_number":85,"context_line":"        try:"},{"line_number":86,"context_line":"            env \u003d env_mgr.EnvManager.create("}],"source_content_type":"text/x-python","patch_set":4,"id":"df7087c5_94b2d093","line":83,"range":{"start_line":83,"start_character":34,"end_line":83,"end_character":37},"updated":"2018-03-12 15:27:38.000000000","message":"p_result","commit_id":"12fdf6975c09cf8039e1f834dafdc31cb5c95ff5"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"40255601271b57c4b735abd0a40af70f3844128c","unresolved":false,"context_lines":[{"line_number":80,"context_line":"                _print(\"\\t - %s : %s.\" % (p_name, p_result[\"message\"]),"},{"line_number":81,"context_line":"                       to_json)"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"                if \"traceback\" in res:"},{"line_number":84,"context_line":"                    _print(\"\".join(p_result[\"traceback\"]), to_json)"},{"line_number":85,"context_line":"        try:"},{"line_number":86,"context_line":"            env \u003d env_mgr.EnvManager.create("}],"source_content_type":"text/x-python","patch_set":4,"id":"df7087c5_ff9525e5","line":83,"range":{"start_line":83,"start_character":34,"end_line":83,"end_character":37},"in_reply_to":"df7087c5_94b2d093","updated":"2018-03-12 15:34:33.000000000","message":"done","commit_id":"12fdf6975c09cf8039e1f834dafdc31cb5c95ff5"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"0cb46784f5dec506a231fb0a1f69884fd244f996","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        if spec:"},{"line_number":68,"context_line":"            with open(os.path.expanduser(spec), \"rb\") as f:"},{"line_number":69,"context_line":"                spec \u003d yaml.safe_load(f.read())"},{"line_number":70,"context_line":"        if extras:"},{"line_number":71,"context_line":"            extras \u003d yaml.safe_load(extras)"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"        if from_sysenv:"}],"source_content_type":"text/x-python","patch_set":8,"id":"df7087c5_3d3a7298","line":70,"updated":"2018-03-15 06:22:39.000000000","message":"it would be nice to move extras, after the block with from_sysenv","commit_id":"bd9fff9f8c045cc6139e053428ab414391e4e56f"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"0cb46784f5dec506a231fb0a1f69884fd244f996","unresolved":false,"context_lines":[{"line_number":75,"context_line":"            spec \u003d result[\"spec\"]"},{"line_number":76,"context_line":"            _print(\"Your system environment includes specifications of \""},{"line_number":77,"context_line":"                   \"%s platform(s).\" % len(spec), to_json)"},{"line_number":78,"context_line":"            _print(\"Discovery information:\", to_json)"},{"line_number":79,"context_line":"            for p_name, p_result in result[\"discovery_details\"].items():"},{"line_number":80,"context_line":"                _print(\"\\t - %s : %s.\" % (p_name, p_result[\"message\"]),"},{"line_number":81,"context_line":"                       to_json)"}],"source_content_type":"text/x-python","patch_set":8,"id":"df7087c5_7d90ea95","line":78,"updated":"2018-03-15 06:22:39.000000000","message":"I would not actually print these message, env is in any case _show() at the end which is going to contain the same information.","commit_id":"bd9fff9f8c045cc6139e053428ab414391e4e56f"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"c194151aad0eb559bb1b4474a28bdf6010a8b808","unresolved":false,"context_lines":[{"line_number":75,"context_line":"            spec \u003d result[\"spec\"]"},{"line_number":76,"context_line":"            _print(\"Your system environment includes specifications of \""},{"line_number":77,"context_line":"                   \"%s platform(s).\" % len(spec), to_json)"},{"line_number":78,"context_line":"            _print(\"Discovery information:\", to_json)"},{"line_number":79,"context_line":"            for p_name, p_result in result[\"discovery_details\"].items():"},{"line_number":80,"context_line":"                _print(\"\\t - %s : %s.\" % (p_name, p_result[\"message\"]),"},{"line_number":81,"context_line":"                       to_json)"}],"source_content_type":"text/x-python","patch_set":8,"id":"df7087c5_c727b3c6","line":78,"in_reply_to":"df7087c5_7d90ea95","updated":"2018-03-16 15:01:34.000000000","message":"This print gives more information than _show. The resulting spec can include no platform credentials which means that show will display nothing.","commit_id":"bd9fff9f8c045cc6139e053428ab414391e4e56f"}],"rally/env/env_mgr.py":[{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"9d16a8cd66a1396fc2ed397a4170cf8b93d7b788","unresolved":false,"context_lines":[{"line_number":383,"context_line":"        Iterates over all available platform-representation plugins which"},{"line_number":384,"context_line":"        checks system environment for credentials."},{"line_number":385,"context_line":"        \"\"\""},{"line_number":386,"context_line":"        sys_env \u003d os.environ"},{"line_number":387,"context_line":"        spec \u003d {}"},{"line_number":388,"context_line":"        for p in platform.Platform.get_all():"},{"line_number":389,"context_line":"            res \u003d p.create_from_sys_environ(sys_env)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff6b8bd7_1dae41e7","line":386,"updated":"2018-03-06 08:55:14.000000000","message":"probably it makes sense to pass the copy of it?","commit_id":"3692c512bace2bd68f90ce78e8de92ab494bab92"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"14abe1f86e194225ba0996105ba9f158baf3aa7a","unresolved":false,"context_lines":[{"line_number":383,"context_line":"        Iterates over all available platform-representation plugins which"},{"line_number":384,"context_line":"        checks system environment for credentials."},{"line_number":385,"context_line":"        \"\"\""},{"line_number":386,"context_line":"        sys_env \u003d os.environ"},{"line_number":387,"context_line":"        spec \u003d {}"},{"line_number":388,"context_line":"        for p in platform.Platform.get_all():"},{"line_number":389,"context_line":"            res \u003d p.create_from_sys_environ(sys_env)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff6b8bd7_3dc22587","line":386,"in_reply_to":"ff6b8bd7_1dae41e7","updated":"2018-03-06 08:56:53.000000000","message":"yes, sure.","commit_id":"3692c512bace2bd68f90ce78e8de92ab494bab92"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"2397032b33b4cc4e90b66d7c4740fd42e1d4776e","unresolved":false,"context_lines":[{"line_number":389,"context_line":""},{"line_number":390,"context_line":"    @classmethod"},{"line_number":391,"context_line":"    @plugins.ensure_plugins_are_loaded"},{"line_number":392,"context_line":"    def create_from_sys_environ(cls, name, description\u003dNone, extras\u003dNone,"},{"line_number":393,"context_line":"                                config\u003dNone):"},{"line_number":394,"context_line":"        \"\"\"Creates DB record for new env and returns an instance of EnvManager"},{"line_number":395,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"df7087c5_06eb0479","line":392,"updated":"2018-03-11 19:31:21.000000000","message":"I would do this differently, \n\nYou are creating fork in logic of env creation but it\u0027s needed. \n\nBasically instead of actually creating env, you should just create_env_spec_from_env \n\nSo when you specify from_sysenv in CLI you just add one small step of creating the spec, if that fails you just say it failed.","commit_id":"b47633daba511121a611a220ff9b2a303b21132a"}],"rally/plugins/openstack/platforms/existing.py":[{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"9d16a8cd66a1396fc2ed397a4170cf8b93d7b788","unresolved":false,"context_lines":[{"line_number":206,"context_line":"                            v not in sys_environ]"},{"line_number":207,"context_line":"        tenant_name \u003d sys_environ(\"OS_PROJECT_NAME\","},{"line_number":208,"context_line":"                                  sys_environ(\"OS_TENANT_NAME\"))"},{"line_number":209,"context_line":"        if missing_env_vars or tenant_name is None:"},{"line_number":210,"context_line":"            return None"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"        endpoint_type \u003d sys_environ(\"OS_ENDPOINT_TYPE\","}],"source_content_type":"text/x-python","patch_set":1,"id":"ff6b8bd7_7df73df7","line":209,"updated":"2018-03-06 08:55:14.000000000","message":"so this is going to cause the trouble, we should use the same pattern as in other methods (we return the dict with details) \n\n{\n   \"success\": \u003cbool\u003e, \n   \"message\": \"\u003ccustom message\u003e\", \n    \"spec\": {}\n}\n\nso we can understand what\u0027s happenign inside","commit_id":"3692c512bace2bd68f90ce78e8de92ab494bab92"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"14abe1f86e194225ba0996105ba9f158baf3aa7a","unresolved":false,"context_lines":[{"line_number":206,"context_line":"                            v not in sys_environ]"},{"line_number":207,"context_line":"        tenant_name \u003d sys_environ(\"OS_PROJECT_NAME\","},{"line_number":208,"context_line":"                                  sys_environ(\"OS_TENANT_NAME\"))"},{"line_number":209,"context_line":"        if missing_env_vars or tenant_name is None:"},{"line_number":210,"context_line":"            return None"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"        endpoint_type \u003d sys_environ(\"OS_ENDPOINT_TYPE\","}],"source_content_type":"text/x-python","patch_set":1,"id":"ff6b8bd7_9d36d1b4","line":209,"in_reply_to":"ff6b8bd7_7df73df7","updated":"2018-03-06 08:56:53.000000000","message":"makes sence","commit_id":"3692c512bace2bd68f90ce78e8de92ab494bab92"},{"author":{"_account_id":26025,"name":"chenxu","email":"xuchen1990xx@gmail.com","username":"chenxu"},"change_message_id":"e3842e801a2001d158e6510f993b4c7dc248895e","unresolved":false,"context_lines":[{"line_number":247,"context_line":"            spec[\"admin\"][\"project_name\"] \u003d spec[\"admin\"].pop(\"tenant_name\")"},{"line_number":248,"context_line":"            spec[\"admin\"][\"user_domain_name\"] \u003d user_domain_name or \"Default\""},{"line_number":249,"context_line":"            project_domain_name \u003d project_domain_name or \"Default\""},{"line_number":250,"context_line":"            spec[\"admin\"][\"project_domain_name\"] \u003d project_domain_name"},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"        return {\"spec\": spec, \"available\": True, \"message\": \"Available\"}"}],"source_content_type":"text/x-python","patch_set":4,"id":"df7087c5_1f933951","line":250,"range":{"start_line":250,"start_character":12,"end_line":250,"end_character":48},"updated":"2018-03-12 15:27:38.000000000","message":"spec[\"admin\"][\"project_domain_name\"] \u003d project_domain_name or \"Default\"","commit_id":"12fdf6975c09cf8039e1f834dafdc31cb5c95ff5"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"40255601271b57c4b735abd0a40af70f3844128c","unresolved":false,"context_lines":[{"line_number":247,"context_line":"            spec[\"admin\"][\"project_name\"] \u003d spec[\"admin\"].pop(\"tenant_name\")"},{"line_number":248,"context_line":"            spec[\"admin\"][\"user_domain_name\"] \u003d user_domain_name or \"Default\""},{"line_number":249,"context_line":"            project_domain_name \u003d project_domain_name or \"Default\""},{"line_number":250,"context_line":"            spec[\"admin\"][\"project_domain_name\"] \u003d project_domain_name"},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"        return {\"spec\": spec, \"available\": True, \"message\": \"Available\"}"}],"source_content_type":"text/x-python","patch_set":4,"id":"df7087c5_7f04b54a","line":250,"range":{"start_line":250,"start_character":12,"end_line":250,"end_character":48},"in_reply_to":"df7087c5_1f933951","updated":"2018-03-12 15:34:33.000000000","message":"see previous line(249) ;)","commit_id":"12fdf6975c09cf8039e1f834dafdc31cb5c95ff5"},{"author":{"_account_id":26025,"name":"chenxu","email":"xuchen1990xx@gmail.com","username":"chenxu"},"change_message_id":"571a75752834a3cae9e5800e8624abec65e24268","unresolved":false,"context_lines":[{"line_number":247,"context_line":"            spec[\"admin\"][\"project_name\"] \u003d spec[\"admin\"].pop(\"tenant_name\")"},{"line_number":248,"context_line":"            spec[\"admin\"][\"user_domain_name\"] \u003d user_domain_name or \"Default\""},{"line_number":249,"context_line":"            project_domain_name \u003d project_domain_name or \"Default\""},{"line_number":250,"context_line":"            spec[\"admin\"][\"project_domain_name\"] \u003d project_domain_name"},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"        return {\"spec\": spec, \"available\": True, \"message\": \"Available\"}"}],"source_content_type":"text/x-python","patch_set":4,"id":"df7087c5_6f115552","line":250,"range":{"start_line":250,"start_character":12,"end_line":250,"end_character":48},"in_reply_to":"df7087c5_7f04b54a","updated":"2018-03-13 01:18:58.000000000","message":"I means these two lines can be combined into one line. : )","commit_id":"12fdf6975c09cf8039e1f834dafdc31cb5c95ff5"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"0cb46784f5dec506a231fb0a1f69884fd244f996","unresolved":false,"context_lines":[{"line_number":230,"context_line":"            \"endpoint_type\": endpoint_type,"},{"line_number":231,"context_line":"            \"region_name\": sys_environ.get(\"OS_REGION_NAME\", \"\"),"},{"line_number":232,"context_line":"            \"https_cacert\": sys_environ.get(\"OS_CACERT\", \"\"),"},{"line_number":233,"context_line":"            \"https_insecure\": strutils.bool_from_string("},{"line_number":234,"context_line":"                sys_environ.get(\"OS_INSECURE\")),"},{"line_number":235,"context_line":"            \"profiler_hmac_key\": sys_environ.get(\"OSPROFILER_HMAC_KEY\"),"},{"line_number":236,"context_line":"            \"profiler_conn_str\": sys_environ.get(\"OSPROFILER_CONN_STR\")"}],"source_content_type":"text/x-python","patch_set":8,"id":"df7087c5_5dd88679","line":233,"updated":"2018-03-15 06:22:39.000000000","message":"no more oslo, just copy this simple method to our code.","commit_id":"bd9fff9f8c045cc6139e053428ab414391e4e56f"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"c194151aad0eb559bb1b4474a28bdf6010a8b808","unresolved":false,"context_lines":[{"line_number":230,"context_line":"            \"endpoint_type\": endpoint_type,"},{"line_number":231,"context_line":"            \"region_name\": sys_environ.get(\"OS_REGION_NAME\", \"\"),"},{"line_number":232,"context_line":"            \"https_cacert\": sys_environ.get(\"OS_CACERT\", \"\"),"},{"line_number":233,"context_line":"            \"https_insecure\": strutils.bool_from_string("},{"line_number":234,"context_line":"                sys_environ.get(\"OS_INSECURE\")),"},{"line_number":235,"context_line":"            \"profiler_hmac_key\": sys_environ.get(\"OSPROFILER_HMAC_KEY\"),"},{"line_number":236,"context_line":"            \"profiler_conn_str\": sys_environ.get(\"OSPROFILER_CONN_STR\")"}],"source_content_type":"text/x-python","patch_set":8,"id":"df7087c5_67c90724","line":233,"in_reply_to":"df7087c5_5dd88679","updated":"2018-03-16 15:01:34.000000000","message":"It out of scope for this patch. `create_spec_from_sys_environ` method is an adopted version of https://github.com/openstack/rally/blob/master/rally/cli/envutils.py#L114 .\n\nReplacing oslo_utils.strutils.bool_from_string with a custom method will affect other code as well and this patch will increase with a redundant number of lines.","commit_id":"bd9fff9f8c045cc6139e053428ab414391e4e56f"}]}