)]}'
{"rally/plugins/openstack/osclients.py":[{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"6d75f5c749346614472e92c7844bbc50ece93c63","unresolved":false,"context_lines":[{"line_number":410,"context_line":"        if self.credential.endpoint_type:"},{"line_number":411,"context_line":"            kw_args[\"endpoint_type\"] \u003d self.credential.endpoint_type"},{"line_number":412,"context_line":""},{"line_number":413,"context_line":"        client \u003d octavia.OctaviaAPI("},{"line_number":414,"context_line":"            endpoint\u003dself._get_endpoint(service_type),"},{"line_number":415,"context_line":"            **kw_args)"},{"line_number":416,"context_line":"        return client"}],"source_content_type":"text/x-python","patch_set":3,"id":"df7087c5_82ede9f0","line":413,"range":{"start_line":413,"start_character":8,"end_line":413,"end_character":36},"updated":"2018-03-08 23:55:02.000000000","message":"Session missing?\n\nsession\u003dself.keystone.get_session()[0]","commit_id":"7dc4546cd77cc7985ad5d5a944bf8b6a62e9701f"},{"author":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"change_message_id":"f608f5a938b14f347f8a8ac1aeab5db0e9594a38","unresolved":false,"context_lines":[{"line_number":410,"context_line":"        if self.credential.endpoint_type:"},{"line_number":411,"context_line":"            kw_args[\"endpoint_type\"] \u003d self.credential.endpoint_type"},{"line_number":412,"context_line":""},{"line_number":413,"context_line":"        client \u003d octavia.OctaviaAPI("},{"line_number":414,"context_line":"            endpoint\u003dself._get_endpoint(service_type),"},{"line_number":415,"context_line":"            **kw_args)"},{"line_number":416,"context_line":"        return client"}],"source_content_type":"text/x-python","patch_set":3,"id":"df7087c5_d1ab911a","line":413,"range":{"start_line":413,"start_character":8,"end_line":413,"end_character":36},"in_reply_to":"df7087c5_82ede9f0","updated":"2018-03-10 20:18:33.000000000","message":"Done","commit_id":"7dc4546cd77cc7985ad5d5a944bf8b6a62e9701f"},{"author":{"_account_id":26025,"name":"chenxu","email":"xuchen1990xx@gmail.com","username":"chenxu"},"change_message_id":"53d8104952437f2f06015d030420e851b1be7c13","unresolved":false,"context_lines":[{"line_number":396,"context_line":"        return client"},{"line_number":397,"context_line":""},{"line_number":398,"context_line":""},{"line_number":399,"context_line":"@configure(\"octavia\", default_service_type\u003d\"load-balancer\")"},{"line_number":400,"context_line":"class Octavia(OSClient):"},{"line_number":401,"context_line":"    \"\"\"Wrapper for OctaviaClient which returns an authenticated native client."},{"line_number":402,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"df7087c5_7638c03c","line":399,"range":{"start_line":399,"start_character":1,"end_line":399,"end_character":58},"updated":"2018-03-19 06:06:05.000000000","message":"Octavia has two versions of API. So let us add \"default_version\u003d\"2\", supported_versions\u003d[\"1\", \"2\"]\".  : )","commit_id":"0be028b344ba4ec97c8f1a7f9098ad4fa3156922"},{"author":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"change_message_id":"5f16a0c89d7dc5a59e9258e496a2640752d79ced","unresolved":false,"context_lines":[{"line_number":396,"context_line":"        return client"},{"line_number":397,"context_line":""},{"line_number":398,"context_line":""},{"line_number":399,"context_line":"@configure(\"octavia\", default_service_type\u003d\"load-balancer\")"},{"line_number":400,"context_line":"class Octavia(OSClient):"},{"line_number":401,"context_line":"    \"\"\"Wrapper for OctaviaClient which returns an authenticated native client."},{"line_number":402,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"df7087c5_9c1253b4","line":399,"range":{"start_line":399,"start_character":1,"end_line":399,"end_character":58},"in_reply_to":"df7087c5_7638c03c","updated":"2018-03-19 07:58:50.000000000","message":"Hi chenxu, thanks for the reviews.\n\nI\u0027m aware of the two API version Octavia have.\nBut the V1 API is not at all relevant for our case since it only being used when Octavia is a neutron-lbaas provider (as opposed to its own keystone endpoint as I address it here). Thus I don\u0027t see a reason to mention this here.","commit_id":"0be028b344ba4ec97c8f1a7f9098ad4fa3156922"},{"author":{"_account_id":26025,"name":"chenxu","email":"xuchen1990xx@gmail.com","username":"chenxu"},"change_message_id":"53d8104952437f2f06015d030420e851b1be7c13","unresolved":false,"context_lines":[{"line_number":410,"context_line":"        if self.credential.endpoint_type:"},{"line_number":411,"context_line":"            kw_args[\"endpoint_type\"] \u003d self.credential.endpoint_type"},{"line_number":412,"context_line":""},{"line_number":413,"context_line":"        client \u003d octavia.OctaviaAPI("},{"line_number":414,"context_line":"            endpoint\u003dself._get_endpoint(service_type),"},{"line_number":415,"context_line":"            session\u003dself.keystone.get_session()[0],"},{"line_number":416,"context_line":"            **kw_args)"}],"source_content_type":"text/x-python","patch_set":5,"id":"df7087c5_765f6072","line":413,"range":{"start_line":413,"start_character":25,"end_line":413,"end_character":36},"updated":"2018-03-19 06:06:05.000000000","message":"version\u003dself.choose_version(version)","commit_id":"0be028b344ba4ec97c8f1a7f9098ad4fa3156922"},{"author":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"change_message_id":"9012ddd2a68547eb4f7de5794da6a4b04ff33239","unresolved":false,"context_lines":[{"line_number":410,"context_line":"        if self.credential.endpoint_type:"},{"line_number":411,"context_line":"            kw_args[\"endpoint_type\"] \u003d self.credential.endpoint_type"},{"line_number":412,"context_line":""},{"line_number":413,"context_line":"        client \u003d octavia.OctaviaAPI("},{"line_number":414,"context_line":"            endpoint\u003dself._get_endpoint(service_type),"},{"line_number":415,"context_line":"            session\u003dself.keystone.get_session()[0],"},{"line_number":416,"context_line":"            **kw_args)"}],"source_content_type":"text/x-python","patch_set":5,"id":"df7087c5_e67c19ed","line":413,"range":{"start_line":413,"start_character":25,"end_line":413,"end_character":36},"in_reply_to":"df7087c5_765f6072","updated":"2018-03-19 09:49:11.000000000","message":"if you look at: https://github.com/openstack/python-octaviaclient/blob/master/octaviaclient/api/v2/octavia.py\n\nyou\u0027ll see that OctaviaAPI (nor BaseAPI) accept version.","commit_id":"0be028b344ba4ec97c8f1a7f9098ad4fa3156922"}]}