)]}'
{"rally/common/db/api.py":[{"author":{"_account_id":25568,"name":"Luis Pigueiras","email":"lpigueiras@gmail.com","username":"lpigueiras"},"change_message_id":"2d361ab8144189489920b36d3bca2c10255b1d8a","unresolved":false,"context_lines":[{"line_number":586,"context_line":"        values[\"status\"] \u003d status"},{"line_number":587,"context_line":"    if platforms is not None:"},{"line_number":588,"context_line":"        # clean before"},{"line_number":589,"context_line":"        session.query(models.Platform).filter_by(env_uuid\u003duuid).delete()"},{"line_number":590,"context_line":""},{"line_number":591,"context_line":"        for p in platforms:"},{"line_number":592,"context_line":"            p[\"env_uuid\"] \u003d uuid"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f6a8fd7_d4c4e861","line":589,"updated":"2018-04-18 13:23:48.000000000","message":"Is this really fine? If the save fails maybe you get an inconsistent state of the environment...","commit_id":"377e9da7f789801570b9b87d394d69aa57a02c05"}],"rally/env/env_mgr.py":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"bae994082908f7f77b6303caab4612c6d88d24c6","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    CLEANING \u003d \"CLEANING\""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    FAILED_TO_UPDATE \u003d \"FAILED TO UPDATE\""},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    DESTROYING \u003d \"DESTROYING\""},{"line_number":45,"context_line":"    FAILED_TO_DESTROY \u003d \"FAILED TO DESTROY\""}],"source_content_type":"text/x-python","patch_set":1,"id":"9f6a8fd7_2ca7a20d","line":42,"range":{"start_line":42,"start_character":4,"end_line":42,"end_character":41},"updated":"2018-04-24 11:36:43.000000000","message":"Platforms are allowed to not just use existing infrastructure (via providing credentials), but Platform classes, in theory, can deploy something.\nIt means that update action can take more than several seconds.I suggest to add a status \"updating\"","commit_id":"377e9da7f789801570b9b87d394d69aa57a02c05"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"bae994082908f7f77b6303caab4612c6d88d24c6","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        CLEANING: (READY, ),"},{"line_number":52,"context_line":"        FAILED_TO_CREATE: (DESTROYING, ),"},{"line_number":53,"context_line":"        DESTROYING: (DESTROYED, FAILED_TO_DESTROY),"},{"line_number":54,"context_line":"        FAILED_TO_DESTROY: (DESTROYING, )"},{"line_number":55,"context_line":"    }"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9f6a8fd7_acb2d247","line":54,"range":{"start_line":54,"start_character":8,"end_line":54,"end_character":41},"updated":"2018-04-24 11:36:43.000000000","message":"you need to add mapping for FAILED_TO_UPDATE:\n\nFAILED_TO_UPDATE): (DESTROYING, UPDATING)","commit_id":"377e9da7f789801570b9b87d394d69aa57a02c05"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"bae994082908f7f77b6303caab4612c6d88d24c6","unresolved":false,"context_lines":[{"line_number":578,"context_line":"        return db.env_update("},{"line_number":579,"context_line":"            self.uuid, description\u003ddescription, config\u003dconfig, extras\u003dextras)"},{"line_number":580,"context_line":""},{"line_number":581,"context_line":"    @plugins.ensure_plugins_are_loaded"},{"line_number":582,"context_line":"    def update_spec(self, new_spec):"},{"line_number":583,"context_line":"        \"\"\"Update env spec\"\"\""},{"line_number":584,"context_line":"        self._validate_and_update_env(self.uuid, new_spec)"},{"line_number":585,"context_line":"        self._update_platforms()"},{"line_number":586,"context_line":""},{"line_number":587,"context_line":"    _HEALTH_FORMAT \u003d {"},{"line_number":588,"context_line":"        \"type\": \"object\","}],"source_content_type":"text/x-python","patch_set":1,"id":"9f6a8fd7_4cec5629","line":585,"range":{"start_line":581,"start_character":5,"end_line":585,"end_character":32},"updated":"2018-04-24 11:36:43.000000000","message":"as far as I understand it extends the env with new platforms and existing ones will not be updated.","commit_id":"377e9da7f789801570b9b87d394d69aa57a02c05"}]}