)]}'
{"rally/plugins/common/runners/constant.py":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"87602e5bbcc857a1dabd76f602028e8e7e08c47d","unresolved":false,"context_lines":[{"line_number":27,"context_line":"from rally.task import utils as butils"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"def _worker_process(queue, iteration_gen, timeout, concurrency, times, duration,"},{"line_number":31,"context_line":"                    context, cls, method_name, args, event_queue, aborted,"},{"line_number":32,"context_line":"                    info):"},{"line_number":33,"context_line":"    \"\"\"Start the scenario within threads."}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_f8569bcd","line":30,"range":{"start_line":30,"start_character":71,"end_line":30,"end_character":80},"updated":"2018-11-05 12:52:30.000000000","message":"please document a new argument","commit_id":"853bde5ce9418026192e8486eb364ff9fe144ea2"},{"author":{"_account_id":21470,"name":"Matthieu Simonin","email":"matthieu.simonin@inria.fr","username":"msimonin"},"change_message_id":"6c57cf6c487c4a95b6225d54ade5df31393ba36a","unresolved":false,"context_lines":[{"line_number":27,"context_line":"from rally.task import utils as butils"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"def _worker_process(queue, iteration_gen, timeout, concurrency, times, duration,"},{"line_number":31,"context_line":"                    context, cls, method_name, args, event_queue, aborted,"},{"line_number":32,"context_line":"                    info):"},{"line_number":33,"context_line":"    \"\"\"Start the scenario within threads."}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_f988da1a","line":30,"range":{"start_line":30,"start_character":71,"end_line":30,"end_character":80},"in_reply_to":"3f79a3b5_f8569bcd","updated":"2018-11-05 16:50:44.000000000","message":"Done","commit_id":"853bde5ce9418026192e8486eb364ff9fe144ea2"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"87602e5bbcc857a1dabd76f602028e8e7e08c47d","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        else:"},{"line_number":61,"context_line":"            return False"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    assert times is not None or duration is not None"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    pool \u003d collections.deque()"},{"line_number":66,"context_line":"    alive_threads_in_pool \u003d 0"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_4d8e33d8","line":63,"range":{"start_line":63,"start_character":4,"end_line":63,"end_character":52},"updated":"2018-11-05 12:52:30.000000000","message":"I prefer to replace this with `if` check with a user-friendly error message","commit_id":"853bde5ce9418026192e8486eb364ff9fe144ea2"},{"author":{"_account_id":21470,"name":"Matthieu Simonin","email":"matthieu.simonin@inria.fr","username":"msimonin"},"change_message_id":"6c57cf6c487c4a95b6225d54ade5df31393ba36a","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        else:"},{"line_number":61,"context_line":"            return False"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    assert times is not None or duration is not None"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    pool \u003d collections.deque()"},{"line_number":66,"context_line":"    alive_threads_in_pool \u003d 0"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_b9926249","line":63,"range":{"start_line":63,"start_character":4,"end_line":63,"end_character":52},"in_reply_to":"3f79a3b5_4d8e33d8","updated":"2018-11-05 16:50:44.000000000","message":"Done.\nI used InvalidArgumentsException, not sure it\u0027s the right semantic.","commit_id":"853bde5ce9418026192e8486eb364ff9fe144ea2"},{"author":{"_account_id":21470,"name":"Matthieu Simonin","email":"matthieu.simonin@inria.fr","username":"msimonin"},"change_message_id":"4b4821c62048b53921f81b5324f3a1dd3a1112a7","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        else:"},{"line_number":61,"context_line":"            return False"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    assert times is not None or duration is not None"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    pool \u003d collections.deque()"},{"line_number":66,"context_line":"    alive_threads_in_pool \u003d 0"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_2de04c27","line":63,"range":{"start_line":63,"start_character":4,"end_line":63,"end_character":52},"in_reply_to":"3f79a3b5_9c1674f3","updated":"2018-11-05 19:18:37.000000000","message":"I see, I used ValueError here.","commit_id":"853bde5ce9418026192e8486eb364ff9fe144ea2"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"aa573a3d7cec06ed265f33c0275fdd52e13ce289","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        else:"},{"line_number":61,"context_line":"            return False"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    assert times is not None or duration is not None"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    pool \u003d collections.deque()"},{"line_number":66,"context_line":"    alive_threads_in_pool \u003d 0"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_9c1674f3","line":63,"range":{"start_line":63,"start_character":4,"end_line":63,"end_character":52},"in_reply_to":"3f79a3b5_b9926249","updated":"2018-11-05 17:08:24.000000000","message":"It was a mistake creating a bunch of custom exceptions (which duplicates the native ones). Hope that someday we will reduce them. At least for one, I would like to do not extend the number of places where they are used.\nLet\u0027s use here AttributeError, TypeError or ValueError","commit_id":"853bde5ce9418026192e8486eb364ff9fe144ea2"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"5b82ad476ac2b4b43789269230f5771b10a99ec0","unresolved":false,"context_lines":[{"line_number":268,"context_line":"            \"duration\": {"},{"line_number":269,"context_line":"                \"type\": \"number\","},{"line_number":270,"context_line":"                \"minimum\": 0.0,"},{"line_number":271,"context_line":"                \"description\": \"The number of seconds during which to generate\""},{"line_number":272,"context_line":"                               \" a load.\""},{"line_number":273,"context_line":"            },"},{"line_number":274,"context_line":"            \"timeout\": {"},{"line_number":275,"context_line":"                \"type\": \"number\","}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_5ce53c06","line":272,"range":{"start_line":271,"start_character":32,"end_line":272,"end_character":40},"updated":"2018-11-05 17:10:00.000000000","message":"it would be nice to note here the behavior of duration\u003d0","commit_id":"853bde5ce9418026192e8486eb364ff9fe144ea2"},{"author":{"_account_id":21470,"name":"Matthieu Simonin","email":"matthieu.simonin@inria.fr","username":"msimonin"},"change_message_id":"4b4821c62048b53921f81b5324f3a1dd3a1112a7","unresolved":false,"context_lines":[{"line_number":268,"context_line":"            \"duration\": {"},{"line_number":269,"context_line":"                \"type\": \"number\","},{"line_number":270,"context_line":"                \"minimum\": 0.0,"},{"line_number":271,"context_line":"                \"description\": \"The number of seconds during which to generate\""},{"line_number":272,"context_line":"                               \" a load.\""},{"line_number":273,"context_line":"            },"},{"line_number":274,"context_line":"            \"timeout\": {"},{"line_number":275,"context_line":"                \"type\": \"number\","}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_0dcf90b2","line":272,"range":{"start_line":271,"start_character":32,"end_line":272,"end_character":40},"in_reply_to":"3f79a3b5_5ce53c06","updated":"2018-11-05 19:18:37.000000000","message":"Done","commit_id":"853bde5ce9418026192e8486eb364ff9fe144ea2"}]}
