)]}'
{"rally/common/streaming_algorithms.py":[{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"c1800992e31875e0f839b34f442596bb879aa1d9","unresolved":false,"context_lines":[{"line_number":167,"context_line":""},{"line_number":168,"context_line":"    def _dump_chunk(self):"},{"line_number":169,"context_line":"        with open(self._filename, \"w+\") as f:"},{"line_number":170,"context_line":"            f.write(\" \" + \" \".join(self._chunk))"},{"line_number":171,"context_line":"        self._chunk \u003d []"},{"line_number":172,"context_line":"        self._current_chunk_size \u003d 0"},{"line_number":173,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_6d5b34f8","line":170,"updated":"2020-02-16 21:51:06.000000000","message":"would work faster if we do something like \n\n\" \".join(itertools.chain([\"\"], self._chunk_size))","commit_id":"113ebbaf9fdb63ab4d79956abece945ef000f58c"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"a08ae169bd75aa974675689b47d0e96fa292e5b3","unresolved":false,"context_lines":[{"line_number":167,"context_line":""},{"line_number":168,"context_line":"    def _dump_chunk(self):"},{"line_number":169,"context_line":"        with open(self._filename, \"w+\") as f:"},{"line_number":170,"context_line":"            f.write(\" \" + \" \".join(self._chunk))"},{"line_number":171,"context_line":"        self._chunk \u003d []"},{"line_number":172,"context_line":"        self._current_chunk_size \u003d 0"},{"line_number":173,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_cde588d0","line":170,"in_reply_to":"3fa7e38b_6d5b34f8","updated":"2020-02-16 22:08:18.000000000","message":"right","commit_id":"113ebbaf9fdb63ab4d79956abece945ef000f58c"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"c1800992e31875e0f839b34f442596bb879aa1d9","unresolved":false,"context_lines":[{"line_number":173,"context_line":""},{"line_number":174,"context_line":"    def add(self, value):"},{"line_number":175,"context_line":"        if self._deleted:"},{"line_number":176,"context_line":"            raise TypeError(\"unexist\")"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"        self._chunk.append(value)"},{"line_number":179,"context_line":"        self._current_chunk_size +\u003d 1"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_8d5eb0e5","line":176,"updated":"2020-02-16 21:51:06.000000000","message":"okay this would be something really hard to debug, just out of message I don\u0027t understand what\u0027s happening here, for example why it\u0027s not just ignored?","commit_id":"113ebbaf9fdb63ab4d79956abece945ef000f58c"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"a08ae169bd75aa974675689b47d0e96fa292e5b3","unresolved":false,"context_lines":[{"line_number":173,"context_line":""},{"line_number":174,"context_line":"    def add(self, value):"},{"line_number":175,"context_line":"        if self._deleted:"},{"line_number":176,"context_line":"            raise TypeError(\"unexist\")"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"        self._chunk.append(value)"},{"line_number":179,"context_line":"        self._current_chunk_size +\u003d 1"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_adea8c9d","line":176,"in_reply_to":"3fa7e38b_8d5eb0e5","updated":"2020-02-16 22:08:18.000000000","message":"1) ignoring is not good. such case should not happen anytime. it is not expected behavior \n\n2)  this message appears as PoC :)","commit_id":"113ebbaf9fdb63ab4d79956abece945ef000f58c"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"c1800992e31875e0f839b34f442596bb879aa1d9","unresolved":false,"context_lines":[{"line_number":185,"context_line":"            self.add(point)"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"    def result(self):"},{"line_number":188,"context_line":"        if self._deleted:"},{"line_number":189,"context_line":"            raise TypeError(\"unexist\")"},{"line_number":190,"context_line":"        if os.path.isfile(self._filename):"},{"line_number":191,"context_line":"            with open(self._filename) as f:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_ed6e4495","line":188,"updated":"2020-02-16 21:51:06.000000000","message":"maybe make sense to create method, like _ensure_not_deleted","commit_id":"113ebbaf9fdb63ab4d79956abece945ef000f58c"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"a08ae169bd75aa974675689b47d0e96fa292e5b3","unresolved":false,"context_lines":[{"line_number":185,"context_line":"            self.add(point)"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"    def result(self):"},{"line_number":188,"context_line":"        if self._deleted:"},{"line_number":189,"context_line":"            raise TypeError(\"unexist\")"},{"line_number":190,"context_line":"        if os.path.isfile(self._filename):"},{"line_number":191,"context_line":"            with open(self._filename) as f:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_6d26d424","line":188,"in_reply_to":"3fa7e38b_ed6e4495","updated":"2020-02-16 22:08:18.000000000","message":"messages should be different :)","commit_id":"113ebbaf9fdb63ab4d79956abece945ef000f58c"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"c1800992e31875e0f839b34f442596bb879aa1d9","unresolved":false,"context_lines":[{"line_number":205,"context_line":"            os.remove(self._filename)"},{"line_number":206,"context_line":"        self._deleted \u003d True"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"    def __del__(self):"},{"line_number":209,"context_line":"        self.reset()"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_cd5fc8db","line":208,"updated":"2020-02-16 21:51:06.000000000","message":"Not sure about latest python but __del__ was messing with GC and it was not always properly called (if you don\u0027t have del \u003cthis\u003e explicit call of it)\nhttps://docs.python.org/3.4/library/gc.html#gc.garbage","commit_id":"113ebbaf9fdb63ab4d79956abece945ef000f58c"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"a08ae169bd75aa974675689b47d0e96fa292e5b3","unresolved":false,"context_lines":[{"line_number":205,"context_line":"            os.remove(self._filename)"},{"line_number":206,"context_line":"        self._deleted \u003d True"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"    def __del__(self):"},{"line_number":209,"context_line":"        self.reset()"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_8d29d0f1","line":208,"in_reply_to":"3fa7e38b_cd5fc8db","updated":"2020-02-16 22:08:18.000000000","message":"fixed","commit_id":"113ebbaf9fdb63ab4d79956abece945ef000f58c"}],"rally/task/processing/charts.py":[{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"c1800992e31875e0f839b34f442596bb879aa1d9","unresolved":false,"context_lines":[{"line_number":403,"context_line":"        root[name] \u003d {"},{"line_number":404,"context_line":"            # streaming algorithms"},{"line_number":405,"context_line":"            \"sa\": ["},{"line_number":406,"context_line":"                streaming.PointsSaver(),"},{"line_number":407,"context_line":"                streaming.MinComputation(),"},{"line_number":408,"context_line":"                streaming.MaxComputation(),"},{"line_number":409,"context_line":"                streaming.MeanComputation(),"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_edf3a4e6","line":406,"updated":"2020-02-16 21:51:06.000000000","message":"so this might leave your file created and not cleaned up by rally.","commit_id":"113ebbaf9fdb63ab4d79956abece945ef000f58c"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"a08ae169bd75aa974675689b47d0e96fa292e5b3","unresolved":false,"context_lines":[{"line_number":403,"context_line":"        root[name] \u003d {"},{"line_number":404,"context_line":"            # streaming algorithms"},{"line_number":405,"context_line":"            \"sa\": ["},{"line_number":406,"context_line":"                streaming.PointsSaver(),"},{"line_number":407,"context_line":"                streaming.MinComputation(),"},{"line_number":408,"context_line":"                streaming.MaxComputation(),"},{"line_number":409,"context_line":"                streaming.MeanComputation(),"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_ed39643f","line":406,"in_reply_to":"3fa7e38b_edf3a4e6","updated":"2020-02-16 22:08:18.000000000","message":"the location of the file is /tmp dir. In case of unexpected failure of rally process, the system will remove it)","commit_id":"113ebbaf9fdb63ab4d79956abece945ef000f58c"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"c1800992e31875e0f839b34f442596bb879aa1d9","unresolved":false,"context_lines":[{"line_number":477,"context_line":"        # process percentiles"},{"line_number":478,"context_line":"        points \u003d points.result()"},{"line_number":479,"context_line":"        points.sort()"},{"line_number":480,"context_line":"        p50ile \u003d utils.percentile(points, 0.5, ignore_sorting\u003dTrue)"},{"line_number":481,"context_line":"        p90ile \u003d utils.percentile(points, 0.9, ignore_sorting\u003dTrue)"},{"line_number":482,"context_line":"        p95ile \u003d utils.percentile(points, 0.95, ignore_sorting\u003dTrue)"},{"line_number":483,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_6db334ed","line":480,"updated":"2020-02-16 21:51:06.000000000","message":"just wander do we ever use it with sorting?","commit_id":"113ebbaf9fdb63ab4d79956abece945ef000f58c"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"a08ae169bd75aa974675689b47d0e96fa292e5b3","unresolved":false,"context_lines":[{"line_number":477,"context_line":"        # process percentiles"},{"line_number":478,"context_line":"        points \u003d points.result()"},{"line_number":479,"context_line":"        points.sort()"},{"line_number":480,"context_line":"        p50ile \u003d utils.percentile(points, 0.5, ignore_sorting\u003dTrue)"},{"line_number":481,"context_line":"        p90ile \u003d utils.percentile(points, 0.9, ignore_sorting\u003dTrue)"},{"line_number":482,"context_line":"        p95ile \u003d utils.percentile(points, 0.95, ignore_sorting\u003dTrue)"},{"line_number":483,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_0d35e042","line":480,"in_reply_to":"3fa7e38b_6db334ed","updated":"2020-02-16 22:08:18.000000000","message":"not. I left this ability for the case when this method will be used by third-party plugins.","commit_id":"113ebbaf9fdb63ab4d79956abece945ef000f58c"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"c1800992e31875e0f839b34f442596bb879aa1d9","unresolved":false,"context_lines":[{"line_number":758,"context_line":"            for ins in (points, min_v, max_v, avg):"},{"line_number":759,"context_line":"                ins.add(value)"},{"line_number":760,"context_line":""},{"line_number":761,"context_line":"    def _process_row(self, name, sa):"},{"line_number":762,"context_line":"        points, count, min_v, max_v, avg \u003d sa"},{"line_number":763,"context_line":""},{"line_number":764,"context_line":"        # get percentiles"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_edc6444a","line":761,"updated":"2020-02-16 21:51:06.000000000","message":"this method looks almost identical to MainStats._process_raw except that it accepts and returns \"name\" argument","commit_id":"113ebbaf9fdb63ab4d79956abece945ef000f58c"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"a08ae169bd75aa974675689b47d0e96fa292e5b3","unresolved":false,"context_lines":[{"line_number":758,"context_line":"            for ins in (points, min_v, max_v, avg):"},{"line_number":759,"context_line":"                ins.add(value)"},{"line_number":760,"context_line":""},{"line_number":761,"context_line":"    def _process_row(self, name, sa):"},{"line_number":762,"context_line":"        points, count, min_v, max_v, avg \u003d sa"},{"line_number":763,"context_line":""},{"line_number":764,"context_line":"        # get percentiles"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_6d749404","line":761,"in_reply_to":"3fa7e38b_edc6444a","updated":"2020-02-16 22:08:18.000000000","message":"`MainStats._process_raw` take care about `success` sa instance....","commit_id":"113ebbaf9fdb63ab4d79956abece945ef000f58c"}]}