)]}'
{"tox.ini":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"1de212470cd560ba50ef236cea140abf2c030f31","unresolved":false,"context_lines":[{"line_number":18,"context_line":"                      make"},{"line_number":19,"context_line":"deps \u003d -r{toxinidir}/requirements.txt"},{"line_number":20,"context_line":"       -r{toxinidir}/test-requirements.txt"},{"line_number":21,"context_line":"install_command \u003d python -m pip install -c ./upper-constraints.txt -U {opts} {packages}"},{"line_number":22,"context_line":"usedevelop \u003d True"},{"line_number":23,"context_line":"commands \u003d"},{"line_number":24,"context_line":"  find . -type f -name \"*.pyc\" -delete"}],"source_content_type":"text/x-properties","patch_set":3,"id":"1fa4df85_9f3994a4","line":21,"range":{"start_line":21,"start_character":18,"end_line":21,"end_character":24},"updated":"2020-03-17 13:24:24.000000000","message":"I wonder, should it be `python3 -m`?","commit_id":"16e651a315e5b1e1b0425bf594bc8a11d7b0701a"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"bb22b4f1d643852914bb54d6f71c78289ada99ac","unresolved":false,"context_lines":[{"line_number":18,"context_line":"                      make"},{"line_number":19,"context_line":"deps \u003d -r{toxinidir}/requirements.txt"},{"line_number":20,"context_line":"       -r{toxinidir}/test-requirements.txt"},{"line_number":21,"context_line":"install_command \u003d python3 -m pip install -c ./upper-constraints.txt -U {opts} {packages}"},{"line_number":22,"context_line":"usedevelop \u003d True"},{"line_number":23,"context_line":"commands \u003d"},{"line_number":24,"context_line":"  find . -type f -name \"*.pyc\" -delete"}],"source_content_type":"text/x-properties","patch_set":7,"id":"ff570b3c_c563e0b0","line":21,"range":{"start_line":21,"start_character":0,"end_line":21,"end_character":88},"updated":"2020-05-25 11:20:55.000000000","message":"Few comments about this:\n\nthe `upper-constraints.txt` could be moved to the `deps` above this line, and it could point to the `openstack/requirements` repo rather than to the local copy to stay up-to-date all the time:\n\n```\ndeps \u003d \n    -c{env:UPPER_CONSTRAINTS_FILE:https://opendev.org/openstack/requirements/raw/branch/master/upper-constraints.txt}\n    -r{toxinidir}/requirements.txt\n    -r{toxinidir}/test-requirements.txt\n```\n\nSo, now this line could be dropped since tox 3.2.0  automatically call pip as a module of the python interpreter in use. Also we already refer to `basepython` in version 3 (3.6) so we don\u0027t need to specify the version to use there.","commit_id":"57a09c754977876f0e33a723b79860e7a3a672d6"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"b306a67c2b5b27360413e7d0fff140d49a32c9f0","unresolved":false,"context_lines":[{"line_number":18,"context_line":"                      make"},{"line_number":19,"context_line":"deps \u003d -r{toxinidir}/requirements.txt"},{"line_number":20,"context_line":"       -r{toxinidir}/test-requirements.txt"},{"line_number":21,"context_line":"install_command \u003d python3 -m pip install -c ./upper-constraints.txt -U {opts} {packages}"},{"line_number":22,"context_line":"usedevelop \u003d True"},{"line_number":23,"context_line":"commands \u003d"},{"line_number":24,"context_line":"  find . -type f -name \"*.pyc\" -delete"}],"source_content_type":"text/x-properties","patch_set":7,"id":"ff570b3c_904be8ae","line":21,"range":{"start_line":21,"start_character":0,"end_line":21,"end_character":88},"in_reply_to":"ff570b3c_c563e0b0","updated":"2020-05-25 13:11:04.000000000","message":"\u003e the `upper-constraints.txt` could be moved to the `deps` above this\n \u003e line, \n\n+1\n\n\u003e and it could point to the `openstack/requirements` repo\n \u003e rather than to the local copy to stay up-to-date all the time.\n\nno, please no. Rally stopped following global requirements ~4 year ago - https://github.com/openstack/requirements/commit/f2ce9309e35b1a93459ce683b9a05ee1f32f221c#diff-89c28a76ce4a788d623438b98d59f7d2 \n\nAlso, having an external resource (https://opendev.org/openstack/requirements/raw/branch/master/upper-constraints.txt) at deps requires internet access. I see that it can be overridden via env variable, but the default behavior will require net...","commit_id":"57a09c754977876f0e33a723b79860e7a3a672d6"}]}