)]}'
{"rally/common/objects/deploy.py":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"a5b6912dc1bd1e7ef6ee62737b7aecd20cd5ac66","unresolved":false,"context_lines":[{"line_number":155,"context_line":"        for platform, credentials in self._all_credentials.items():"},{"line_number":156,"context_line":"            if platform \u003d\u003d \"openstack\":"},{"line_number":157,"context_line":"                try:"},{"line_number":158,"context_line":"                    from rally_openstack.common import credential"},{"line_number":159,"context_line":"                except ImportError:"},{"line_number":160,"context_line":"                    all_credentials[platform] \u003d credentials"},{"line_number":161,"context_line":"                else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"df33271e_1d6fefc5","line":158,"updated":"2020-04-05 13:14:27.000000000","message":"We are trying to make such changes in a backward-compatible way, so the latest rally will work with not the latest rally-openstack (at least for some time).\n\nMethod `get_all_credentials` is used only by `get_credentials_for`. `get_credentials_for` is used only by Tempest manager. Can you modify that code to use \"modern\" way to take credentials?\n\nI.e replace https://github.com/openstack/rally-openstack/blob/master/rally_openstack/verification/tempest/context.py#L45-L46 with something like\n\n    env_data \u003d self.verifier.env.data\n    platforms \u003d dict(\n            (p[\"platform_name\"], p[\"platform_data\"])\n            for p in env_data[\"platforms\"].values())\n    creds \u003d platforms[\"openstack\"]\n    admin_creds \u003d credential.OpenStackCredential(api_info\u003dcreds.get(\"api_info\", {}), **creds[\"admin\"])\n\nI would be appreciated for the help!","commit_id":"02baa28e6b23a93dc6e038f94c550a0f9a17cf43"},{"author":{"_account_id":11692,"name":"Cédric OLLIVIER","email":"ollivier.cedric@gmail.com","username":"col"},"change_message_id":"e715461deed0d363038379e47fb6e35d95eaa1b6","unresolved":false,"context_lines":[{"line_number":155,"context_line":"        for platform, credentials in self._all_credentials.items():"},{"line_number":156,"context_line":"            if platform \u003d\u003d \"openstack\":"},{"line_number":157,"context_line":"                try:"},{"line_number":158,"context_line":"                    from rally_openstack.common import credential"},{"line_number":159,"context_line":"                except ImportError:"},{"line_number":160,"context_line":"                    all_credentials[platform] \u003d credentials"},{"line_number":161,"context_line":"                else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"df33271e_9d6c9f9d","line":158,"in_reply_to":"df33271e_1d6fefc5","updated":"2020-04-05 13:54:27.000000000","message":"Yes it would only work with rally-openstack master.\nI will do my best. But it seems that you update the code in the review.","commit_id":"02baa28e6b23a93dc6e038f94c550a0f9a17cf43"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"3c20bfc8efe400736f8d66210bce6d6009e4e019","unresolved":false,"context_lines":[{"line_number":155,"context_line":"        for platform, credentials in self._all_credentials.items():"},{"line_number":156,"context_line":"            if platform \u003d\u003d \"openstack\":"},{"line_number":157,"context_line":"                try:"},{"line_number":158,"context_line":"                    from rally_openstack.common import credential"},{"line_number":159,"context_line":"                except ImportError:"},{"line_number":160,"context_line":"                    all_credentials[platform] \u003d credentials"},{"line_number":161,"context_line":"                else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"df33271e_879a065f","line":158,"in_reply_to":"df33271e_9d6c9f9d","updated":"2020-04-10 13:02:53.000000000","message":"\u003e But it seems that you update the code in the review.\n\nwhat do you mean? rally-openstack code still includes usage of get_credentials_for in several places.\n\nBtw, I turned on treating warning as errors for tox[*], so now it catches the similar issues that you are facing at your CI.\n\n[*] - https://github.com/openstack/rally-openstack/blob/master/tox.ini#L119","commit_id":"02baa28e6b23a93dc6e038f94c550a0f9a17cf43"}]}