)]}'
{"rally/plugins/task/contexts/script/script.py":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"f911ed25b10b15eca25afa00b44cbf11ce056450","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    CONFIG_SCHEMA \u003d {"},{"line_number":23,"context_line":"        \"type\": \"object\","},{"line_number":24,"context_line":"        \"$schema\": consts.JSON_SCHEMA,"},{"line_number":25,"context_line":"        \"additionalProperties\": False,"},{"line_number":26,"context_line":"        \"properties\": {"},{"line_number":27,"context_line":"            \"setup\": {"},{"line_number":28,"context_line":"                \"type\": \"array\","}],"source_content_type":"text/x-python","patch_set":2,"id":"1f621f24_3aaa1584","line":25,"updated":"2020-11-12 15:17:31.000000000","message":"see the main comment","commit_id":"3452740f9eec6a28719f6b4b646cabc2f9cabf96"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"f911ed25b10b15eca25afa00b44cbf11ce056450","unresolved":false,"context_lines":[{"line_number":32,"context_line":"                \"type\": \"array\","},{"line_number":33,"context_line":"                \"items\": {\"type\": \"string\"}"},{"line_number":34,"context_line":"            }"},{"line_number":35,"context_line":"        }"},{"line_number":36,"context_line":"    }"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    def setup(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f621f24_ba9d8567","line":35,"updated":"2020-11-12 15:17:31.000000000","message":"This context is redundant if nothing is specified, so you need to add \"required\": [\"setup\", \"cleanup\"]","commit_id":"3452740f9eec6a28719f6b4b646cabc2f9cabf96"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"f911ed25b10b15eca25afa00b44cbf11ce056450","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    def setup(self):"},{"line_number":39,"context_line":"        cmds \u003d self.config.get(\"setup\")"},{"line_number":40,"context_line":"        Commander.run_cmds(cmds)"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    def cleanup(self):"},{"line_number":43,"context_line":"        cmds \u003d self.config.get(\"cleanup\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f621f24_5a7b9126","line":40,"updated":"2020-11-12 15:17:31.000000000","message":"it would be nice to transmit task related info as env variables while executing the command.\n\nRALLY_ENV_UUID\nRALLY_TASK_UUID\nRALLY_TASK_OWNER_UUID\nRALLY_EXECUTION_STEP \u003d context.setup / context.cleanup or something like that","commit_id":"3452740f9eec6a28719f6b4b646cabc2f9cabf96"}],"rally/plugins/task/scenarios/script/script.py":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"f911ed25b10b15eca25afa00b44cbf11ce056450","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"        \"\"\""},{"line_number":40,"context_line":"        # time \u003d self.context[\"iteration\"]"},{"line_number":41,"context_line":"        LOG.info(\"Benchmark by tool: \" + tool_name)"},{"line_number":42,"context_line":"        cmds_run_tool \u003d commands[\"run\"]"},{"line_number":43,"context_line":"        cmds_result_to_chart_data \u003d commands[\"result2chart\"]"},{"line_number":44,"context_line":"        self.run_tool(cmds_run_tool, params)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f621f24_5aa0b190","line":41,"updated":"2020-11-12 15:17:31.000000000","message":"This is redundant. You can use \u0027description\u0027 field while running workload. \u0027description\u0027 field is also will be included in html report. \n\nSee https://github.com/openstack/rally/blob/3.2.0/rally-jobs/self-rally.yaml#L11 for example","commit_id":"3452740f9eec6a28719f6b4b646cabc2f9cabf96"},{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"f911ed25b10b15eca25afa00b44cbf11ce056450","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        # time \u003d self.context[\"iteration\"]"},{"line_number":41,"context_line":"        LOG.info(\"Benchmark by tool: \" + tool_name)"},{"line_number":42,"context_line":"        cmds_run_tool \u003d commands[\"run\"]"},{"line_number":43,"context_line":"        cmds_result_to_chart_data \u003d commands[\"result2chart\"]"},{"line_number":44,"context_line":"        self.run_tool(cmds_run_tool, params)"},{"line_number":45,"context_line":"        self.collect_result(cmds_result_to_chart_data)"},{"line_number":46,"context_line":"        charts_data \u003d self.parse_json_data(charts_data_file)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f621f24_da9a0112","line":43,"updated":"2020-11-12 15:17:31.000000000","message":"It sounds like a good idea, but the validation of input arg (which is missing now) is too complicated.\n\nImo, it is better to leave this to command itself and document the case, i.e:\n\n  commands\u003d[\n    \"RESULT1\u003d$(command1 --foo --bar)\",\n    \"RESULT2\u003d$(command2 --foo --bar)\",\n    \"RESULT3\u003d$(command3 --foo --bar)\",\n    \"RESULT4\u003d$(command4 --foo --bar)\",\n    \"RESULT5\u003d$(command5 --foo --bar)\",\n    # this is the final script that uses all above env\n    # variables and transforms into rally output\n    \"final_command\"\n  ]","commit_id":"3452740f9eec6a28719f6b4b646cabc2f9cabf96"}],"rally/plugins/task/utils.py":[{"author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"change_message_id":"f911ed25b10b15eca25afa00b44cbf11ce056450","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        else:"},{"line_number":36,"context_line":"            command \u003d cmd.split(\" \")"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"        text \u003d subprocess.check_output(command)"},{"line_number":39,"context_line":"        if is_stdout:"},{"line_number":40,"context_line":"            print(\"Response: \" + str(text))"},{"line_number":41,"context_line":"        return str(text)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f621f24_5aaf1129","line":38,"updated":"2020-11-12 15:17:31.000000000","message":"see https://github.com/openstack/rally/blob/master/rally/verification/utils.py#L27 it also covers printing stdout on demand","commit_id":"3452740f9eec6a28719f6b4b646cabc2f9cabf96"}]}