)]}'
{"id":"openstack%2Frally~761045","triplet_id":"openstack%2Frally~master~Id114dc5d17608cf9461ee63234e7ff5b175dbe9c","project":"openstack/rally","branch":"master","topic":"bp/benchmark_by_scripts","hashtags":[],"change_id":"Id114dc5d17608cf9461ee63234e7ff5b175dbe9c","subject":"Support benchmark by script","status":"NEW","created":"2020-11-03 03:55:06.000000000","updated":"2020-11-13 11:44:15.000000000","submit_type":"MERGE_IF_NECESSARY","mergeable":true,"submittable":false,"total_comment_count":6,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"c1c5c81743d4e395301f1a42758a0a4b5d7565c6","_number":761045,"virtual_id_number":761045,"owner":{"_account_id":28910,"name":"DatLQ","email":"datlq3@viettel.com.vn","username":"datlq"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},{"tag":"autogenerated:zuul:check","value":1,"date":"2020-11-03 04:26:52.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"date":"2020-11-13 02:48:05.000000000","_account_id":28910,"name":"DatLQ","email":"datlq3@viettel.com.vn","username":"datlq"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"all":[{"value":-1,"date":"2020-11-12 15:17:31.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":28910,"name":"DatLQ","email":"datlq3@viettel.com.vn","username":"datlq"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":28910,"name":"DatLQ","email":"datlq3@viettel.com.vn","username":"datlq"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":28910,"name":"DatLQ","email":"datlq3@viettel.com.vn","username":"datlq"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-11-03 04:26:52.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2020-11-12 15:17:31.000000000","updated_by":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"reviewer":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"state":"REVIEWER"}],"messages":[{"id":"a78435e75ebfd66c3974dedc42a3cdb6ebb5bcfc","author":{"_account_id":28910,"name":"DatLQ","email":"datlq3@viettel.com.vn","username":"datlq"},"date":"2020-11-03 03:55:06.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"e8205113c93d2c1f45d052122ecd288536f626ad","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-11-03 04:08:45.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/d2426dbf328d412683bf9d17fb356a0d : SUCCESS in 5m 12s\n- rally-tox-cover https://zuul.opendev.org/t/openstack/build/28598078515a44d5bc2ff2d6cc6d840f : SUCCESS in 7m 35s\n- rally-tox-docs https://zuul.opendev.org/t/openstack/build/8a0b967db77340a389a37d0618010290 : SUCCESS in 4m 27s\n- rally-tox-pep8 https://zuul.opendev.org/t/openstack/build/44db128d6f874f2187ced1c2911557d9 : SUCCESS in 4m 05s\n- rally-tox-py36 https://zuul.opendev.org/t/openstack/build/4dc835d4229b4096970c334b4eb37e00 : SUCCESS in 3m 54s\n- rally-tox-py37 https://zuul.opendev.org/t/openstack/build/f24b550518e445c183aeaa160c0daec1 : SUCCESS in 5m 20s\n- rally-tox-py38 https://zuul.opendev.org/t/openstack/build/97432b028eb5409fa1a93b4abcd28579 : SUCCESS in 5m 33s\n- rally-tox-samples https://zuul.opendev.org/t/openstack/build/51a2521f5ce2482c8303bf3f296c068e : SUCCESS in 6m 01s\n- rally-tox-functional https://zuul.opendev.org/t/openstack/build/d8676af97a8a4971bdaed8dbb3310645 : SUCCESS in 7m 56s\n- rally-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/2296adf75ddb4137a81a38e8d71f3a7d : SUCCESS in 8m 31s\n- rally-tox-self https://zuul.opendev.org/t/openstack/build/149382e904744cd38ea3ef11070fe731 : SUCCESS in 7m 47s\n- rally-install-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/17af27e52bb24205ab200376af5f2d7b : SUCCESS in 6m 58s\n- rally-install-ubuntu-focal https://zuul.opendev.org/t/openstack/build/8147d20516e546c0b013a0fc098a9c8d : SUCCESS in 6m 39s\n- rally-install-centos-7 https://zuul.opendev.org/t/openstack/build/03f5d50deb164f318db81e4a5ceb920c : SUCCESS in 6m 56s\n- rally-install-centos-8 https://zuul.opendev.org/t/openstack/build/fd4283050ccc4dabaf3886d9b001dc11 : SUCCESS in 7m 45s\n- rally-docker-build https://zuul.opendev.org/t/openstack/build/814acc70a1ee452ba73eadc7f0a4ed58 : SUCCESS in 9m 02s","accounts_in_message":[],"_revision_number":1},{"id":"bf2c3b1223d1d3a97e7d86a99e8bee9c11db28b9","author":{"_account_id":28910,"name":"DatLQ","email":"datlq3@viettel.com.vn","username":"datlq"},"date":"2020-11-03 04:10:11.000000000","message":"Uploaded patch set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"d864f95a88a7ce170626884b775a14648dd3bf98","author":{"_account_id":28910,"name":"DatLQ","email":"datlq3@viettel.com.vn","username":"datlq"},"date":"2020-11-03 04:19:58.000000000","message":"Patch Set 2:\n\n@Andrey Kurilin, I think Rally should support run script/command line for using third-party benchmark tools. Output of tools/scripts is generated to html.","accounts_in_message":[],"_revision_number":2},{"id":"a91dbeee4cfa0d6ac300783e6b54205fe6982383","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-11-03 04:26:52.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/f6f33f4991ba41ababf555ac93ff6929 : SUCCESS in 5m 31s\n- rally-tox-cover https://zuul.opendev.org/t/openstack/build/b878063c164b478ba9ffdef2d0035e43 : SUCCESS in 4m 41s\n- rally-tox-docs https://zuul.opendev.org/t/openstack/build/93f8eebb12ea422597bb86920379f316 : SUCCESS in 4m 22s\n- rally-tox-pep8 https://zuul.opendev.org/t/openstack/build/99d5f7fafa0e4a54aafd16ec7f3773dc : SUCCESS in 3m 47s\n- rally-tox-py36 https://zuul.opendev.org/t/openstack/build/633fcc54b3644d5486e08900ead774ea : SUCCESS in 3m 57s\n- rally-tox-py37 https://zuul.opendev.org/t/openstack/build/9153a451514341b39e4b799c9a2e7580 : SUCCESS in 4m 03s\n- rally-tox-py38 https://zuul.opendev.org/t/openstack/build/2323937496fe476eb0343ac87a7e896d : SUCCESS in 4m 48s\n- rally-tox-samples https://zuul.opendev.org/t/openstack/build/c326f27b0bf04582aed2048e28deb4e6 : SUCCESS in 4m 34s\n- rally-tox-functional https://zuul.opendev.org/t/openstack/build/4bf6204f48c044a4bad446bac0506c73 : SUCCESS in 5m 59s\n- rally-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/615f271a46504e47be2c4a1efd440c6b : SUCCESS in 6m 31s\n- rally-tox-self https://zuul.opendev.org/t/openstack/build/71b056746948466199bf80b5a7d57acb : SUCCESS in 8m 18s\n- rally-install-ubuntu-bionic https://zuul.opendev.org/t/openstack/build/0e9e0580c8ea4d0c9857cc979eeb3bbc : SUCCESS in 6m 36s\n- rally-install-ubuntu-focal https://zuul.opendev.org/t/openstack/build/6c491a834dc14b88a0bf5fea469087d7 : SUCCESS in 7m 27s\n- rally-install-centos-7 https://zuul.opendev.org/t/openstack/build/f5ebabab7591447ba9e9ae4136c881c8 : SUCCESS in 6m 24s\n- rally-install-centos-8 https://zuul.opendev.org/t/openstack/build/7c9b39eb8b0748438778d0a53656bdb6 : SUCCESS in 6m 34s\n- rally-docker-build https://zuul.opendev.org/t/openstack/build/d4048e68168541b18e02c6be73cc89b3 : SUCCESS in 9m 02s","accounts_in_message":[],"_revision_number":2},{"id":"98ce2ac28ff51e01f64dd78a54179eef7d8b2a25","author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"date":"2020-11-09 12:54:16.000000000","message":"Patch Set 2:\n\nSorry for the delay. Will try to review your change soon.\n\nThe idea itself looks good to me","accounts_in_message":[],"_revision_number":2},{"id":"225b1f5f62f103dbc43fd056c858dbc44b0c7cc5","author":{"_account_id":28910,"name":"DatLQ","email":"datlq3@viettel.com.vn","username":"datlq"},"date":"2020-11-12 01:50:01.000000000","message":"Patch Set 2:\n\n\u003e Sorry for the delay. Will try to review your change soon.\n \u003e \n \u003e The idea itself looks good to me\n\nThanks. Hope you review soon.","accounts_in_message":[],"_revision_number":2},{"id":"f911ed25b10b15eca25afa00b44cbf11ce056450","author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"date":"2020-11-12 15:17:31.000000000","message":"Patch Set 2: Code-Review-1\n\n(6 comments)\n\nRally plugins for OpenStack platform include 2 interesting plugins:\n\n- Scenario VMTasks.boot_runcommand_delete@openstack - https://github.com/openstack/rally-openstack/blob/2.1.0/rally_openstack/task/scenarios/vm/vmtasks.py#L140\n- Context image_command_customizer@openstack - https://github.com/openstack/rally-openstack/blob/2.1.0/rally_openstack/task/contexts/vm/image_command_customizer.py#L27\n\nBoth of these plugins are designed to execute scripts on the remote host (via ssh). What I like in that plugins is the way of customization for execution.\n\nRelatively to your changes, instead of specifying a list of commands to execute, it would be nice to support the following format:\n\n interpreter - str / defaults to \u0027/bin/bash\u0027\n script_file - str\n script_inline - a list of strings or a string\n command_args - a list of scrings\n env - a dict of env variables\n\n\nIt would be nice to extend tox-self job to run new plugins. see https://github.com/openstack/rally/blob/3.2.0/rally-jobs/self-rally.yaml","accounts_in_message":[],"_revision_number":2},{"id":"a8babf51f8c02155625d092cfe75339f0d60881b","author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"date":"2020-11-12 15:27:43.000000000","message":"Patch Set 2:\n\nAlso, https://github.com/openstack/rally-openstack/blob/2.1.0/rally_openstack/task/scenarios/vm/utils.py#L106-L136 this can be helpful as an example of processing input args.\n\nAs for validation the input argument for the scenario, it would be nice to write custom validator like https://github.com/openstack/rally-openstack/blob/2.1.0/rally_openstack/task/scenarios/vm/vmtasks.py#L45","accounts_in_message":[],"_revision_number":2},{"id":"dd5e1aa96b3717de0ae11a71dbba76e94d1c4ec4","author":{"_account_id":28910,"name":"DatLQ","email":"datlq3@viettel.com.vn","username":"datlq"},"date":"2020-11-13 02:48:05.000000000","message":"Patch Set 2:\n\n1. Why isn\u0027t context with command and scenario with command proposed to rally for other plugins using ? I used to contribute this changes to rally-openstack project but you asked me to move to rally project (https://review.opendev.org/#/c/601491/)\n2. Scenario VMTasks.boot_runcommand_delete@openstack (https://github.com/openstack/rally-openstack/blob/2.1.0/rally_openstack/task/scenarios/vm/vmtasks.py#L140) only run command on server and after that, delete server. If want to run command on a  server many times in one context, seem have not any scenario support it.","accounts_in_message":[],"_revision_number":2},{"id":"9531aac8679804c5bf9e23dc2e95a4c39468237e","author":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"},"date":"2020-11-13 11:44:15.000000000","message":"Patch Set 2:\n\nYes, your plugins are platform independent (as I said in https://review.opendev.org/#/c/601491/ change). I referred plugins from rally-openstack repo just to show a good example of input arguments it would be nice to use in your plugins.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"3452740f9eec6a28719f6b4b646cabc2f9cabf96","revisions":{"434b06d77aa0b89bc38717acfabb83a954d81dbb":{"kind":"REWORK","_number":1,"created":"2020-11-03 03:55:06.000000000","uploader":{"_account_id":28910,"name":"DatLQ","email":"datlq3@viettel.com.vn","username":"datlq"},"ref":"refs/changes/45/761045/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/rally","ref":"refs/changes/45/761045/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/rally refs/changes/45/761045/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/rally refs/changes/45/761045/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/rally refs/changes/45/761045/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/rally refs/changes/45/761045/1"}}},"commit":{"parents":[{"commit":"11cf577f14e69c235eeb175f0dc4c83185728965","subject":"Propose 3.2.0 release","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/rally/commit/11cf577f14e69c235eeb175f0dc4c83185728965"}]}],"author":{"name":"Dat Le","email":"datlq3@viettel.com.vn","date":"2020-11-03 03:49:29.000000000","tz":420},"committer":{"name":"Dat Le","email":"datlq3@viettel.com.vn","date":"2020-11-03 03:49:29.000000000","tz":420},"subject":"Support benchmark openstack by scripts include: - script context: script setup environment before run benchmark and     cleanup environment after that - script scenario: run benchmark tools and run script to collect results","message":"Support benchmark openstack by scripts include:\n- script context: script setup environment before run benchmark and\n    cleanup environment after that\n- script scenario: run benchmark tools and run script to collect results\n\nChange-Id: Id114dc5d17608cf9461ee63234e7ff5b175dbe9c\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/rally/commit/434b06d77aa0b89bc38717acfabb83a954d81dbb"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/rally/commit/434b06d77aa0b89bc38717acfabb83a954d81dbb"}]},"branch":"refs/heads/master"},"3452740f9eec6a28719f6b4b646cabc2f9cabf96":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2020-11-03 04:10:11.000000000","uploader":{"_account_id":28910,"name":"DatLQ","email":"datlq3@viettel.com.vn","username":"datlq"},"ref":"refs/changes/45/761045/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/rally","ref":"refs/changes/45/761045/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/rally refs/changes/45/761045/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/rally refs/changes/45/761045/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/rally refs/changes/45/761045/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/rally refs/changes/45/761045/2"}}},"commit":{"parents":[{"commit":"11cf577f14e69c235eeb175f0dc4c83185728965","subject":"Propose 3.2.0 release","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/rally/commit/11cf577f14e69c235eeb175f0dc4c83185728965"}]}],"author":{"name":"Dat Le","email":"datlq3@viettel.com.vn","date":"2020-11-03 03:49:29.000000000","tz":420},"committer":{"name":"Dat Le","email":"datlq3@viettel.com.vn","date":"2020-11-03 04:05:06.000000000","tz":420},"subject":"Support benchmark by script","message":"Support benchmark by script\n\nScript context: script setup environment before running benchmark\nand cleanup environment after that\n\nScript scenario: run tools by command line or run script for\nbenchmark and collect results\n\nChange-Id: Id114dc5d17608cf9461ee63234e7ff5b175dbe9c\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/rally/commit/3452740f9eec6a28719f6b4b646cabc2f9cabf96"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/rally/commit/3452740f9eec6a28719f6b4b646cabc2f9cabf96"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"OK","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":9545,"name":"Andriy Kurilin","email":"andr.kurilin@gmail.com","username":"akurilin"}},{"label":"Workflow","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{"label:Verified\u003dMAX":"","label:Verified\u003dMIN":""}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","label:Code-Review\u003dMIN"],"atom_explanations":{"label:Code-Review\u003dMAX":"","label:Code-Review\u003dMIN":""}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{"label:Workflow\u003dMAX":"","label:Workflow\u003dMIN":""}}}]}