)]}'
{".zuul.yaml":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"7115c2fc9d4893a11de8bd8f5323fa635cb98ae3","unresolved":true,"context_lines":[{"line_number":15,"context_line":"            voting: false"},{"line_number":16,"context_line":"        - rbd-iscsi-client-py36"},{"line_number":17,"context_line":"        - openstack-tox-py38"},{"line_number":18,"context_line":"        - openstack-tox-py39"},{"line_number":19,"context_line":"        - rbd-iscsi-client-code-coverage:"},{"line_number":20,"context_line":"            voting: false"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"4253dbd9_78cc1a01","line":18,"updated":"2022-08-17 08:10:15.000000000","message":"-1: Project doesn\u0027t support 3.9. If it does, then it needs to update its setup.cfg : https://github.com/openstack/rbd-iscsi-client/blob/f0227095b9b5cebd60840548bc0de3e81942c02c/setup.cfg#L22-L24","commit_id":"9d894b2263ab9de91b240330c7f2683a225a0cd8"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"b43621ef43f5c02333c4b940bdf0d71784010818","unresolved":false,"context_lines":[{"line_number":15,"context_line":"            voting: false"},{"line_number":16,"context_line":"        - rbd-iscsi-client-py36"},{"line_number":17,"context_line":"        - openstack-tox-py38"},{"line_number":18,"context_line":"        - openstack-tox-py39"},{"line_number":19,"context_line":"        - rbd-iscsi-client-code-coverage:"},{"line_number":20,"context_line":"            voting: false"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"f2842857_14d6c33b","line":18,"in_reply_to":"4253dbd9_78cc1a01","updated":"2022-08-17 14:40:20.000000000","message":"Done","commit_id":"9d894b2263ab9de91b240330c7f2683a225a0cd8"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"7115c2fc9d4893a11de8bd8f5323fa635cb98ae3","unresolved":true,"context_lines":[{"line_number":26,"context_line":"            voting: false"},{"line_number":27,"context_line":"        - rbd-iscsi-client-py36"},{"line_number":28,"context_line":"        - openstack-tox-py38"},{"line_number":29,"context_line":"        - openstack-tox-py39"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"- job:"},{"line_number":32,"context_line":"    name: rbd-iscsi-client-code-coverage"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"4bfa3dea_a4f2137d","line":29,"updated":"2022-08-17 08:10:15.000000000","message":"-1: ditto","commit_id":"9d894b2263ab9de91b240330c7f2683a225a0cd8"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"b43621ef43f5c02333c4b940bdf0d71784010818","unresolved":false,"context_lines":[{"line_number":26,"context_line":"            voting: false"},{"line_number":27,"context_line":"        - rbd-iscsi-client-py36"},{"line_number":28,"context_line":"        - openstack-tox-py38"},{"line_number":29,"context_line":"        - openstack-tox-py39"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"- job:"},{"line_number":32,"context_line":"    name: rbd-iscsi-client-code-coverage"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"594ea7b2_08808fa8","line":29,"in_reply_to":"4bfa3dea_a4f2137d","updated":"2022-08-17 14:40:20.000000000","message":"Done","commit_id":"9d894b2263ab9de91b240330c7f2683a225a0cd8"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"83a5a3a731b8700d63c9d82cdea64bedc343fa65","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"bfc9fda2_d2f93701","updated":"2022-08-17 07:38:52.000000000","message":"LGTM, non voting nature of pep8 is fixed in the followup patch.","commit_id":"9d894b2263ab9de91b240330c7f2683a225a0cd8"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"bb1c0a9157dcee61dd0f12078df26d0a13d612ab","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"9224d6b0_06bdab26","updated":"2022-09-09 14:25:14.000000000","message":"I think this looks good.  Thanks Brian!","commit_id":"fe63f0cc892a1598654ec09f086512915d1d154e"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"051dbd43fcfa9f3ec3d2ab1e3fdcbded9407b9b0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"8bd84011_9b4623b7","updated":"2022-08-17 18:53:25.000000000","message":"comments have been addressed. still LGTM.","commit_id":"fe63f0cc892a1598654ec09f086512915d1d154e"}],"setup.cfg":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"051dbd43fcfa9f3ec3d2ab1e3fdcbded9407b9b0","unresolved":true,"context_lines":[{"line_number":20,"context_line":"    Programming Language :: Python :: 3 :: Only"},{"line_number":21,"context_line":"    Programming Language :: Python :: 3"},{"line_number":22,"context_line":"    Programming Language :: Python :: 3.6"},{"line_number":23,"context_line":"    Programming Language :: Python :: 3.7"},{"line_number":24,"context_line":"    Programming Language :: Python :: 3.8"},{"line_number":25,"context_line":"    Programming Language :: Python :: 3.9"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-ttcn-cfg","patch_set":3,"id":"e3d5e89d_13bed7c6","line":23,"range":{"start_line":23,"start_character":0,"end_line":23,"end_character":41},"updated":"2022-08-17 18:53:25.000000000","message":"should we remove this as well?","commit_id":"fe63f0cc892a1598654ec09f086512915d1d154e"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"6419f55af7d1eb56bbb448490b8e0f2fb2792570","unresolved":true,"context_lines":[{"line_number":20,"context_line":"    Programming Language :: Python :: 3 :: Only"},{"line_number":21,"context_line":"    Programming Language :: Python :: 3"},{"line_number":22,"context_line":"    Programming Language :: Python :: 3.6"},{"line_number":23,"context_line":"    Programming Language :: Python :: 3.7"},{"line_number":24,"context_line":"    Programming Language :: Python :: 3.8"},{"line_number":25,"context_line":"    Programming Language :: Python :: 3.9"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-ttcn-cfg","patch_set":3,"id":"3136861d_04663e40","line":23,"range":{"start_line":23,"start_character":0,"end_line":23,"end_character":41},"in_reply_to":"e3d5e89d_13bed7c6","updated":"2022-08-18 11:55:09.000000000","message":"This is like what we have for cinder stable/yoga: https://opendev.org/openstack/cinder/src/branch/stable/yoga/setup.cfg\n\nThe requirement to run unit tests in py 3.7 ended in Victoria:\nhttps://governance.openstack.org/tc/reference/runtimes/victoria.html\n\n... but we can claim by inference that if the code works in py36 and py38, it must also work in py37.\n\nWe could run py37 tests in the gate (probably using the yoga upper-constraints?), but if we decide to, let\u0027s make it a separate patch.","commit_id":"fe63f0cc892a1598654ec09f086512915d1d154e"}]}
