)]}'
{"oslo_release.sh":[{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"5999ca44b0d888f2c87321a496c31948acb486d2","unresolved":false,"context_lines":[{"line_number":81,"context_line":"    fi"},{"line_number":82,"context_line":"    echo \"Tag message is \u0027$TAGMSG\u0027\""},{"line_number":83,"context_line":"    git tag -m \"$TAGMSG\" -s \"$VERSION\" $TARGETSHA"},{"line_number":84,"context_line":"    #    git push gerrit $VERSION"},{"line_number":85,"context_line":"fi"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"exit 1"}],"source_content_type":"text/x-sh","patch_set":3,"id":"3a961159_c8f44557","line":84,"updated":"2015-01-15 00:07:48.000000000","message":"Was this supposed to go away? Seems like an important step ;)","commit_id":"bc8b29b64dd4fc1025bf3fccfe15544e18e69bb4"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"42aa67118ddf2d65e70df0a0f5d6091dc524f549","unresolved":false,"context_lines":[{"line_number":81,"context_line":"    fi"},{"line_number":82,"context_line":"    echo \"Tag message is \u0027$TAGMSG\u0027\""},{"line_number":83,"context_line":"    git tag -m \"$TAGMSG\" -s \"$VERSION\" $TARGETSHA"},{"line_number":84,"context_line":"    #    git push gerrit $VERSION"},{"line_number":85,"context_line":"fi"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"exit 1"}],"source_content_type":"text/x-sh","patch_set":3,"id":"3a961159_0dd9d882","line":84,"in_reply_to":"3a961159_c8f44557","updated":"2015-01-15 19:22:33.000000000","message":"D\u0027oh! Fixed.","commit_id":"bc8b29b64dd4fc1025bf3fccfe15544e18e69bb4"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"3993c5fa87bddb23922a7f7e2ae89fbbcf712674","unresolved":false,"context_lines":[{"line_number":84,"context_line":"    git push gerrit $VERSION"},{"line_number":85,"context_line":"fi"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"exit 1"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"if [[ \"$ALPHA_RELEASE\" !\u003d \"1\" ]]; then"},{"line_number":90,"context_line":"  title \"Renaming next-$SERIES to $VERSION\""}],"source_content_type":"text/x-sh","patch_set":4,"id":"3a961159_204e8796","line":87,"updated":"2015-01-16 09:23:54.000000000","message":"?","commit_id":"8f02b52975b6389948bc5d261835d05eaaf3c955"},{"author":{"_account_id":308,"name":"Thierry Carrez","email":"thierry@openstack.org","username":"ttx"},"change_message_id":"495fa442b7663328f6027f7e4a1dc5077fc7bacd","unresolved":false,"context_lines":[{"line_number":84,"context_line":"    git push gerrit $VERSION"},{"line_number":85,"context_line":"fi"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"exit 1"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"if [[ \"$ALPHA_RELEASE\" !\u003d \"1\" ]]; then"},{"line_number":90,"context_line":"  title \"Renaming next-$SERIES to $VERSION\""}],"source_content_type":"text/x-sh","patch_set":4,"id":"3a961159_c9bdefd8","line":87,"in_reply_to":"3a961159_204e8796","updated":"2015-01-16 10:15:39.000000000","message":"Looks like another leftover from testing indeed","commit_id":"8f02b52975b6389948bc5d261835d05eaaf3c955"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"05ba42b2b26966516888edff1ad542e488fb1382","unresolved":false,"context_lines":[{"line_number":84,"context_line":"    git push gerrit $VERSION"},{"line_number":85,"context_line":"fi"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"exit 1"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"if [[ \"$ALPHA_RELEASE\" !\u003d \"1\" ]]; then"},{"line_number":90,"context_line":"  title \"Renaming next-$SERIES to $VERSION\""}],"source_content_type":"text/x-sh","patch_set":4,"id":"3a961159_12354f44","line":87,"in_reply_to":"3a961159_c9bdefd8","updated":"2015-01-16 17:17:19.000000000","message":"Done","commit_id":"8f02b52975b6389948bc5d261835d05eaaf3c955"}],"sanity_check_version.py":[{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"3993c5fa87bddb23922a7f7e2ae89fbbcf712674","unresolved":false,"context_lines":[{"line_number":91,"context_line":"        actual \u003d same_minor[2] + 1"},{"line_number":92,"context_line":"        expected \u003d new_version[2]"},{"line_number":93,"context_line":"        if expected !\u003d actual:"},{"line_number":94,"context_line":"            return [\u0027new version %r increments patch version more than one over %r\u0027 % "},{"line_number":95,"context_line":"                    (format_version(new_version), format_version(same_minor))]"},{"line_number":96,"context_line":"    if same_major is not None and same_major !\u003d same_minor:"},{"line_number":97,"context_line":"        print(\u0027last version in major series %r\u0027 %"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a961159_60440f73","line":94,"updated":"2015-01-16 09:23:54.000000000","message":"Trailing whitespace","commit_id":"8f02b52975b6389948bc5d261835d05eaaf3c955"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"05ba42b2b26966516888edff1ad542e488fb1382","unresolved":false,"context_lines":[{"line_number":91,"context_line":"        actual \u003d same_minor[2] + 1"},{"line_number":92,"context_line":"        expected \u003d new_version[2]"},{"line_number":93,"context_line":"        if expected !\u003d actual:"},{"line_number":94,"context_line":"            return [\u0027new version %r increments patch version more than one over %r\u0027 % "},{"line_number":95,"context_line":"                    (format_version(new_version), format_version(same_minor))]"},{"line_number":96,"context_line":"    if same_major is not None and same_major !\u003d same_minor:"},{"line_number":97,"context_line":"        print(\u0027last version in major series %r\u0027 %"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a961159_7245b3b2","line":94,"in_reply_to":"3a961159_60440f73","updated":"2015-01-16 17:17:19.000000000","message":"The pep8 issues are fixed in the next patch where that testing is enabled.","commit_id":"8f02b52975b6389948bc5d261835d05eaaf3c955"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"3993c5fa87bddb23922a7f7e2ae89fbbcf712674","unresolved":false,"context_lines":[{"line_number":100,"context_line":"            actual \u003d same_major[1] + 1"},{"line_number":101,"context_line":"            expected \u003d new_version[1]"},{"line_number":102,"context_line":"            if actual \u003e expected:"},{"line_number":103,"context_line":"                return [\u0027new version %r increments minor version more than one over %r\u0027 % "},{"line_number":104,"context_line":"                        (format_version(new_version), format_version(same_major))]"},{"line_number":105,"context_line":"            if new_version[2] !\u003d 0:"},{"line_number":106,"context_line":"                return [\u0027new version %r increments minor version and patch version\u0027 %"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a961159_00326b0f","line":103,"updated":"2015-01-16 09:23:54.000000000","message":"here too :)","commit_id":"8f02b52975b6389948bc5d261835d05eaaf3c955"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"2a4d6f15bfc9d290ff096db3178f1e21f154d68e","unresolved":false,"context_lines":[{"line_number":67,"context_line":"def apply_rules(new_version, existing_versions):"},{"line_number":68,"context_line":"    if not existing_versions:"},{"line_number":69,"context_line":"        if new_version[0] !\u003d 0:"},{"line_number":70,"context_line":"            return [\u0027first version in repository does not start with 0\u0027]"},{"line_number":71,"context_line":"        return []"},{"line_number":72,"context_line":"    if new_version in existing_versions:"},{"line_number":73,"context_line":"        return [\u0027version %r already exists in repository\u0027 %"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_db0e83e3","line":70,"updated":"2015-01-16 18:09:07.000000000","message":"Do we necessarily want to enforce this?  I don\u0027t know if we have any projects where it isn\u0027t true, but it seems like it would be difficult to fix if we do.","commit_id":"c3ea9bb9f29584141612cf6f03aa7c88dfc3e970"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"048249aea9b21c9a94e37018c425d38abbe99231","unresolved":false,"context_lines":[{"line_number":67,"context_line":"def apply_rules(new_version, existing_versions):"},{"line_number":68,"context_line":"    if not existing_versions:"},{"line_number":69,"context_line":"        if new_version[0] !\u003d 0:"},{"line_number":70,"context_line":"            return [\u0027first version in repository does not start with 0\u0027]"},{"line_number":71,"context_line":"        return []"},{"line_number":72,"context_line":"    if new_version in existing_versions:"},{"line_number":73,"context_line":"        return [\u0027version %r already exists in repository\u0027 %"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a930d6b_a650bc32","line":70,"in_reply_to":"1a930d6b_9decf4bc","updated":"2015-01-27 16:22:16.000000000","message":"Ah, didn\u0027t realize that.\n\nIn that case, we probably don\u0027t want the early returns in this function.  The messages should be appended to a list that then gets returned after all of the checks.  As it is right now I think you could only ever get one warning back from this, so this check might hide a more concerning problem that would be found in the later checks.","commit_id":"c3ea9bb9f29584141612cf6f03aa7c88dfc3e970"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"5a44dab0b37049b41f59617905bb4380c207c3a1","unresolved":false,"context_lines":[{"line_number":67,"context_line":"def apply_rules(new_version, existing_versions):"},{"line_number":68,"context_line":"    if not existing_versions:"},{"line_number":69,"context_line":"        if new_version[0] !\u003d 0:"},{"line_number":70,"context_line":"            return [\u0027first version in repository does not start with 0\u0027]"},{"line_number":71,"context_line":"        return []"},{"line_number":72,"context_line":"    if new_version in existing_versions:"},{"line_number":73,"context_line":"        return [\u0027version %r already exists in repository\u0027 %"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a930d6b_9decf4bc","line":70,"in_reply_to":"3a961159_db0e83e3","updated":"2015-01-27 13:38:40.000000000","message":"The rules are presented to the user with an option to continue, so all you have to do is press \u003creturn\u003e.","commit_id":"c3ea9bb9f29584141612cf6f03aa7c88dfc3e970"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"2a4d6f15bfc9d290ff096db3178f1e21f154d68e","unresolved":false,"context_lines":[{"line_number":88,"context_line":"    if same_minor is not None:"},{"line_number":89,"context_line":"        print(\u0027last version in minor series %r\u0027 %"},{"line_number":90,"context_line":"              format_version(same_minor))"},{"line_number":91,"context_line":"        actual \u003d same_minor[2] + 1"},{"line_number":92,"context_line":"        expected \u003d new_version[2]"},{"line_number":93,"context_line":"        if expected !\u003d actual:"},{"line_number":94,"context_line":"            return [\u0027new version %r increments patch version more than one over %r\u0027 % "}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_1b3acb33","line":91,"updated":"2015-01-16 18:09:07.000000000","message":"Nit: I would probably swap the actual and expected names here.  It seems backwards to me this way.","commit_id":"c3ea9bb9f29584141612cf6f03aa7c88dfc3e970"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"5a44dab0b37049b41f59617905bb4380c207c3a1","unresolved":false,"context_lines":[{"line_number":88,"context_line":"    if same_minor is not None:"},{"line_number":89,"context_line":"        print(\u0027last version in minor series %r\u0027 %"},{"line_number":90,"context_line":"              format_version(same_minor))"},{"line_number":91,"context_line":"        actual \u003d same_minor[2] + 1"},{"line_number":92,"context_line":"        expected \u003d new_version[2]"},{"line_number":93,"context_line":"        if expected !\u003d actual:"},{"line_number":94,"context_line":"            return [\u0027new version %r increments patch version more than one over %r\u0027 % "}],"source_content_type":"text/x-python","patch_set":5,"id":"1a930d6b_1d38043c","line":91,"in_reply_to":"3a961159_1b3acb33","updated":"2015-01-27 13:38:40.000000000","message":"I\u0027ll look at this in a follow-up patch.","commit_id":"c3ea9bb9f29584141612cf6f03aa7c88dfc3e970"}],"tox.ini":[{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"3993c5fa87bddb23922a7f7e2ae89fbbcf712674","unresolved":false,"context_lines":[{"line_number":15,"context_line":"commands \u003d python setup.py testr --slowest --testr-args\u003d\u0027{posargs}\u0027"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"[testenv:pep8]"},{"line_number":18,"context_line":"#deps \u003d flake8"},{"line_number":19,"context_line":"#commands \u003d flake8"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"[testenv:venv]"}],"source_content_type":"text/x-properties","patch_set":4,"id":"3a961159_c02b0393","line":18,"updated":"2015-01-16 09:23:54.000000000","message":"?","commit_id":"8f02b52975b6389948bc5d261835d05eaaf3c955"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"05ba42b2b26966516888edff1ad542e488fb1382","unresolved":false,"context_lines":[{"line_number":15,"context_line":"commands \u003d python setup.py testr --slowest --testr-args\u003d\u0027{posargs}\u0027"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"[testenv:pep8]"},{"line_number":18,"context_line":"#deps \u003d flake8"},{"line_number":19,"context_line":"#commands \u003d flake8"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"[testenv:venv]"}],"source_content_type":"text/x-properties","patch_set":4,"id":"3a961159_f27fe3dc","line":18,"in_reply_to":"3a961159_c02b0393","updated":"2015-01-16 17:17:19.000000000","message":"I started turning it on, then found I was going to have to make a bunch of changes in unrelated files, so left it for the next patch. It\u0027s a little messy to leave this here, but it\u0027s all fixed up in the next patch.","commit_id":"8f02b52975b6389948bc5d261835d05eaaf3c955"}]}
