)]}'
{"expire_old_bug_reports.py":[{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"3174c88642ab8e9afb07674ac0ddc73f761cfc24","unresolved":false,"context_lines":[{"line_number":90,"context_line":"        LOG.error(\"Can\u0027t proceed without Launchpad credential.\")"},{"line_number":91,"context_line":"        sys.exit()"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    # NOTE(markus_z): possibly you have to install \"keyrings.alt\":"},{"line_number":94,"context_line":"    # sudo pip install keyrings.alt"},{"line_number":95,"context_line":"    launchpad \u003d Launchpad.login_with(PROJECT_NAME + \u0027-bugs\u0027,"},{"line_number":96,"context_line":"                                     \u0027production\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_b03ba9ea","line":93,"updated":"2016-05-25 14:38:54.000000000","message":"Is this note saying that keyring is required? We deal with this in the other tools by specifying a credential file explicitly (see launchpad_add_comment.py for an example).\n\nThat may not be necessary for this tool, since it\u0027s not meant to run in the gate where there is no one around to type the keyring passphrase, but keyring often prompt for a passphrase repeatedly on a cloud server than on a local system with gnome or some other system-level integration.","commit_id":"01413b646d23d517dc747b195a1dc1a7d63c77e2"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"8de07db961a39ded83897693862f11ebda7609e3","unresolved":false,"context_lines":[{"line_number":90,"context_line":"        LOG.error(\"Can\u0027t proceed without Launchpad credential.\")"},{"line_number":91,"context_line":"        sys.exit()"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    # NOTE(markus_z): possibly you have to install \"keyrings.alt\":"},{"line_number":94,"context_line":"    # sudo pip install keyrings.alt"},{"line_number":95,"context_line":"    launchpad \u003d Launchpad.login_with(PROJECT_NAME + \u0027-bugs\u0027,"},{"line_number":96,"context_line":"                                     \u0027production\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_99b69188","line":93,"in_reply_to":"bab6814e_b03ba9ea","updated":"2016-05-25 14:55:22.000000000","message":"In the long run I\u0027d like to have this script automatically executed, so it makes absolutely sense to use the credentials file. I\u0027m going to look it up and use it in ps2.","commit_id":"01413b646d23d517dc747b195a1dc1a7d63c77e2"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"3174c88642ab8e9afb07674ac0ddc73f761cfc24","unresolved":false,"context_lines":[{"line_number":102,"context_line":""},{"line_number":103,"context_line":"def fill_supported_release_names():"},{"line_number":104,"context_line":"    LOG.info(\"filling supported release names...\")"},{"line_number":105,"context_line":"    lp_project \u003d get_project_client()"},{"line_number":106,"context_line":"    for s in lp_project.series:"},{"line_number":107,"context_line":"        if s.active:"},{"line_number":108,"context_line":"            # stable branch names"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_b691e29c","line":105,"updated":"2016-05-25 14:38:54.000000000","message":"There are 2 calls, creating 2 clients on lines 105 and 126. Why not create the client and pass it to these functions?","commit_id":"01413b646d23d517dc747b195a1dc1a7d63c77e2"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"8de07db961a39ded83897693862f11ebda7609e3","unresolved":false,"context_lines":[{"line_number":102,"context_line":""},{"line_number":103,"context_line":"def fill_supported_release_names():"},{"line_number":104,"context_line":"    LOG.info(\"filling supported release names...\")"},{"line_number":105,"context_line":"    lp_project \u003d get_project_client()"},{"line_number":106,"context_line":"    for s in lp_project.series:"},{"line_number":107,"context_line":"        if s.active:"},{"line_number":108,"context_line":"            # stable branch names"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_b990b54f","line":105,"in_reply_to":"bab6814e_b691e29c","updated":"2016-05-25 14:55:22.000000000","message":"yeah, makes sense, I\u0027ll do that in the next patch set.","commit_id":"01413b646d23d517dc747b195a1dc1a7d63c77e2"}]}