)]}'
{"aclmanager.py":[{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"bc799dc6e01fc8ff7507a9deef8b276610d4e103","unresolved":false,"context_lines":[{"line_number":33,"context_line":"              \u0027openstack/trove-image-builder\u0027]"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"def repositories_list():"},{"line_number":37,"context_line":"    \"\"\"Yields (team, repo) tuples for cycle-with-milestones deliverables\"\"\""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    r \u003d requests.get(\u0027http://git.openstack.org/cgit/openstack/governance/plain/reference/projects.yaml\u0027)  # noqa"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_f55c5bef","line":36,"updated":"2016-08-08 13:27:29.000000000","message":"This function reproduces logic found in releasetools.governance.get_repositories().","commit_id":"17e0b083a4eb4ac7b31311130156182adafdc202"},{"author":{"_account_id":308,"name":"Thierry Carrez","email":"thierry@openstack.org","username":"ttx"},"change_message_id":"6b0c48f4f247a00e4f171e215369b4eddf2ae1bc","unresolved":false,"context_lines":[{"line_number":33,"context_line":"              \u0027openstack/trove-image-builder\u0027]"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"def repositories_list():"},{"line_number":37,"context_line":"    \"\"\"Yields (team, repo) tuples for cycle-with-milestones deliverables\"\"\""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    r \u003d requests.get(\u0027http://git.openstack.org/cgit/openstack/governance/plain/reference/projects.yaml\u0027)  # noqa"}],"source_content_type":"text/x-python","patch_set":2,"id":"3ac371cc_0bfd853a","line":36,"in_reply_to":"9ad45d7e_f55c5bef","updated":"2016-08-15 13:31:03.000000000","message":"Fixed in subsequent patchset","commit_id":"17e0b083a4eb4ac7b31311130156182adafdc202"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"bc799dc6e01fc8ff7507a9deef8b276610d4e103","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    for project in config:"},{"line_number":70,"context_line":"        aclfilename \u003d project.get(\u0027acl-config\u0027)"},{"line_number":71,"context_line":"        if aclfilename:"},{"line_number":72,"context_line":"            acl[project[\u0027project\u0027]] \u003d aclfilename[19:]"},{"line_number":73,"context_line":"        else:"},{"line_number":74,"context_line":"            acl[project[\u0027project\u0027]] \u003d project[\u0027project\u0027] + \u0027.config\u0027"},{"line_number":75,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_b53023a0","line":72,"updated":"2016-08-08 13:27:29.000000000","message":"Is this slice of aclfilename doing the same thing as os.path.basename()?","commit_id":"17e0b083a4eb4ac7b31311130156182adafdc202"},{"author":{"_account_id":308,"name":"Thierry Carrez","email":"thierry@openstack.org","username":"ttx"},"change_message_id":"6b0c48f4f247a00e4f171e215369b4eddf2ae1bc","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    for project in config:"},{"line_number":70,"context_line":"        aclfilename \u003d project.get(\u0027acl-config\u0027)"},{"line_number":71,"context_line":"        if aclfilename:"},{"line_number":72,"context_line":"            acl[project[\u0027project\u0027]] \u003d aclfilename[19:]"},{"line_number":73,"context_line":"        else:"},{"line_number":74,"context_line":"            acl[project[\u0027project\u0027]] \u003d project[\u0027project\u0027] + \u0027.config\u0027"},{"line_number":75,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3ac371cc_4b95bde2","line":72,"in_reply_to":"9ad45d7e_b53023a0","updated":"2016-08-15 13:31:03.000000000","message":"In fact it returns the last two components of the path. I proposed a subsequent patch to do that using a combination of os.path functions.","commit_id":"17e0b083a4eb4ac7b31311130156182adafdc202"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"bc799dc6e01fc8ff7507a9deef8b276610d4e103","unresolved":false,"context_lines":[{"line_number":123,"context_line":"def modify_gerrit_groups(args):"},{"line_number":124,"context_line":"    \"\"\"Handles the \u0027groups\u0027 action\"\"\""},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    if args.stage \u003d\u003d \u0027pre_release\u0027:"},{"line_number":127,"context_line":"        actions \u003d [(\u0027DELETE\u0027, lambda x: \u0027%s-stable-maint\u0027 % x),"},{"line_number":128,"context_line":"                   (\u0027PUT\u0027, lambda x: \u0027%s-release\u0027 % x)]"},{"line_number":129,"context_line":"    elif args.stage \u003d\u003d \u0027post_release\u0027:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_353c332f","line":126,"updated":"2016-08-08 13:27:29.000000000","message":"This if/elif block could use some comments to explain why we use different groups in different phases. Unless that\u0027s documented somewhere else and you want to link to it here?","commit_id":"17e0b083a4eb4ac7b31311130156182adafdc202"},{"author":{"_account_id":308,"name":"Thierry Carrez","email":"thierry@openstack.org","username":"ttx"},"change_message_id":"6b0c48f4f247a00e4f171e215369b4eddf2ae1bc","unresolved":false,"context_lines":[{"line_number":123,"context_line":"def modify_gerrit_groups(args):"},{"line_number":124,"context_line":"    \"\"\"Handles the \u0027groups\u0027 action\"\"\""},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    if args.stage \u003d\u003d \u0027pre_release\u0027:"},{"line_number":127,"context_line":"        actions \u003d [(\u0027DELETE\u0027, lambda x: \u0027%s-stable-maint\u0027 % x),"},{"line_number":128,"context_line":"                   (\u0027PUT\u0027, lambda x: \u0027%s-release\u0027 % x)]"},{"line_number":129,"context_line":"    elif args.stage \u003d\u003d \u0027post_release\u0027:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3ac371cc_bcc75544","line":126,"in_reply_to":"9ad45d7e_353c332f","updated":"2016-08-15 13:31:03.000000000","message":"Done","commit_id":"17e0b083a4eb4ac7b31311130156182adafdc202"}]}
